KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 96 - Still Unstable!

2017-11-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/96/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 03:54:34 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 96 - Unstable!

2017-11-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/96/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 03:54:34 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 145 - Fixed!

2017-11-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/145/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 12 Nov 2017 03:53:59 + Build duration: 2 min 41 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 139 - Still Unstable!

2017-11-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/139/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 12 Nov 2017 03:53:59 + Build duration: 1 min 37 sec and counting JUnit Tests

D8767: Fix translation of toolbar name when it has i18n context

2017-11-11 Thread Alexander Potashev
aspotashev created this revision. aspotashev added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Configure Toolbars dialog did not take into account the "context" attribute of toolbar text whic

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-11 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > ConfigureChecks.cmake:106 >Falling back to Fake backend") > -set (KAUTH_BACKEND "FAKE") > +#set (KAUTH_BACKEND "FAKE") > endif (NOT PolkitQt5-1_FOUND) Is this change required? > ConfigureCheck

D7810: Add missing icon sizes

2017-11-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me now. @hein? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham Cc: andre

D7810: Add missing icon sizes

2017-11-11 Thread mandian
mandian updated this revision to Diff 22206. mandian added a comment. I cleaned the patch and I included icon-dark too. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7810?vs=19506&id=22206 REVISION DETAIL https://phabricator.kde.org/D7810 AFFECTED

D8546: Add Aztec code generator

2017-11-11 Thread Volker Krause
vkrause updated this revision to Diff 22205. vkrause added a comment. Fix off-by-one inconsistency in layerCount It now always means the amount of layers and not the index of the last layer. Fixes rendering of the unusually short Air Baltic boarding pass data. REPOSITORY R2

D7810: Add missing icon sizes

2017-11-11 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham Cc: andreask, hein, ngraham, cfeck, #frameworks

D7810: Add missing icon sizes

2017-11-11 Thread Nathaniel Graham
ngraham added a comment. Feel free to modify this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham Cc: andreask, hein, ngraham, cfeck, #frameworks

D7810: Add missing icon sizes

2017-11-11 Thread mandian
mandian added a comment. It like changes for size of icons in MimeTypes is not more needed because the bug is in caja and not in Breeze theme. Do you prefer I submit a new patch without these two changes? INLINE COMMENTS > hein wrote in index.theme:297 > Hmm why lower this one: I did this

D8546: Add Aztec code generator

2017-11-11 Thread Volker Krause
vkrause updated this revision to Diff 22188. vkrause added a comment. Adapt to review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8546?vs=21526&id=22188 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8546 AFFECTED FILES CMak

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-11 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7274 To: vkrause, #frameworks, cordlandwehr

D8697: Don't check whether an empty filename exists

2017-11-11 Thread David Faure
dfaure added a comment. Personally, I don't find a check in QFile/QFileInfo "much cleaner". It's an invalid call, arguably. So checking here makes sense. REPOSITORY R241 KIO BRANCH fix-empty-exists REVISION DETAIL https://phabricator.kde.org/D8697 To: elvisangelaccio, dfaure Cc: apol

D8332: Added baloo urls into places model

2017-11-11 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > dvratil wrote in kfileplacesmodel.cpp:153 > typo: `withBaloo` Minor: QLatin1String("true") is enough for a comparison (no need to use a 16-bit-per-char string) > kfileplacesview.cpp:1350 > +qWarning() << "Invalid search url:" << url; > +