mart added a comment.
ping
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D8522
To: mart, #plasma, #frameworks
Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
elvisangelaccio created this revision.
elvisangelaccio added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The latest Qt 5.10 beta includes [1] which breaks KIO all over the
place, since `url.setPath("//foo")` will now result in an invalid
dfaure added a reviewer: thiago.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio, #frameworks, dfaure, thiago
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Urgh. That QUrl change doesn't make things easy for this type of code indeed.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio
elvisangelaccio created this revision.
elvisangelaccio added reviewers: dfaure, thiago.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Same fix as in https://phabricator.kde.org/D8836, this time for testtrash.
TEST PLA
dfaure added a comment.
Maybe we need a KUrl class :-)
Just kidding.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8837
To: elvisangelaccio, dfaure, thiago
Cc: #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8837
To: elvisangelaccio, dfaure, thiago
Cc: #frameworks
dfaure added a comment.
More seriously, this could be a reason for adding QUrl::addPath(), like we
had in KUrl.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8837
To: elvisangelaccio, dfaure, thiago
Cc: #frameworks
bcooksley added a comment.
Elvis, how many other issues like this do we expect to crop up due to Qt 5.10?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8837
To: elvisangelaccio, dfaure, thiago
Cc: bcooksley, #frameworks
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8837#168327, @bcooksley wrote:
> Elvis, how many other issues like this do we expect to crop up due to Qt
5.10?
I have two other failing tests in kio, which I'm fixing now. I guess this
change will probably break so
elvisangelaccio updated this revision to Diff 22432.
elvisangelaccio added a comment.
- Fix also mkpathjobtest and fileundomanagertest
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8836?vs=22430&id=22432
BRANCH
master
REVISION DETAIL
https://phabricator.
dfaure added inline comments.
INLINE COMMENTS
> mkpathjob.cpp:46
> for (; i < basePathComponents.count() && i <
> m_pathComponents.count(); ++i) {
> if (m_pathComponents.at(i) == basePathComponents.at(i)) {
> +if (m_url.path() == QLatin1Char('/')) {
I think
cgiboudeaux added a comment.
In https://phabricator.kde.org/D8837#168327, @bcooksley wrote:
> Elvis, how many other issues like this do we expect to crop up due to Qt
5.10?
https://bugs.kde.org/386420 ?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator
elvisangelaccio updated this revision to Diff 22433.
elvisangelaccio added a comment.
- Use local variables
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8836?vs=22432&id=22433
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
AFFECTED FIL
elvisangelaccio marked 2 inline comments as done.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio, #frameworks, dfaure, thiago
elvisangelaccio edited the summary of this revision.
elvisangelaccio edited the test plan for this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio, #frameworks, dfaure, thiago
dfaure accepted this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio, #frameworks, dfaure, thiago
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmoduleqml.cpp:143
> +{
> +//FIXME: those are all workarounds around the QQuickWidget brokeness
> +if (watched == d->quickWidget && ev
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kcmoduleqml.cpp:154
> can this be null?
Quick glance at `QQuickItemPrivate::nextPrevItemInTabFocusChain` shows it
cannot. In doubt it returns `this`.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.o
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2353119aae8f: Fix KIO::mkpath with qtbase 5.10 beta 4
(authored by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8836?vs=22433&id=22436
REVISION DET
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:05938a167dd4: Fix testtrash with qtbase 5.10 beta 4
(authored by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8837?vs=22431&id=22437
REVISION DETAI
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/140/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 16 Nov 2017 11:14:33 +
Build duration:
4 min 55 sec and counting
CONSOLE OUTPUT
[...
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/139/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Thu, 16 Nov 2017 11:14:33 +
Build duration:
5 min 59 sec and counting
JUnit Tests
Name: (ro
elvisangelaccio created this revision.
elvisangelaccio added reviewers: adridg, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I broke the build on FreeBSD, this patch should fix it.
REPOSITORY
R241 KIO
BRAN
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Weird, I wonder what's the relation with FreeBSD :) Compiler, I guess...
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8841
To: elvisangelaccio, adr
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:378808a575d7: port from deprecated
KAuthorized::authorizeKAction to authorizeAction (authored by sitter).
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8824?vs=
sitter updated this revision to Diff 22443.
sitter added a comment.
rebased
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8825?vs=22379&id=22443
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8825
AFFECTED FILES
src/kbookmarkmanager
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.9/13/
Project:
Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 16 Nov 2017 12:07:38 +
Build duration:
12 min and counting
JUnit Test
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a208dc70c9a5: Fix build on FreeBSD (authored by
elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8841?vs=22441&id=22446
REVISION DETAIL
https://phabr
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/141/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 16 Nov 2017 12:56:08 +
Build duration:
6 min 58 sec and counting
JUnit Tests
Name: (
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/140/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Thu, 16 Nov 2017 12:56:08 +
Build duration:
10 min and counting
JUnit Tests
Name: (root) Fa
renatoo updated this revision to Diff 22451.
renatoo added a comment.
Make 'isFileIndexingEnabled' a static function
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=22328&id=22451
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
aut
renatoo updated this revision to Diff 22454.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=22394&id=22454
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
renatoo updated this revision to Diff 22453.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=22393&id=22453
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodelte
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Looks good to me :)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D8811
To: anthonyfieroni, leinir, dfaure
Cc: broulik, #frameworks, ZrenBot
kossebau added a reviewer: dfaure.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8728
To: kossebau, #frameworks, dfaure
Cc: ngraham
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> framesvgitem.cpp:295
> +
> +const QVector m_oldMargins;
> +FrameSvgItemMargins *const m_margins;
If we always have 4 and can initialised them to
mart updated this revision to Diff 22463.
mart added a comment.
- guard null
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8522?vs=21440&id=22463
BRANCH
phab/keynav
REVISION DETAIL
https://phabricator.kde.org/D8522
AFFECTED FILES
src/kcmoduleqml.
mart marked 2 inline comments as done.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D8522
To: mart, #plasma, #frameworks, davidedmundson
Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R295 KCMUtils
BRANCH
phab/keynav
REVISION DETAIL
https://phabricator.kde.org/D8522
To: mart, #plasma, #frameworks, davidedmundson
Cc: broulik, davidedmundson, ngraham, plasma-devel, #framewo
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:9ebf898572ca: keyboard navigation in and out QML kcms
(authored by mart).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8522?vs=22463&id=22464
REVISION DETAIL
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in framesvgitem.cpp:295
> If we always have 4 and can initialised them to 0 qreal[4] with a c style
> array would be better.
Would it? it's harder to compare then as you can't do a simple `!=`
REPOSITORY
R242 Plasma Framework
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:11c9206bf68f: Reduce spurious signal emissions (authored
by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8809?vs=22304&id=22465
REVISIO
ngraham created this revision.
ngraham added reviewers: Frameworks, broulik, elvisangelaccio.
REVISION SUMMARY
master now has KF 5.40, so require that and always use
KIO::PreviewJob::defaultPlugins(), which lets us get rid of some unnecessary
code
TEST PLAN
Tested in KDE Neon. Compiles and
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/143/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 16 Nov 2017 15:20:59 +
Build duration:
7 min 0 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/139/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Thu, 16 Nov 2017 15:20:59 +
Build duration:
9 min 1 sec and counting
JU
sitter created this revision.
sitter added reviewers: Frameworks, whiting, gregormi.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
it's not useful in production
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8848
AFFECTED FIL
elvisangelaccio accepted this revision as: elvisangelaccio.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8847
To: ngraham, #frameworks, broulik, elvisangelaccio
gregormi accepted this revision.
gregormi added a comment.
This revision is now accepted and ready to land.
Approval from my side. Thanks.
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8848
To: sitter, #frameworks, whiting, gregormi
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Creating a window handle is relatively slow. We don't want it in the
constructor if we don't need it.
Replaces https://phabrica
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/58/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 16 Nov 2017 15:20:59 +
Build duration:
2 hr 29 min and counting
bcooksley added a comment.
The reason why I ask is - would it be worth setting up a parallel build
against Qt 5.10 on the CI to see what else breaks test wise?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8837
To: elvisangelaccio, dfaure, thiago
Cc: cgiboudeaux, bcoo
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8396?vs=21046&id=22482#toc
REPOSITORY
R127 KWayland
CHANGES
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/58/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 16 Nov 2017 19:23:25 +
Build duration:
8 min 52 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/59/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Thu, 16 Nov 2017 19:23:25 +
Build duration:
11 min and counting
JUnit Tests
Name:
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source
model for PlacesItemModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #f
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source
model for PlacesItemModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham,
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source
model for PlacesItemModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure
Cc: mwolff, dfa
ngraham added a comment.
@ervin and @dvratil, any remaining concerns?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure
Cc: mwolff, dfaure, ervin, usta, mlaurent, d
ngraham added a comment.
If the ability to add a custom path is important, maybe we should put that
under "Terminal options". I don't think we're ever going to figure out a
functional UI for that single text field to work equally well for searching and
entering a path with history.
REPOSITO
rkflx added a comment.
IMHO the problem is not so much in the single text field, but how/where the
results are presented.
(Sorry I haven't got around to open the task yet. I did not forget, but
Okular was more important last weekend…)
REPOSITORY
R241 KIO
REVISION DETAIL
https://pha
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/60/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Thu, 16 Nov 2017 22:28:36 +
Build duration:
6 min 7 sec and counting
JUnit Tests
N
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/59/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 16 Nov 2017 22:28:36 +
Build duration:
6 min 33 sec and counting
JUnit Tests
cgiboudeaux created this revision.
cgiboudeaux added a reviewer: graesslin.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
This test needs the weston executable. Skip the test if the progr
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:75a3723c45e3: Depend on KIO::PreviewJob::defaultPlugins()
and KF 5.40 (authored by ngraham).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8847?vs=22466&id=2249
apol updated this revision to Diff 22496.
apol added a comment.
Pass LANG=C to readelf so it doesn't appear in catalan (or anything other
than C) and pass ECM_ADDITIONAL_FIND_ROOT_PATH to look for dependencies
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabrica
apol updated this revision to Diff 22498.
apol added a comment.
Added "" around a variable that may contain ;
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8173?vs=22496&id=22498
BRANCH
arcpatch-D8173_1 (branched from master)
REVISION DETAI
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Could you please add a message that it is missing?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8858
To: cgiboudeaux, graesslin
Cc: plasma-deve
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:ab6a48778bbe: [knewstuff] Do not leak ImageLoader on
error (authored by anthonyfieroni).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8811?vs=22408&id=22501
RE
genethomas added a comment.
I can not commit. Can you please arrange access for myself?
$git push
fatal: remote error: service not enabled: /syntax-highlighting
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8782
To: genethomas, vkrause, dhaumann
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/33/
Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 17 Nov 2017 04:04:57 +
Build duration:
2 hr 21 min and counting
JUnit T
72 matches
Mail list logo