smithjd added inline comments.
INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:119
> I see an added check for "already exists" and an early return (good), but no
> support for KIO::Overwrite. If the user uses dolphin to copy a tag they might
> click on "overwrite" and it won't work, if copy()
smithjd updated this revision to Diff 22792.
smithjd marked 6 inline comments as done.
smithjd added a comment.
- Review changes.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22712=22792
BRANCH
master-nestedTags (branched from master)
REVISION
aleksejshilin created this revision.
aleksejshilin added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Since breadcrumb menu is opened on mouse press, it may receive
the corresponding mouse release event which may unintentionally
activate the
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesviewtest.cpp:70
> +
> +void KFilePlacesViewTest::testUrlChangedContaisConvertedUrl_data()
> +{
typo: Contains.
I would just have called it `testUrlChanged` because it also checks that it's
emitted, not just what the emitted value is
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:1039
> +
> +//use a invalid start postion
> +QVERIFY(!m_places->movePlace(100, 20));
typo: position
>
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: ngraham, #frameworks
renatoo updated this revision to Diff 22782.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22770=22782
REVISION DETAIL
https://phabricator.kde.org/D8947
AFFECTED FILES
renatoo updated this revision to Diff 22775.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=22763=22775
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
autotests/CMakeLists.txt
renatoo updated this revision to Diff 22776.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=22764=22776
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 22779.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22767=22779
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
renatoo updated this revision to Diff 22780.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22768=22780
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
renatoo updated this revision to Diff 22783.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22771=22783
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22778.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22766=22778
REVISION DETAIL
https://phabricator.kde.org/D8943
AFFECTED FILES
renatoo updated this revision to Diff 22781.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22769=22781
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
renatoo updated this revision to Diff 22777.
renatoo added a comment.
Updated from master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=22765=22777
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 22770.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22759=22770
REVISION DETAIL
https://phabricator.kde.org/D8947
AFFECTED FILES
renatoo updated this revision to Diff 22769.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22758=22769
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
renatoo updated this revision to Diff 22771.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22762=22771
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22766.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22755=22766
REVISION DETAIL
https://phabricator.kde.org/D8943
AFFECTED FILES
renatoo updated this revision to Diff 22768.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22757=22768
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
renatoo updated this revision to Diff 22767.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22756=22767
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
renatoo updated this revision to Diff 22765.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=22454=22765
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 22764.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=22453=22764
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 22763.
renatoo marked 2 inline comments as done.
renatoo added a comment.
Updated unit test name
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=22451=22763
REVISION DETAIL
https://phabricator.kde.org/D8332
renatoo updated this revision to Diff 22762.
renatoo marked an inline comment as done.
renatoo added a comment.
Implemented unit test
Fixed documentation
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22741=22762
REVISION DETAIL
renatoo updated this revision to Diff 22759.
renatoo marked an inline comment as done.
renatoo added a comment.
Updated documentation
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22740=22759
REVISION DETAIL
https://phabricator.kde.org/D8947
renatoo updated this revision to Diff 22758.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22739=22758
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
renatoo updated this revision to Diff 22757.
renatoo added a comment.
Updated parent brach
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22738=22757
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
renatoo updated this revision to Diff 22755.
renatoo marked 2 inline comments as done.
renatoo added a comment.
Updated documentation
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22736=22755
REVISION DETAIL
https://phabricator.kde.org/D8943
renatoo updated this revision to Diff 22756.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22737=22756
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
renatoo retitled this revision from "Expose KFilePlacesModel 'iconName' rule"
to "Expose KFilePlacesModel 'iconName' role".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Wed, 22 Nov 2017 17:16:01 +
Build duration:
2 min 49 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kemoticons kf5-qt5 SUSEQt5.7
Date of build:
Wed, 22 Nov 2017 16:20:29 +
Build duration:
5 min 19 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20WindowsMSVCQt5.9/15/
Project:
Frameworks kemoticons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 22 Nov 2017 16:20:29 +
Build duration:
1 min 52 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks kemoticons kf5-qt5 SUSEQt5.10
Date of build:
Wed, 22 Nov 2017 16:20:29 +
Build duration:
1 min 36 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R301:fb467669f8a3: KEmoticons: port plugins to JSON and add
support for loading with… (authored by dfaure).
REPOSITORY
R301 KEmoticons
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R301 KEmoticons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks, apol
Cc: apol
kossebau added inline comments.
INLINE COMMENTS
> kfileplacesmodel.h:52
> +GroupRole = 0x0a5b64ee,
> +// @since 5.41
> +IconNameRole = 0x00a45c00
+1 for adding `@since`. But needs three slashes`///` for doxygen to pick up
this comment
REPOSITORY
R241 KIO
REVISION
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/63/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 22 Nov 2017 15:22:49 +
Build duration:
18 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/21/
Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 22 Nov 2017 15:22:49 +
Build duration:
14 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Wed, 22 Nov 2017 15:22:49 +
Build duration:
8 min 28 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Wed, 22 Nov 2017 15:22:49 +
Build duration:
8 min 5 sec and counting
JUnit Tests
kossebau added a comment.
@dfaure thanks for review.
Given these are kf5-specific mimetypes I am unsure whether to propose them
also for inclusion in shared-mime-info. What do you think?
I have been tempted to also add mimetypes for all the special scripty files
(Messages.sh,
dfaure added a reviewer: apol.
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks, apol
Cc: apol
dfaure added a comment.
ping?
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D8671
To: dfaure, #frameworks
Cc: apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:dbde1029b3b7: Install mimetype definitions for
kcfg/kcfgc/ui.rc/knotify qrc files (authored by kossebau).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
mimetypesforkfdevelopmentfiles
REVISION DETAIL
https://phabricator.kde.org/D8728
To: kossebau, #frameworks, dfaure
Cc: ngraham
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Good stuff, it also skips a call to refresh() when nothing changed, which is
good for performance.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: #frameworks
kossebau updated this revision to Diff 22746.
kossebau added a comment.
- drop qrc mimetype proposal, qt types are to be dealt with upstream
- x-vnd -> vnd
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8728?vs=22095=22746
BRANCH
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: #frameworks
dfaure accepted this revision.
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesviewtest.cpp:56
> +// Ensure we'll have a clean bookmark file to start
> +QFile::remove(bookmarksFile());
> +
You could just call cleanupTestCase() here, I usually do that too. Cleanup at
start,
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesmodel.h:80
> +/**
> + * @brief Move place at 'row' to a position before 'before'
> + * @since 5.41
this doesn't match the names of the parameters, and use @p rather than single
quotes.
REPOSITORY
R241 KIO
REVISION
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodel.h:137
> + * "search:/documents" into a Query-URL that will be handled by
> + * the corresponding IO-slave. Virtual
renatoo planned changes to this revision.
renatoo added a comment.
Implement unit test
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8947: Expose KFilePlacesModel 'iconName' rule.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo added a dependent revision: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace'.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: #frameworks
renatoo added a dependent revision: D8947: Expose KFilePlacesModel 'iconName'
rule.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8946: Avoid unnecessary 'dataChanged' signal.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: #frameworks
renatoo added a dependent revision: D8946: Avoid unnecessary 'dataChanged'
signal.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8945: Return a valid bookmark object for any entry
in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a reviewer: dfaure.
renatoo added a dependency: D8944: Create a 'KFilePlacesModel::refresh'
function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: #frameworks
renatoo added a dependent revision: D8945: Return a valid bookmark object for
any entry in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added a dependency: D8943: Create 'KFilePlacesModel::convertedUrl'
static function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: #frameworks
renatoo added a dependent revision: D8943: Create
'KFilePlacesModel::convertedUrl' static function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure, mwolff
Cc:
renatoo added a dependent revision: D8944: Create a 'KFilePlacesModel::refresh'
function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added dependencies: D8332: Added baloo urls into places model, D8434:
Created 'remote' section, D8348: Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc:
renatoo added a dependent revision: D8943: Create
'KFilePlacesModel::convertedUrl' static function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham,
renatoo added a dependent revision: D8943: Create
'KFilePlacesModel::convertedUrl' static function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent,
renatoo abandoned this revision.
renatoo added a comment.
This review was spited in small ones:
https://phabricator.kde.org/D8943
https://phabricator.kde.org/D8944
https://phabricator.kde.org/D8945
https://phabricator.kde.org/D8946
https://phabricator.kde.org/D8947
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
with 'KFilePlacesModel::movePlace' the external APIs can easily move
items in the model without replicate the code.
TEST PLAN
Unit test
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Make possible for external APIs to get the iconName used in each entry
of KFilePlacesModel
TEST PLAN
Unit test created
REPOSITORY
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Only emit 'dataChanged' signal if the data really changes
TEST PLAN
Unit test created
REPOSITORY
R241 KIO
REVISION DETAIL
renatoo added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: #frameworks
renatoo added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Make sure that 'KFilePlacesModel::bookmarkForIndex' return a bookmark
for any item in the model.
TEST PLAN
unit test created
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Move convertedUrl from KFilePlacesView to KFilePlacesModel to be reused
by other views that use the same model.
TEST PLAN
unit test
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Expose a public function that allows manually reload bookmark
information
TEST PLAN
unit test created
REPOSITORY
R241 KIO
REVISION
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.9/14/
Project:
Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 22 Nov 2017 12:33:14 +
Build duration:
1 hr 28 min and counting
franckarrecot updated this revision to Diff 22734.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21644=22734
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
franckarrecot added inline comments.
INLINE COMMENTS
> mwolff wrote in kfileplacesview.cpp:298
> the reserve + loop should be the same as doing
>
> m_disappearingItems += indexesGroup;
I'm filling a list of persistant indexes with regular indexes that is why I use
the loop, if you have any
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:5dffdee21f20: do not show edit bookmarks action if
keditbookmarks is not installed (authored by sitter).
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R294 KBookmarks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8825
To: sitter, #frameworks, apol
Cc: apol
franckarrecot added a comment.
precision on useless comment
INLINE COMMENTS
> franckarrecot wrote in kfileplacesmodel.cpp:257
> it is currently not needed here since each change an object metadata ( eg :
> item isHidden metadata ) would trigger a loadBookmarkList().
> And in this code we
franckarrecot updated this revision to Diff 22726.
franckarrecot edited the test plan for this revision.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21755=22726
REVISION DETAIL
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
franckarrecot added a comment.
taking ownership back to fix comments, thanks Laurent for taking care of it
:-)
INLINE COMMENTS
> renatoo wrote in kfileplacesmodel.cpp:257
>
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D8864
To: broulik, #plasma, hein
Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:119
> missing KIO::Overwrite support? Can the dest already exist?
I see an added check for "already exists" and an early return
dfaure accepted this revision.
dfaure added a comment.
Sure.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks
91 matches
Mail list logo
