D9207: Don't load KDE platform module in kglobalaccel5

hein removed subscribers: apol, graesslin. hein added a reviewer: graesslin. hein added a comment. I consider this patch in some sense a micro-optimization. I think given our time in the release cycle it'd be OK to apply and essentially see what if anything breaks. However I also won't feel

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 03:40:30 + Build duration: 20 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 03:40:29 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/3/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 03:40:29 + Build duration: 9 min 2 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 12 Dec 2017 02:00:44 + Build duration: 3 min 20 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Dec 2017 02:00:44 + Build duration: 3 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 12 Dec 2017 02:00:44 + Build duration: 2 min 36 sec and counting JUnit

D9292: Remove premise that doesn't apply anymore

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY I can't find any project (on ArchLinux repositories) that puts icons in a subdirectory named "pixmaps". Since our premise is that Gnome does it, maybe it's not

D9167: Improve string handling

apol abandoned this revision. apol marked an inline comment as done. apol added a subscriber: mlaurent. apol added a comment. :( when I rebased to current master I realized that @mlaurent worked on a very similar patch without going through review (which btw is policy in KDE Frameworks).

D9167: Improve string handling

apol marked 2 inline comments as done. apol added a comment. Thanks! INLINE COMMENTS > dhaumann wrote in kiconeffect.cpp:165 > Previously, this was not an else if(), but just an if(). > > Are you sure this works as intended? Yes, `effectGroupState` is not going to change values out of the

D9076: Have an application that can cross-check if the promised platforms are correct

apol updated this revision to Diff 23784. apol added a comment. Wording, FreeBSDQt5.9 REPOSITORY R857 CI System Tooling CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9076?vs=23189=23784 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9076 AFFECTED FILES

D9076: Have an application that can cross-check if the promised platforms are correct

apol marked an inline comment as done. apol added a comment. In https://phabricator.kde.org/D9076#177399, @adridg wrote: > To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for that something,

D9257: MessageInterface: Add CenterInView as additional position

dhaumann updated this revision to Diff 23782. dhaumann added a comment. - Honor spacing for message widgets REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9257?vs=23781=23782 BRANCH MessageInterface (branched from master) REVISION DETAIL

D9257: MessageInterface: Add CenterInView as additional position

dhaumann updated this revision to Diff 23781. dhaumann added a comment. - Remove unneeded include REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9257?vs=23780=23781 BRANCH MessageInterface (branched from master) REVISION DETAIL

D9257: MessageInterface: Add CenterInView as additional position

dhaumann updated this revision to Diff 23780. dhaumann added a comment. - Simplify MessageWidget member variable handling REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9257?vs=23655=23780 BRANCH MessageInterface (branched from master) REVISION

D9219: WIP: Extend Scripting API

dhaumann added a comment. @cullmann Did you intentionally request changes or was that by accident and you meant Accept? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9219 To: dhaumann, cullmann, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann,

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann added a comment. @mwolff I still would like to know from you whether you think this patch makes thinks better: I need additional helper functions etc. just to use the STL to avoid these allocs. Additional helper functions are added complexity, since it's not standard Qt stuff that

D9289: KCompletionBox: restore proper layering behaviour on Mac

rjvbb added a comment. kurlrequestertest_gui on Mac, unpatched frameworks 5.38, Qt 5.8.0: F5542277: Screen Shot 2017-12-11 at 15.40.13.png idem, with this patch: F5542279: Screen Shot 2017-12-11 at 21.09.08.png

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak updated this revision to Diff 23772. petermajchrak added a comment. Small code tweaks, nothing that changes functionality REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8536?vs=22957=23772 REVISION DETAIL https://phabricator.kde.org/D8536

D9207: Don't load KDE platform module in kglobalaccel5

graesslin added a comment. In https://phabricator.kde.org/D9207#178257, @apol wrote: > In https://phabricator.kde.org/D9207#176322, @graesslin wrote: > > > I'm against a risky change here. Especially as this becomes irrelevant with Wayland. > > > What makes it risky?

D9290: [filewidgets] Fix create path

dfaure added a comment. Yes, QUrl::addPath would really be convenient. Meanwhile, make an addPath helper that just does if !endsWith('/') append('/') Calling cleanPath sounds much much slower to me... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9290 To:

D9290: [filewidgets] Fix create path

anthonyfieroni added a comment. Something like QString makePath(QString path) { return QDir::cleanPath(path); } QString makePath(Qstring path1, QString path2, ...) { return makePath(path1 + '/' + path2, ...); } REPOSITORY R241 KIO REVISION

D9289: KCompletionBox: restore proper layering behaviour on Mac

ltoscano edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9289 To: rjvbb, #frameworks Cc: kde-mac

D9290: [filewidgets] Fix create path

anthonyfieroni created this revision. anthonyfieroni added reviewers: Frameworks, dfaure, hein, aacid. Restricted Application added a project: Frameworks. REVISION SUMMARY Basically the problem is .path() + / + .. result in //path/to should we create some generic solution like

D9289: KCompletionBox: restore proper layering behaviour on Mac

rjvbb edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. rjvbb removed a subscriber: Frameworks. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9289 To: rjvbb, #frameworks Cc: kde-mac

D9289: KCompletionBox: restore proper layering behaviour on Mac

rjvbb edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9289 To: rjvbb, #framework_syntax_highlighting Cc: kde-mac, #frameworks

D9289: KCompletionBox: restore proper layering behaviour on Mac

rjvbb created this revision. rjvbb added a reviewer: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This restores proper layering behaviour on Mac, fixing the regression described in

KDE CI: Frameworks bluez-qt kf5-qt5 SUSEQt5.7 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20SUSEQt5.7/6/ Project: Frameworks bluez-qt kf5-qt5 SUSEQt5.7 Date of build: Mon, 11 Dec 2017 17:19:08 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks bluez-qt kf5-qt5 SUSEQt5.7 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20SUSEQt5.7/5/ Project: Frameworks bluez-qt kf5-qt5 SUSEQt5.7 Date of build: Sun, 10 Dec 2017 09:36:28 + Build duration: 1 day 7 hr and counting CONSOLE OUTPUT

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/5/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Mon, 11 Dec 2017 14:15:41 + Build duration: 4 min 2 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Dec 2017 14:15:41 + Build duration: 3 min 46 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/3/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 11 Dec 2017 14:15:41 + Build duration: 1 min 38 sec and counting JUnit

D9287: disappearing scrollbars on mobile

davidedmundson added a comment. If we have a runtime dep, we need to make it explicit in CMakeLists.txt. INLINE COMMENTS > DefaultListItemBackground.qml:23 > import QtQuick.Controls 1.0 as Controls > import QtQuick.Controls.Private 1.0 > import org.kde.plasma.core 2.0 as PlasmaCore does

D9287: disappearing scrollbars on mobile

mart created this revision. mart added reviewers: Plasma, bshah. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY like other platforms, on mobile devices make scrollbars visible only when

D9286: don't multiply svg sizes by devicepixelratio

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY when the native high dpi scaling is enabled, some things gets scaled two times, as sizes

D9197: experimental support for rcc files loading in kpackage

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Needs tests and docs INLINE COMMENTS > package.cpp:407 > +QString path = filePath(fileType, filename); > +//consytruct a qrc:/ url or a file:/ url, the

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 11 Dec 2017 08:03:15 + Build duration: 28 min and counting JUnit Tests Name: (root)

D9277: Remove cmake warning about generating moc file

mlaurent added a comment. @dfaure yep I rebuild all qt5.10 so yep :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/30/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Dec 2017 08:03:15 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/30/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 11 Dec 2017 08:03:15 + Build duration: 7 min 13 sec and counting JUnit Tests Name: (root)

D9277: Remove cmake warning about generating moc file

dfaure added a comment. Do you have qtbase commit b71b7461b0 ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks

D9213: KUriFilter: port away from KServiceTypeTrader

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6246cc480678: KUriFilter: port away from KServiceTypeTrader (authored by dfaure). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9213?vs=23535=23747 REVISION DETAIL

D9213: KUriFilter: port away from KServiceTypeTrader

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9213 To: dfaure, apol, davidedmundson Cc: #frameworks