graesslin accepted this revision.
graesslin added inline comments.
INLINE COMMENTS
> prefix.sh.cmake:3-4
> +
> +# LD_LIBRARY_PATH only needed if you are building without rpath
> +# export LD_LIBRARY_PATH=@KDE_INSTALL_FULL_LIBDIR@:$LD_LIBRARY_PATH
>
Just a note: this would break for
apol updated this revision to Diff 24473.
apol added a comment.
Explain
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9550?vs=24458=24473
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9550
AFFECTED FILES
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/26/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Fri, 29 Dec 2017 20:03:04 +
Build duration:
6 min 27 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/25/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Fri, 29 Dec 2017 19:52:38 +
Build duration:
6 min 58 sec and counting
JUnit Tests
dfaure added a comment.
Why leave it here, commented out, without explanations?
I'd either remove it completely, or explain the '#' ...
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9550
To: apol, #frameworks, dfaure, ngraham
Cc:
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
+1, LD_LIBRARY_PATH is the Dark Side. :-)
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9550
To: apol, #frameworks, dfaure,
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/15/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Fri, 29 Dec 2017 16:42:23 +
Build duration:
16 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/13/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Fri, 29 Dec 2017 16:42:23 +
Build duration:
7 min 44 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/15/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
Date of build:
Fri, 29 Dec 2017 16:42:23 +
Build duration:
2 min 44 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4595a2c2709e: [server] Add a method
IdleInterface::simulateUserActivity (authored by graesslin).
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
CHANGED PRIOR TO
velurimithun added inline comments.
INLINE COMMENTS
> mlaurent wrote in kprocesstest.cpp:93
> ?
> QStringLiteral works fine with QStringList
Yeah working!!, I changed it!!
But, Unable to eliminate this compile error
> kstringhandlertest.cpp:45
> +expected << QLatin1String("kparts") <<
velurimithun updated this revision to Diff 24452.
velurimithun added a comment.
patch created for all the changes from starting
This diff contains total changes in all files...
kcoreaddons compilation done!!
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
12 matches
Mail list logo