D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-21 Thread Laurent Montel
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. You still forgot to launch autotest... see: "laurent@linux-5nvn:/compile/kde5/framework/frameworks/kcoreaddons/build> ./bin/kaboutdatatest - Start testing of KAboutDat

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-21 Thread Veluri Mithun
velurimithun updated this revision to Diff 25712. velurimithun added a comment. - Compare license file correctly REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=25677&id=25712 BRANCH complieWithoutRemoveDef REVISION DETAIL https://phabricat

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-21 Thread Veluri Mithun
velurimithun added a comment. **Note:** In kdirwatch_qfswatch_unittest KDirWatch_UnitTest::benchNotifyWatcher() fails before and after changes in kdirwatch_unittest.cpp file REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

2018-01-21 Thread Randy Kron
rkron added a comment. @davidedmundson Thanks for the commit! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: dhaumann, ngraham, alexeymin, aacid, #frameworks

Re: Dependency Loop: Purpose

2018-01-21 Thread Albert Astals Cid
El dijous, 18 de gener de 2018, a les 19:41:59 CET, Ben Cooksley va escriure: > Hi all, > > I've been examining the dependencies for Purpose, and it appears that > it has build time dependencies on 'kaccounts-integration' and > 'kdeconnect-kde' > > This creates an effective dependency loop as the

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 2 - Still Failing!

2018-01-21 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Sun, 21 Jan 2018 19:38:55 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 2 - Still Failing!

2018-01-21 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/2/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 21 Jan 2018 19:38:55 + Build duration: 2 min 38 sec and counting CONSOLE OUT

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 2 - Still Unstable!

2018-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/2/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 21 Jan 2018 19:38:55 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 2 - Still Unstable!

2018-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 21 Jan 2018 19:38:55 + Build duration: 12 min and counting JUnit Tests Name: (roo

Re: A new tier1 for icontheme.rcc handling

2018-01-21 Thread Matthieu Gallien
Hello, On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote: > Hi everyone. > > Only some few of you will be aware of KIconThemes ability to load binary > icon themes automagically. > > https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 > > The code looks for a icontheme.rc

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

2018-01-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9468 To: habacker, dfaure Cc: #frameworks

Re: Dependency Loop: Purpose

2018-01-21 Thread Ben Cooksley
On Mon, Jan 22, 2018 at 8:30 AM, Albert Astals Cid wrote: > El dijous, 18 de gener de 2018, a les 19:41:59 CET, Ben Cooksley va escriure: >> Hi all, >> >> I've been examining the dependencies for Purpose, and it appears that >> it has build time dependencies on 'kaccounts-integration' and >> 'kdec

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 25 - Still Unstable!

2018-01-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 01:31:13 + Build duration: 4 min 14 sec and counting JUnit Tests Name: (ro