davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Can you please also fix the stupid off by one in the autotest which is why we
didn't see this.
for(int i = 1; i < KAboutLicense::LGPL_V2_1 ; i++) { /*current highest
kossebau created this revision.
kossebau added reviewers: davidedmundson, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.
REVISION SUMMARY
Fixup for
rjvbb added a comment.
I can confirm that the patch appears to have no (side)effect whatsoever when
using the Freetype fontengine (available also on Mac with
`-cocoa:fontengine=freetype`!)
The resulting lineheight looks fine when using the standard Mac CoreText
fontengine, and I cannot
dhaumann added a comment.
Testing under Linux, I cannot see any visual difference when selecting the
same font in KWrite with and without patch. I guess this is mostly a good sign.
From my side this is a "+1", but a bit more testing also by @rjvbb is
certainly appreciated, therefore not
This revision was automatically updated to reflect the committed changes.
Closed by commit R298:a78f3c63e9ab: Make kdoctools dependency optional
(authored by vkrause).
REPOSITORY
R298 KDesignerPlugin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9594?vs=24555=26086
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R315:576d0eec01ef: Unexport kjscmd (authored by vkrause).
REPOSITORY
R315 KJsEmbed
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9589?vs=24545=26085
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R315:6d334380a2c3: Make kdoctools dependency optional
(authored by vkrause).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9588?vs=24544=26084#toc
REPOSITORY
R315 KJsEmbed
CHANGES SINCE LAST
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20WindowsMSVCQt5.9/4/
Project:
Frameworks kholidays kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sat, 27 Jan 2018 19:11:01 +
Build duration:
15 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks kholidays kf5-qt5 SUSEQt5.7
Date of build:
Sat, 27 Jan 2018 19:11:01 +
Build duration:
5 min 45 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks kholidays kf5-qt5 SUSEQt5.10
Date of build:
Sat, 27 Jan 2018 19:11:01 +
Build duration:
2 min 0 sec and counting
JUnit Tests
michaelh added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in filemetadataprovider.cpp:323
> I don't think so, because `IndexedDataRetriever::start()` does not block.
In that case it might be safer to do
IndexedDataRetriever *ret = new IndexedDataRetriever(filePath,
michaelh edited the summary of this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
michaelh marked 4 inline comments as done.
michaelh added inline comments.
INLINE COMMENTS
> filemetadataprovider.cpp:141
> }
> -else {
> -//
> -// Only report the stuff that is common to all the files
> -//
> -QSet allProperties;
> -QList
michaelh updated this revision to Diff 26079.
michaelh added a comment.
Leave early w/o files
Fix comments
Rename setFilesItems to setFileItems
Apply coding style
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10105?vs=26068=26079
BRANCH
fvogt added a comment.
There is one issue I have with this. While this is close to the `sudo`-mode
of temporary authorization grants, it doesn't work that way as the whole
session has full access via file.so.
It would be great if this could work with just the application which
elvisangelaccio added a comment.
+1, looks good to me.
INLINE COMMENTS
> michaelh wrote in filemetadataprovider.cpp:323
> Is it guaranteed, that this is emitted before IndexedDataRetriever job is
> finished?
I don't think so, because `IndexedDataRetriever::start()` does not block.
rjvbb added a comment.
OK, testing. I'll let you know if I notice anything off.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D10145
To: cullmann, #ktexteditor
Cc: rjvbb, anthonyfieroni, ngraham, #frameworks, michaelh, kevinapavew,
demsking, cullmann, sars,
elvisangelaccio edited the summary of this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
elvisangelaccio added inline comments.
INLINE COMMENTS
> filemetadataprovider.cpp:140
> +} else {
> m_data = files.first();
> +insertSingleFileBasicData();
This will crash if `files` is empty, I think?
> filemetadataprovider.cpp:195
> +allDirectories &=
michaelh marked an inline comment as done.
michaelh added inline comments.
INLINE COMMENTS
> filemetadataprovider.cpp:323
> +emit dataAvailable();
>
> } else {
Is it guaranteed, that this is emitted before IndexedDataRetriever job is
finished?
REPOSITORY
R824 Baloo
This revision was automatically updated to reflect the committed changes.
Closed by commit R314:016aa871a084: Make kdoctools dependency optional
(authored by vkrause).
REPOSITORY
R314 KJs
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9587?vs=24543=26072
REVISION DETAIL
michaelh updated this revision to Diff 26071.
michaelh added a comment.
Update signal descriptions
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=25962=26071
BRANCH
dataavail
REVISION DETAIL
https://phabricator.kde.org/D10113
AFFECTED
ngraham added a comment.
Thanks René. Regarding those questions, what would your preferences be?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D9070
To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts,
cullmann added a comment.
Either this patch can improve that or make it worse ;=)
I tried out some .desktop file with different translations inside that have
"complex" glyphs and I think it works better now.
If you have time to test that, it would be great.
Btw., that you sometimes
anthonyfieroni added a comment.
Is this has same impact in rtl language or some kind of hieroglyphs, it's
painted a bit up or down cutted.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D10145
To: cullmann, #ktexteditor
Cc: anthonyfieroni, ngraham, #frameworks,
michaelh updated this revision to Diff 26068.
michaelh added a comment.
Correct merging errors
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10105?vs=26058=26068
BRANCH
requestfinished (branched from master)
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R175:730063cb9dc1: Put built-in holiday definitions into qrc
(authored by vkrause).
REPOSITORY
R175 PIM: KHolidays
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10135?vs=26034=26069
REVISION
cullmann created this revision.
cullmann added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
cullmann requested review of this revision.
REVISION SUMMARY
I played a bit more with KTextEditor on macOS.
michaelh planned changes to this revision.
michaelh added a comment.
There are merging errors
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R315 KJsEmbed
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9589
To: vkrause, #frameworks, apol
Cc: bshah, michaelh
vkrause added inline comments.
INLINE COMMENTS
> mlaurent wrote in CMakeLists.txt:8
> Just curious it's not default in ECM ? I never used it.
Yep, I was expecting this to be the default too, but it didn't work without
explicitly enabling it.
REPOSITORY
R175 PIM: KHolidays
BRANCH
master
bshah added inline comments.
INLINE COMMENTS
> vkrause wrote in CMakeLists.txt:6
> That suggests it shouldn't even be installed in the first place? Would fix
> the cross-compilation issue too.
I am not sure tbh, question is what it does and what does it mean by developer
tool?
- KJSEmbed
mlaurent accepted this revision.
mlaurent added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:8
> set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
> +set(CMAKE_AUTORCC ON)
>
Just curious it's not default in ECM ? I never used it.
REPOSITORY
michaelh updated this revision to Diff 26058.
michaelh added a comment.
Separate coding-style refactor into extra commit
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10105?vs=25960=26058
BRANCH
requestfinished (branched from master)
REVISION
vkrause added inline comments.
INLINE COMMENTS
> bshah wrote in CMakeLists.txt:6
> :-P
That suggests it shouldn't even be installed in the first place? Would fix the
cross-compilation issue too.
REPOSITORY
R315 KJsEmbed
REVISION DETAIL
https://phabricator.kde.org/D9589
To: vkrause,
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R314 KJs
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9587
To: vkrause, #frameworks, bshah
Cc: michaelh
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R315 KJsEmbed
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9588
To: vkrause, #frameworks, bshah
Cc: michaelh
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R298 KDesignerPlugin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9594
To: vkrause, #frameworks, bshah
Cc: michaelh
bshah added inline comments.
INLINE COMMENTS
> CMakeLists.txt:6
>
> # This is a developer tool, not intended for normal user installs
> add_executable(kjscmd5 ${kjscmd_SRCS})
:-P
REPOSITORY
R315 KJsEmbed
REVISION DETAIL
https://phabricator.kde.org/D9589
To: vkrause, #frameworks
Cc:
michaelh added a dependency: D10143: baloo-widgets: Apply coding style to
filemetadataprovider .
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects,
elvisangelaccio created this revision.
elvisangelaccio added reviewers: lbeltrame, dfaure, davidedmundson, fvogt,
chinmoyr.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
elvisangelaccio requested review of this revision.
REVISION
vkrause added a comment.
ping
REPOSITORY
R315 KJsEmbed
REVISION DETAIL
https://phabricator.kde.org/D9589
To: vkrause, #frameworks
Cc: michaelh
fvogt resigned from this revision.
fvogt added a comment.
Works for me. I'll leave the final review to someone else (@dfaure?).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
jtamate updated this revision to Diff 26047.
jtamate added a comment.
- Faster simplejob start
Finally the C++11 lambda syntax worked.
Now it only uses 0.3% of cpu according to callgrind.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
chinmoyr updated this revision to Diff 26045.
chinmoyr added a comment.
Fix typo. (int->bool in file_p.h line 59)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9966?vs=26044=26045
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9966
AFFECTED
chinmoyr updated this revision to Diff 26044.
chinmoyr added a comment.
1. Added +1 to SocketAddress::length for null byte.
2. Modified PrivilegeOperationReturnValue to use with switch-case and if-else
construct.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
elvisangelaccio added a comment.
I'd split this into 2 patches: one for the code style changes, and another
one for the actual code refactoring.
This way if the refactoring breaks something, it will be easier to figure out
where the problem is.
REPOSITORY
R824 Baloo Widgets
REVISION
nibags added a subscriber: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10136
To: nibags, #framework_syntax_highlighting
Cc: #framework_syntax_highlighting, #frameworks, michaelh, genethomas,
cullmann, vkrause, dhaumann
rjvbb added a comment.
> Thanks for the info! So if/hen this goes in, what are the next steps?
I'd say
- decide whether this is an issue you want to solve only for plasma
environments, or for all platforms where KF5 applications are supported.
- draw up the conditions under
nibags added a reviewer: Framework: Syntax Highlighting.
nibags added a project: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10136
To: nibags, #framework_syntax_highlighting
Cc: #frameworks, michaelh, genethomas, cullmann,
nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
nibags requested review of this revision.
REVISION SUMMARY
Update the syntax highlighting of AppArmor, after the release of AppArmor
2.12.0. In summary, in
dhaumann added inline comments.
INLINE COMMENTS
> filemetadataprovider.h:114
> void loadingFinished();
> +void dataAvailable();
>
Could you add API documentation there what this signal indicates and when to
use it? Typically, if you find code that is documented it is good practice
On Tuesday, 23 January 2018 18:36:10 CET Dominik Haumann wrote:
> Another question: there are holiday files in the git repo. Are these files
> compiled in as resource or loaded via filesystem?
>
> If these files are not added as resource, this probably breaks on Windows
> and OSX.
Good point,
vkrause created this revision.
vkrause added reviewers: Frameworks, KDE PIM.
Restricted Application added a project: KDE PIM.
vkrause requested review of this revision.
REVISION SUMMARY
The file system is still searched in the same place as before, which can
be easier to use than qrc while
fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.
Almost done!
I just noticed some small issues with reading errno after calling
`execWithElevatedPrivileges(...)` (I only left a single comment, the other
places are basically
ngraham added a comment.
Thanks for the info! So if/hen this goes in, what are the next steps?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D9070
To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts,
rjvbb added a comment.
A diagonally related anecdote that shows this location is a more central
point in the font selection process than I thought first:
Applications like Qt's Assistant that call for Helvetica often end up using a
font that looks pixelated - because it's actually an
rjvbb added a comment.
> Is this change purely a conversation of what developers use in code to
call up fonts in their applications?
I think so.
> Or does this also include a discussion where regular users have
interfaces that allow changes to font naming? Let's say, something
chinmoyr marked an inline comment as done.
chinmoyr added inline comments.
INLINE COMMENTS
> fvogt wrote in sharefd_p.h:66
> If that is the case you can do something like:
>
> #if !defined(__linux__) && !defined(__FreeBSD__)
> #error No secure implementation available
> #endif
I think
chinmoyr updated this revision to Diff 26028.
chinmoyr added a comment.
Changed parameters of
execWithElevatedPrivileges(), tryChangeAttr() : now they accept action type,
list of arguments and error code.
tryOpen(): accepts error code as an additional parameter.
@dfaure please have
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/29/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Sat, 27 Jan 2018 08:14:09 +
Build duration:
7 min 20 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/28/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Sat, 27 Jan 2018 08:14:09 +
Build duration:
6 min 36 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:125029d79153: baloo-tools: Make all output messages
translatable (authored by michaelh).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9989?vs=25687=26027
REVISION
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
translate-all (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9989
To: michaelh, smithjd, #frameworks, vhanda, lueck, lbeltrame
Cc: ngraham
65 matches
Mail list logo
