D10376: kio_file: skip error handling for initial perms during file copy

jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. Even moving to a ntfs filesystem without the rights to change owner doesn't end in an empty file. Very good job. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D10366: cmake: don't flag libnm-util as found when ModemManager is found

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH upstream-fixes REVISION DETAIL https://phabricator.kde.org/D10366 To: aleksanderm, #frameworks, jgrulich Cc: michaelh, ngraham

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah yeah, of course. Can't be inlined, since the impl needs to see the private class. Forget what I said, out-of-line it is, and yes, do keep the unittest ;) It at least guards against a

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. See, I almost asked in the previous commit "are you sure that this is going to be faster?", and this patch answers it. It's not. Which is logical, since you are not able to

D10378: Deprecate KFileItemList and introduce KFileItemListV2

dfaure added a comment. I would deprecate KFileItemList only when KFileItemVector is a valid replacement (i.e. all the APIs in KIO use KFileItemVector). Deprecating while people are still forced to use it, only leads to a habit of ignoring deprecation signals (since there's no other

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

This revision was automatically updated to reflect the committed changes. Closed by commit R824:5e4203cd323a: baloo-widgets: Emit metaDataRequestFinished once per request (authored by michaelh). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpluginfactory.h:211 > + */ > +#define K_PLUGIN_CLASS_WITH_JSON(classname, jsonFile) > K_PLUGIN_FACTORY_WITH_JSON(classname ## Factory, json, >

D7909: Add syntax support for Crystal Programming Language

faguilar updated this revision to Diff 26743. faguilar added a comment. Restricted Application added a project: Kate. Remove colors from itemData (suggested by @dhaumann) REPOSITORY R40 Kate CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7909?vs=19732=26743 REVISION DETAIL

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In https://phabricator.kde.org/D7909#199469, @dhaumann wrote: > Sorry for the late reply. > > Please do the following changes: > > - remove hard-coded colors from itemDatas. This way, your highlighting will look good in all color themes. > > Also,

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

markg added a comment. In https://phabricator.kde.org/D10341#202720, @markg wrote: > In https://phabricator.kde.org/D10341#202704, @dfaure wrote: > > > I like the idea of enabling moves for KFileItem very much. > > > > But here's a fun fact: your unittest passes even without the

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

markg updated this revision to Diff 26739. markg added a comment. Get rid of the temp file. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10380?vs=26738=26739 BRANCH refactor_dirlistercache REVISION DETAIL https://phabricator.kde.org/D10380 AFFECTED

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY This refactors KFileItemList uses to KFileItemListV2 where possible.

D10378: Deprecate KFileItemList and introduce KFileItemListV2

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Summary Deprecate KFileItemList. It's using QList and lacks move

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

markg added a comment. In https://phabricator.kde.org/D10341#202704, @dfaure wrote: > I like the idea of enabling moves for KFileItem very much. > > But here's a fun fact: your unittest passes even without the rest of the patch. > > PASS : KFileItemTest::testMove() > >

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/40/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Wed, 07 Feb 2018 23:14:37 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Feb 2018 23:14:37 + Build duration: 8 min 4 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 23:14:37 + Build duration: 6 min 33 sec and counting JUnit

D10257: KUrlMimeData: fix handling of PreferLocalUrls

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > mwolff wrote in kurlmimedata.cpp:67 > future cleanup: remove all the `QString::fromLatin1(s_...)` in this file with > a call to `QString kdeUriListMime() { return QStringLiteral("..."); }` OK, done in

D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D10333 REVISION DETAIL https://phabricator.kde.org/D10333 To: aacid, dfaure Cc: kossebau, apol, #frameworks, michaelh, ngraham

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

dfaure added a comment. I like the idea of enabling moves for KFileItem very much. But here's a fun fact: your unittest passes even without the rest of the patch. PASS : KFileItemTest::testMove() That's because std::move() doesn't move, it only makes the argument eligible

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Right, apart from the coding issues I found, the bigger issue is that this will not work, xdg templates are simple files I guess, not desktop files. In case you're wondering,

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. Is this committable? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

aacid added a comment. In https://phabricator.kde.org/D10333#202036, @kossebau wrote: > Makes sense to me to have a shorter version for the common case of just one registered plugin. Less boilerplate :) > > Please add a note in the API dox that this macro is for the case of just one

D10124: Faster simplejob start

dfaure added a comment. Looks good, but this means you can also remove the Q_PRIVATE_SLOT declaration for those slots defined in the private class (slotConnected, _k_foo etc.) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff,

D10333: Introduce K_PLUGIN_CLASS_WITH_JSON

aacid updated this revision to Diff 26729. aacid added a comment. add macro to KCoreAddons_AUTOMOC_MACRO_NAMES REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10333?vs=26623=26729 BRANCH arcpatch-D10333 REVISION DETAIL

D10358: Repair copying file to VFAT without warnings.

dfaure updated this revision to Diff 26728. dfaure added a comment. rebased CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10358?vs=26686=26728 BRANCH silence_vfat_warnings REVISION DETAIL https://phabricator.kde.org/D10358 AFFECTED FILES src/ioslaves/file/file.cpp

D10358: Repair copying file to VFAT without warnings.

dfaure added a comment. Proper fix for the data loss in https://phabricator.kde.org/D10376. I'll rebase this one on top of it, to keep the silencing of the other warnings over vfat (other than the "nobody shall be allowed to peek" code). REPOSITORY R241 KIO REVISION DETAIL

D10376: kio_file: skip error handling for initial perms during file copy

dfaure created this revision. dfaure added reviewers: chinmoyr, markg, jtamate. Restricted Application added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY This reverts the parts of https://phabricator.kde.org/R241:13ab6a85bbb8502fe47935f92f466e0223baa2ac

Re: Possible regression in kio with data loss

On mardi 6 février 2018 19:10:34 CET Mark Gaiser wrote: > On Tue, Feb 6, 2018 at 4:17 PM, Jaime wrote: > > Hi all, this is becoming urgent if next release is this weekend. > > It still happens to me (with kio just compiled from master) > > If it is then add the KIO master

D10358: Repair copying file to VFAT without warnings.

dfaure added a comment. OK, this shows that we need to fix a bigger issue before silencing the warnings on VFAT. But I just noticed something. The instructions you posted to kde-frameworks-devel for reproducing the bug are somewhat broken. sudo mount -t vfat -o

D10365: New icon for Elisa music player

andreask added a comment. Elisa is a new music player app (yes another one) cassettes are old-school yes, but the benefit is that it look like an old (stable well developed) app in addition it's way more unique than other music player apps. REPOSITORY R266 Breeze Icons REVISION DETAIL

D10365: New icon for Elisa music player

paullesur added reviewers: Breeze, VDG, Elisa, andreaska. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur, #breeze, #vdg, #elisa, andreaska Cc: andreaska, ltoscano, ngraham, #frameworks, paullesur, michaelh, ognarb, januz, kmf, progwolff,

D10365: New icon for Elisa music player

paullesur added a subscriber: andreaska. paullesur added a comment. In https://phabricator.kde.org/D10365#202503, @ngraham wrote: > Hmm, the old-skool cassette doesn't really blend in with Elisa's sleek, modern appearance IMHO. My first try for Elisa's icon looked like a small

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D10362: Swap reveal password button logic

elvisangelaccio added a comment. Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). Would it be possible to implement this feature like in the Windows 10 lock screen? (i.e. don't toggle the state; reveal the password

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added inline comments. INLINE COMMENTS > ktooltippositiontest.cpp:84 > +i.next(); > +//FIXME: Compose names w/o compiler warning -Wformat-security > + > QTest::addRow(QStringLiteral("small/%1").arg(i.key()).toLatin1().constData()) Any hints? REPOSITORY R236

D9973: ktooltipwidget: Fix tooltip positioning

michaelh marked 3 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham Cc: cfeck, michaelh, ngraham

D9973: ktooltipwidget: Fix tooltip positioning

michaelh updated this revision to Diff 26717. michaelh added a comment. - Correct author email REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9973?vs=26715=26717 BRANCH tooltip_and_test REVISION DETAIL https://phabricator.kde.org/D9973

D9973: ktooltipwidget: Fix tooltip positioning

michaelh updated this revision to Diff 26715. michaelh edited the test plan for this revision. michaelh added a comment. - Add KTooltipPositionTest to autotests - Make KToolTipWidget pass test REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @broulik Thanks :-) My idea was to add a submenu "own templates" to the menu but this would greatly exceed my knowledge. At the moment this is more try, error and debgugging, learning by doing ^^ Will try to improve this match further. REPOSITORY R241 KIO

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 19:10:06 + Build duration: 13 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Feb 2018 19:10:06 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/28/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 07 Feb 2018 19:10:06 + Build duration: 9 min 33 sec and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 18:42:41 + Build duration: 11 min and counting JUnit Tests

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

broulik added a comment. Pretty cool! How about moving the custom ones to the top below Folder? Imho if the user went through the trouble of adding custom templates, he or she is most likely to use them most often? Perhaps also add a separator line? REPOSITORY R241 KIO REVISION DETAIL

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10142 To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, schernikov, michaelh, ZrenBot,

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d38825d934e4: [server] Dont crash when a subsurface gets commited whose parent surface got… (authored by graesslin). Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/119/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 07 Feb 2018 18:07:00 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/100/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 18:07:00 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/120/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Feb 2018 18:07:00 + Build duration: 6 min 51 sec and counting JUnit Tests Name:

D9983: Don't stat(/etc/localtime) between read() and write() copying files

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8d73867b3d43: Dont stat(/etc/localtime) between read() and write() copying files (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10365: New icon for Elisa music player

ltoscano added a comment. But the 80s are back :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur Cc: ltoscano, ngraham, #frameworks, paullesur, michaelh, ognarb, januz, kmf, progwolff, andreask, mgallien

D10365: New icon for Elisa music player

ltoscano added a project: Elisa. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur Cc: ngraham, #frameworks, michaelh, ognarb, januz, kmf, progwolff, andreask, mgallien

D10365: New icon for Elisa music player

ngraham added a comment. Hmm, the old-skool cassette doesn't really blend in with Elisa's sleek, modern appearance IMHO. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur Cc: ngraham, #frameworks, michaelh

D10365: New icon for Elisa music player

paullesur added a comment. In https://phabricator.kde.org/D10365#202483, @ngraham wrote: > Screenshot please! F5697207: Screenshot_20180207_121553.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10365 To:

D10366: cmake: don't flag libnm-util as found when ModemManager is found

aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. aleksanderm requested review of this revision. REVISION SUMMARY Looks like a leftover from when this file was imported from NM. libnm-util has nothing to

D10365: New icon for Elisa music player

ngraham added a comment. Screenshot please! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur Cc: ngraham, #frameworks, michaelh

D10365: New icon for Elisa music player

paullesur created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. paullesur requested review of this revision. REVISION SUMMARY New icon for Elisa music player REPOSITORY R266 Breeze Icons BRANCH master REVISION

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. In https://phabricator.kde.org/D10300#202468, @lbeltrame wrote: > Ping? Why this has not been committed even if in "accepted" state? Because I wasn't at my system yet.

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

lbeltrame added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Ping? Why this has not been committed even if in "accepted" state? REPOSITORY R127 KWayland BRANCH subsurface-parent-destroyed REVISION DETAIL https://phabricator.kde.org/D10300

D10362: Swap reveal password button logic

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me, consistency is good. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg, ngraham Cc:

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks Cc: michaelh, ngraham

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac created this revision. mmustac added a reviewer: Frameworks. Restricted Application added a project: Frameworks. mmustac requested review of this revision. REVISION SUMMARY This patch adds the support for templates in the XDG_TEMPLATES_DIR location which points in default to: [en]

D10362: Swap reveal password button logic

starbuck added a comment. Dolphin screenshot where "eye crossed out=files hidden": https://user-images.githubusercontent.com/840070/34343479-cdc01690-e984-11e7-8728-2dac1e258c18.png Would further be also likely more consistent with other toggles in the future, like imagined on mobile

D10362: Swap reveal password button logic

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10362: Swap reveal password button logic

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10362: Swap reveal password button logic

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY Indicate state, not the action it will

D10358: Repair copying file to VFAT without warnings.

jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. Copying to a VFAT has no problems. Moving to a VFAT has the following problem: An Access Denied Information appears after the file have been created. In both cases, there

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/99/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 07 Feb 2018 09:40:03 + Build duration: 1 hr 1 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/119/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Feb 2018 09:40:03 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/118/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 07 Feb 2018 09:40:02 + Build duration: 6 min 33 sec and counting JUnit Tests Name:

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#202300, @vkrause wrote: > I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies. It doesn' needed to run anything @

D10358: Repair copying file to VFAT without warnings.

dfaure created this revision. dfaure added reviewers: chinmoyr, markg, jtamate. Restricted Application added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY The refactoring returned the wrong value, which led to warnings, but it was also in the wrong place.

D9983: Don't stat(/etc/localtime) between read() and write() copying files

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9983 To: jtamate, #frameworks, dfaure Cc: fvogt, ngraham, michaelh