D12228: kdirlister new connect syntax

dfaure added a comment. Signals having changed from protected to public in Qt5, the whole idea of preventing others to emit signals went down the drain anyway. Extending that to KJob we could make the signals non-private there, with strong documentation "don't emit this yourself". REPOSITOR

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32254. michaelh added a comment. - Remove unrelated whitespace change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32201&id=32254 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phab

D12218: Remove Reload button from the file dialogs' toolbar

broulik added a comment. Is it also accessible from the menu in the top right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32255. michaelh added a comment. - Wrap transaction operations REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32254&id=32255 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:344 > do the calls to m_transaction using a wrapper, e.g. > `DatabaseSanitizer::removeDocument(info.id)` I'm assuming you meant `DatabaseSanitizerImpl::removeDocument(info.id)`. If you meant `DatabaseSanitiz

D11945: Optimize AppArmor & SELinux highlighting and improve regex

dhaumann added a comment. Out of curiosity: why are you putting multiple items in the same line on the keyword lists? This bloats up the diff and makes a real review so much harder... :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags,

D12226: balooshow: Colorize only when attached to terminal

michaelh updated this revision to Diff 32256. michaelh added a comment. - Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32193&id=32256 BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 AFFECTED F

D12226: balooshow: Colorize only when attached to terminal

This revision was automatically updated to reflect the committed changes. Closed by commit R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32256&id=32257 REVIS

D12242: KJob public signals

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY KIO::KCoreDirLister connects to those signals, they must be public so the new connect syntax compiles. TES

D12235: Add XDG Output Protocol

romangg added a reviewer: romangg. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12235 To: davidedmundson, romangg Cc: #frameworks, michaelh, ngraham, bruns

D11945: Optimize AppArmor & SELinux highlighting and improve regex

nibags updated this revision to Diff 32260. nibags added a comment. - SELinux CIL: Add binaries and float. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11945?vs=32240&id=32260 BRANCH opt-apparmor-selinux (branched from master) REVISION DET

D11902: Add highlighting for GDB command listings and gdbinit files

mwolff added a comment. Ping? Or can I just commit? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11902 To: mwolff, vkrause, dhaumann, #kate Cc: #frameworks, michaelh, ngraham, bruns

D11902: Add highlighting for GDB command listings and gdbinit files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given we have unit tests + the static checker is happy (I assume), feel free to commit. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde

D11902: Add highlighting for GDB command listings and gdbinit files

This revision was automatically updated to reflect the committed changes. Closed by commit R216:88288f834175: Add highlighting for GDB command listings and gdbinit files (authored by mwolff). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11902?vs=

D11945: Optimize AppArmor & SELinux highlighting and improve regex

nibags added a comment. I thought it would be better if the keywords used fewer lines in the file. If it's more comfortable I can restore it to how it was before... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann Cc: #framewor

D11361: add a version containmentForScreen with activity

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bfa19dbc8fc7: add a version containmentForScreen with activity (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11361?vs=31200&id=32263#toc REPOSITORY R242 Plasma Framework

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/129/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Apr 2018 09:22:52 + Build duration: 2 min 49 sec and counting JU

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/104/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 09:22:52 + Build duration: 5 min 31 sec and counting

D12235: Add XDG Output Protocol

davidedmundson updated this revision to Diff 32266. davidedmundson added a comment. Some minor fixes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12235?vs=32227&id=32266 BRANCH davidedmundson/xdgoutput REVISION DETAIL https://phabricator.kde.org/D1

D12242: KJob public signals

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kjob.h:472 > * > - * This is a private signal, it can't be emitted directly by subclasses > of > + * @note: This is a private signal, it can't b

D12242: KJob public signals

jtamate updated this revision to Diff 32267. jtamate added a comment. Changed from "can't" to "shouldn't". REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12242?vs=32258&id=32267 REVISION DETAIL https://phabricator.kde.org/D12242 AFFECTED FILES src

D12242: KJob public signals

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D12242 To: jtamate, dfaure, #frameworks Cc: michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

apol added a comment. Landing, I'm unsure if it's worth re-spinning. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12216 To: apol, #frameworks, arojas Cc: michaelh, ngraham, bruns

D12225: Also make installation of translated docs optional

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R317 Kross BRANCH master REVISION DETAIL https://phabricator.kde.org/D12225 To: heikobecker, #frameworks, apol Cc: michaelh, ngraham, bruns

D12231: Reduce the number of zombies to a minimum

apol added a comment. https://phabricator.kde.org/D12216 Please check the list first... REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12231 To: tcberner, #freebsd, sitter, apol Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/130/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Apr 2018 11:36:58 + Build duration: 3 min 9 sec and counting JUn

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/105/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 11:36:58 + Build duration: 4 min 36 sec and counting

D12225: Also make installation of translated docs optional

This revision was automatically updated to reflect the committed changes. Closed by commit R317:03d503362514: Also make installation of translated docs optional (authored by heikobecker). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12225?vs=32186&id=32273 RE

D12216: Don't need to run previous iterations commands again

heikobecker added a comment. In D12216#247225 , @apol wrote: > I'm unsure if it's worth re-spinning ki18n. It's already out, so it would need a .1, but it may be worth it as it appears builds are hanging otherwise. REPOSITORY R249 KI18

D11204: Support NTFS hidden files

vonreth added a comment. The commit broke the build on mac. 11:43:10 /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:421:19: error: no matching function for call to 'getxattr' 11:43:10 auto lengt

D11204: Support NTFS hidden files

markg added a comment. In D11204#247248 , @vonreth wrote: > The commit broke the build on mac. > > 11:43:10 /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:4

D12231: Reduce the number of zombies to a minimum

tcberner abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12231 To: tcberner, #freebsd, sitter, apol Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

mart created this revision. mart added a reviewer: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY the grid view always takes the full kcm the extra space is added as space

D12244: new resize policy

mart edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

mart added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

mart added a comment. https://www.youtube.com/watch?v=6sXGiGUOSLU&feature=youtu.be https://www.youtube.com/watch?v=yN736sDWPHY&feature=youtu.be REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, br

D12244: new resize policy

ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

mart added a comment. F5809678: vokoscreen-2018-04-16_14-49-45.mkv REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Definitely worth a .1 REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D12216 To: apol, #frameworks, arojas, sitter Cc: sitter, heikobecker, michaelh,

D12218: Remove Reload button from the file dialogs' toolbar

ngraham added a comment. In D12218#247125 , @broulik wrote: > Is it also accessible from the menu in the top right? No, that's a settings menu, not a toolbar overflow menu. Ultimately the toolbar should be editable, to satisfy all possibl

D12216: Don't need to run previous iterations commands again

This revision was automatically updated to reflect the committed changes. Closed by commit R249:9c32bdab29b3: Don't need to run previous iterations commands again (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12216?vs=32157&id=32277 REVISIO

D12244: new resize policy

mart updated this revision to Diff 32280. mart added a comment. - binding loops -- REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12244?vs=32274&id=32280 BRANCH phab/newResizing REVISION DETAIL https://phabricator.kde.org/D12244 AFFECTED FILES

D12247: Use "Do x" action texts for drop menu entries

kossebau created this revision. kossebau added reviewers: VDG, Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Dropping some item onto a containment results in a menu w

D12247: Use "Do x" action texts for drop menu entries

kossebau added a comment. Example of dropping an SVG file onto the background: Before: F5809685: Screenshot_20180416_151514.png After: F5809689: Screenshot_20180416_150907.png REPOSITORY R242 Plasma Fr

D12247: Use "Do x" action texts for drop menu entries

kossebau added a comment. Alternativly one could change those menu section titles (which sadly are hard to recognize as such with Breeze theme) to be "Add Widgets" and "Set Wallpaper", and then list the widgets and wallpapers by their name as before, as kind of inlined submenus. Though tha

D12233: Avoid manipulation of lists with quadratic complexity

michaelh updated this revision to Diff 32285. michaelh added a comment. - Include omissions - Const! REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=3&id=32285 BRANCH remove-if (branched from master) REVISION DETAIL https://phabricator.kde

D12233: Avoid manipulation of lists with quadratic complexity

michaelh added inline comments. INLINE COMMENTS > bruns wrote in fileindexscheduler.cpp:148 > You can put the lambda into the `remove_if` invocation: > > auto tail = std::remove_if(list.begin(), list.end(), > [&dir](const QString& file) { >

D12244: new resize policy

mart added a dependent revision: D12088: port the ksplash kcm to the new design. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

mart added a dependent revision: D12090: port the look and feel kcm to new design. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: #frameworks, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. I personally find the reload button much more useful to have there. ... (looking at the buttons) ... Why not removing back, forward and up? This is not an ironic or sarcastic suggestion! Just be frank, how often do you use back? How often do you use forward (

D12244: new resize policy

mart updated this revision to Diff 32287. mart added a comment. - better centering REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12244?vs=32280&id=32287 BRANCH phab/newResizing REVISION DETAIL https://phabricator.kde.org/D12244 AFFECTED FILES

D12244: new resize policy

broulik added a comment. Fine in principle but it doesn't enforce any minimum spacing F5809738: Screenshot_20180416_164705.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12244 To: mart, #vdg, #plasma Cc: broulik, #f

D12244: new resize policy

mart updated this revision to Diff 32291. mart added a comment. - ensure items never overlap REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12244?vs=32287&id=32291 BRANCH phab/newResizing REVISION DETAIL https://phabricator.kde.org/D12244 AFFECT

D12218: Remove Reload button from the file dialogs' toolbar

rkflx added a comment. In D12218#247355 , @markg wrote: > And up? Well, it's twice in there already. You have the breadcrumb bar which allows you to go up. Not if you are in Edit mode (see bug for discussion). Also note that e.g. openSUS

D12244: new resize policy

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R296:ed25dc538941: new resize policy (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https:/

D10702: Always use a job to delete files to avoid freezing process waiting on IO

jtamate added a comment. > The current state is that it freezes as long as the file deletion (unlink) lasts. Ok, let's go for it. Another use case when this could be useful is when the filesystem is slow, one possible way to know if this is the case is using something like bo

D12247: Use "Do x" action texts for drop menu entries

ngraham added a comment. In D12247#247328 , @kossebau wrote: > Alternativly one could change those menu section titles (which sadly are hard to recognize as such with Breeze theme) Agreed, this definitely needs improvement. In D12247

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. >> Refresh on the other hand is something i use relatively often, more then any of the other buttons. > > Curious to know: What do you need Refresh for? Maybe there's need for some changes so you won't have to hit that button manually so often? As i said, it's

D11732: Improve protocols documentation

romangg added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11732 To: romangg, #frameworks Cc: davidedmundson, michaelh, ngraham, bruns

D11753: baloodb: Add clean command

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:187 > + > +bool isIgnored(const QStorageInfo& storageInfo, const > DatabaseSanitizer::ItemAccessFilters accessFilter) > +{ Are you planning to use this one anywhere else? Otherwise, inside `deviceFilters(...)`: aut

D12251: Integrate with androiddeployqt dependencies files

apol created this revision. apol added reviewers: Frameworks, vkrause, aacid. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Tell androiddeployqt where to look instead of just installing everything TEST PLAN okularpart gets in okul

D11753: baloodb: Add clean command

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:173 > + > +QMap deviceFilters(QVector& infos, const > DatabaseSanitizer::ItemAccessFilters accessFilter) > +{ Pass in a List/Set of deviceIds, and return the same type. > michaelh wrote in databasesanitizer.cpp:343 >

D12251: Integrate with androiddeployqt dependencies files

aacid added a comment. I'm not convinced at all parts are not in that folder. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

ngraham added a comment. In D12218#247400 , @markg wrote: > As i said, it's all relative. I barely use any of the buttons but the one i do use is refresh. > I only need it when i'm impatient (for instance when wanting to click on a file that

D12235: Add XDG Output Protocol

romangg added a task: T8501: Fractional Scaling. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12235 To: davidedmundson, romangg Cc: #frameworks, michaelh, ngraham, bruns

D12222: baloodb: Use complete access filtering for all outputs

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:252 > +auto& summary = listResult.second; > for (const auto& info: listResult.first) { > +if (ignoredDevices[info.id] == false) { If ignoredDevices is a Set/List, you can do a filter pass over the fileList fir

D12242: KJob public signals

This revision was automatically updated to reflect the committed changes. Closed by commit R244:c0b312a41f7f: KJob public signals (authored by jtamate). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12242?vs=32267&id=32307 REVISION DETAIL https://phabri

D12233: Avoid manipulation of lists with quadratic complexity

bruns added inline comments. INLINE COMMENTS > michaelh wrote in fileindexscheduler.cpp:148 > I suppose developers on my level will appreciate code to be most > self-explanatory. I'm not objecting though, we might al well go "all the way": > > list.erase(std::remove_if(list.begin(), list.end(

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/73/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Apr 2018 17:07:48 + Build duration: 3 min 8 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/56/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 17:07:48 + Build duration: 3 min 39 sec and counting JUnit Tes

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Apr 2018 17:07:48 + Build duration: 6 min 33 sec and counting JUnit Tests

D11874: change 24px view-media-artist icon

astippich added a reviewer: andreask. astippich added a comment. ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

apol updated this revision to Diff 32313. apol added a comment. Document installation process REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12251?vs=32301&id=32313 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 AFFECTED FILES src/

D12251: Integrate with androiddeployqt dependencies files

apol added a comment. Related and reason of albert's comment: https://phabricator.kde.org/D12250 REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. In D12218#247481 , @ngraham wrote: > In D12218#247400 , @markg wrote: > > > As i said, it's all relative. I barely use any of the buttons but the one i do use is refresh. > >

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32320. michaelh marked 17 inline comments as done. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32255&id=32320 BRANCH sanitize-clean (branched from master

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:173 > Pass in a List/Set of deviceIds, and return the same type. Your suggestion in D1 can be reused. I'll do it there. > bruns wrote in databasesanitizer.cpp:187 > A

D12222: baloodb: Use complete access filtering for all outputs

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:252 > If ignoredDevices is a Set/List, you can do a filter pass over the fileList > first. > > auto& fileList = listResult.first; > auto tail = fileList.end(); > for (auto deviceId : ignoredDevices) { >

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32321. michaelh added a comment. - Use remove_if REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32176&id=32321 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D12222: baloodb: Use complete access filtering for all outputs

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:180 > + [deviceId,&summary] (const FileInfo& info) { > + summary.accessible += info.accessible; > + return info.id == deviceId; How can this

D12233: Avoid manipulation of lists with quadratic complexity

michaelh updated this revision to Diff 32322. michaelh added a comment. - Apply suggested change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=32285&id=32322 BRANCH remove-if (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D12233: Avoid manipulation of lists with quadratic complexity

michaelh marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12233: Avoid manipulation of lists with quadratic complexity

michaelh marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:240 > +// Save the view settings before closing the dialog when the Escape key > +// is presed or the close button in the titlebar is clicked > +void KDEPlatformFileDialog::reject() typo: pressed REPOSITORY

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham marked an inline comment as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D12240 To: ngraham, #frameworks Cc: elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham updated this revision to Diff 32338. ngraham added a comment. Fix typo REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12240?vs=32236&id=32338 BRANCH save-view-config-on-close-and-escape (branched from master) RE

D12222: baloodb: Use complete access filtering for all outputs

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:179 > +tail = std::remove_if(infos.begin(), tail, > + [deviceId,&summary] (const FileInfo& info) { > + summary.accessible += info.accessible; missing space > da

D12218: Remove Reload button from the file dialogs' toolbar

rkflx added a comment. Can we find a compromise? For example, the Places panel already seems to know when something is on a remote location. Could we show Refresh only for remote folders? The toolbar reorganizing itself would also make users aware of the need to manually refresh in some case

D12269: Don't install plugins within lib on android

apol created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. apol requested review of this revision. REVISION SUMMARY Otherwise we hit a weird code path on androiddeployqt. This is what the offic

D12270: Create a public function to access the actionMenu

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Create a public function to access the actionMenu, so clients and subclasses can manipulate it as they see fit.

D12227: Save the dialog view settings even when canceling

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12227: Save the dialog view settings even when canceling

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12239 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

anthonyfieroni added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:243 > +{ > +m_fileWidget->writeViewConfig(); > +QDialog::reject(); You can see at line 108 on reject is called slotCancel, so for convenience just call it m_fileWidget->slotCancel(); Then you can

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

anthonyfieroni added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:108 > m_buttons->addButton(m_fileWidget->cancelButton(), > QDialogButtonBox::RejectRole); > connect(m_buttons, SIGNAL(rejected()), m_fileWidget, SLOT(slotCancel())); > connect(m_fileWidget->okB

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham updated this revision to Diff 32361. ngraham added a comment. Use a vastly cleaner and cleverer approach (thanks @anthonyfieroni) REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12240?vs=32338&id=32361 BRANCH save

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:108 > Even better to me should be > > connect(this, &KDEPlatformFileDialog::rejected, m_fileWidget, > &KFileWidget::slotCancel); > > PS: You can

  1   2   >