D12295: Supporting nested brackets for Kate autobrackets

ngraham added reviewers: Kate, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: sraizada, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking,

D12295: Supporting nested brackets for Kate autobrackets

sraizada updated this revision to Diff 34333. sraizada added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Improved patch, closing brackets get eaten properly in all cases I tested. The only issue I found is that

D12932: handle string lists as input

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Output looks sane for me. REPOSITORY R293 Baloo BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D12932: handle string lists as input

astippich added a comment. with D11365 applied (e.g. multiple entries are string lists) and using a file with multiple artists balooshow -x testmultiple.opus Bitrate: 67000 Channels: 1 Duration: 1 Genre:

D12932: handle string lists as input

bruns added a comment. Can you do a manual test on an appropriate file, and add the output (before and after) for `balooshow -x `? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D12932: handle string lists as input

bruns added a comment. looks good, although untested REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D11365: also test for value types in taglibextractortest and fix errors

bruns added inline comments. Restricted Application added a subscriber: kde-frameworks-devel. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:389 > Are you sure we need this cast ? I do not think we will ever need to have > negative track numbers added. The original type is unsigned int

D12932: handle string lists as input

astippich updated this revision to Diff 34323. astippich added a comment. - fix mistakes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34318=34323 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES

D12932: handle string lists as input

bruns added inline comments. INLINE COMMENTS > result.cpp:90 > +bool shouldBeIndexed = > KFileMetaData::PropertyInfo(property).shouldBeIndexed(); > +for (const auto& val : value.toStringList()) > +{ `const auto list = value.toStringList();`, to avoid detach. >

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel, andreaska, markg, broulik,

D12932: handle string lists as input

astippich marked 4 inline comments as done. astippich added a comment. Thanks, and sorry, copied and pasted too quickly without thinking this through REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D12932: handle string lists as input

astippich updated this revision to Diff 34318. astippich added a comment. - incorporate feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34314=34318 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES

D12932: handle string lists as input

bruns added inline comments. INLINE COMMENTS > result.cpp:90 > +const QStringList val = value.toStringList(); > +if (val.isEmpty()) > +return; this check is not strictly necessary - if the list is empty, you iterate zero times in the loop. But see below [1] >

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham marked an inline comment as done. ngraham added a comment. Any opinions from #frameworks folks? REPOSITORY R241 KIO BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin,

D12932: handle string lists as input

astippich added a comment. Unfortunately I couldn't find tests that execute this code path. Do we have test for this somewhere? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, ngraham, bruns

D12932: handle string lists as input

astippich created this revision. astippich added a reviewer: bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY handles string lists as inputs for

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > rkflx wrote in kdiroperator.cpp:1888 > I think it is a misconception that toolbar icons represent state. I don't > know of any toolbar in our software where this is the case, so why should > users

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham updated this revision to Diff 34313. ngraham added a comment. `view-sort-ascending` it is, for now REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=34312=34313 BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham updated this revision to Diff 34312. ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Merge master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=33498=34312 BRANCH arcpatch-D12337 REVISION DETAIL

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

This revision was automatically updated to reflect the committed changes. Closed by commit R302:49f871844632: Check if group LastGroup, as KIconEffect doesnt handle UserGroup anyway (authored by fabiank). Restricted Application edited subscribers, added: kde-frameworks-devel; removed:

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > org_kde_plasma_virtual_desktop.xml:4 > +

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

apol added a comment. LGTM REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12905 To: heikobecker, ilic Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/17/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 16 May 2018 11:47:03 + Build duration: 1 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 16 May 2018 12:00:54 + Build duration: 53 min and counting

D9653: [FStab Handling] Clean up process running by using lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit R245:967dc53dc9a5: [FStab Handling] Clean up process running by using lambdas (authored by broulik). Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/111/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 16 May 2018 11:47:03 + Build duration: 37 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 159 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/159/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 16 May 2018 12:00:54 + Build duration: 4 min 49 sec and counting

D12876: [Dialog] Handle dialog being minimized gracefully

This revision was automatically updated to reflect the committed changes. Closed by commit R242:11f4e5b392ac: [Dialog] Handle dialog being minimized gracefully (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 262 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/262/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 16 May 2018 11:47:03 + Build duration: 11 min and counting JUnit Tests Name: (root)

D12876: [Dialog] Handle dialog being minimized gracefully

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12876 To: broulik, #plasma, mart Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fc6b85b832c7: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle… (authored by broulik). Restricted Application removed a subscriber: Frameworks. REPOSITORY R241 KIO

D12876: [Dialog] Handle dialog being minimized gracefully

mart added inline comments. INLINE COMMENTS > broulik wrote in dialog.cpp:1371 > We don't know the previous state of the window with `windowState` (singular, > pre-5.10 API) so we cannot restore a full screen or maximized state. Not sure > if that is a usecase, though. Anyway, this new API

D12820: Add KWayland virtual desktop protocol

romangg added a comment. In D12820#263516 , @mart wrote: > but then... how to manage collisions? allowing to set the same row/column to different desktops and make kwin responsibility of this not happening? For a layout change the

D12919: [Plotter] Don't render if m_node is null

broulik added a comment. > Do you know if that bug reporter had 2617a2ab9d472a78559f11ee8d430d951e3335f2 applied? Given it said Frameworks 5.46 I would assume so REPOSITORY R296 KDeclarative REVISION DETAIL

D12820: Add KWayland virtual desktop protocol

mart added a comment. so: - the manager just having a maximum_rows event, which tells that's the boundary of rows the kayout should have or... not even that (then the setting of maximum row/columns becomes completely kwin internal) - the location managed completely internally

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Wed, 16 May 2018 09:22:17 + Build duration: 2 min 1 sec and counting JUnit Tests

D12924: Process DBus replies in the ::match thread

This revision was automatically updated to reflect the committed changes. Closed by commit R308:56382f8d9a80: Process DBus replies in the ::match thread (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12924?vs=34270=34273

D12924: Process DBus replies in the ::match thread

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH master REVISION DETAIL https://phabricator.kde.org/D12924 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12924: Process DBus replies in the ::match thread

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY

D12919: [Plotter] Don't render if m_node is null

davidedmundson added a comment. Have you seen 2617a2ab9d472a78559f11ee8d430d951e3335f2 The point we set m_node to null we disconnect the connection that calls render. Do you know if that bug reporter had

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added a comment. Restricted Application removed a subscriber: Frameworks. Any suggestion how to fix the overload problem? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel,

D12919: [Plotter] Don't render if m_node is null

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Sounds good to me. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12919 To: broulik, #plasma, bshah Cc: bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D12919: [Plotter] Don't render if m_node is null

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `m_node` is deleted when window changes, we would

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Wed, 16 May 2018 06:39:51 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 16 May 2018 06:39:51 + Build duration: 1 min 47 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Wed, 16 May 2018 06:39:51 + Build duration: 1 min 43 sec and counting JUnit Tests Name:

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

This revision was automatically updated to reflect the committed changes. Closed by commit R237:c1fa17e99ad9: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file (authored by maximilianocuria). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE