D13714: Fix broken url to API specification

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. TEST PLAN checked link in browser REPOSITORY R235 Attica BRANCH master REVISION DETAIL https:/

D13714: Fix broken url to API specification

habacker added a reviewer: mlaurent. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D13714 To: habacker, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13714: Fix broken url to API specification

habacker updated this revision to Diff 36629. habacker added a comment. - fixed author REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13714?vs=36628&id=36629 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13714 AFFECTED FILES README.md

D13714: Fix broken url to API specification

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13714 To: habacker, mlaurent, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13714: Fix broken url to API specification

This revision was automatically updated to reflect the committed changes. Closed by commit R235:864107a0184a: Fix broken url to API specification (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13714?vs=36629&id=36630 REVISION DETAIL h

D13257: [server] Send frame event instead of flush on relative pointer motion

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. You're matching the buttonReleased/buttonPressed/axis/etc events. So +2 for the immediate fix. But longterm the point of sendFrame is to help batching so the current cod

D13706: [KMoreTools] Enable installing tools via appstream url

dhaumann resigned from this revision. dhaumann added a comment. This revision is now accepted and ready to land. @ngraham Since you know more about installation (e.g. via Discover), I would like you to give another +1, if possible. REPOSITORY R304 KNewStuff BRANCH appstream REVISION DET

D13706: [KMoreTools] Enable installing tools via appstream url

dhaumann added a comment. The API documentation can / should still be improved. I tried to give an example of possible improvements. INLINE COMMENTS > kmoretools.h:490 > + * @since 5.48 > + * @return The service' appstream id > + */ What about this: /** * Returns the assoc

D13718: Support choosing .ico files in custom icon file chooser

ngraham created this revision. ngraham added reviewers: Frameworks, cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY .ico files work fine, so we should allow the

D13718: Support choosing .ico files in custom icon file chooser

ngraham edited the summary of this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13719: OdfExtractor: deal with non-common prefix names

kossebau created this revision. kossebau added a reviewer: vandenoever. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Autotest odfextractortest still works. R

D13706: [KMoreTools] Enable installing tools via appstream url

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Tried this out. It's a really great feature to support installation via the AppStream URL--the logical next step after an app has been recommended to you. I tried a few and inst

D13721: [ECMGenerateHeaders] Add option for other header file extension than .h

kossebau created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Quite some C++-based projects do not use .h as header fil

D13718: Support choosing .ico files in custom icon file chooser

cfeck added a comment. But does it actually work? Our icon loader removes the extension, and tries to find the icon with a set of known extensions (grep -i xpm in kiconloader.cpp). REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks,

D13718: Support choosing .ico files in custom icon file chooser

ngraham added a comment. It does actually work; I tried it. The bug reporter also reported that it worked for him too if he manually entered the path to a .ico file. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks, cfeck Cc: kde-fr

D13722: Don't export kf5-config to the CMake config file

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY It's not needed during building, but the corresponding find_package call will check fo

D13719: OdfExtractor: deal with non-common prefix names

vandenoever accepted this revision. vandenoever added a comment. This revision is now accepted and ready to land. Good fixes. Just some small naming suggestions. INLINE COMMENTS > odfextractor.cpp:37 > + > +QDomElement namedItemNS(const QDomNode &node, const QString &nsURI, const > QString &

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

aacid added inline comments. INLINE COMMENTS > global.cpp:44 > +KFormat::BinaryUnitDialect > dialect(KFormat::BinaryUnitDialect(mainGroup.readEntry("BinaryUnitDialect", > int(KFormat::DefaultBinaryDialect; > +dialect = > static_cast(mainGroup.readEntry("BinaryUnitDialect", > int(d

D13719: OdfExtractor: deal with non-common prefix names

kossebau updated this revision to Diff 36647. kossebau added a comment. Update to Jos' feedback (thanks for that) Using "firstChildElementNS" as name for the method, so it's closer to QDomNode API and more telling what it does If no-one has further comments, would commit on Wednesda

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg edited the summary of this revision. REPOSITORY R127 KWayland BRANCH fixRelativeMotionFrame REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg, #plasma, #kwin, #frameworks, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

gregormi added a comment. In D13706#282765 , @ngraham wrote: > I'd like to see the missing AppStream URLs filled in for all the software in this list. There are currently some claring omissions, especially for KDE software (e.g. ksysguard) for w

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

pino added inline comments. INLINE COMMENTS > aacid wrote in global.cpp:44 > Am i reading the code wrong or are we doing the readEntry twice? (i know the > old code did the same) > > Do you understand why? > Am i reading the code wrong or are we doing the readEntry twice? (i know the > old co

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36650. nicolasfella added a comment. - doc++ REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36620&id=36650 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED FILES src/

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36651. nicolasfella added a comment. - Add more appstream ids REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36650&id=36651 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFE

D13706: [KMoreTools] Enable installing tools via appstream url

ngraham added inline comments. INLINE COMMENTS > kmoretoolspresets.cpp:60 > +ADD_ENTRY("angrysearch",0, > "https://github.com/DoTheEvo/ANGRYsearch";, ""); > +ADD_ENTRY("com.uploadedlobster.peek", 0, > "https://github.com/phw/peek";, ""); // easy to use

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36652. nicolasfella added a comment. o - Even more appstream ids. Thanks Nate REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36651&id=36652 BRANCH appstream REVISION DETAIL https://phabricator.kde

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella marked 9 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, ngraham Cc: ngraham, dhaumann, kde-frameworks-devel, michaelh, bruns

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio added a comment. +1, thanks! REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidor

D13706: [KMoreTools] Enable installing tools via appstream url

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Here's the last of the apps for which I could find upstream AppStream information: After those are updated, I'm good with this! INLINE COMMENTS > kmoretoolspresets.cpp:61 > +ADD

D13706: [KMoreTools] Enable installing tools via appstream url

This revision was automatically updated to reflect the committed changes. Closed by commit R304:84432a55e969: [KMoreTools] Enable installing tools via appstream url (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13706?vs=36652&id=36655#toc REPOSITORY R304 KN

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 25 Jun 2018 21:20:37 + Build duration: 1 min 33 sec and counting JUnit Tests

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

aacid added inline comments. INLINE COMMENTS > global.cpp:58 > > -const int precision = (unit == 0) ? 0 : 1; // unit == 0 -> Bytes, no > rounding > -return dialectUnits.at(unit).arg(QLocale().toString(size, 'f', > precision)); > +return KFormat().formatByteSize(fileSize, -1, diale

D13729: Isolate every test within WaylandOutputManagement

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The current code used the same outp

D13730: Fix memory management in WaylandOutputManagement

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY There was no destructor in the prot

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

pino updated this revision to Diff 3. pino marked an inline comment as done. pino added a comment. Fix precision passed to formatByteSize(). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13549?vs=36179&id=3 BRANCH kformat (branched from master) REV

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

pino marked an inline comment as done. pino added inline comments. INLINE COMMENTS > aacid wrote in global.cpp:58 > Should this -1 be 1? Looking at the kformat code it'll use that unless unit > is 0 so the old code would be using 1 and the new one -1 Indeed, 1 is the right value, and `KFormat`