KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/88/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 02 Jul 2018 02:02:35 + Build duration: 7 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 02 Jul 2018 02:02:35 + Build duration: 4 min 2 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/33/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Jul 2018 02:02:35 + Build duration: 3 min 8 sec and counting JUnit Tests

D13829: Lua: fix multi-line string

ngraham added reviewers: cullmann, KTextEditor, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13829 To: jpoelen, dhaumann, cullmann, #ktexteditor, #kate Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13813: make this test work again with new uds implementation

ngraham added a comment. FWIW, I'd be okay with bumping the minimum KIO version to 5.47 in master. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks, elvisangelaccio Cc: ngraham, bruns, elvisangelaccio, kfm-devel, spoorun,

D13814: Speedup sort

apol added a comment. +1 otherwise. INLINE COMMENTS > kfileitemmodel.cpp:1715 > { > -KFileItemModelLessThan lessThan(this, m_collator); > +auto lanbdaLessThan = [&] (const KFileItemModel::ItemData* a, const > KFileItemModel::ItemData* b) > +{ it's "lambda". REPOSITORY R318

D13124: [RFC] Add Share action to Dolphin context menu

apol added a comment. Looks good to me overall. Maybe it would make sense to call it ShareFileItemAction everywhere? "purpose" is an implementation detail here. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg,

D13559: Fix some of cppcheck warnings

apol added a comment. I don't see any fix here. It's just silencing cppcheck. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13403: Android: Make it possible to override a target's APK directory

apol updated this revision to Diff 37024. apol added a comment. Remove unrelated change REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13403?vs=35751=37024 BRANCH arcpatch-D13403 REVISION DETAIL https://phabricator.kde.org/D13403

D13643: Add LabPlot project file icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 182 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/182/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 01 Jul 2018 22:16:54 + Build duration: 3 min 13 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/32/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 01 Jul 2018 22:16:55 + Build duration: 3 min 25 sec and counting

D13643: Add LabPlot project file icon

abetts added a comment. Oh great! I thought the team was looking for a logo. Then, I have nothing more to add. It looks great. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: abetts, asemke, ngraham,

D13643: Add LabPlot project file icon

ngraham added a comment. In D13643#285745 , @abetts wrote: > My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo. But it //is// a file icon... Typically the

D13813: make this test work again with new uds implementation

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. In D13813#285441 , @jtamate wrote: > Updated the patch with context. > > It will not work with kio previous to

D13805: Present error dialog when user tries to create directory named "." or ".."

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > knewfilemenu.cpp:860 > +// Test to see if the user has given "." or ".." as a name > +if (name == "." || name ==

D13643: Add LabPlot project file icon

abetts added a comment. My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: abetts,

D13643: Add LabPlot project file icon

asemke added a comment. Thank for this work. It looks nice to me. However, maybe it's better for people from VDG and Breeze teams to accept this or to raise objections. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg,

D13814: Speedup sort

markg added a comment. In D13814#285686 , @bruns wrote: > In D13814#285660 , @markg wrote: > > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race

D13805: Present error dialog when user tries to create directory named "." or ".."

dfaure added a comment. Well, it makes sense for this check to be at the GUI level, the user interaction can be better adapted then, as in this patch. KIO::mkpath("/home/dfaure/tmp/.") should at least not warn or error in any way IMHO. (btw mkdir of such a path, on the command

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. @apol ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13814: Speedup sort

jtamate updated this revision to Diff 37019. jtamate added a comment. Can not use the name lessThan because of: error: use of ‘lessThan’ before deduction of ‘auto’ REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37010=37019 REVISION DETAIL

D13814: Speedup sort

jtamate added a comment. In D13814#285691 , @bruns wrote: > I assume you are sorting by name with "natural sorting". There may be another possibility for speedup here: > `QCollator::sortkey()`, http://doc.qt.io/qt-5/qcollator.html#sortKey

D13814: Speedup sort

bruns added a comment. I assume you are sorting by name with "natural sorting". There may be another possibility for speedup here: `QCollator::sortkey()`, http://doc.qt.io/qt-5/qcollator.html#sortKey It might be possible to generate the sortkey in e.g.

D13814: Speedup sort

jtamate updated this revision to Diff 37010. jtamate added a comment. Remove the _ prefix. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=36953=37010 REVISION DETAIL https://phabricator.kde.org/D13814 AFFECTED FILES

D13814: Speedup sort

jtamate added a comment. In D13814#285686 , @bruns wrote: > In D13814#285660 , @markg wrote: > > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was

D13814: Speedup sort

bruns added a comment. In D13814#285660 , @markg wrote: > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race conditions?). You could look back in the commit log when that was added to figure

D13829: Lua: fix multi-line string

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Strings that end with

D13814: Speedup sort

markg added a comment. > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race conditions?). You could look back in the commit log when that was added to figure out more about it. To answer that myself, it was done in this commit:

D13814: Speedup sort

markg added a comment. +1 Great! :) Back to the good old fast performance it once had! Please do get rid of the underscore before the name. Nothing (afaict) does that in Dolphin, lets not introduce it. Just lessThan is fine. Also, note that this was done for a reason. I think it

D13828: Revert "updated Japanese holidays (in Japanese and English)"

phanect edited the summary of this revision. phanect added reviewers: KDE PIM, Frameworks, winterz, mlaurent. phanect added subscribers: winterz, mlaurent. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. Sorry, I made another code review request by mistake: https://phabricator.kde.org/D13828 Please close this request and continue with D13828 . REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect edited the summary of this revision. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni added a comment. Also notice functions after https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$1693 there is no guaranteed that they should be run in same thread. I manage to downgrade Qt 5.11 and upgrade again there is not broken icons after.

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is green https://build.kde.org/job/test/19/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 37004. bshah added a comment. - fix tests REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36992=37004 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D13559: Fix some of cppcheck warnings

bshah added a comment. bump? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 37000. rjvbb added a comment. KThemeSettings moved to its own header+implementation files, and extended so different groups can be read. I don't think it needs much else in terms of functionality or complexity, if anything. There's no point in exporting it

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 103 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/103/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Sun, 01 Jul 2018 10:24:38 + Build duration: 23 min and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/21/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 01 Jul 2018 10:30:50 + Build duration: 7 min 32 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 181 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/181/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 01 Jul 2018 10:24:39 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/20/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 01 Jul 2018 10:22:42 + Build duration: 8 min 5 sec and counting JUnit

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is unstable Link to build: https://build.kde.org/job/test/18/ See console output for more information: https://build.kde.org/job/test/18/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc:

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36992. bshah added a comment. - less fun, but this time try failing unit test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36991=36992 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B520: Diff 36991! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/17/ See console output for more information: https://build.kde.org/job/test/17/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36991. bshah added a comment. - find qt5 fun, because that will make build fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36989=36991 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is green https://build.kde.org/job/test/16/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36989. bshah added a comment. - final change handover chnage REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36988=36989 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is green https://build.kde.org/job/test/15/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B517: Diff 36988! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/14/ See console output for more information: https://build.kde.org/job/test/14/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36988. bshah added a comment. - enough derps REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36987=36988 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/13/ See console output for more information: https://build.kde.org/job/test/13/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B516: Diff 36987! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36987. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36986=36987 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bshah

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. @ngraham Name: Thomas Marshall Email: tmarshall7...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham,

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B515: Diff 36986! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/12/ See console output for more information: https://build.kde.org/job/test/12/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36986. bshah added a comment. - derp REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36985=36986 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To: bshah

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B514: Diff 36985! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 36985. bshah added a comment. - edit 4, to check change handover works REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=36982=36985 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/test/11/ See console output for more information: https://build.kde.org/job/test/11/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci,

D13819: dummy commit to test pre-review CI

bshah created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Harbormaster failed remote builds in B508: Diff 36977! Harbormaster returned this revision to the author for changes because remote builds failed.