D13674: Make it possible to go up to root again

jtamate added a comment. In D13674#288162 , @dfaure wrote: > somehow stub out any actual kioslave usage, and *just* test URLs. Please, check https://phabricator.kde.org/D13939 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.k

D13940: Add syntax highlighting support for Stan

jeffreyarnold created this revision. jeffreyarnold added a reviewer: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jeffreyarnold requested review of this revision. REVISION SUMMARY Add syntax h

D13940: Add syntax highlighting support for Stan

pino added a comment. It looks like your forgot to include the actual `highlight.stan` file for the test suite, can you please amend this commit to include it? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13940 To: jeffreyarnold, #framework_syntax_hig

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin added a comment. In D13921#288012 , @ngraham wrote: > There's a problem with the git setup on the computer you used to make this commit; the `name` field appears to be empty, so I get an error when I try to apply the patch

D13814: Speedup sort

jtamate updated this revision to Diff 37305. jtamate added a comment. My crashes are gone just doing a single comparison using the collator at the constructor. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37273&id=37305 REVISION DETAIL https:

D13670: Add subseq operator to match sub-sequences

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Perfect, thanks! REPOSITORY R309 KService BRANCH feature/match-subseq REVISION DETAIL https://phabricator.kde.org/D13670 To: michaeleden, dfaure, #frameworks Cc: kde-frameworks-deve

D13939: Don't ask for passwords in kfilewidgettest

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, that's one way. Somewhat obvious (it becomes a test for QUrl API basically), but yeah, KFileWidget doesn't have a mock mechanism for the actual KIO operations. Thanks. REPOSITORY

D13939: Don't ask for passwords in kfilewidgettest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:aca95c9df958: Don't ask for passwords in kfilewidgettest (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13939?vs=37302&id=37306 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/71/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 08 Jul 2018 08:53:00 + Build duration: 5 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 314 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/314/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Jul 2018 08:52:59 + Build duration: 26 min and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 161 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/161/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 08 Jul 2018 08:53:00 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed

D13941: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13943: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13814: Speedup sort

markg added a comment. Somehow i'm inclined to think that m_collator is wrong. But inspecting the code shows no issue as far as i can tell. It's a normal class member that lives as long as the KFileItemModel instance lives. Now here's a tricky part. KFileItemModel is new'ed for each vie

D13944: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: ltoscano. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 30 - Aborted!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.10/31/ Project: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Jul 2018 10:05:23 + Build duration: 2.9 sec and counting CONSOLE OUTPUT

D13945: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests ib BUILD_TESTING is on TEST PLAN Buil

D13946: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13947: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: mdawson, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLA

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 32 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.10/32/ Project: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Jul 2018 10:31:24 + Build duration: 6.2 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 33 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.10/33/ Project: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Jul 2018 10:32:29 + Build duration: 7.6 sec and counting CONSOLE OUTPUT

D13948: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Build

D13949: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13950: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13951: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13952: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13952: Honor BUILD_TESTING

arojas updated this revision to Diff 37319. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13952?vs=37318&id=37319 REVISION DETAIL https://phabricator.kde.org/D13952 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michael

D13953: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13954: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13955: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13956: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: davidedmundson, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on T

D13957: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Build

D13958: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: dfaure, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PL

D13958: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D13958 To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13959: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13960: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13958: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R310:347d932b9a49: Honor BUILD_TESTING (authored by arojas). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13958?vs=37325&id=37328 REVISION DETAIL https://phabri

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 08 Jul 2018 11:39:06 + Build duration: 6 min 10 sec and counting JUnit

D13962: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13963: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13964: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: mck182, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13965: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: valir, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN

D13941: Honor BUILD_TESTING

elvisangelaccio added a comment. Isn't `BUILD_TESTING` already honored by `ecm_add_tests` ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13941 To: arojas, dfaure Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

elvisangelaccio added a comment. @jtamate Can you show a complete gdb backtrace + valgrind log of this crash? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio Cc: elvisangelaccio, apol, bruns, markg, kfm

D13941: Honor BUILD_TESTING

arojas added a comment. There's more stuff being built inside tests and autotests besides ecm_add_tests REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13941 To: arojas, dfaure Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D13570: Add workaround for labels with word-wrapping

elvisangelaccio added a reviewer: cfeck. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13570 To: elvisangelaccio, davidedmundson, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13570: Add workaround for labels with word-wrapping

elvisangelaccio added a comment. Ping. If no one has objections, I'll push it after the next tag. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13570 To: elvisangelaccio, davidedmundson, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13316: manually set format in jpeg thumbnail creator

elvisangelaccio added a comment. I guess this change makes sense (given that we are in the jpeg plugin), but what about `QImageReader::decideFormatFromContent()` ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #framew

D13948: Honor BUILD_TESTING

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13948 To: arojas, cfeck Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D13948: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R236:00175c834fb8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13948?vs=37314&id=37341 REVISION DETAIL https://phab

D13570: Add workaround for labels with word-wrapping

cfeck added a comment. Could you add a bug number so that people reading the code can decide if/when the workaround can get removed? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13570 To: elvisangelaccio, davidedmundson, cfeck Cc: kde-frameworks-devel, mic

D13670: Add subseq operator to match sub-sequences

michaeleden added a comment. @dfaure I don't believe I have permission to edit the wiki, can I make a revision against it somehow? REPOSITORY R309 KService BRANCH feature/match-subseq REVISION DETAIL https://phabricator.kde.org/D13670 To: michaeleden, dfaure, #frameworks Cc: kde-fram

D13812: Revert "updated Japanese holidays (in Japanese and English)"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:1c2ecfbf9570: holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect (authored by winterz). REPOSITOR

D13814: Speedup sort

jtamate added a comment. In D13814#288615 , @elvisangelaccio wrote: > @jtamate Can you show a complete gdb backtrace + valgrind log of this crash? Here you are F6051257: dolphin.crash.log REPOSITOR

D13627: [KSharedDataCache] Assume lock before flush changes

anthonyfieroni retitled this revision from "[KIconThemes] Isolate private data from race conditions" to "[KSharedDataCache] Assume lock before flush changes". anthonyfieroni edited the summary of this revision. anthonyfieroni added a reviewer: mpyne. anthonyfieroni changed the repository for this

D13627: [KSharedDataCache] Assume lock before flush changes

anthonyfieroni updated this revision to Diff 37343. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13627?vs=36742&id=37343 REVISION DETAIL https://phabricator.kde.org/D13627 AFFECTED FILES src/lib/caching/kshareddatacache.cpp To: anthonyfieroni, davi

D13970: Handle empty preview lists

cordlandwehr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Do not access the first list's element if the list possibly might be empty.

D13814: Speedup sort

jtamate added a comment. Reading the source of QCollator*, I guess the hack works because I get a collator where d->dirty is true, and in compare there is this code if (d->dirty) d->init(); Once initialized, I don't see any other modification of QCollator members. Probabl

D13814: Speedup sort

elvisangelaccio reopened this revision. This revision is now accepted and ready to land. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarrom

D13814: Speedup sort

elvisangelaccio added a comment. Hmm, so the crash is in `ucol_close()` (aka in ICU) and we are working around it by forcing the cleanup in the KFileItemModel ctor (= single thread). Sounds reasonable, but we should (1) document this hack in the comment and/or in the commit message and (

D13814: Speedup sort

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileitemmodel.cpp:111 > + > +// warm up the collator so it does not has thread safety problems later > +m_collator.compare(QStringLi

D13972: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds

D13973: Honor BUILD_TESTING

arojas edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D13973 To: arojas, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13973: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on. Also remove unnece

D13974: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Build

D13975: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13976: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13977: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: mirko, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests and benchmarks if BUILD_TESTING is

D13980: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: ivan. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds

D13974: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D13974 To: arojas, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13972: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D13972 To: arojas, mart, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13974: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R277:4eadd9ee0ef1: Honor BUILD_TESTING (authored by arojas). REPOSITORY R277 KPlotting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13974?vs=37348&id=37357 REVISION DETAIL https://phabricat

D13972: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R290:1fec80d89989: Honor BUILD_TESTING (authored by arojas). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13972?vs=37346&id=37358 REVISION DETAIL https://phabricato

D13698: Improve ECMAddAppIconMacro.

This revision was automatically updated to reflect the committed changes. dschmidt marked an inline comment as done. Closed by commit R240:2c2bb8f4766f: Improve ECMAddAppIconMacro. (authored by dschmidt). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D13982: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 08 Jul 2018 17:59:57 + Build duration: 1 min 8 sec and counting JUnit Tests

D13983: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13985: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Bui

D13986: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Buil

D13970: Handle empty preview lists

ngraham added reviewers: gregormi, nicolasfella, dhaumann, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13987: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: afiestas, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PL

D13989: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds

D13990: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only builds tests if BUILD_TESTING is on TEST PLAN Bu

D13991: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: dvratil. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Bui

D13992: Honor BUILD_TESTING

arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds

D13992: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13992 To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13986: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D13986 To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13991: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D13991 To: arojas, dvratil, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13989: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D13989 To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13987: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D13987 To: arojas, afiestas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13993: Honor BUILD_TESTING

arojas created this revision. arojas added reviewers: alexmerry, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST P

D13986: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R301:e7f4466de3b5: Honor BUILD_TESTING (authored by arojas). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13986?vs=37366&id=37374 REVISION DETAIL https://phabrica

D13992: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R495:f03e2db94959: Honor BUILD_TESTING (authored by arojas). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13992?vs=37372&id=37375 REVISION DETAIL https://pha

D13947: Honor BUILD_TESTING

mdawson accepted this revision. mdawson added a comment. This revision is now accepted and ready to land. LGTM, thanks! REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13947 To: arojas, mdawson, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/37/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 08 Jul 2018 19:00:02 + Build duration: 1 min 24 sec and counting JUnit Tests

D13991: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R312:6239b73d5fa8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R312 KXmlRpcClient CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13991?vs=37371&id=37376 REVISION DETAIL https://phabr

D13989: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R307:1599ed797389: Honor BUILD_TESTING (authored by arojas). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13989?vs=37369&id=37377 REVISION DETAIL https://phabricator

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/72/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Jul 2018 19:00:02 + Build duration: 1 min 46 sec and counting JUnit Tests Nam

D13987: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R252:5ec96d346322: Honor BUILD_TESTING (authored by arojas). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13987?vs=37367&id=37379 REVISION DETAIL https

  1   2   >