D15155: [KMountPoint] Fix typo in probablySlow()

ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15155 To: broulik, dfaure, dhaumann, aacid, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a comment. Anyone at home? Not answering a simple question is rude, at best. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, apol, #frameworks Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D15158: [KMountPoint] Remove Windows CE support

bruns created this revision. bruns added reviewers: Frameworks, Windows. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The Windows CE line ended in 2012, with Windows Mobile 8. Remove supporting

D15157: [KMountPoint] Remove AIX support

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY AIX has not seen a release for 3 years and can be considered legacy and completely

D15156: [KMountPoint] Remove traces of supermount

bruns updated this revision to Diff 40675. bruns added a comment. remove stray comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15156?vs=40674=40675 REVISION DETAIL https://phabricator.kde.org/D15156 AFFECTED FILES src/core/kcoredirlister.cpp

D15156: [KMountPoint] Remove traces of supermount

bruns created this revision. bruns added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY supermount was a out-of-tree linux kernel patch for linux 2.6.x, for

D15141: [KSambaShareData] Accept spaces in ACL host name

bruns added a comment. In D15141#317370 , @broulik wrote: > > Any chance you can create a unit test? > > Will try. Should it just check a couple of strings for validity? And also check that the ACL it read are valid since they must be as

D15155: [KMountPoint] Fix typo in probablySlow()

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15155 To: broulik, dfaure, dhaumann, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15155: [KMountPoint] Fix typo in probablySlow()

broulik created this revision. broulik added reviewers: dfaure, dhaumann. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It probably should have been `smbfs` as everywhere else. TEST PLAN Cannot

D15154: Also check smb-share for whether it's an SMB mount

broulik created this revision. broulik added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is the "type" exposed by gvfsd CCBUG: 344146 TEST PLAN Depends

D15153: RFC: Resolve gvfsd mounts

broulik added a dependent revision: D15154: Also check smb-share for whether it's an SMB mount. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15153 To: broulik, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15153: RFC: Resolve gvfsd mounts

broulik created this revision. broulik added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We only see the toplevel `/run/user/foo/gvfs` folder as a mount, not the

D14529: Android: Make sure Qm translations get loaded

apol added a comment. It is where Qt installs things indeed. I've done a couple of failed attempts at finding other ways to get this different. In the best scenario anyway we'll have to add an `if(ANDROID)` elsewhere if it's not here. I'd say we can iterate it in the future but the

Re: KDE apps have missing icons when not on Breeze

Albert Astals Cid ha scritto: El dimecres, 29 d’agost de 2018, a les 21:13:03 CEST, Albert Vaca va escriure: Do you think it's a good idea to ask packagers to make KIconThemes depend on Breeze icons? I think depend is probably "too strong", but recommend for sure. Did you also consider to

Re: KDE apps have missing icons when not on Breeze

El dimecres, 29 d’agost de 2018, a les 21:13:03 CEST, Albert Vaca va escriure: > Do you think it's a good idea to ask packagers to make KIconThemes depend > on Breeze icons? I think depend is probably "too strong", but recommend for sure. Cheers, Albert > > On Wed, Aug 29, 2018, 19:29 Albert

Re: KDE apps have missing icons when not on Breeze

Do you think it's a good idea to ask packagers to make KIconThemes depend on Breeze icons? On Wed, Aug 29, 2018, 19:29 Albert Astals Cid wrote: > El dimecres, 29 d’agost de 2018, a les 12:56:53 CEST, Aleix Pol va > escriure: > > On Tue, Aug 28, 2018 at 10:45 PM Albert Astals Cid > wrote: > > >

D15141: [KSambaShareData] Accept spaces in ACL host name

broulik added a comment. > Any chance you can create a unit test? Will try. Should it just check a couple of strings for validity? And also check that the ACL it read are valid since they must be as they came from `net usershare`? REPOSITORY R241 KIO REVISION DETAIL

D11353: manager: add support to R/W the GlobalDnsConfiguration property

This revision was automatically updated to reflect the committed changes. Closed by commit R282:6b2c3e8fce2f: manager: add support to R/W the GlobalDnsConfiguration property (authored by aleksanderm, committed by jgrulich). Herald added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO

Re: KDE apps have missing icons when not on Breeze

El dimecres, 29 d’agost de 2018, a les 12:56:53 CEST, Aleix Pol va escriure: > On Tue, Aug 28, 2018 at 10:45 PM Albert Astals Cid wrote: > > > > El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va > > escriure: > > > Missatge de Albert Vaca del dia dj., 16 d’ag. 2018 > > >

Re: KDE apps have missing icons when not on Breeze

For icons to work on Windows, we rely on apps linking against KIconThemes (see [1]). I would add a similar hack for Gnome: I think it is a safe-enough assumption that apps will link against KIconThemes. I will submit a patch proposal soon-ish. [1]

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.9 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.9/31/ Project: Frameworks karchive kf5-qt5 SUSEQt5.9 Date of build: Wed, 29 Aug 2018 17:12:38 + Build duration: 6 min 12 sec and counting JUnit Tests

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.10 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks karchive kf5-qt5 SUSEQt5.10 Date of build: Wed, 29 Aug 2018 17:12:38 + Build duration: 1 min 4 sec and counting JUnit Tests

D14580: support for multi pages kcms

abetts added a comment. In D14580#317289 , @mart wrote: > F6223394: Spectacle.k3.png > > in case the kcm wants to go multi columns (default off): > F6223399: Spectacle.l3.png

D14580: support for multi pages kcms

mart added a comment. F6223394: Spectacle.k3.png in case the kcm wants to go multi columns (default off): F6223399: Spectacle.l3.png REPOSITORY R295 KCMUtils REVISION DETAIL

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat added a comment. @aacid, I've just sent file to the e-mail. I also attached the same file to this message: F6223361: tar_non_ascii_file_name.tar.gz REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To:

D14580: support for multi pages kcms

abetts added a comment. What does this look like now Marco? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14580 To: mart, #plasma, #frameworks Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15141: [KSambaShareData] Accept spaces in ACL host name

bruns added a comment. Any chance you can create a unit test? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15141 To: broulik, dfaure, fvogt Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

broulik created this revision. broulik added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 344146 TEST PLAN Accessed a SMB share from Nautilus, chose "Open in

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

broulik added a reviewer: fvogt. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15146 To: broulik, dfaure, ngraham, fvogt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6512: Add support for proposed tags addition in OCS 1.7

This revision was automatically updated to reflect the committed changes. Closed by commit R235:76f66bab8841: Add support for proposed tags addition in OCS 1.7 (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6512?vs=39175=40648 REVISION

D6512: Add support for proposed tags addition in OCS 1.7

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, shipit! REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra, ngraham Cc: cfeck, ahiemstra,

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/19/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 29 Aug 2018 12:38:21 + Build duration: 5 min 36 sec and

D6513: Add support for Attica tags support

leinir added a comment. Welcome back from Akademy - sorry for being a pest, but it'd be really nifty if we could get this and it's dependent in D6512 through before 5.50... :) REPOSITORY R304 KNewStuff REVISION DETAIL

D15136: Fixed a typeo

mlaurent added a comment. done. REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15136: Fixed a typeo

mlaurent closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15141: [KSambaShareData] Accept spaces in ACL host name

broulik created this revision. broulik added reviewers: dfaure, fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise it would reject `Unix User\foo` TEST PLAN (or whatever the part

D15136: Fixed a typeo

ssloan added a comment. Thanks scottsl...@gmail.com REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

Re: KDE apps have missing icons when not on Breeze

On Tue, Aug 28, 2018 at 10:45 PM Albert Astals Cid wrote: > > El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va > escriure: > > Missatge de Albert Vaca del dia dj., 16 d’ag. 2018 a > > les 13:57: > > > > > Hi everyone, > > > > > > If we want to reach more potential users,

D14580: support for multi pages kcms

mart updated this revision to Diff 40629. mart added a comment. - cosmetic spacing REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40625=40629 BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D14580 AFFECTED FILES

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann added a comment. For the std::vector or other things, I will create new requests. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15134 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

This revision was automatically updated to reflect the committed changes. Closed by commit R216:4d3ed1fc7297: replace raw pointer with weak_ptr (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15134?vs=40621=40626#toc REPOSITORY R216 Syntax Highlighting CHANGES

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

vkrause added a comment. This seems reasonable, the raw pointer use here probably predates DefinitionRef. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15134 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh,

D14580: support for multi pages kcms

mart updated this revision to Diff 40625. mart added a comment. hide title of qml modules from KCMultidialog REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40500=40625 BRANCH mart/multipageKCM REVISION DETAIL

D15139: hide title of qml modules from kcmultidialog

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REPOSITORY R295 KCMUtils BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D15139 AFFECTED FILES

D15139: hide title of qml modules from kcmultidialog

mart abandoned this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15139 To: mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann updated this revision to Diff 40621. cullmann added a comment. Proposed solution that is "safe": We use a weak reference to check for state validity. This is bit more expensive than the raw-pointer but even save if e.g. by accident a new definition gets allocated to the same

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann added a comment. Regarding implicit sharing, is this actually shared between two (subsequent) lines with the same state (think of e.g. a multi-line license header block)? Then it might be interesting to keep it, otherwise I agree, the increased control of a std::vector might be

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

vkrause added a comment. Regarding implicit sharing, is this actually shared between two (subsequent) lines with the same state (think of e.g. a multi-line license header block)? Then it might be interesting to keep it, otherwise I agree, the increased control of a std::vector might be

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

cullmann added a comment. For: I can't answer the m_defData question without digging deeper into this unfortunately. The rest looks good to me though. Ok. I think in 99% of the cases it is save enough, thought some 100% save thing would be nicer. Actually one could just add a

D15134: decrease StateData space by more than 50% and half the number of needed mallocs

vkrause added a comment. I can't answer the m_defData question without digging deeper into this unfortunately. The rest looks good to me though. INLINE COMMENTS > state.cpp:117 > return false; > -return d->m_contextStack.top()->indentationBasedFoldingEnabled(); > +return

D13700: implement reading of the replaygain tags

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Some inline comments INLINE COMMENTS > taglibextractor.cpp:254-263 > +if(!strcmp( userTextFrame->description().toCString( true ), > "replaygain_track_gain" ) ) {

D15136: Fixed a typeo

mlaurent added a comment. I will commit for you. what is your email address ? REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,