D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » krunner » kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20WindowsMSVCQt5.11/8/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 17 Sep 2018 05:42:26 + Build duration: 3 min 15 sec and counting JUnit Tests Name:

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags REPOSITORY R240 Extra CMak

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 245 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/245/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 17 Sep 2018 04:35:01 + Build duration: 8 min 39 sec and counting JUnit Tests Name: (root) Failed: 1

D14757: Warn user before copy/move operation if available space is not enough

shubham added a comment. Sorry for that, will take care of that in future. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Yes, but they still hadn't approved the current version. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham added a comment. @ngraham I thought those "request changes" were against my prior diffs REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. @shubham, in the future, when there are still reviewers who have marked their status as "Request Changes", please wait for them to approve before pushing. Since that didn't happen this time, if @pino or @dfaure have any remaining concerns with this patch, please

D14757: Warn user before copy/move operation if available space is not enough

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5a48bd21212c: Warn user before copy/move operation if available space is not enough (authored by shubham). REPOSITORY

D15070: Bindings: Query the install directory from python

bruns planned changes to this revision. bruns added a comment. Postponed this to do some cleanup first: D15558 , D15559 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: br

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns added a comment. These are the other places which should be treated the same: https://lxr.kde.org/search?_filestring=&_string=KDE_INSTALL_PYTHONBINDINGSDIR REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D15558 To: bruns, #frameworks Cc: kde-frameworks-dev

D15557: Improve "insufficient disk space" error messgae

ngraham added a comment. We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a directory. Adjusting the code here to know those pieces of information not easily possible

D14632: keyword rule: Spport for keywords inclusion from another language/file

dhaumann added a comment. Yes, and calling loadKeywords would only do work the first time. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-deve

D14632: keyword rule: Spport for keywords inclusion from another language/file

jpoelen added a comment. `resolveIncludeKeywords()` would then use `loadKeywords()` instead of `load()` ? This should be enough. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwr

Re: Quality of Frameworks announcements

Hi, indeed I agree that the log messages should be better. Maybe blogging about how to write good log messages can already help. Besides that, there is a simple reason for this kind of messages appeared: we did big changes by replacing the entire highlighting implementation in KTextEditor by the

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau updated this revision to Diff 41778. kossebau marked 3 inline comments as done. kossebau added a comment. Update to Dominik's first review REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=41694&id=41778 BRANCH addAnnotationItemDelegate

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau marked 15 inline comments as done. kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in abstractannotationitemdelegate.h:52 > I am asking myself: Is wrappedLineCount >= 1 always true? If so, can you add > this as documentation? wrappedLineCount == 1 means no wrapping line

D15557: Improve "insufficient disk space" error messgae

abetts added a comment. I like the proposal already. I would just add other strings for perspective: - Cannot move file. File larger than remaining space. - Unable to move file, insufficient space remaining. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (

D15559: Python bindings: use cmake_parse_arguements, fix documentation

bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Use of positional arguments is error prone, as e.g. switchi

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Although KDE_INSTALL_PYTHONBINDINGSDIR follows the the standard pattern of KDE_INSTALL

D15557: Improve "insufficient disk space" error messgae

shubham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: kde-fra

D14757: Warn user before copy/move operation if available space is not enough

ngraham accepted this revision. ngraham added a comment. That's better: F6268143: Better.png FWIW, I've submitted a patch to slightly improve the error message: D15557 @pino and @dfaure, are you good wit

D15557: Improve "insufficient disk space" error messgae

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error messgae

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, Dolphin, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The prior error was misleading, and always said "Disk full."

D15556: Fix: Email highlighting for unclosed parenthesis in Subject header

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b1da54ab91e3: Fix: Email highlighting for unclosed parenthesis in Subject header (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41765. shubham added a comment. addressed broulik's comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41764&id=41765 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cp

D14757: Warn user before copy/move operation if available space is not enough

shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

broulik added inline comments. INLINE COMMENTS > copyjob.cpp:887 > qCDebug(KIO_COPYJOB_DEBUG)<<"Stating finished. To > copy:"< -//TODO warn user beforehand if space is not enough > +if (m_totalSize > m_freeSpace) { > +q->setError(ERR_DISK_FULL); Please check

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41764. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41761&id=41764 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham

D15556: Fix: Email highlighting for unclosed parenthesis in Subject header

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-email-subject (branched from master) REVISION DETAIL https://phabricator.kde.org/D15556 To: dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, k

D15556: Fix: Email highlighting for unclosed parenthesis in Subject header

dhaumann created this revision. dhaumann added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Unfortunately, the "Subject:" header needs to be treated indepen

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Perfect, thanks! I did some investigation and this oddly-formed string is actually built by KIO itself, in `core/job_error.cpp`: case KIO::ERR_DISK_FULL: result = i18n("Could not write file %1.\nDisk full.", errorText); break; It looks like

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41761. shubham added a comment. done above requested change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41751&id=41761 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Yay, it works now! If I try to copy a folder that is too big, it stops immediately before anything happens, and the following is displayed in Dolphin: F6268053: It works, mostly.png The weird display is probably a bug in

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41751. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41747&id=41751 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham

D14757: Warn user before copy/move operation if available space is not enough

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. You forgot the error line. :) It needs `q->setError(ERR_DISK_FULL);` before `setErrorText()`. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: sh

D15318: Automatically re-upload saved files located on remote locations instead of asking first

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

D15318: Automatically re-upload saved files located on remote locations instead of asking first

ngraham updated this revision to Diff 41749. ngraham added a comment. Fix some compile errors, oops :/ REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15318?vs=41718&id=41749 BRANCH samba-auto-re-upload-after-save (branched from master) REVISION DETAIL htt

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41747. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41746&id=41747 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure,

D14757: Warn user before copy/move operation if available space is not enough

ngraham added a comment. Looking better, thanks! I will test shortly. I have one string change suggestion; can we change it to: There is not enough space available at %1 to hold the file.%2 are required but only %3 are available. REPOSITORY R241 KIO REVISION DETAIL https://phabri

D14757: Warn user before copy/move operation if available space is not enough

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham updated this revision to Diff 41746. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41655&id=41746 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure,

D13700: implement reading of the replaygain tags

astippich added a comment. @bruns any further comments/objections? REPOSITORY R286 KFileMetaData BRANCH replaygain REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/72/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 16 Sep 2018 14:15:49 + Build duration: 5 min 40 sec and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 16 Sep 2018 14:15:49 + Build duration: 1 min 20 sec and counting JUnit Tests Name: (root) Fa

D12520: [PasteJob] Emit KDirNotify on paste

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. "perhaps fix storedPut to do that?" --> I'm not in favour. Generally speaking, we want to do this at the highest level possible, so that batching N jobs doesn't trigger N notifications.

Re: Quality of Frameworks announcements

Hello Yuri, Thanks for bringing this to my attention. I generate the KF5 release changelog based on the git commits, with some automated filtering (to remove most maintenance commits like "fix build", "add override", "fix comment", version upgrades etc. etc.) and some manual filtering (I go th

Re: kio slaves + kcrash + drkonqi

Hi Harald, On mardi 11 septembre 2018 14:25:15 CEST Harald Sitter wrote: > The debugging faq [1] suggest that this should behave like KCrash. by > default all crashes get drkonqi'd unless you set KDE_DEBUG at which > point drkonqi is disabled. However, having quickly jumped through the > kdelibs h

D14632: keyword rule: Spport for keywords inclusion from another language/file

dhaumann added a comment. To be clear, currently we have two states: - load metadata only - load full file Instead, we could have three states: - load metadata only - load keyword lists (in addition to metadata) - load full file This is my preferred solution. ;) REPOS

D14632: keyword rule: Spport for keywords inclusion from another language/file

dhaumann added a comment. This was also my interpretation: only include the Definitions that use itemDatas / colors. What we currently do: we already support loading the language metadata without loading the rest. Then, we support loading the full XML file. What we could do: add the

D15527: Remove assumption about the barcode aspect ratio from the QML integration

This revision was automatically updated to reflect the committed changes. Closed by commit R280:b7c033ba77c2: Remove assumption about the barcode aspect ratio from the QML integration (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15527?v

D15526: Fix rendering glitches caused by rounding errors in Code 128

This revision was automatically updated to reflect the committed changes. Closed by commit R280:fe7b0ce74704: Fix rendering glitches caused by rounding errors in Code 128 (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15526?vs=41688&id=41