D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

ngraham added a comment. "Format with destination drive to a filesystem type which" -> "Reformat the destination drive to use a filesystem that" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

shubham updated this revision to Diff 44688. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43938=44688 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham,

D12045: Clean up existing documentation

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, go for it. Such a shame that Michael disappeared. REPOSITORY R293 Baloo BRANCH doc-cleanup REVISION DETAIL https://phabricator.kde.org/D12045 To: michaelh, #baloo, ngraham

D16588: Change package manager icons to emblems

ngraham added a comment. These are pretty darn good. They no longer have package-related iconography, but maybe that's okay and they never needed it in the first place. I can see how it would actually get in the way given how these icons are actually used. These icons are also used by

D16588: Change package manager icons to emblems

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16594: Add context to kcmodule connection to lambdas

davidedmundson added inline comments. INLINE COMMENTS > bruns wrote in kcmoduleqml.cpp:74 > `this` is desctructed after `d` has been deleted, so the signal may be still > connected after d is deleted. > > Does `disconnect(configModule, 0, this, 0)` work, when called in the > destructor?

D12045: Clean up existing documentation

bruns added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. I think these changes are a sufficient improvement to push it as is, we can do more fixups later. @ngraham - your opinion? REPOSITORY R293 Baloo REVISION DETAIL

D16560: create a separate test file for embedded images test

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH cover_jpg REVISION DETAIL https://phabricator.kde.org/D16560 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16554: move supported mimetypes to static string list

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > taglibextractor.cpp:71 > +QStringLiteral("audio/x-vorbis+ogg"), > +QStringLiteral("audio/wav"), > +QStringLiteral("audio/x-wavpack"), w < x REPOSITORY

D16583: use qlatin1 for embedded image extractor

bruns added a comment. Please use proper Capitalization in the Summary. INLINE COMMENTS > embeddedimagedata.cpp:175 > TagLib::List lstPic; > -if (mimeType == QStringLiteral("audio/ogg") || mimeType == > QStringLiteral("audio/x-vorbis+ogg")) { > +if (mimeType ==

D16585: simplify handling of id3 tags

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. A definitive improvement ... REPOSITORY R286 KFileMetaData BRANCH simplify_id3 REVISION DETAIL https://phabricator.kde.org/D16585 To: astippich, mgallien, bruns Cc:

D16579: Musepack disk number field name is DISC.

bruns added a comment. In D16579#352406 , @smithjd wrote: > In D16579#352282 , @bruns wrote: > > > In D16579#352279 , @smithjd wrote: > > > > > I would

D16579: Musepack disk number field name is DISC.

smithjd added a comment. In D16579#352282 , @bruns wrote: > In D16579#352279 , @smithjd wrote: > > > I would instead recommend a tag editor that properly tags APE files, such as puddletag.

D16594: Add context to kcmodule connection to lambdas

bruns added inline comments. INLINE COMMENTS > kcmoduleqml.cpp:74 > setButtons((KCModule::Buttons)(int)d->configModule->buttons()); > -connect(configModule, ::ConfigModule::buttonsChanged, [=] { > +connect(configModule, ::ConfigModule::buttonsChanged, this, > [=] { >

D16594: Add context to kcmodule connection to lambdas

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D16594 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16554: move supported mimetypes to static string list

astippich updated this revision to Diff 44661. astippich added a comment. - use local static variable REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16554?vs=44613=44661 BRANCH mimetype_lists REVISION DETAIL https://phabricator.kde.org/D16554

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#352323 , @pino wrote: > In D16498#352314 , @bruns wrote: > > > Please answer why you consider running a full blown postscript interpreter in an uncontrolled

D16594: Add context to kcmodule connection to lambdas

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY configModule outlives KCModuleQML. BUG: 397894 TEST PLAN

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino added a comment. In D16498#352314 , @bruns wrote: > Please answer why you consider running a full blown postscript interpreter in an uncontrolled environment (no sandboxing, runs without user interaction) is better than 20 code lines of

D16490: [XmlExtractor] Add unittest for XML extractor

astippich added a comment. This causes the Qt5.9 build to fail https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/workflow-stage/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc:

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

bruns added a comment. Please update the diff. INLINE COMMENTS > bruns wrote in job_error.cpp:1079 > "Format **with**" > "filesystem type" or just "filesystem" > either "a file" or better "files" "transeferred" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16465: [KSambaShare] Make "net usershare info" parser testable

bruns added a comment. Ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16465 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16554: move supported mimetypes to static string list

bruns added inline comments. INLINE COMMENTS > astippich wrote in epubextractor.cpp:44 > All the stringlists are currently implemented as a private static member of > the class... would you like to change that to a local static variable? I consider this cleaner, yes. We don't expose static

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. @pino Please answer why you consider running a full blown postscript interpreter in an uncontrolled environment (no sandboxing, runs without user interaction) is better than 20 code lines of trivial text parsing. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16592: [ExtractorCollection] Add unit-test to verify only specific extractor is used

bruns added a dependent revision: D16593: [ExtractorCollection] Use only best matching extractor plugin. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16592 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16593: [ExtractorCollection] Use only best matching extractor plugin

bruns created this revision. bruns added reviewers: Frameworks, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY If there is a direct match for a mime type, only the matching

D16592: [ExtractorCollection] Add unit-test to verify only specific extractor is used

bruns created this revision. bruns added reviewers: Frameworks, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY If there is a direct match, only the matching extractor plugin

D16490: [XmlExtractor] Add unittest for XML extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:dbb34ea5039c: [XmlExtractor] Add unittest for XML extractor (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16490?vs=44409=44656

D16489: [KFileMetaData] Add extractor for generic XML and SVG

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9c58ae5b4800: [KFileMetaData] Add extractor for generic XML and SVG (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16489?vs=44645=44655

D16579: Musepack disk number field name is DISC.

bruns added a comment. In D16579#352279 , @smithjd wrote: > I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats

D16579: Musepack disk number field name is DISC.

smithjd added a comment. I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats usually know WHY they use their format of choice, and will know there are potential

D16490: [XmlExtractor] Add unittest for XML extractor

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Alright, you convinced me. REPOSITORY R286 KFileMetaData BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc:

D16579: Musepack disk number field name is DISC.

astippich added a comment. In D16579#352255 , @smithjd wrote: > I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the

D16579: Musepack disk number field name is DISC.

smithjd added a comment. I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the standard then is a more viable course of action. REPOSITORY R286 KFileMetaData REVISION

D16490: [XmlExtractor] Add unittest for XML extractor

bruns added a comment. In D16490#352244 , @astippich wrote: > I understand that ExtractorCollection is not used, and that the extractor gets the mimetype directly set in the test. > But the list retrieved via XmlExtractor::mimetypes() is

D16489: [KFileMetaData] Add extractor for generic XML and SVG

astippich accepted this revision. astippich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > bruns wrote in xmlextractor.cpp:24 > qCDebug(...) ... I think that gets pulled in via "kfilemetadata_debug.h", but nevermind REPOSITORY R286 KFileMetaData

D16554: move supported mimetypes to static string list

astippich added inline comments. INLINE COMMENTS > bruns wrote in epubextractor.cpp:44 > The idea behind using anonymous namespaces is to neither "pollute" the class > namespace nor the global namespace. Remove the "EPubExtractor::" qualifier, > see `fetchMetadata`. All the stringlists are

D16490: [XmlExtractor] Add unittest for XML extractor

astippich added a comment. I understand that ExtractorCollection is not used, and that the extractor gets the mimetype directly set in the test. But the list retrieved via XmlExtractor::mimetypes() is part of the extractor itself, isn't it? So imho that should be tested here. All I'm

D16563: Actually use fileNameTerms and xAttrTerms

aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

bruns added a dependency: D16490: [XmlExtractor] Add unittest for XML extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16591 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D16490: [XmlExtractor] Add unittest for XML extractor

bruns added a dependent revision: D16591: [XmlExtractor] Use QXmlStreamReader for better performance. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16490: [XmlExtractor] Add unittest for XML extractor

bruns retitled this revision from "[KFileMetaData] Add unittest for XML extractor" to "[XmlExtractor] Add unittest for XML extractor". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel,

D16416: z/OS CLIST file syntax highlighting

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:185b54827ab0: z/OS CLIST file syntax highlighting (authored by phily, committed by cullmann). CHANGED PRIOR TO COMMIT

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:a2032c52bf1b: Creating new syntax highlighting file for Job Control Language (JCL) (authored by phily, committed by

D16579: Musepack disk number field name is DISC.

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. In D16579#352218 , @smithjd wrote: > In D16579#352191 , @astippich wrote: > > > Yes,

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

bruns created this revision. bruns added reviewers: Frameworks, astippich. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY At least in the benchmark, QXmlStreamReader is more than twice as

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

cullmann added a comment. Merged ;=) Git commit a2032c52bf1b5ced774c2f58994aaeb4d233f25a by Christoph Cullmann, on behalf of Phil Young. Committed on 01/11/2018 at 15:54. Pushed by cullmann into branch 'master'. Creating new syntax highlighting file for Job Control Language

D16579: Musepack disk number field name is DISC.

smithjd added a comment. In D16579#352191 , @astippich wrote: > In D16579#352147 , @smithjd wrote: > > > In D16579#351910 , @astippich wrote: > > > >

D16489: [KFileMetaData] Add extractor for generic XML and SVG

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > astippich wrote in xmlextractor.cpp:24 > seems unused qCDebug(...) ... > xmlextractor.cpp:48 > +} else if (node.localName() == QLatin1String("text")) { > +qCDebug(KFILEMETADATA_LOG) <<

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

cullmann accepted this revision. cullmann added a comment. nice, thanks, will merge this! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16415 To: phily, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 95 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/95/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 01 Nov 2018 15:34:57 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 3

D16489: [KFileMetaData] Add extractor for generic XML and SVG

bruns updated this revision to Diff 44645. bruns marked an inline comment as done. bruns added a comment. Reorder mimetype check to use SVG(+XML) special case if applicable and use generic implementation for all other mimetypes inheriting from application/xml. Use static QStringList for

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 68 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/68/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 01 Nov 2018 15:34:57 + Build duration: 7 min 12 sec and counting CONSOLE OUTPUT [...truncated

D16490: [KFileMetaData] Add unittest for XML extractor

bruns added a comment. In D16490#352199 , @astippich wrote: > In D16490#352109 , @bruns wrote: > > > In D16490#351935 , @astippich wrote: > > > > > In

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. In D16490#352109 , @bruns wrote: > In D16490#351935 , @astippich wrote: > > > In D16490#351799 , @bruns wrote: > > > > > In

D12820: Add KWayland virtual desktop protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d0db5da57563: Add KWayland virtual desktop protocol (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12820?vs=38123=44643#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

D16579: Musepack disk number field name is DISC.

astippich added a comment. In D16579#352147 , @smithjd wrote: > In D16579#351910 , @astippich wrote: > > > The ape tag tests fail with this patch, but the test is actually wrong in that regard. It

D16579: Musepack disk number field name is DISC.

smithjd updated this revision to Diff 44638. smithjd added a comment. - Change the unit test to check if the APE 'disc' value is correct. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44607=44638 BRANCH master-musepackFixes (branched

D16579: Musepack disk number field name is DISC.

smithjd added a comment. In D16579#351910 , @astippich wrote: > The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before. > I've found references

D16554: move supported mimetypes to static string list

bruns added inline comments. INLINE COMMENTS > epubextractor.cpp:44 > { > +const QStringList EPubExtractor::mMimetypes = { > +QStringLiteral("application/epub+zip"), The idea behind using anonymous namespaces is to neither "pollute" the class namespace nor the global namespace. Remove the

D16563: Actually use fileNameTerms and xAttrTerms

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH arcpatch-D16563 REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16490: [KFileMetaData] Add unittest for XML extractor

bruns added a comment. In D16490#351935 , @astippich wrote: > In D16490#351799 , @bruns wrote: > > > In D16490#351662 , @astippich wrote: > > > > >

D16588: Change package manager icons to emblems

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old package-* icons were hard to read and straddled the line between being symbols

D16585: simplify handling of id3 tags

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY remove unrequired checks and use range-based loop

D16583: use qlatin1 for embedded image extractor

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY use qlatin1string where applicable instead of

D16563: Actually use fileNameTerms and xAttrTerms

aacid updated this revision to Diff 44618. aacid retitled this revision from "Remove unused variables" to "Actually use fileNameTerms and xAttrTerms". aacid added a comment. update summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16563?vs=44617=44618

D16563: Actually use fileNameTerms and xAttrTerms

aacid edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16563: Remove unused variables

aacid updated this revision to Diff 44617. aacid added a comment. actually use the variables REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16563?vs=44586=44617 BRANCH arcpatch-D16563 REVISION DETAIL https://phabricator.kde.org/D16563 AFFECTED FILES

D16570: Remove unused variables

aacid closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16570 To: aacid, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16489: [KFileMetaData] Add extractor for generic XML and SVG

astippich requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16489 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. In D16490#351799 , @bruns wrote: > In D16490#351662 , @astippich wrote: > > > Only one minor thing: please also check that the mimetype is in the list of supported

D16554: move supported mimetypes to static string list

astippich updated this revision to Diff 44613. astippich added a comment. - adjust taglibwriter REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16554?vs=44612=44613 BRANCH mimetype_lists REVISION DETAIL https://phabricator.kde.org/D16554

D16554: move supported mimetypes to static string list

astippich updated this revision to Diff 44612. astippich added a comment. - coding style fixes - use anonymous namespace REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16554?vs=44572=44612 BRANCH mimetype_lists REVISION DETAIL

D16579: Musepack disk number field name is DISC.

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before. I've found

D16570: Remove unused variables

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, away with the vars. Thanks! REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D16570 To: aacid, cullmann Cc: cullmann,