This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:57fdd7769506: Update the About KDE text
(authored by ngraham).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
rjvbb added a comment.
> Please, let's find the root causes and fix things at the base instead of
adding such
I suck at debugging event-driven code, unfortunately. But even if "we" find a
fixable bug in some framework there's still no guarantee that no one will ever
run KDevelop
kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.
Oh, I missed the latter "For an as-yet unknown reason populateContextMenu()
will be called with every view in which the contextmenu has been opened when
the CTags plugin is
kossebau added a comment.
> TextDocument::populateContextMenu() is called when the user opens the
contextmenu but this can happen for more than just the view currently active.
What does "more than just the view currently active" mean? How can that
happen? From what I see
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:205ed84ee213: [KFileMetaData] Add extractor for DSC
conforming (Encapsulated) Postscript (authored by bruns).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16498?vs=44408=45492#toc
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16885
To: davidedmundson, #kwin, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9e90fdd2a593: [Bookmarks Runner] Avoid leaking
FetchSqlite instances (authored by bruns).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:145caeac1050: [Bookmarks Runner] Open database connection
in the query thread (authored by bruns).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
QList::erase will move the data underneath where the iterator is
davidedmundson retitled this revision from "Update PlasmaWindowManagementTest
for VirtualDesktop changes" to "Update PlasmaWindowModel test to reflect
VirtualDesktop changes".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16880
To: davidedmundson, #kwin
Cc:
davidedmundson added inline comments.
INLINE COMMENTS
> runnermanager.cpp:274
>
> +if (runners.isEmpty() && !deadRunners.isEmpty()) {
> +// protection against broken category data (e.g. from different
> locale)
what does deadRunners have to do with this?
REPOSITORY
kossebau resigned from this revision.
kossebau added a comment.
No time and insight, sorry.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D16832
To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets,
davidedmundson updated this revision to Diff 45483.
davidedmundson added a comment.
update the plasma virtual desktop test at the same time
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16883?vs=45480=45483
BRANCH
master
REVISION DETAIL
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
VirtualDesktops with the new plurality was added
rjvbb created this revision.
rjvbb added a reviewer: KDevelop.
rjvbb added a project: KDevelop.
rjvbb requested review of this revision.
REVISION SUMMARY
`TextDocument::populateContextMenu()` is called when the user opens the
contextmenu but this can happen for more than just the view
bruns added a comment.
You are replicating `mdb_copy -c` here.
According to the man page:
> Compact while copying. Only current data pages will be copied; freed or
unused pages will be omitted from the copy. [...] **Currently it fails if the
environment has suffered a page leak**
shubham marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
shubham updated this revision to Diff 45470.
shubham retitled this revision from "Warn user before copy/move job if the file
size exceeds the maximum possible file size in FAT32 filesystem(4 GB) " to
"Warn user before copy/move job if the file size exceeds the maximum possible
file size in
bruns added a comment.
IMHO we should just disallow specifying symlinks in both
include/excludeFolders. The user can just use exludeFolders = /storage/stuff if
he wants to exclude it.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D16878
To: poboiko, #frameworks,
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Before we send the data we don't know what desktop a client is on.
poboiko accepted this revision.
poboiko added a comment.
This revision is now accepted and ready to land.
Apart from trivial comment, this looks fine. I've tested it on my setup (with
bunch of (e)ps files), and randomly chosen files seems to be indexed nicely. It
also reduced the size of the
poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
Assume user has `~/stuff` folder, that is symlinked to i.e.
davidedmundson added a subscriber: mart.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16877
To: davidedmundson, #kwin
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
TEST PLAN
Valgrind was quieter on the virtual desktop test
REPOSITORY
R127
poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
Currently, after the indexing is done, there is a huge difference
poboiko updated this revision to Diff 45452.
poboiko added a comment.
It's a bad idea to removeRecursively starting from root of the tree
(documentid 0).
If user has indexed `/home/username` folder, there is also an index entry for
`/home` (that's how IdTreeDB works).
However, `/home`
poboiko updated this revision to Diff 45451.
poboiko added a comment.
Rebase on master
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15983?vs=43446=45451
BRANCH
arcpatch-D15983
REVISION DETAIL
https://phabricator.kde.org/D15983
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:8761b763eacd: Added a set of Game Folder icons (authored
by andreyorst, committed by ndavis).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
ndavis added a comment.
It's been 3 days and no response, so I guess I'll land it.
REPOSITORY
R266 Breeze Icons
BRANCH
arcpatch-D8912 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8912
To: ndavis, #vdg, ngraham, andreyorst
Cc: aaronhoneycutt, bruns, ngraham,
29 matches
Mail list logo
