KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/47/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 03 Mar 2019 08:30:49 + Build duration: 1 day 23 hr and counting JUnit Tests

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.11/40/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 04 Mar 2019 17:05:51 + Build duration: 15 hr and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Mar 2019 08:29:50 + Build duration: 5 min 16 sec and counting BUILD ARTIFACTS abi-compat

D19527: Remove find modules provided by ECM

cgiboudeaux added a comment. FindSasl2.cmake & FindPulseAudio.cmake also exist in both repo. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D19527 To: vkrause, apol Cc: cgiboudeaux, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d95ff837a9bc: [text thumbnailer] Use KSyntaxHighlighting for text rendering (authored by kossebau). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19432?vs=52901

D19530: Avoid fractionals in GridDelegate sizes and alignments

filipf added a comment. In D19530#424922 , @rooty wrote: > A lot easier on the eyes now, really nice fix > > This'll be landing in 5.16? KF 5.57 as far as I can tell. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 WindowsMSVCQt5.11 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20WindowsMSVCQt5.11/20/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 05 Mar 2019 08:36:46 + Build duration: 42 min and counting JUnit Tests Name:

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. In D18793#424628 , @cullmann wrote: > I don't like the change to call typeChars. > > 1. that needs a valid view, activeView() might be null. > 2. replaceText is not interactive per-default, but typeChars is. >

D19536: [autotests] Fix KWindowInfoX11Test::testState

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY KWindowInfoX11Test::testState(skipSwitcher) fails because Openbox doesn't implement _KDE_NET_WM

D19536: [autotests] Fix KWindowInfoX11Test::testState

zzag edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19536 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: Make file overwrite a bit safer

dfaure added a comment. This test fails in CI, please investigate and fix: FAIL! : JobTest::safeOverwrite(dest file exists) Compared values are not the same Actual (spyTotalSize.count()): 0 Expected (1) : 1 Loc: [/home/jenkins/workspace/Frameworks/kio/k

D19536: [autotests] Fix KWindowInfoX11Test::testState

davidedmundson added a comment. Autotests aren't only run on KDE CI. Can we query _NET_SUPPORTED ? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19536 To: zzag, #kwin Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}

dfaure created this revision. dfaure added reviewers: kossebau, apol, cgiboudeaux. Herald added projects: Frameworks, Build System. dfaure requested review of this revision. REVISION SUMMARY Note that the first test had a comment "without optional arguments" so I removed the INCLUDE_INSTALL_DI

D19536: [autotests] Fix KWindowInfoX11Test::testState

zzag updated this revision to Diff 53190. zzag added a comment. check supported states REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19536?vs=53187&id=53190 BRANCH foo REVISION DETAIL https://phabricator.kde.org/D19536 AFFECTED FILES autotes

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure added a comment. Makes sense --> https://phabricator.kde.org/D19538 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: kossebau, cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh,

D19534: [i18n] compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19536: [autotests] Fix KWindowInfoX11Test::testState

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH foo REVISION DETAIL https://phabricator.kde.org/D19536 To: zzag, #kwin, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D19536: [autotests] Fix KWindowInfoX11Test::testState

zzag updated this revision to Diff 53192. zzag added a comment. sneaky update REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19536?vs=53190&id=53192 BRANCH foo REVISION DETAIL https://phabricator.kde.org/D19536 AFFECTED FILES autotests/kwindo

D19536: [autotests] Fix KWindowInfoX11Test::testState

This revision was automatically updated to reflect the committed changes. Closed by commit R278:cc765bfb3f90: [autotests] Fix KWindowInfoX11Test::testState (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19536?vs=53192&id=53193 REVISI

D11924: Add "SkipSwitcher" to API

zzag added a comment. @dfaure cc765bfb3f90a52410cbc0d2324de121cdffda61 REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: zzag, dfaure, kde-framewor

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 05 Mar 2019 11:16:33 + Build duration: 2 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Mar 2019 11:16:33 + Build duration: 3 min 30 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 05 Mar 2019 11:16:33 + Build duration: 9 min 39 sec and counting BUILD ARTIFACTS abi-compa

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson added a comment. > I'm not sure changing the codec for all kauth stuff is the best I did it in just my one helper initially, but in review it was suggested to make it global as it affects everyone. I'm content with either as long as I'm not deadlocked between them. REPOSI

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson updated this revision to Diff 53197. davidedmundson added a comment. Add comment REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7732?vs=52913&id=53197 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7732 AFFECTED FILES src/k

D19534: [i18n] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R249:e6833a6aa37e: [i18n] compile without foreach (authored by mlaurent). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19534?vs=53179&id=53198 REVISION DETAIL https:/

KDE CI: Frameworks » ki18n » kf5-qt5 AndroidQt5.12 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20AndroidQt5.12/5/ Project: kf5-qt5 AndroidQt5.12 Date of build: Tue, 05 Mar 2019 12:20:46 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 05 Mar 2019 12:49:28 + Build duration: 4 min 21 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 05 Mar 2019 12:49:28 + Build duration: 5 min 0 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Mar 2019 12:49:28 + Build duration: 5 min 8 sec and counting BUILD ARTIFACTS abi-compati

D19530: Avoid fractionals in GridDelegate sizes and alignments

This revision was automatically updated to reflect the committed changes. Closed by commit R296:715ce3c20837: Avoid fractionals in GridDelegate sizes and alignments (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19530?vs=5316

D18770: [KStatusNotifierItem] use fallback sizes when none is available

apol added a comment. Makes sense to me +1 Would it be possible to add a unit test? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D18770 To: pino Cc: apol, bruns, davidedmundson, kde-frameworks-devel, michaelh, ngraham

D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19538 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, fazevedo, michaelh, ngraham

D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19538 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, fazevedo, michaelh, ngraham, bruns

D19534: [i18n] compile without foreach

sh-zam reopened this revision. sh-zam added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:74 > add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00) > +add_definitions(-DQT_NO_FOREACH) > Removing this line is doesn't allow build to succe

D19534: [i18n] compile without foreach

sh-zam added inline comments. INLINE COMMENTS > sh-zam wrote in CMakeLists.txt:74 > Removing this line is doesn't allow build to succeed, I had to comment this > line to make it successful. > > My build log: F6659392: build.log > I am using build_kf5.sh >

D17816: Support for xattrs on kio copy/move

ngraham added a comment. Thanks, that would be appreciated. This looks like it's so close... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,

D19534: [i18n] compile without foreach

dfaure added a comment. I pushed a fix, please test: https://commits.kde.org/ki18n/927fd6c20a7e0acfe87353abb93dcb066d1d0713 Laurent: this was Android-specific code, not compiled on Linux. I suggest grepping for Q_FOREACH/foreach after it compiles. REPOSITORY R249 KI18n REVISION DETAI

D17816: Support for xattrs on kio copy/move

bruns added a comment. Does this work correctly when the source is a symlink? - getxattr vs lgetxattr. INLINE COMMENTS > copyxattrjob.cpp:134 > +#endif > +if (valuelen == -1) { > +q->setErrorText(QLatin1String("libc failed to extract a xattr > value from file")); if err

KDE CI: Frameworks » ki18n » kf5-qt5 AndroidQt5.12 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20AndroidQt5.12/6/ Project: kf5-qt5 AndroidQt5.12 Date of build: Tue, 05 Mar 2019 15:25:26 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 242 l

D19544: Send blur/background contrast in device pixels

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY A Qt app using Qt scaling will only know the position of windows an

D19534: [i18n] compile without foreach

kossebau added a comment. In D19534#425198 , @dfaure wrote: > I pushed a fix, please test: https://commits.kde.org/ki18n/927fd6c20a7e0acfe87353abb93dcb066d1d0713 > > Laurent: this was Android-specific code, not compiled on Linux. I suggest g

D19534: [i18n] compile without foreach

kossebau added a comment. Ah, seems I missed this was Android-specific code, and CI confirms what I had been thinking before, by failing the build for Android. Okay, nothing missed here on my side it seems, so moving out again :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator

D19544: Send blur/background contrast in device pixels

zzag added inline comments. INLINE COMMENTS > kwindoweffects.cpp:266 > +auto dpr = qApp->devicePixelRatio(); > +data << r.x() * dpr << r.y() * dpr << r.width() * dpr << > r.height() * dpr; > } should we floor or round? REPOSITORY R278 KWindowSystem REVISION

KDE CI: Frameworks » ki18n » kf5-qt5 WindowsMSVCQt5.11 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20WindowsMSVCQt5.11/28/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 05 Mar 2019 12:20:46 + Build duration: 3 hr 47 min and counting CONSOLE OUTPUT [...t

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

ngraham added a comment. Semi-relatedly: can we make this little bottom-left corner icon not not have a hover effect if it's not clickable, and have a tooltip when you hover over it so you can figure out what it means? It appeared recently and I found myself very confused by it due to those

D19544: Send blur/background contrast in device pixels

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in kwindoweffects.cpp:266 > should we floor or round? Our best option is to match QHighDpi::toNativePixels(QRect) Which seems to floor REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19544 To: d

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. BTW, here's the bug report tracking the issue in Breeze itself, if anyone wants to take a crack at it: https://bugs.kde.org/show_bug.cgi?id=399680 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, k

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar updated this revision to Diff 53213. loh.tar retitled this revision from "DocumentPrivate: Don't scroll view when add auto-bracket at end of file" to "DocumentPrivate: Don't jump view when edit using 'scroll past last line'". loh.tar edited the summary of this revision. loh.tar edited the

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar added inline comments. INLINE COMMENTS > kateview.cpp:1463 > > -m_viewInternal->updateCursor(KTextEditor::Cursor(position.line(), x), > false, true, calledExternally); > +m_viewInternal->updateCursor(KTextEditor::Cursor(position.line(), x), > false, false, calledExternally); >

D19527: Remove find modules provided by ECM

vkrause updated this revision to Diff 53218. vkrause added a comment. Also remove FindPulseAudio. The Sasl2 one misses compatibility variables in ECM it seems. REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19527?vs=53163&id=53218 BRANCH master

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar added a comment. > Semi-relatedly: can we make this little bottom-left corner icon not not have a hover effect if it's not clickable, and have a tooltip when you hover over it so you can figure out what it means? It appeared recently and I found myself very confused by it due to thos

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

ngraham added a comment. Tooltips are used throughout KDE and are approved by our HIG. We can use one here. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktext

D19544: Send blur/background contrast in device pixels

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D19544 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D19534: [i18n] compile without foreach

dfaure added a comment. Well, you could have pushed a fix ;-) Done now. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: kossebau, sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ki18n » kf5-qt5 AndroidQt5.12 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20AndroidQt5.12/7/ Project: kf5-qt5 AndroidQt5.12 Date of build: Tue, 05 Mar 2019 17:30:06 + Build duration: 49 sec and counting

D19534: [i18n] compile without foreach

sh-zam added a comment. The latest commit is working now. Thanks for helping REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: kossebau, sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns

D19534: [i18n] compile without foreach

kossebau added a comment. In D19534#425325 , @dfaure wrote: > Well, you could have pushed a fix ;-) It seemed to me you were actively working on related stuff, and I was just too quickly curious without access to a build setup, so did not

D7732: Force KAuth helpers to have UTF-8 support

aacid added a comment. In D7732#425077 , @davidedmundson wrote: > > I'm not sure changing the codec for all kauth stuff is the best > > I did it in just my one helper initially, but in review it was suggested to make it global as it affects e

D15408: Don't assert deleting the temporary file

jtamate planned changes to this revision. jtamate added a comment. The more I try to understand my own explanations, the less I agree with my past me. - Reading again the QTemporary documentation, without anything, the constructor creates a temporary file in the temp directory with prefi

D19491: generic config interface

cullmann added a comment. In D19491#424808 , @dhaumann wrote: > Currently, one cannot 'unset' a value, but I guess that is ok, since we did not have that before > > In general this approach is OK. Some thoughts on this: > > - is it as fas

D19532: Don't crash when no contexts are present

davispuh added a comment. In D19532#424926 , @cullmann wrote: > Hi, first: good thing to get this fixed, yes, it shall not crash. > > For the fix: Wouldn't it be enough to just change the > > if (!d->m_definition.isValid()) { > > app

D19532: Don't crash when no contexts are present

cullmann added a comment. No, because defData isn't defined there yet, it's created only later with auto defData = DefinitionData::get(d->m_definition); > you can just move that up some lines, or? === I actually have taken a short look, perha

D19491: generic config interface

loh.tar added a comment. > either extra key or "CamlCase" the key we use for the command-line/kate: var line I would avoid any kind of extra key. Just one string used for the config file and these document variables. I guess "Tab Width" is simpler to convert to "set-tab-width" as "TabWi

D19532: Don't crash when no contexts are present

cullmann added a comment. F6660164: test.diff This would be my proposed patch + unit test. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever Cc: kwrite-devel, kd

D19532: Don't crash when no contexts are present

davispuh added a comment. In D19532#425376 , @cullmann wrote: > No, because defData isn't defined there yet, it's created only later with auto defData = DefinitionData::get(d->m_definition); > > => you can just move that up some lines, or?

D19491: generic config interface

cullmann added a comment. I think some extra keys are not avoidable to be compatible with the old stuff. See e.g. // BEGIN ConfigInterface stff QStringList KTextEditor::DocumentPrivate::configKeys() const { static const QStringList keys = { QLatin1String("backup-on-sav

D19532: Don't crash when no contexts are present

cullmann added a comment. Calling the ::get is no issue. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullm

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

cullmann added a comment. In D19512#425307 , @ngraham wrote: > Tooltips are used throughout KDE and are approved by our HIG. We can use one here. I am not sure if tooltips are that great in the status bar. You often hover over that duri

D19532: Don't crash when no contexts are present

davispuh added a comment. In D19532#425381 , @cullmann wrote: > Calling the ::get is no issue. That's good then, but we can't use `applyFormat(0, text.size(), Format());` because Kate asserts when `!Format->isValid()` which it won't be so

D19532: Don't crash when no contexts are present

cullmann added a comment. In D19532#425384 , @davispuh wrote: > In D19532#425381 , @cullmann wrote: > > > Calling the ::get is no issue. > > > That's good then, but we can't use `applyFormat(0,

D19491: generic config interface

loh.tar added a comment. Well, when it is important to be compatible, then may that needed. OTH would it be so terrible to break it? Perhaps it may more important to keep the doc variables untouched than the config file keys. So I would adjust the config file keys to fit the doc variabl

D19491: generic config interface

cullmann added a comment. I think breaking the config files is just as bad ;=) After we have converted all things, we might even support exporting/importing the complete document/view/render global config to from other formats like json using the "nice" keys, as we can just write a small

T10554: KDiff3 to join Applications

aacid added a comment. In T10554#177819 , @cfeck wrote: > Moving KDiff3 to KDE Applications was suggested at https://marc.info/?l=kde-core-devel&m=155055818529475&w=2 Ouch, inside a thread named "Kdiff3 craft setup", no wonder i ignored i

D19551: [knotifications] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R289 KNotifications

KDE CI: Frameworks » ki18n » kf5-qt5 WindowsMSVCQt5.11 - Build # 29 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20WindowsMSVCQt5.11/29/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 05 Mar 2019 16:08:16 + Build duration: 4 hr 5 min and counting JUnit Tests Name: pr

D19532: Don't crash when no contexts are present

davispuh updated this revision to Diff 53234. davispuh added a comment. Improvements REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19532?vs=53175&id=53234 BRANCH context REVISION DETAIL https://phabricator.kde.org/D19532 AFFECTED FILES

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53235. davispuh added a comment. Allow invalid Format() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53177&id=53235 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFECTED FILE

D19532: Don't crash when no contexts are present

cullmann added a reviewer: vkrause. cullmann added a comment. Ok with that. Volker, ok, too? I think the if(...isLoaded) removal is a diff artifact, that was never in the original code bug just in the first try here. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabric

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53236. davispuh added a comment. Whoops... REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53235&id=53236 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFECTED FILES src/synta

D19533: Don't crash on malformed syntax highlighting files

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19533 To: davispuh, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demski

D19533: Don't crash on malformed syntax highlighting files

cullmann added a comment. In principle ok, but I would like to have the m_properties.resi code in that if shared. We already have that, just a few lines above. You just need to move the computation of the auto definitions = definition().includedDefinitions(); a few lines up, you can j

D19533: Don't crash on malformed syntax highlighting files

cullmann added a comment. And btw., thanks for taking care of that crash, it's ugly to crash for such things. My fault, did never test that :/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19533 To: davispuh, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-

D19461: Logcat: fix dsError color with underline="0"

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. But lets think about KTextEditor issues on an other day and first have this workaround + the nice unit test. REPOSITORY R216 Syntax Highlighting BRANCH logcat-fix-error-color REVI

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a reviewer: dhaumann. cullmann added a comment. Perhaps Dominik has some idea if that is right or not ;=) REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel,

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53237. davispuh added a comment. Don't duplicate code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53236&id=53237 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFECTED FILES

D19533: Don't crash on malformed syntax highlighting files

cullmann added a comment. Hmm, I just thought that might be correct, but doesn't that kill highlighting for all definitions that include none? If forgot that includedDefinitions() doesn't include itself, that check makes no sense ;=) I think we are missing some check at the end if we h

D19533: Don't crash on malformed syntax highlighting files

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Sorry that I was confused, but I just have seen your check of definitions.isEmpty() and thought that would be the right one. REPOSITORY R39 KTextEditor REVISION DETAIL ht

D19551: [knotifications] compile without foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > knotifyconfig.cpp:53 > QCache &cache = *static_cache; > -Q_FOREACH (const QString &filename, cache.keys()) { > +const auto listFiles = cache.keys

D19461: Logcat: fix dsError color with underline="0"

nibags added a comment. I want to check the colors of this highlighter before doing the commit REPOSITORY R216 Syntax Highlighting BRANCH logcat-fix-error-color REVISION DETAIL https://phabricator.kde.org/D19461 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite

D19557: Update css

ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Header look like http://docs.carlschwan.eu/ Screenshot comming TEST PLAN Wasn't able

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb added reviewers: VDG, Documentation. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar updated this revision to Diff 53252. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Enable ViewTest: ScrollPastEndOfDocument * Start testing of KateViewTest * Config: Using QtTest library 5.12.1, Qt 5.12.1 (x86_64-l

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar updated this revision to Diff 53253. loh.tar added a comment. - Use signal KTextEditor::DocumentPrivate::readWriteChanged to update icon CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19512?vs=53123&id=53253 REVISION DETAIL https://phabricator.kde.org/D19512 AFFECTED FILE

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

loh.tar added a comment. Regarding icon, tooltip and save action, see also https://phabricator.kde.org/D17730#392331 REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, doms