D19557: Update css

ognarb added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? I only had a png version in my hard drive, but if it's a problem I can convert the png in a jpg. In D19557#426057

D18673: Add symlinks for flatpak

ngraham added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18673 To: GeeXT, #frameworks, #vdg Cc: nibags, kde-frameworks-devel, michaelh, ngraham, bruns

D18673: Add symlinks for flatpak

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I like the functionality, though I'm not thrilled about having to change these symlinks around as apps change their appstream IDs, and constabtly add new ones as different packa

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

habacker marked 2 inline comments as done. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

habacker updated this revision to Diff 53327. habacker marked an inline comment as done. habacker added a comment. - added @since tag The patch was added to build the stable version of KMyMoney for Windows to fix an issue not been able to have common printer settings. Since KHTML is th

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Withdrawing my approval, after realizing that this is missing the "enough free space at destination" check. Imagine a 5GB partition with a 4GB file on it. You want to copy anothe

D18673: Add symlinks for flatpak

nibags added a comment. +1 Also missing the symlink for JDownloader (org.jdownloader.JDownloader.svg): https://flathub.org/apps/details/org.jdownloader.JDownloader I don't know if it's also necessary to add symlinks for AppImage apps: https://appimage.github.io/apps/ For example: hot

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Mar 2019 21:43:20 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 06 Mar 2019 21:43:20 + Build duration: 3 min 17 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 06 Mar 2019 21:43:21 + Build duration: 2 min 15 sec and counting JUnit Tests Name:

D19544: Send blur/background contrast in device pixels

This revision was automatically updated to reflect the committed changes. Closed by commit R278:abcf323ab6f3: Send blur/background contrast in device pixels (authored by davidedmundson). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19544?vs=53210&id=53

D19575: Add collapse-all and expand-all action icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great to me! REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg,

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, b

D18604: Implement support for writing rating information for taglib writer

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoo

D19575: Add collapse-all and expand-all action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricato

D19532: Don't crash when no contexts are present

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. In D19532#426005 , @vkrause wrote: > In D19532#425432 , @cullmann wrote: > > > Ok

D19307: Enforce new muted icon style in all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

Re: kconf_update lost its update.log in 2014

El divendres, 1 de març de 2019, a les 11:21:04 CET, Harald Sitter va escriure: > On Thu, Feb 28, 2019 at 8:20 PM Albert Astals Cid wrote: > > > > El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va > > escriure: > > > ...and I don't understand why > > > > > > Hi! > > > > > > th

D19557: Update css

broulik added a comment. Can't we just go SVG with the icon? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

aacid added a comment. The code is fine, the bigger question here is if we want new features in khtml that is part of the "portingAids" part of frameworks. INLINE COMMENTS > khtmlview.h:207 > + * @param quick if true, fully automated printing, without print dialog > + */ > +void

D19557: Update css

aacid added a comment. Why changing from jpg to png for the image file ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/45/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Mar 2019 17:01:08 + Build duration: 21 min and counting BUILD ARTIFACTS abi-compatibility-result

D19532: Don't crash when no contexts are present

vkrause added a comment. In D19532#425432 , @cullmann wrote: > Ok with that. > Volker, ok, too? > I think the if(...isLoaded) removal is a diff artifact, that was never in the original code bug just in the first try here. Yep, repla

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/49/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 06 Mar 2019 17:01:08 + Build duration: 6 min 26 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 06 Mar 2019 17:01:08 + Build duration: 6 min 6 sec and counting BUILD ARTIFACTS abi-compatibility-r

D19422: Fix upper/lower case rename on case insensitive fs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ef5b9c6991aa: Fix upper/lower case rename on case insensitive fs (authored by hoffmannrobert, committed by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D194

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

habacker marked an inline comment as done. habacker added inline comments. INLINE COMMENTS > tbaumgart wrote in khtmlview.cpp:3134 > Why don't you pass a reference to the QPrinter object here? Because api dealing with QPrinter always use a pointer. void QWebView::print(QPrinter *) void QPrintP

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau updated this revision to Diff 53299. kossebau added a comment. update to latest master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19565?vs=53273&id=53299 BRANCH configfileextensions REVISION DETAIL https://phabricator.kde.org/D19565 AFFE

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d996a0fba67d: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up (authored by kossebau). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D195

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

kossebau added a comment. @apol Thanks for review :) REPOSITORY R237 KConfig BRANCH reruncmakeonkfgcchange REVISION DETAIL https://phabricator.kde.org/D19567 To: kossebau, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar updated this revision to Diff 53296. loh.tar retitled this revision from "DocumentPrivate: Auto reload in read-only mode" to "DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt". loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 53297. chinmoyr added a comment. Remove unrelated changes commited by mistake. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=53291&id=53297 BRANCH arcpatch-D18904 (branched from master) REVISION DETAIL http

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

sirgienko created this revision. sirgienko added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sirgienko requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH octave-we

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 53291. chinmoyr added a comment. Delete .part file when Overwrite flag is set. @dfaure please have a look at it again. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18904?vs=51383&id=53291 BRANCH arcpatch-D18904_1

D19422: Fix upper/lower case rename on case insensitive fs

hoffmannrobert added a comment. Could you please land it for me, I don't have commit access. Thanks. REPOSITORY R241 KIO BRANCH fix_case_rename REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, mich

D19422: Fix upper/lower case rename on case insensitive fs

chinmoyr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix_case_rename REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY R237 KConfig BRANCH reruncmakeonkfgcchange REVISION DETAIL https://phabricator.kde.org/D19567 To: kossebau, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh,

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

apol added a comment. +1 LGTM REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The build configuration depends on the value of the "File=" entry in the kcfg

D19367: SearchBar: Don't block GUI when enter incremental pattern

loh.tar updated this revision to Diff 53281. loh.tar retitled this revision from "[RFC]SearchBar: Don't block GUI when enter incremental pattern" to "SearchBar: Don't block GUI when enter incremental pattern". loh.tar edited the test plan for this revision. loh.tar added a comment. - Consider

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

tbaumgart added inline comments. INLINE COMMENTS > khtmlview.cpp:3134 > + > +void KHTMLView::print(QPrinter *_printer, bool quick) > +{ Why don't you pass a reference to the QPrinter object here? REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker Cc: tba

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau updated this revision to Diff 53273. kossebau added a comment. fixup: correct default cpp for SourceExtension in README.dox REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19565?vs=53272&id=53273 BRANCH configfileextensions REVISION DETAIL htt

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When using kconfig_compiler generated sources in projects where the used file

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 06 Mar 2019 12:05:54 + Build duration: 6 min 2 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kholidays » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 06 Mar 2019 11:39:25 + Build duration: 2 min 44 sec and counting

KDE CI: Frameworks » kitemmodels » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 06 Mar 2019 11:39:24 + Build duration: 1 min 27 sec and counting

KDE CI: Frameworks » kitemviews » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 06 Mar 2019 11:39:23 + Build duration: 1 min 1 sec and counting

KDE CI: Frameworks » kplotting » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 06 Mar 2019 11:39:22 + Build duration: 56 sec and counting

KDE CI: Frameworks » syndication » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 06 Mar 2019 11:39:21 + Build duration: 54 sec and counting

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 06 Mar 2019 09:55:42 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 06 Mar 2019 09:55:42 + Build duration: 6 min 42 sec and counting JUnit Tests Nam

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/37/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Mar 2019 09:55:42 + Build duration: 6 min 10 sec and counting BUILD ARTIFACTS abi-c