D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau updated this revision to Diff 53987. kossebau added a comment. add documentation about wanted behaviour, so the next person does not change it again REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19787?vs=53986&id=53987 BRANCH

D19798: Fix Words & Chars String on katestatusbar.

ppeter added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19798 To: ppeter, #kate Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau updated this revision to Diff 53986. kossebau added a comment. Only prevent width/height of textureRect becoming 0, otherwise keep old behaviour. Not changing to qround to prevent bad image quality due to up-sampling. F6695867: Screenshot_20190316_070411.png

D19798: Fix Words & Chars String on katestatusbar.

ppeter added a comment. The reason why I just change `%1/%2` to `%2/%1` not swap `wordsInDocument` and `wordsInSelection`, because I want to notify translators about this change (or those current translation may have some issue when applied this fix.) Sorry for my poor English :( REPO

D19798: Fix Words & Chars String on katestatusbar.

ppeter updated this revision to Diff 53985. ppeter added a comment. Fix the newline issue. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19798?vs=53984&id=53985 BRANCH fixStatusBarString (branched from master) REVISION DETAIL https://phabricator.k

D19798: Fix Words & Chars String on katestatusbar.

ppeter created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ppeter requested review of this revision. REVISION SUMMARY The current string I think have some issues, for example: This is a text file: ABC DEF GHI J

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/55/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 16 Mar 2019 04:44:50 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/41/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 16 Mar 2019 04:44:50 + Build duration: 9 min 28 sec and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/59/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Mar 2019 04:44:50 + Build duration: 7 min 21 sec and counting JUnit Tests Name: projectroo

D18845: authority: add support for passing details to polkit

bruns added a comment. LGTM - @fvogt , @chinmoyr ? REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: mati865, kde-frameworks-devel

D19762: Only get clearTextPath when used

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D19762 To: broulik, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R373 Image Thumbnailers BRANCH master REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks, bruns Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexd

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 77 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/77/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Mar 2019 22:32:18 + Build duration: 6 min 24 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/54/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Mar 2019 22:32:18 + Build duration: 5 min 15 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/85/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Mar 2019 22:32:18 + Build duration: 2 min 0 sec and counting JUnit Tests Name: pro

D19602: [KParts] Fix compilation for Qt 5.13

This revision was automatically updated to reflect the committed changes. Closed by commit R306:3f3c760d7f52: [KParts] Fix compilation for Qt 5.13 (authored by matthieugras, committed by mlaurent). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19602?vs=53396&i

D19795: Add Variable interface to KTextEditor::Editor

dhaumann added a comment. What I wonder is whether we really need the "Variable" class. Maybe it would be better to just have - registerExactMatch(QString name, QString description, function) - registerPrefixMatch(QString prefix, QString description, function) If such a change woul

D19795: Add Variable interface to KTextEditor::Editor

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY The Variable interface allows to register either exact matches

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentusagemodel.cpp:261 > > if (!url.isValid() || !(fileItem.isFile() || fileItem.isDir())) { > return QVariant(); How do you expect isFile()

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. In D19787#431712 , @apol wrote: > Does this solve the fluffy bunny issue? Yes, both approaches solve the broken rendering for Fluffy Bunny, as they both prevent width/height to be set to 0. Given the fuzzy nature

D19771: Use placeholder instead of label

loh.tar added a comment. For me is your distinction between Find/Search not very intuitive. But OK, in terms of HIG may that somehow a wanted subtlety. Filter on the other hand is something else, yes, and here not fitting. So "Find..." in both cases. Not answered are the questions about

D19784: Avoid calling QT_LSTAT and accessing recent documents

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:254 > +// return any useful information for our purposes here. > +url.setScheme(QString()); > +KFileItem fileItem(url); This looks very much like a workaround. How about adding an argument to the KFileItem to skip th

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

apol added a comment. Does this solve the fluffy bunny issue? Otherwise it could be that the theme needs adapting to tell plasma to repeat the pattern instead of stretching it. INLINE COMMENTS > framesvgitem.cpp:148 > if (m_border == FrameSvg::TopBorder || m_border == > Frame

D19783: [kitemview] compile without foreach

apol added inline comments. INLINE COMMENTS > kwidgetitemdelegatepool.cpp:136 > +const auto lst = d->widgetInIndex.keys(); > +for (QWidget *widget : lst) { > const QAbstractProxyModel *proxyModel = qobject_cast QAbstractProxyModel *>(d->delegate->d->model); This one clearly shou

D19696: Add blender thumbnailer

chinmoyr updated this revision to Diff 53971. chinmoyr added a comment. Removed unused headers. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53848&id=53971 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19696 AFFECTE

D19771: Use placeholder instead of label

ngraham added a comment. That's different. "Filter" actually hides non-matched entries. "Find" highlights them while keeping the context and surrounding content. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cfeck, loh.t

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53970. davispuh added a comment. Also check for present formats REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53237&id=53970 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFEC

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ngraham added a comment. Yep, I always do. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 added a comment. In D19733#431693 , @ngraham wrote: > So now this happens: > > F6693594: Weird.gif > > Does the category Icon in System Settings itself need to be updated too? Did you cle

D19791: Make KFontRequester consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R236:0c04c4c8c450: Make KFontRequester consistent (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19791?vs=53968&id=53969#toc REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ngraham added a comment. So now this happens: F6693594: Weird.gif Does the category Icon in System Settings itself need to be updated too? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndav

D19791: Make KFontRequester consistent

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH make-kfontrequester-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D19791 To: GB_2, #plasma, #vdg, ngraham Cc: #vdg, kde-frameworks-devel,

D19786: Fix WebDAV directory renaming if KeepAlive is off

ngraham added reviewers: Frameworks, Dolphin, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

ngraham added reviewers: Frameworks, dfaure, Dolphin. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert, #frameworks, dfaure, #dolphin Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D19771: Use placeholder instead of label

cfeck added a comment. In D19771#431674 , @ngraham wrote: > - "Find" is limited to items in the current view only, and usually pertains to text. I prefer the term "Filter" for this. If there is no filter, you see everything, if there is

D19771: Use placeholder instead of label

ngraham added a comment. "Find" and "search" are different things. Broadly: - "Find" is limited to items in the current view only, and usually pertains to text. - "Search" is anything broader than that. So for this, "Find" is the appropriate term. REPOSITORY R39 KTextEditor REV

D19791: Make KFontRequester consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Make the KFontRequester widget consistent with the new font selection style in the Fonts K

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

meven added a comment. glibc 2.28 was released in August 2018, it is at least in (k)ubuntu 18.10, and I would expect in most other distros as well. I would be happy to help test this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, e

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. An alternative approach might be to do instead //if tiling horizontally if (m_border == FrameSvg::TopBorder || m_border == FrameSvg::BottomBorder || m_border == FrameSvg::NoBorder) { textureRect.setWidth(qMax(1, nodeRect.width() / m_elementNativeSi

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a subscriber: sitter. kossebau added a comment. I have to admit I am not exactly sure what this code does (being a noob to openGL), so my assumptions about the effects I saw by try & error might be wrong. Thus please check properly someone who understands this code. Broken

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau created this revision. kossebau added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The old logic results in broken rendering if the sample was bigger than the

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Reset m_request.isKeepAlive to true if responseCode == 301 during renaming a directory. Otherwise the co

D19785: DocumentPrivate: Review del/backspace

loh.tar added a comment. This patch is the byproduct of some playing with RTL text, Bug 385694. But a sane solution may need some more effort, so I tend to not offer my current state of that playing. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19785 To: lo

D19785: DocumentPrivate: Review del/backspace

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Avoid bad selection in some case of undo in block mode - Do

D19771: Use placeholder instead of label

loh.tar added subscribers: ngraham, loh.tar. loh.tar added a comment. > So the change in Search and replace need to be reverted. That should @ngraham decide. See also https://phabricator.kde.org/T10258#178907 I would badly suggest to use in both cases the same term, "Find" or "Search

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/84/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Mar 2019 12:48:37 + Build duration: 50 min and counting JUnit Tests Name: project

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 53 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/53/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Mar 2019 12:48:37 + Build duration: 29 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 76 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/76/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Mar 2019 12:48:37 + Build duration: 28 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 140 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/140/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 15 Mar 2019 12:48:37 + Build duration: 6 min 11 sec and counting JUnit Tests

D19783: [kitemview] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R276 KItemViews BRA

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d0b4c3f2545f: Add preferences-desktop-theme-applications and preferences-desktop-theme… (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1973

D19602: [KParts] Fix compilation for Qt 5.13

matthieugras added a comment. In D19602#431385 , @mlaurent wrote: > Ping do you want that we commit for you ? > Otherwise I will do it as I need this patch. Yes please, go ahead REPOSITORY R306 KParts BRANCH master REVISION

D19779: point readme to the wiki page

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the wiki page says the readme is duplicated into the wiki. so, what we end up with is either - they end up out o

D19767: Fix malloc/delete mismatch

sitter added inline comments. INLINE COMMENTS > aacid wrote in kio_sftp.cpp:446 > Use ssh_string_free_char ? +1 "The caller needs to free the memory using ssh_string_free_char()." http://api.libssh.org/stable/group__libssh__sftp.html#gab4860a441da019060f78c8d236d9ec91 REPOSITORY R320 KIO Ex

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D19733 REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns