D19876: Fix: apply correctly the text colors of the chosen scheme

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:c922bc8352ac: Fix: apply correctly the text colors of the chosen scheme (authored by nibags). REPOSITORY R39 KTextEdi

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags added a comment. Sorry, I committed this diff, but it hasn't been fully accepted. Although I made the changes that mwolff requested. If there is a problem, I can undo the commit or update it REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19876 To: ni

D20046: Verify mimetypes for all existing sample files, add some more

bcooksley added a comment. Can you please file a task on the #build.kde.org board so I can get this worked through with the FreeBSD folks? (It will likely require the package being updated in FreeBSD itself) REPOSITORY R286 KFileMetaData R

D20092: New class KOSRelease - a parser for os-release files

sitter added a subscriber: davidedmundson. sitter added a comment. The only relevant change in the history not from me is from @davidedmundson it seems. Dave, are you ok with changing the license from GPL to LGPL? https://phabricator.kde.org/R102:65e55f0b090247263bb3ba2b45615fa3b2ff1320

D20092: New class KOSRelease - a parser for os-release files

davidedmundson added a comment. > Dave, are you ok with changing the license from GPL to LGPL? Sure. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol, mpyne Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel,

D20225: use more appropriate plasma-specific icon for plasma category

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY with D20176 landed we can now use the more appropriate icon variant for plasma her

D20176: make start-here-kde also available start-here-kde-plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9ff7e4658ded: make start-here-kde also available start-here-kde-plasma (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20176?vs=55209&id=5

D20225: use more appropriate plasma-specific icon for plasma category

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D20225 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

sitter updated this revision to Diff 55338. sitter added a comment. - defaultFilePath is now static in the cpp only, the public ctor defaults to QString() for the filePath, which gets checked in the private ctor and diverted to defaultFilePath if necessary - Private ctor now copies filePath

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406121 Needed for the upcoming do not disturb mode and overhauled notifcations. F6

D20225: use more appropriate plasma-specific icon for plasma category

This revision was automatically updated to reflect the committed changes. Closed by commit R252:bf27abdb08eb: use more appropriate plasma-specific icon for plasma category (authored by sitter). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20225

D20219: Propose Stefan Bruns as KFileMetaData maintainer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:79db0d55b933: Propose Stefan Bruns as KFileMetaData maintainer (authored by apol). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20219?vs=55323&id=55342 REV

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/62/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Apr 2019 13:25:25 + Build duration: 1 min 31 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Apr 2019 13:25:25 + Build duration: 2 min 41 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/62/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Apr 2019 13:25:25 + Build duration: 6 min 50 sec and counting BUILD ARTIFACTS abi-comp

D20169: Add profile support interface for TerminalInterface

hindenburg added a reviewer: Frameworks. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks Cc: michaelh, ngraham, bruns

D20226: Add "notifications" and "notifications-disabled" icons

ngraham added a comment. +1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think you could match the dimensions of that icon? REPOSITORY R266 Breeze

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 added a comment. In D20226#442841 , @ngraham wrote: > +1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (`preferences-desktop-notification-bell`) is triggering my OCD. :) Do

D20226: Add "notifications" and "notifications-disabled" icons

abetts added a comment. The line that goes across almost completely removes the bell's pendulum to the right. Maybe move the pendulum closer to the center so that even when there is that red strike line, the user can still make out that it is a notification bell REPOSITORY R266 Breeze Ico

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 updated this revision to Diff 55347. GB_2 added a comment. Move bell's pendulum REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55339&id=55347 BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DE

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

abetts added a comment. In D20226#442854 , @GB_2 wrote: > Move bell's pendulum Love it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-framework

D17355: Align Plasma QML button content in center if it has an icon

GB_2 abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: mart, davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeaky

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55346. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment. - Ensure the new added brackets will not be part of the selection when selection was done from right->left - Enhance autotest

D20226: Add "notifications" and "notifications-disabled" icons

ngraham added a comment. In D20226#442844 , @GB_2 wrote: > In D20226#442841 , @ngraham wrote: > > > +1 in general. However the fact that this black version doesn't match the outline/dimensions of th

D20226: Add "notifications" and "notifications-disabled" icons

ndavis added a comment. The proportions aren't quite right. F6749114: Screenshot_20190403_112343.png This is one way to make a perfectly smooth bell. Subtract the red shapes from the black shapes. F6749117: Screenshot_20190403_112550.png

D20226: Add "notifications" and "notifications-disabled" icons

GB_2 added a comment. In D20226#442882 , @ngraham wrote: > Also, could we create a 22x22 version too? How can you efficiently do that without having to realign everything to the new grid manually? REPOSITORY R266 Breeze Icons REVISION

D20230: Allow building without UDev on Linux

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Flatpak has been patching this for a while, there doesn't seem to be a way to use it ther

D20226: Add "notifications" and "notifications-disabled" icons

ndavis added a comment. In D20226#442906 , @GB_2 wrote: > In D20226#442882 , @ngraham wrote: > > > Also, could we create a 22x22 version too? > > > How can you efficiently do that without havin

D20230: Allow building without UDev on Linux

davidedmundson added a comment. What happens if this is not patched out? I'm asking because I'm hoping to use bwrap in more places outside of flatpak. In that case I'm going to need runtime detection. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20230 To: apol

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55355. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Bring back call of view->slotTextInserted I think it's ready for a new review REPOSITORY R39 KTextEdit

D20226: Add "notifications" and "notifications-disabled" icons

bruns added a comment. In D20226#442902 , @ndavis wrote: > The proportions aren't quite right. > > F6749114: Screenshot_20190403_112343.png > > This is one way to make a perfectly smooth bell. Subtra

D20226: Add "notifications" and "notifications-disabled" icons

ndavis added a comment. In D20226#442934 , @bruns wrote: > Diagonal or round shapes are **not** required to be pixel grid aligned. Actually, it is not even possible, as there is **always** some antialiasing. It even helps to make round shapes a

D20233: Add syntax highlighting for fish shell

adiestelhorst created this revision. adiestelhorst added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. adiestelhorst requested review of this revision. REVISION SUMMARY For fish shell version 2.7.

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#439120 , @ndavis wrote: > In D19952#439031 , @arvidhansson wrote: > > > In D19952#438965 , @ndavis wrote: > > >

D20220: AppArmor & SELinux: remove one indentation in XML files

nibags updated this revision to Diff 55366. nibags added a comment. - Fix some indentations REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20220?vs=55325&id=55366 BRANCH remove-indentation REVISION DETAIL https://phabricator.kde.org/D20220

D20230: Allow building without UDev on Linux

apol added a comment. I don't really remember the reason why we can't use udev there, it was more of a "it can be there but it will be useless", then there was a very long discussion with "what if I..." and people saying that udev needed redesigning. It was few years ago. At the moment if

D20230: Allow building without UDev on Linux

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's a good reason to do it at compile time :D REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D20230 To: apol, #frameworks, davide

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

nibags updated this revision to Diff 55367. nibags added a comment. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. - Remove "alias" in the "_end_rule" context and add some comments REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

nibags updated this revision to Diff 55368. nibags added a comment. - Fix some indentations - Remove selinux-*.xml changes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20221?vs=55367&id=55368 BRANCH remove-indentation REVISION DETAIL h

D20220: AppArmor & SELinux: remove one indentation in XML files

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH remove-indentation REVISION DETAIL https://phabricator.kde.org/D20220 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-framework

D20220: AppArmor & SELinux: remove one indentation in XML files

This revision was automatically updated to reflect the committed changes. Closed by commit R216:508be5417e67: AppArmor & SELinux: remove one indentation in XML files (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20220?vs=5536

D17991: Refactor the way device backends are built and registered

pino updated this revision to Diff 55373. pino added a comment. Rebase on master. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17991?vs=51892&id=55373 BRANCH cmake-backends-refactor (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

nibags updated this revision to Diff 55378. nibags added a comment. - Apply changes in apparmor.xml, remove selinux-*.xml changes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20221?vs=55368&id=55378 BRANCH arcpatch-D20221 REVISION DETAIL

D20238: device: include Reapply() in the interface

aleksanderm created this revision. aleksanderm added reviewers: jgrulich, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. aleksanderm requested review of this revision. REVISION SUMMARY The NetworkMan

D20238: device: include Reapply() in the interface

aleksanderm updated this revision to Diff 55379. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20238?vs=55377&id=55379 REVISION DETAIL https://phabricator.kde.org/D20238 AFFECTED FILES src/device.cpp src/device.h To: aleksanderm, jgrulich, #f

D17991: Refactor the way device backends are built and registered

pino added a comment. BTW if nobody will comment on this within one month, I will commit it as-is. 4 months without a review will be enough, considering also other reviews for Solid got comments/approvals. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To:

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

nibags updated this revision to Diff 55382. nibags added a comment. - Update tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20221?vs=55378&id=55382 BRANCH arcpatch-D20221 REVISION DETAIL https://phabricator.kde.org/D20221 AFFECTED F

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau updated this revision to Diff 55383. kossebau added a comment. Remove last bit about stripping that was still in the patch REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20166?vs=55231&id=55383 BRANCH uncompressedsvginrepo RE

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis commandeered this revision. ndavis edited reviewers, added: arvidhansson; removed: ndavis. ndavis added a comment. Alright. I'll finish it when I have time. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: ndavis, #vdg, arvidhansson Cc: ngraham,

D20238: device: include Reapply() in the interface

jgrulich added inline comments. INLINE COMMENTS > device.h:241 > + */ > +QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, > qulonglong version_id, uint flags); > /** 1. const NMVariantMapMap &connection 2. I would maybe pick a different name, because it doesn't rea