Re: KCrash - test_crasher spins in a loop on Windows

On Sat, 13 Apr 2019, 07:35 Ben Cooksley, wrote: > Hi all, > > Currently we have an issue where the test_crasher test will endlessly > fork itself while trying to setup it's conditions to run. > > This leads to an issue where it will occupy a single CPU core of a > builder indefinitely until it's

D20529: add license to python test files

bcooksley added a comment. In D20529#451561 , @bruns wrote: > In D20529#451147 , @bcooksley wrote: > > > can we get the full command it's running? > > > `ctest -V -R externalextractortest`

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis added a comment. One concern: Previously, the `go-up` icon in `go.svg` used a completely different style from the other `go-*` icons. Does anyone know why that was? I can't find any reason for it to use a different style. REPOSITORY R242 Plasma Framework (Library) REVISION DET

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20623 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH update-icons (branched from master) REVISION DETAIL h

D20608: Declare properties as meta type

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH enum_meta REVISION DETAIL https://phabricator.kde.org/D20608 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoo

D20529: add license to python test files

bruns added a comment. In D20529#451147 , @bcooksley wrote: > can we get the full command it's running? `ctest -V -R externalextractortest` REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20529 To: astipp

D20529: add license to python test files

bruns added a comment. In D20529#451147 , @bcooksley wrote: > The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python) > > I'd therefore suggest that

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56405. bruns added a comment. disable configure action when in configuration mode REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56287&id=56405 BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20

D20617: [balooctl] Factor out file index status collection from output

bruns added a dependent revision: D20620: [balooctl] Switch multiline output to new helper. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh,

D20620: [balooctl] Switch multiline output to new helper

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Output is mostly unchanged, but symlinks are no

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

aacid closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20616 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20619: [balooctl] Use new helper in json output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The output is mostly the same, save for the fol

D20617: [balooctl] Factor out file index status collection from output

bruns added a dependent revision: D20619: [balooctl] Use new helper in json output. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippi

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. We shouldn't indeed. Maybe it's a candidate to get in KGuiAddons REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D20616 To: aacid, apol Cc: apol,

D20618: [balooctl] Use new helper for simple format output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Symlinks are no longer reported as "Basic index

D20617: [balooctl] Factor out file index status collection from output

bruns added a dependent revision: D20618: [balooctl] Use new helper for simple format output. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20617 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michael

D20617: [balooctl] Factor out file index status collection from output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The three output formats (singleline, multiline

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY This is a port of 1b49ea4d3154630f79b604a191265cff687c18ad

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 16 Apr 2019 21:59:22 + Build duration: 8 min 41 sec and counting BUILD ARTIFACTS acc/KF5W

D20614: KKeySequenceWidget: Don't show English strings to the user

aacid closed this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D20614 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 16 Apr 2019 21:59:22 + Build duration: 2 min 18 sec and counting JUnit Tests Name:

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

aacid closed this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20613 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20614: KKeySequenceWidget: Don't show English strings to the user

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D20614 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20614: KKeySequenceWidget: Don't show English strings to the user

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY KKeyServer::modToStringUser is only for english texts BUGS: 405925 REPOSITORY R263 KXmlGui BRANCH master REVISIO

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D20613 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20606: Toggle folding of child ranges by right click

dhaumann added a comment. I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann, ngraham, dh

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D20613 AFFECTED FILES src/kkeyserver.h To:

D20565: Ensure not to fold the end marker

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Yes, I am in favor. thanks REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel, kde-frameworks-devel, #ktextedit

D18996: Fix building with namespaced Qt

cullmann closed this revision. cullmann added a comment. The build issue got fixed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: davschul, vkrause Cc: cgiboudeaux, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, mich

D20606: Toggle folding of child ranges by right click

cullmann added reviewers: ngraham, dhaumann. cullmann added a comment. I think the feature is nice. For the code: I would like to have comments for the function decls. to tell what they really do. e.g. toggleFoldingInRange needs a short summary what it does, the comments in the functio

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/85/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Apr 2019 17:54:41 + Build duration: 9 min 6 sec and counting BUILD ARTIFACTS acc/KF5Fi

D20604: Fix stack-buffer-overflow read on malformed files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20604 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20605: Fix null-dereference on malformed tar files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:084dabd35bfb: Fix null-dereference on malformed tar files (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20605?vs=56373&id=56389 REVISION DET

D20604: Fix stack-buffer-overflow read on malformed files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20604 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20605: Fix null-dereference on malformed tar files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20605 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/84/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Apr 2019 17:45:54 + Build duration: 8 min 45 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 16 Apr 2019 17:51:07 + Build duration: 2 min 25 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 16 Apr 2019 17:45:54 + Build duration: 5 min 12 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/84/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 16 Apr 2019 17:48:27 + Build duration: 2 min 8 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/83/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 16 Apr 2019 17:45:54 + Build duration: 2 min 31 sec and counting JUnit Tests Name:

D20608: Declare properties as meta type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Will be used in another test REPOSITORY R286 KFileMetaData BRANCH

D20528: Change properties attributes for consistency

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4808263e41bf: Change properties attributes for consistency (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20528?vs=56173&id=56385 RE

D20529: add license to python test files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:eb9b1ef9b30d: add license to python test files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20529?vs=56174&id=56383 REVISION DETAI

D19445: Handle variant list in formatting functions

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ffdee4011145: Handle variant list in formatting functions (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=55926&id=56384 REV

Re: grantlee commit access

On Monday, 15 April 2019 23:20:58 CEST David Faure wrote: > Thanks for the merge of the Qt 5.13 build fix. > > I would certainly welcome grantlee as a KF5 framework, I think it makes > things easier from a KDE point of view, and it reduces the bus factor in > terms of who can actually push to the

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. Oh, may that fit too? Bug 352868 - Folding for all nodes (not just top-level) and/or siblings to current REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel, #

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. A possible improvement could be to add slots to make the folding accessible by some keyboard action, but I'm not in the mood for that now. Bug 343060 - global folding code keyboard shortcuts REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org

D20606: Toggle folding of child ranges by right click

loh.tar added a comment. This patch supersedes D20565 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, b

D20606: Toggle folding of child ranges by right click

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this patch will all, and only, the nested folding

D20605: Fix null-dereference on malformed tar files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY findOrCreate can return nullptr so fail if it does oss-fuzz #14275 REPOSITORY R243 KArchive BRANCH master REVISI

D20604: Fix stack-buffer-overflow read on malformed files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Make sure we read at most 32 bytes for the user/group oss-fuzz #14264 REPOSITORY R243 KArchive BRANCH master REV

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

ngraham added a comment. Good idea, but the problem I keep running into is that `flickable.contentHeight` is set to 0 here. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20283 To: ngraham, #plasma, mart, broulik Cc: broulik, davidedmundson, GB_2, kde-framewor

D20498: Change namespace of MobileCursor

dkardarakos abandoned this revision. dkardarakos added a comment. Not relevant anymore, @mart fixed it as a separate commit. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.or

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. In D20525#449801 , @bruns wrote: > In D20525#449788 , @ngraham wrote: > > > +1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is na

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

broulik added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20602 To: kossebau, #plasma, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Instead of swapping out one random number for another, please correctly calculate the implicit size of the page, like `GridViewKCM` does: Something like implicitHeight:

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

kossebau created this revision. kossebau added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY During Pre-Plasma5 the hard-coded height of 20 of the progressbar was changed

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/78/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Apr 2019 12:46:22 + Build duration: 13 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/71/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 16 Apr 2019 12:46:22 + Build duration: 5 min 10 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/81/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 16 Apr 2019 12:46:22 + Build duration: 4 min 20 sec and counting JUnit Tests Nam

D20597: Align z's to pixel grid in system.svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0ff81fe4c728: Align z's to pixel grid in system.svg (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20597?vs=56356&id=56365

D20597: Align z's to pixel grid in system.svg

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-z (branched from master) REVISION DETAIL https://phabricator.kde.org/D20597 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

dfaure added a comment. This change also introduced regressions in two unittests: jobtest and kdirmodeltest. I'll let you look into those :-) https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobt

D20599: Fix compilation error on window

meven abandoned this revision. meven added a comment. Already merged: https://cgit.kde.org/kio.git/commit/?id=8f9f0f8db2480f0e8392048b3ca9cb974ec266b7 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20599 To: meven, dfaure, #frameworks, bcooksley Cc: kde-frameworks-deve

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/90/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Apr 2019 10:39:02 + Build duration: 24 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/87/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 16 Apr 2019 10:39:02 + Build duration: 8 min 21 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 16 Apr 2019 10:39:02 + Build duration: 7 min 12 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.

D20599: Fix compilation error on window

dfaure added a comment. Sorry, I was faster :/ https://commits.kde.org/kio/8f9f0f8db2480f0e8392048b3ca9cb974ec266b7 At least we agree on the exact patch, thanks for the confirmation :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20599 To: meven, dfaure

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 260 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/260/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 16 Apr 2019 10:39:02 + Build duration: 5 min 48 sec and counting

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#451148 , @bcooksley wrote: > MSVC doesn't like this change i'm afraid - see https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/console > Looks like you're ma

D20599: Fix compilation error on window

meven created this revision. meven added reviewers: dfaure, Frameworks, bcooksley. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/D20096#451148 TEST PLAN Compiles on MSV

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

dfaure added a comment. Nah, no C++17 here, the compiler is just confused because it doesn't know the types uid_t and gid_t. I'll add some #ifndef Q_OS_WIN. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bcooksley added a comment. MSVC doesn't like this change i'm afraid - see https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/console Looks like you're making use of C++17 features? REPOSITORY R241 KIO REVISION DETAIL https://phabricat

D20529: add license to python test files

bcooksley added a comment. The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python) I'd therefore suggest that something isn't entirely right with how Python is being executed by the tests here...

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/70/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 16 Apr 2019 09:28:43 + Build duration: 30 min and counting BUILD ARTIFACTS acc/KF5Plas

D20594: Fix MobileTextSelection namespacing

mart added a comment. sorry, didn't notice it :( REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/80/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 16 Apr 2019 09:28:42 + Build duration: 14 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/77/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Apr 2019 09:28:42 + Build duration: 6 min 46 sec and counting BUILD ARTIFACTS acc/K

D20594: Fix MobileTextSelection namespacing

broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-framework.git/commit/?id=8431223542110fd112cda5a4b352ab4a8a21bb51 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame

D20594: Fix MobileTextSelection namespacing

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

zzag added a comment. > Maybe we can revisit once I've done the kwin side? Sure. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20595 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

davidedmundson marked 2 inline comments as done. davidedmundson added a comment. > What about xdg_shell_unstable_v6? Code wise it's a super easy copy + paste. I'm somewhat torn when it comes to adding new "features" to deprecated specs that I can't do real-world testing of. Maybe

D20595: Implement set_window_geometry

davidedmundson updated this revision to Diff 56357. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20595?vs=56353&id=56357 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20595 AFFECTED FILES autot

D20595: Implement set_window_geometry

zzag added inline comments. INLINE COMMENTS > xdgshell_interface.h:283 > + * @brief windowGeometry > + * The position of the window within the buffer > + * s/position/geometry/ > xdgshell_stable_interface.cpp:524 > +if (s->m_topLevel) { > +s->m_topLevel->d_func()->window

D20597: Align z's to pixel grid in system.svg

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20597 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This does the same thing as D20586 , but for the Breeze

D20586: Sharpen Z's in system-suspend* icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:db9fdceac1ac: Sharpen Z's in system-suspend* icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20586?vs=56331&id=56355 REVISION DETAI

D20595: Implement set_window_geometry

zzag added a comment. What about xdg_shell_unstable_v6? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20595 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Used by clients to say where their true window geometry is relative

D20594: Fix MobileTextSelection namespacing

broulik edited the summary of this revision. broulik added a reviewer: lbeltrame. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

broulik created this revision. broulik added reviewers: Plasma, mart, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is all in `MobileTextSelection` instead of `Private` now. TEST PLAN I

D20592: Set correct kwalletd_bin_path

This revision was automatically updated to reflect the committed changes. Closed by commit R311:25f9723e87ce: Set correct kwalletd_bin_path (authored by broulik). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20592?vs=56347&id=56349 REVISION DETAIL https:/

D20592: Set correct kwalletd_bin_path

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D20592 To: broulik, davidedmundson, jriddell Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20592: Set correct kwalletd_bin_path

broulik created this revision. broulik added reviewers: davidedmundson, jriddell. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is installed as `kwalletd5` TEST PLAN Compiled this and kwallet

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 172 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/172/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 16 Apr 2019 07:02:45 + Build duration: 5 min 59 sec and counting JUnit Test