D20833: Simpler check for flatpak

broulik added inline comments. INLINE COMMENTS > knotificationmanager.cpp:94 > > if (!qEnvironmentVariableIsEmpty("XDG_RUNTIME_DIR")) { > +d->inSandbox = QFileInfo::exists(QLatin1String("/.flatpak-info")); Do you need this check now, even, since you're not using it anymore? REPOS

D20815: Ensure highlighted folding marker after unfold

loh.tar updated this revision to Diff 57002. loh.tar edited the test plan for this revision. loh.tar added a comment. - Fix jump of big unfold II :-/ I notice that this not yet works when done by Short-Cut/Menu and there are nested folding ranges CHANGES SINCE LAST UPDATE https://phabr

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. In D19812#455478 , @ngraham wrote: > TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be useful

D20833: Simpler check for flatpak

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY I saw it being checked like that, I think it reads a bit cleaner. REPOSITORY R289 KNotif

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 25 Apr 2019 20:09:26 + Build duration: 2 min 20 sec and counting BUILD ARTIFACTS acc/KF5Book

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

aacid added a comment. In D20209#456213 , @hallas wrote: > In D20209#455579 , @aacid wrote: > > > @hallas but tests are still failing since your previous commit. Can you have a look? https://build.k

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

aacid added a comment. In D20209#456214 , @ngraham wrote: > The failing one is using Qt 5.10 FWIW 5.12 fails too https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.12/18/testReport/ REPOSITORY R294 KBookmarks RE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/95/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 25 Apr 2019 19:47:39 + Build duration: 7 min 32 sec and counting JUnit Tests Name: projectroo

D12647: Move the inline preview button into the menu

meven added a comment. In D12647#434327 , @ngraham wrote: > I don't think this makes sense anymore. "Put the Show Inline Preview button in the settings menu" is still in T8552 , shouldn't we remove this

D20827: Reword some text, a couple clean ups, add a separator

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f17749e70c09: Reword some text, a couple clean ups, add a separator (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20827?vs=56988&id=56991 REVISIO

D17816: Support for xattrs on kio copy/move

spoorun added a comment. In D17816#425196 , @bruns wrote: > Does this work correctly when the source is a symlink? - getxattr vs lgetxattr. Did anyone get to check? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17

D20827: Reword some text, a couple clean ups, add a separator

GB_2 accepted this revision. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg, GB_2 Cc: kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPet

D20827: Reword some text, a couple clean ups, add a separator

GB_2 added reviewers: Frameworks, VDG. GB_2 added a project: VDG. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, squea

D20827: Reword some text, a couple clean ups, add a separator

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH rewored REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19812: Add a web page to view and compare icons of different sizes

GB_2 added a comment. I personally think this could be quite useful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20827: Reword some text, a couple clean ups, add a separator

meven edited the test plan for this revision. meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20827: Reword some text, a couple clean ups, add a separator

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Re-word some menu items per T8552#140370 REPOSITORY R241 KIO BRANCH rewore

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/80/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 25 Apr 2019 18:01:44 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/87/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 25 Apr 2019 18:01:44 + Build duration: 5 min 31 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/90/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 25 Apr 2019 18:01:44 + Build duration: 3 min 39 sec and counting JUnit Tests Nam

D20825: Fix wrong group names for 22, 32 px in audio.svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:176643f48c84: Fix wrong group names for 22, 32 px in audio.svg (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20825?vs=5698

D20825: Fix wrong group names for 22, 32 px in audio.svg

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20825 To: ndavis, #vdg, #plasma, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Code looks sane now. But the UI needs polish. Putting it in the advanced page feels awkward to me, and even on that page, its location isn't right. It feels arbitrary, disconne

D20825: Fix wrong group names for 22, 32 px in audio.svg

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Before this fix, the system tray audio widget would try to use the 32px icons where

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

ngraham added a comment. The failing one is using Qt 5.10 FWIW REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added a comment. In D20209#455579 , @aacid wrote: > @hallas but tests are still failing since your previous commit. Can you have a look? https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/ H

D20735: [KPropertiesDialog] Add octal permissions

ngraham added a reviewer: VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino, #vdg Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop edited the test plan for this revision. JJRcop set the repository for this revision to R292 KUnitConversion. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks

D20735: [KPropertiesDialog] Add octal permissions

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

shubham updated this revision to Diff 56979. shubham added a comment. 1. Use mode_t to get the permissions 2. Position the octal permissions inside "Advanced Permissions" tab REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20735?vs=56735&id=56979 BRANCH oct

D20815: Ensure highlighted folding marker after unfold

loh.tar updated this revision to Diff 56977. loh.tar added a comment. - Ensure cursor don't move when isssue toggleFoldingsInRange CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20815?vs=56970&id=56977 REVISION DETAIL https://phabricator.kde.org/D20815 AFFECTED FILES src/view/k

D20815: Ensure highlighted folding marker after unfold

loh.tar added a comment. I think about a patch to issue the foldingPreview in case of unfold when done by click on the icon bar. Unfortunately would that need some bigger changes at the toggleFolding functions to return what was done. Oops! Noticed that we have now some odd behavior when

D20815: Ensure highlighted folding marker after unfold

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this patch behaves the unfold like the fold to highlight t

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

abetts added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20806: Add HiDPI support

ngraham removed a reviewer: Frameworks. REPOSITORY R382 KSane Library REVISION DETAIL https://phabricator.kde.org/D20806 To: volkov, sars, #frameworks Cc: ltoscano, ngraham

D20806: Add HiDPI support

ltoscano added a comment. The KSane library is not a framework. REPOSITORY R382 KSane Library REVISION DETAIL https://phabricator.kde.org/D20806 To: volkov, sars, #frameworks Cc: ltoscano, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 25 Apr 2019 13:05:17 + Build duration: 5 min 23 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/86/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 25 Apr 2019 13:05:18 + Build duration: 4 min 20 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/89/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 25 Apr 2019 13:05:18 + Build duration: 4 min 19 sec and counting JUnit Tests Nam

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham added a comment. So can someone clarify what's requested for @JJRcop now? REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: cfeck, apol, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

broulik added inline comments. INLINE COMMENTS > zzag wrote in windowthumbnail.cpp:213 > Do you actually need Q_FALLTHROUGH() here? I fall through so I wanted to make it explicit. I would have put a `// fallthrough` comment otherwise REPOSITORY R242 Plasma Framework (Library) REVISION DETAI

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

zzag added inline comments. INLINE COMMENTS > windowthumbnail.cpp:213 > +case ItemEnabledHasChanged: > +Q_FALLTHROUGH(); > +case ItemVisibleHasChanged: Do you actually need Q_FALLTHROUGH() here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b2424879a19: [Window Thumbnail] Also monitor scene visibility and clean up (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20805?vs=56951&id=56956#toc REPOSITORY R242

D20806: Add HiDPI support

ngraham added a reviewer: Frameworks. REPOSITORY R382 KSane Library REVISION DETAIL https://phabricator.kde.org/D20806 To: volkov, sars, #frameworks Cc: ngraham

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20805 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

cfeck added a comment. The encode/decode functions were already reviewed for kdelibs4. It's the remaining code that needs review. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18161 To: cfeck, #frameworks, #dolphin, dfaure Cc: frispete, nathanshearer, nerdopolist, ngr

D20693: Remove pixelated border

This revision was automatically updated to reflect the committed changes. Closed by commit R304:e1f5782a8518: Remove pixelated border (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20693?vs=56794&id=56952 REVISION DETAIL https://phab

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

broulik added a comment. I recall there was also a bug about "games becoming slow when hovering them in task bar" which might be the same bug: us not unredirecting it again REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20805 To: broulik, #plasma

D20693: Remove pixelated border

leinir added a comment. That does indeed look good, and not a huge departure from what we have already, which i'm sure will make people feel quite at home in the new version :) I do wonder if we'd want to, at some point, make it look closer to Discover, but certainly for now this seems a muc

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Just because the item is `visible` doesn't mean the window itself is. Keep track of t

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

cfeck added a comment. KFormat knows about the prefixes, but doesn't know their name. I would say adding translations for "megabytes" etc. to KCoreAddons is out of scope. REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: cfeck, apol, aacid, ngraha

D20626: Refactor and cleanup

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. - The description still says "Refactor and cleanup" (note that phabricator doesn't auto-update from the commit log, unless you use arc diff --verbatim, so one often has to copy/pa