D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57441. meven added a comment. Fix an issue where the closuser would be called for each finished event once set REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57124&id=57441 BRANCH arcpatch-D20838 REVISION DETAIL

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57442. meven added a comment. Grab the focus so that the currentItem becomes the kfilewidget selected item, otherwise the user needs to give the kdiroperator the focus first REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D208

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Having to maintain and sync the module identifier in m

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau added a comment. Possibly the ECMGenerateQmlTypes could be also merged somehow, but I have no experience with that, so leaving to someone else to improve here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https:/

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

broulik accepted this revision. broulik added a comment. Even more noticeable when using high dpi (Plasmashell doesn't use scaling on X): Before F6805353: Screenshot_20190503_105021.png After F6805355: Screenshot_20190503_105047.png

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

davidedmundson accepted this revision. REPOSITORY R296 KDeclarative BRANCH same-button-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D20977 To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bru

D20986: Don't call click on the delegate, when we just want it to become current item

leinir created this revision. leinir added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY If you have any actions in your GridDelegate, activating them would previously cause t

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57450. kossebau added a comment. Add DEPENDS & DESIGNERSUPPORTED, nothing complicated there (besides going for asking string with pair of identifier & version, to avoid any arg clash & make parsing easier) REPOSITORY R240 Extra CMake Modules CHANGE

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20986: Don't call click on the delegate, when we just want it to become current item

broulik added a comment. -1 Most KCMs actually use `onClicked` to update the selected plugin and other bits. They don't actually set `currentIndex` on the `ListView` directly but have it updated based on whatever current scheme or theme etc is selected. REPOSITORY R296 KDeclarative R

D20986: Don't call click on the delegate, when we just want it to become current item

leinir added a comment. In D20986#460112 , @broulik wrote: > -1 > > Most KCMs actually use `onClicked` to update the selected plugin and other bits. They don't actually set `currentIndex` on the `ListView` directly but have it updated based

D20986: Don't call click on the delegate, when we just want it to become current item

broulik added a comment. oh, crap, right, I thought that was the delegate code, not the buttons. I think it just shouldn't do anything then since when changing the `currentIndex` if the KCM isn't prepared for that might cause the visual index and actual selected setting to become out of

D20955: use actually existing breeze icon for the new file Program.desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b127112914df: use actually existing breeze icon for the new file Program.desktop (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20955?vs=57368&id=

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/98/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 10:18:53 + Build duration: 8 min 28 sec and counting JUnit Tests Name: projectroo

D7732: Force KAuth helpers to have UTF-8 support

davidedmundson closed this revision. davidedmundson added a comment. This was merged, phabricator ignored it for some reason REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7732 To: davidedmundson, apol, aacid Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraha

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 101 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/101/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 May 2019 10:18:54 + Build duration: 25 min and counting BUILD ARTIFACTS acc/KF5KIO-5.58.0.xmllog

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

apol added a comment. wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the code is to construct the file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma Cc: apol, kde-frameworks-devel, kde-buildsystem, be

D20958: New menu of syntax highlighting in the status bar

nibags added a comment. Thanks for the comments, in a while I will update the diff with the suggestions/corrections. > The only thing I would like to have is an auto generated "most often used" list. That was also suggested somewhere. This way you could quickly change between preferred

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau added a comment. In D20984#460128 , @apol wrote: > wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the code is to construct the file. You mean, replace `file(GENERATE` with `file(WRITE ... qmldir)`? Might be

D20959: Allow to change the Mode, after changing the Highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0a6ea0624228: Allow to change the Mode, after changing the Highlighting (authored by nibags). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20959?vs=57373&id=574

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57457. kossebau added a comment. Use file(WRITE/APPEND) over file(GENERATE), for less intermediate vars REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20984?vs=57450&id=57457 BRANCH addinstallqmlplugin

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

This revision was automatically updated to reflect the committed changes. Closed by commit R296:a2e42b49: [KeySequenceItem] Make the clear button have the same height as shortcut button (authored by filipf). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57459. kossebau added a comment. get rid of newer list(TRANSFORM) REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20984?vs=57457&id=57459 BRANCH addinstallqmlplugin REVISION DETAIL https://phabricator.

D20983: Exclude .gcode and .vdi files from indexing consideration

ngraham updated this revision to Diff 57460. ngraham added a comment. Add more useless Virtualbox files that Baloo shouldn't try to index REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20983?vs=57432&id=57460 BRANCH more-excluded-files (branched from maste

D20983: Exclude .gcode and .vdi files from indexing consideration

ngraham edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20983 To: ngraham, bruns, #baloo Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20938: Add Mounts Backend

ngraham added a comment. In D20938#460029 , @hallas wrote: > I have tried to modify the fstab backend to also show fuse mounts and a //very// simple prototype is this: > > diff --git a/src/solid/devices/backends/fstab/fstabhandling.cpp b/s

D20958: New menu of syntax highlighting in the status bar

ngraham added a comment. In D20958#460130 , @nibags wrote: > > Single-clicking on an item in the list should select it and close the menu; double-click doesn't gain us anything here > > To me the double-click works correctly. It may also be n

D20958: New menu of syntax highlighting in the status bar

loh.tar added a comment. > I could add a "Recent" section to the beginning of the menu, it would be useful. Nice! Just to be clear. That should to be work over session borders, not only the current one. >> The blue frame (in dark theme) looks compared to the other plain menus

D20958: New menu of syntax highlighting in the status bar

anthonyfieroni added inline comments. INLINE COMMENTS > katemodemenulist.cpp:65 > +m_list->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff); > +m_list->setIconSize(QSize(16, 16)); > +m_list->setResizeMode(QListView::Adjust); As well for icon size. > katemodemenulist.cpp:129 > +

D20958: New menu of syntax highlighting in the status bar

anthonyfieroni added a comment. dymanic_cast is expensive, prefer qobject_cast if you want to check result against nullptr, if you don't want - static_cast. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg Cc: anthonyfie

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

abetts added a comment. +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20977 To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20964 To: ngraham, #vdg, elvisangelaccio, GB_2 Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20939: Aztec: Fix padding if the last partial codeword is all one bits

This revision was automatically updated to reflect the committed changes. Closed by commit R280:608370e85a77: Aztec: Fix padding if the last partial codeword is all one bits (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20939?vs=57321&id

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:745 > I did it in `setMimeFilter` since that's where it's determined whether or not > there's a limited assortment of mimetypes, which is what controls what the > string should be. Conditionalizing it based on mode s

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Currently, the fstab backend only lists NFS and SMB share, although th

D20991: [FsTab] Add cache for device file system type

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This is required for efficient lookup of the device filesystem Depe

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

bruns added a dependent revision: D20991: [FsTab] Add cache for device file system type. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20990 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN solid-hardware list details: udi = '/org/kde/fstab/fuse.encfs/home/stefa

D20991: [FsTab] Add cache for device file system type

bruns added a dependent revision: D20995: [Fstab] Add support for non-network filesystems. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

bruns edited the summary of this revision. bruns added a dependency: D20991: [FsTab] Add cache for device file system type. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20995 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57481. kossebau added a comment. Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes This allows e.g. to replace install(TARGETS platformcomponentsplugin DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponent

D20995: [Fstab] Add support for non-network filesystems

bruns added a comment. F6806745: Screenshot_20190503_180519.png REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20995 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11820: Handle properties with multiple values

astippich commandeered this revision. astippich added a reviewer: michaelh. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: astippich, #baloo, #frameworks, michaelh Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, spoorun,

D11820: Handle properties with multiple values

astippich abandoned this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: astippich, #baloo, #frameworks, michaelh Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, spoorun, abrahams

D20999: IconItem: remove remaining & unused smooth property bits

kossebau created this revision. kossebau added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY fix-up for 18a2ca50ab092e27a3464fca8d515cb7791c7d5a

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The Q_PLUGIN_METADATA IID should be the one of the implemented interface. REPOSITO

D21001: Update *.qmltypes to current API of QML modules

kossebau added a comment. I am not exactly sure why the diff is so large, compared to last run in 2017? Done against Qt 5.12.3 on my openSUSE TW. I also got the log ouput Could not find any platform plugin not sure if this is any relevant on calculating the deps, should not, o

D21001: Update *.qmltypes to current API of QML modules

kossebau created this revision. kossebau added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH updateqmltypes REVISION DETAIL https://

D21002: Remove kde4 migration agent completely

bruns created this revision. bruns added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The migration agent is some quite weird mechanism: - it starts the KDE4 kwall

D20515: KCharSelect: add unittest. Hits the assert in QHeaderView.

This revision was automatically updated to reflect the committed changes. Closed by commit R236:b93ef73701a2: KCharSelect: add unittest. Hits the assert in QHeaderView. (authored by dfaure). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20515?vs=56155&

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 17:46:18 + Build duration: 1 min 33 sec and counting JUnit Tests Name:

D20516: KCharSelect: remove unnecessary call

This revision was automatically updated to reflect the committed changes. Closed by commit R236:d47a8fa3010b: KCharSelect: remove unnecessary call (authored by dfaure). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R236 KWidgetsAddons CHANGES S

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/30/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 May 2019 17:46:18 + Build duration: 3 min 15 sec and counting BUILD ARTIFACTS acc/KF5

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 17:47:58 + Build duration: 1 min 31 sec and counting JUnit Tests Name:

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57493. ngraham added a comment. Revert unintentional change to `KFileWidget::currentMimeFilter()` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs=57492&id=57493 BRANCH file-type-when-saving-and-mimetype-is-define

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57492. ngraham marked 3 inline comments as done. ngraham added a comment. Put it in a function and then call that function in all the places where things might change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/31/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 May 2019 17:49:34 + Build duration: 2 min 59 sec and counting BUILD ARTIFACTS acc/KF5

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 May 2019 17:46:18 + Build duration: 14 min and counting BUILD ARTIFACTS acc/KF5Widget

D16116: [KPropertiesDialog] Show a filename for the / directory

bruns added a comment. Is this still relevant - for me, the properties dialog has "Properties for /". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks, ngraham Cc: bruns, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 May 2019 18:00:51 + Build duration: 4 min 6 sec and counting BUILD ARTIFACTS acc/KF5W

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D20990 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

ngraham added inline comments. INLINE COMMENTS > fstabhandling.cpp:144 > +const QString fstype = QFile::decodeName(fe->mnt_type); > +if (_k_isFstabNetworkFileSystem(fstype, fsname)) { > const QString mountpoint = QFile::decodeName(fe->mnt_dir); Only network mounts?

D20995: [Fstab] Add support for non-network filesystems

ngraham added a comment. Nice! Can we make the Places panel display the product rather than the description? I don't think it's necessary to have the fs type listed there in the label. Interested parties can always look that up in the Properties dialog. REPOSITORY R245 Solid REVISION DETA

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

This revision was automatically updated to reflect the committed changes. Closed by commit R245:7aad0e183b3d: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20990?vs=57473&id=5

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 18:46:18 + Build duration: 2 min 31 sec and counting JUnit Tests Name: projectr

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a dependent revision: D21004: [UserMetaData] Shortcut attribute queries for the common case. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, gennad, domson, ashaposhniko

D21004: [UserMetaData] Shortcut attribute queries for the common case

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY Optimize the common case of only a few or no attributes set, no functional changes. TEST PLAN ctest Depend

D20991: [FsTab] Add cache for device file system type

bruns added inline comments. INLINE COMMENTS > ngraham wrote in fstabhandling.cpp:144 > Only network mounts? Others are added in D20995 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas Cc:

D20991: [FsTab] Add cache for device file system type

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D20991 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

This revision was automatically updated to reflect the committed changes. Closed by commit R245:a0320ae774fe: [FsTab] Add cache for device file system type (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20991?vs=57474&id=57509 REVISION DETA

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 19:18:33 + Build duration: 1 min 26 sec and counting JUnit Tests Name: projectr

D20924: ViewConfig: Use new generic config interface

dhaumann added a comment. PS: I know this comment comes too late, but this could have waited 2 more days after the next KF5 tag tomorrow :-) we had 1 day of testing now. Maybe we are lucky and there is no regression - let's try now. REPOSITORY R39 KTextEditor REVISION DETAIL https://ph

D20958: New menu of syntax highlighting in the status bar

dhaumann added a comment. My comments are very vague, but I think this patch could even be better. Only did a review half through due to lack of time. INLINE COMMENTS > katemodemenulist.h:141 > + */ > +class ModeListWidget : public QListWidget > +{ Can you make this a QListView?

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixiid REVISION DETAIL https://phabricator.kde.org/D21000 To: kossebau, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20999: IconItem: remove remaining & unused smooth property bits

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH removelastsmoothbits REVISION DETAIL https://phabricator.kde.org/D20999 To: kossebau, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham,

D21001: Update *.qmltypes to current API of QML modules

apol added a comment. Looks like we were exporting the qmltypes for QtQuick Controls within the calendar file? LGTM overall, but an additional set of eyes would be useful. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21001 To: kossebau, #p

D17071: Don't include any directory sizes in DirectorySizeJob

sasch added a comment. What's blocking here to merge this in Master? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: sasch, adridg, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

apol added a comment. +1 looks good to me besides the nitpick. INLINE COMMENTS > kfilewidget.cpp:594 > // the Filter label/edit > -whatsThisText = i18n("This is the filter to apply to the file list. " > - "File names that do not match the filter will not > be

D20999: IconItem: remove remaining & unused smooth property bits

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c8fe7bc5ac73: IconItem: remove remaining & unused smooth property bits (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D209

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7f4e171ef7ea: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kd

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/95/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 23:53:04 + Build duration: 2 min 8 sec and counting JUnit Tests Name

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/92/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 May 2019 23:53:04 + Build duration: 4 min 11 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/96/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 03 May 2019 23:55:16 + Build duration: 7 min 39 sec and counting JUnit Tests Nam

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/93/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 May 2019 23:57:17 + Build duration: 6 min 41 sec and counting BUILD ARTIFACTS acc/K

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 May 2019 23:53:04 + Build duration: 14 min and counting BUILD ARTIFACTS acc/KF5Plas

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 00:07:29 + Build duration: 19 min and counting BUILD ARTIFACTS acc/KF5Plas

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57516. ngraham marked an inline comment as done. ngraham added a comment. Don't forget to set the parent REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs=57493&id=57516 BRANCH file-type-when-saving-and-mimetype-is

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham updated this revision to Diff 57517. ngraham added a comment. Fix typo in comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20964?vs=57516&id=57517 BRANCH file-type-when-saving-and-mimetype-is-defined (branched from master) REVISION DETAIL ht

D21007: Review kate config pages to improve maintenance friendliness

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Use new signal/slot style by new added helper functions - U

D21007: Review kate config pages to improve maintenance friendliness

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this is more easy on the eyes. Alternatively, one could consider making observeCanges a free function, but please commit for now. INLINE COMMENTS > katedialogs.cpp:156 > +

D21007: Review kate config pages to improve maintenance friendliness

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2af8bdae9ae2: Review kate config pages to improve maintenance friendliness (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21007?vs=57518&id=57522#toc REPOSITORY R39 KTe