D21486: Don't fetch device statistics upon construction

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D21486 To: apol, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/106/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 May 2019 00:46:34 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 30 May 2019 00:46:34 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/116/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 30 May 2019 00:46:34 + Build duration: 4 min 44 sec and counting JUnit Tests

D21378: Make Breeze Light/Dark use more system colors

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb8f02de76d5: Make Breeze Light/Dark use more system colors (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D21486: Don't fetch device statistics upon construction

apol edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D21486 To: apol, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

ngraham added a task: T10958: Faster Startup. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21486: Don't fetch device statistics upon construction

apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. apol requested review of this revision. REVISION SUMMARY To get proper data we'll have to

D21315: Dolphin-style view modes in the file dialog

meven added a comment. In D21315#471780 , @ngraham wrote: > We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches like this, sometimes it's worth waiting for the next release to give it a month of testing rather than

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

bruns added a comment. In D21425#470819 , @broulik wrote: > However in `queryDeviceInterface` we actually check for it being `"1"` and also here in `UDevManager::Private::checkOfInterest`. It is somewhat unfortunate we have the

D21315: Dolphin-style view modes in the file dialog

ngraham added a comment. We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches like this, sometimes it's worth waiting for the next release to give it a month of testing rather than rushing it in close to the deadline. I say let's wait until after tagging to land it, or

D21459: Always save view settings when switching from one view mode to another

ngraham added inline comments. INLINE COMMENTS > meven wrote in kdiroperator.cpp:2691 > Perhaps we could use a more sensible default value for ColumnView. > > What would you say about 32px ? That sounds like a good default size. REPOSITORY R241 KIO REVISION DETAIL

D21440: Delay running UnindexedFileIndexer and IndexCleaner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes perfect sense to me. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson, ngraham Cc: ngraham, poboiko,

D21459: Always save view settings when switching from one view mode to another

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58854. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58816=58854 BRANCH new-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 AFFECTED FILES

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 65 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/65/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 29 May 2019 14:59:48 + Build duration: 12 min and counting JUnit Tests

D21440: Delay running UnindexedFileIndexer and IndexCleaner

broulik added a task: T10958: Faster Startup. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21440: Delay running UnindexedFileIndexer and IndexCleaner

broulik updated this revision to Diff 58853. broulik retitled this revision from "Start baloo_file later" to "Delay running UnindexedFileIndexer and IndexCleaner". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Delay

D20833: Simpler check for flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R289:458e4770d43f: Simpler check for flatpak (authored by apol). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20833?vs=58848=58851 REVISION DETAIL

D21440: Start baloo_file later

broulik added a comment. I would assume so. In the graph, which is a VM, ksplashqml is signalled to quit 2 seconds into the startup at which point plasmashell is pretty much done. So if we delay it by 5 seconds or so that could already be plenty I think. I'll give it a go next week.

D21440: Start baloo_file later

bruns added a comment. I think everything below 10 seconds would be completely fine, is that sufficient to let the remaining ones start? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: poboiko,

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/35/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 29 May 2019 14:45:27 + Build duration: 2 min 59 sec and counting JUnit Tests Name:

D21440: Start baloo_file later

broulik planned changes to this revision. broulik added a comment. Look into delaying the `UnindexedFileIndexer` and `IndexCleaner`. Can I just use `QTimer` or do you want something more sophisticated? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To:

D20833: Simpler check for flatpak

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D20833 To: apol, #frameworks, broulik Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

bruns added a comment. I would very much prefer only delaying the UnindexedFileIndexer and the IndexCleaner. These two are stopgap measures. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: poboiko,

D21379: [UDev Backend] Narrow device queried for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:079b2bc91cb2: [UDev Backend] Narrow device queried for (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=58839=58850 REVISION DETAIL

D20833: Simpler check for flatpak

apol updated this revision to Diff 58848. apol added a comment. A more compact approach REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20833?vs=57023=58848 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20833 AFFECTED FILES

D21379: [UDev Backend] Narrow device queried for

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in udevqtclient.cpp:223 > This is just copied from the other code. I can fixup all of them separately > later if you want. Yes, thats completely fine for

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/112/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 29 May 2019 14:24:42 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 29 May 2019 14:24:42 + Build duration: 8 min 45 sec and counting BUILD ARTIFACTS

D21483: Don't modify a temporary object

apol updated this revision to Diff 58845. apol added a comment. arcanist decided to also push a bunch of unrelated stuff :( REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21483?vs=58844=58845 BRANCH master REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/115/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 29 May 2019 14:24:41 + Build duration: 3 min 3 sec and counting JUnit Tests

D21483: Don't modify a temporary object

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead copy the object, operate it and update it into the object. TEST PLAN just used

D21481: Don't notify about changing to the same state it was at

apol added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21481 To: apol, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21481: Don't notify about changing to the same state it was at

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY The object tracker was telling me it's notifying the same value it already got, and reading the code it seems to be already

D21480: Pass fully-qualified arguments and return values to moc

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise it thinks it's different types. TEST PLAN tests pass, plasmashell

D21459: Always save view settings when switching from one view mode to another

meven added inline comments. INLINE COMMENTS > kdiroperator.cpp:2691 > +// Simple view decoration left, aka compact view > +return {QStringLiteral("listViewIconSize"), 0}; > +} Perhaps we could use a more sensible default value for ColumnView. What would you say

D21379: [UDev Backend] Narrow device queried for

broulik updated this revision to Diff 58839. broulik retitled this revision from "[UDev Backend] Narrow subsystems queried for cameras" to "[UDev Backend] Narrow device queried for". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a

D21440: Start baloo_file later

broulik added a comment. So, I can haz shipit? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21440: Start baloo_file later

poboiko added a comment. In D21440#471144 , @broulik wrote: > The idle tracking is only in the extractor process, not in baloo_file itself. On startup it runs the `UnindexedFileIndexer` and iterates all the folders looking for files to

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added inline comments. INLINE COMMENTS > bruns wrote in udevqtclient.cpp:223 > Nitpick - the existing code uses `toLatin1()`, and for the ASCII subset it > doesn't matter, but I am quite sure properties and values are UTF8 in general. > > I have no strong proof, but the udev changelog

D21315: Dolphin-style view modes in the file dialog

meven added a comment. I have made a small code change. Should I wait for some more review before landing this ? REPOSITORY R241 KIO BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni,

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58832. meven marked an inline comment as done. meven added a comment. Avoid using Toggle in view activation callback names REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58776=58832 BRANCH arcpatch-D21315

D21379: [UDev Backend] Narrow subsystems queried for cameras

bruns added inline comments. INLINE COMMENTS > udevqtclient.cpp:223 > +for (const QString : subsystems) { > +udev_enumerate_add_match_subsystem(en, > subsystem.toLatin1().constData()); > +} Nitpick - the existing code uses `toLatin1()`, and for the ASCII subset it doesn't

D21379: [UDev Backend] Narrow subsystems queried for cameras

bruns added a comment. In D21379#471513 , @broulik wrote: > So, you want me to change that `1` to `QVariant()` then? I think that is completely sufficient, yes. In all the other places, the `!QVariant::toString().isEmpty()` and

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a comment. So, you want me to change that `1` to `QVariant()` then? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a comment. In D21459#471238 , @ngraham wrote: > Nice! What do you think about moving the `if (configGroup && itemView) {` into the new function and calling it something more conditional, like `writeIconZoomSettingsIfNeeded`? Also it

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58816. meven added a comment. Add a zoomSettingsForViewForView to group viewKind to zoom setting name and default value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58811=58816 BRANCH icon-save2 REVISION

D21367: kioexec: change the scary debug messages for delayed deletion

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21367 To: Lekensteyn, elvisangelaccio, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58811. meven added a comment. Rename writeIconZoomSettings to writeIconZoomSettingsIfNeeded, some code improvements REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58780=58811 BRANCH icon-save2 REVISION DETAIL