KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 104 - Still Failing!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/104/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:25:08 + Build duration: 31 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:24:56 + Build duration: 31 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Failing!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/99/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Jun 2019 05:25:08 + Build duration: 28 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:24:28 + Build duration: 26 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/131/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Jun 2019 05:23:36 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:24:13 + Build duration: 20 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 131 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/131/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:23:36 + Build duration: 19 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/33/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:24:01 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/103/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Jun 2019 05:23:10 + Build duration: 12 min and counting BUILD ARTIFACTS

Re: KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.12 - Build # 15 - Failure!

2019-06-11 Thread laurent Montel
Hi, I don't understand why it's not found on android? It found kf 5.59.0 so it's ok but it doesn't find KDE_INSTALL_LOGGINGCATEGORIESDIR ? Le mercredi 12 juin 2019, 07:25:26 CEST CI System a écrit : > BUILD FAILURE > Build > URL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 52 - Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 12 Jun 2019 05:22:47 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/51/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:22:48 + Build duration: 6 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 23 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/23/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:24:29 + Build duration: 3 min 13 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.12 - Build # 14 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.12/14/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:24:46 + Build duration: 2 min 56 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » syndication » kf5-qt5 AndroidQt5.12 - Build # 9 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20AndroidQt5.12/9/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:25:02 + Build duration: 2 min 39 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 31 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/31/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:23:57 + Build duration: 2 min 53 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kitemmodels » kf5-qt5 AndroidQt5.12 - Build # 11 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20AndroidQt5.12/11/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:23:39 + Build duration: 2 min 37 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.12 - Build # 17 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.12/17/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:23:46 + Build duration: 3 min 5 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.12 - Build # 23 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.12/23/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:24:01 + Build duration: 3 min 7 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 39 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/39/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:22:48 + Build duration: 3 min 6 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Fixed!

2019-06-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/111/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 12 Jun 2019 05:22:15 + Build duration: 2 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.12 - Build # 15 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20AndroidQt5.12/15/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:22:39 + Build duration: 2 min 47 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » karchive » kf5-qt5 AndroidQt5.12 - Build # 52 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20AndroidQt5.12/52/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:22:25 + Build duration: 1 min 56 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 20 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/20/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 12 Jun 2019 05:22:10 + Build duration: 44 sec and counting CONSOLE OUTPUT [...truncated

D11552: [WIP] Handle CJK characters

2019-06-11 Thread Honghao Li
Herald edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: kde-frameworks-devel, rasphino, #baloo, bruns, lbeltrame, alexeymin, cfeck, LeGast00n, domson, ashaposhnikov,

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

2019-06-11 Thread Honghao Li
Herald added a subscriber: kde-frameworks-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11587 To: michaelh, #baloo, #frameworks Cc: rasphino, kde-frameworks-devel, bruns, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D21712: KateModeMenuList: move to QListView

2019-06-11 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > katemodemenulist.cpp:85 > m_searchBar->setPlaceholderText(i18nc("Placeholder in search bar", > "Search...")); > +m_searchBar->setToolTip(i18nc("ToolTip of the search bar of modes of > syntax highlighting", "Search for syntax

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-11 Thread Nathaniel Graham
ngraham added a comment. Thanks! I think we should definitely aim to replace the old QWidgets-based one. Otherwise we're signing up for an increased maintenance burden with no real advantages IMO. Consider that we already have the GHNS dialog as well as Discover's UI, and each one has

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

2019-06-11 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. Not that I have the most karma here, but I agree with the reasoning, dead things are dead, zombies are porting aids at best. REPOSITORY R300 KDEWebKit BRANCH master REVISION DETAIL https://phabricator.kde.org/D21400 To:

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

2019-06-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R300 KDEWebKit BRANCH master REVISION DETAIL https://phabricator.kde.org/D21400 To: vkrause, apol Cc: apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

2019-06-11 Thread Nathaniel Graham
ngraham added a comment. @cochise, can you work on fixing those so we can get this in? It would be a shame for all your hard work to be abandoned! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks Cc: cfeck, bruns,

D17816: Support for xattrs on kio copy/move

2019-06-11 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson,

D17816: Support for xattrs on kio copy/move

2019-06-11 Thread Stefan Brüns
bruns added a comment. There are several comments not addressed yet ... INLINE COMMENTS > copyxattrjob.cpp:125 > +m_keyList.removeLast(); // the last item is alwys empty > +for (const auto & key : m_keyList) { > +// get the size of key value `qAsConst(m_keyList)` >

D8532: [WIP] Restrict file extractor with Seccomp

2019-06-11 Thread Nathaniel Graham
ngraham added a comment. Hmm, looks like @davidk has not been active in almost a year, so I suspect someone else may need to commandeer this... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8532 To: davidk, apol, ossi, #frameworks, smithjd, bruns Cc: fvogt,

D8532: [WIP] Restrict file extractor with Seccomp

2019-06-11 Thread Fabian Vogt
fvogt added a comment. In D8532#478224 , @bruns wrote: > I totally agree with fvogt here - the extractors should just receive a readonly file descriptor. > > For this, there are several steps required: > > 1. let the extractors work with

D8532: [WIP] Restrict file extractor with Seccomp

2019-06-11 Thread Stefan Brüns
bruns added a comment. I totally agree with fvogt here - the extractors should just receive a readonly file descriptor. For this, there are several steps required: 1. let the extractors work with file descriptors (KFileMetaData) 2. make sure the extractor plugins are fully

D17816: Support for xattrs on kio copy/move

2019-06-11 Thread Nathaniel Graham
ngraham added reviewers: chinmoyr, bruns, Frameworks. ngraham added a comment. @cochise, @bruns, @dfaure can we make a push to get this in? It's sad to see a patch that fixes an important bug come so close and not quite get merged! REPOSITORY R241 KIO REVISION DETAIL

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

2019-06-11 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D21400 To: vkrause Cc: apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D8532: [WIP] Restrict file extractor with Seccomp

2019-06-11 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8532 To: davidk, apol, ossi, #frameworks, smithjd, bruns Cc: fvogt, mgallien, kde-frameworks-devel, michaelh, #baloo, detlefe, ngraham, nicolasfella, LeGast00n, domson,

D8532: [WIP] Restrict file extractor with Seccomp

2019-06-11 Thread Nathaniel Graham
ngraham added a comment. Ping! What's going on with this? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8532 To: davidk, apol, ossi, #frameworks, smithjd, bruns Cc: fvogt, mgallien, kde-frameworks-devel, michaelh, #baloo, detlefe, ngraham, nicolasfella, LeGast00n,

Re: KNewStuff problem - GSOC 2019

2019-06-11 Thread Dan Leinir Turthra Jensen
Dear Ferencz, If you've got downloading working (that is, if you can initialise a KNSCore::Engine or KNewStuff::Button or the like with a knsrc file with the appropriate categories without an error), then your category should be working fine. If your category does not alredy exist on the KDE

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/103/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 11 Jun 2019 12:55:51 + Build duration: 59 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 94 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 11 Jun 2019 12:55:51 + Build duration: 25 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 98 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/98/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 11 Jun 2019 12:55:51 + Build duration: 20 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 196 - Failure!

2019-06-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/196/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 11 Jun 2019 12:55:51 + Build duration: 2 min 1 sec and counting CONSOLE

D17595: Upstream Dolphin's file rename dialog

2019-06-11 Thread Méven Car
meven added a comment. In D17595#478067 , @emmanuelp wrote: > In D17595#473825 , @meven wrote: > > > I guess we need now to reach to schwarz...@gmail.com romaninflianskas mfuchs chinmoyr mitchell

D17595: Upstream Dolphin's file rename dialog

2019-06-11 Thread Emmanuel Pescosta
emmanuelp added a comment. In D17595#473825 , @meven wrote: > I guess we need now to reach to schwarz...@gmail.com romaninflianskas mfuchs chinmoyr mitchell emateli emmanuelp freininghaus to have lgplv2+ approval. Added myself to the

D19903: Fix build with msvc

2019-06-11 Thread Hannah von Reth
vonreth added inline comments. INLINE COMMENTS > lazy_val.h:41 > public: > -operator decltype(_f()) () const > +operator auto() const -> decltype(_f()) > { Hm recently found out that this code doesn't compile with gcc. REPOSITORY R159 KActivities Statistics BRANCH master

D20907: Disable broken and no longer needed workaround code with msvc2019

2019-06-11 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R314:57aacba17c66: Disable broken and no longer needed workaround code with msvc2019 (authored by vonreth). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE

D17241: WIP:Disable highlighting after 512 characters on a line.

2019-06-11 Thread Christoph Cullmann
cullmann added a comment. For the outer vector, yes. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham,

D17241: WIP:Disable highlighting after 512 characters on a line.

2019-06-11 Thread Dominik Haumann
dhaumann added a comment. Could this be pushed even further by using QVarLengthArray? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-06-11 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D21721#477397 , @ngraham wrote: > How does one test this? By running the khotnewstuff-dialog application and passing a knsrc file to it (though i would point to the first line in the summary for the moment

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 130 - Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/130/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 11 Jun 2019 08:37:45 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 120 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 11 Jun 2019 08:37:46 + Build duration: 6 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 130 - Still Unstable!

2019-06-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/130/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 11 Jun 2019 08:37:45 + Build duration: 7 min 2 sec and counting JUnit Tests Name:

D21742: Add KProtocolInfo::defaultMimetype

2019-06-11 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21742 To: dfaure, stefanocrocco Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21742: Add KProtocolInfo::defaultMimetype

2019-06-11 Thread Stefano Crocco
stefanocrocco accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21742 To: dfaure, stefanocrocco Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21742: Add KProtocolInfo::defaultMimetype

2019-06-11 Thread David Faure
dfaure created this revision. dfaure added a reviewer: stefanocrocco. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY As needed by https://phabricator.kde.org/D21741 TEST PLAN Autotest

D21661: add snoretoast backend for KNotifications on Windows

2019-06-11 Thread Hannah von Reth
vonreth added inline comments. INLINE COMMENTS > pino wrote in notifybysnore.cpp:63 > - splitRef here to not allocate strings that are not used anyway (since they > are split again later on) > - you are using a C++11 for loop on a Qt container, and this will detach it > -- you need to store

D21712: KateModeMenuList: move to QListView

2019-06-11 Thread Nibaldo González
nibags updated this revision to Diff 59577. nibags added a comment. - Correct code style Remove `this->` and `return` at the end of void functions. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21712?vs=59480=59577 BRANCH move-qlistview