KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 12 Jul 2019 05:48:30 + Build duration: 4 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 51 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/51/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 12 Jul 2019 05:49:26 + Build duration: 3 min 21 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 90 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/90/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Jul 2019 05:49:30 + Build duration: 2 min 10 sec and counting CONSOLE OUTPUT

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#494252 , @bruns wrote: > The invalidation has to be done per thread then as well, which you don't do. See fstabmanager.cpp As you can see in fstabmanager.cpp:40, FstabWatcher::instance() stays a

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck, apol Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol,

D21782: Add a warning dialog with details, continue, and cancel button

apol accepted this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter updated this revision to Diff 61603. sitter added a comment. get rid of need for decl_hidden and extend the test to play with visiblity REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22375?vs=61522=61603 BRANCH master REVISION DETAIL

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

sitter added inline comments. INLINE COMMENTS > broulik wrote in kbusyindicatorwidget.cpp:62 > Is that legal in the C++ standard allowed by frameworks? Well, it builds at least under c++11 which is what kf5 is compatible with. According to this page

D22339: Make sure solid backends are reentrant

bruns added a comment. In D22339#494149 , @apol wrote: > In D22339#494142 , @bruns wrote: > > > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket

D21795: [KAuth] Add support for action details in Polkit1 backend.

ngraham added reviewers: dfaure, cfeck. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck Cc: mreeves, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

ngraham added a comment. Ping :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

ngraham added a comment. Can we get this in? REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21427: Always skip trailing slashes in FilderedDirIterator

bruns added a comment. In D21427#494010 , @poboiko wrote: > Ping! > > Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all). The DB corruption is already fixed in KF5.60. REPOSITORY R293 Baloo

D20238: device: include reapplyConnection() in the interface

This revision was automatically updated to reflect the committed changes. Closed by commit R282:2d5a66004425: device: include reapplyConnection() in the interface (authored by aleksanderm, committed by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#494142 , @bruns wrote: > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab? each backend will create things

D22339: Make sure solid backends are reentrant

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab? REPOSITORY R245 Solid REVISION

D22395: Allow updating default DBus timeout on every interface

This revision was automatically updated to reflect the committed changes. Closed by commit R281:a3d262f58d2f: Allow updating default DBus timeout on every interface (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D22395: Allow updating default DBus timeout on every interface

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH aleksander/dbus-timeout REVISION DETAIL https://phabricator.kde.org/D22395 To: aleksanderm, #frameworks, jgrulich, broulik Cc: kde-frameworks-devel, LeGast00n,

D22395: Allow updating default DBus timeout on every interface

aleksanderm updated this revision to Diff 61582. aleksanderm added a comment. Renamed methods and made the getter const. REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22395?vs=61580=61582 BRANCH aleksander/dbus-timeout REVISION DETAIL

D22395: Allow updating default DBus timeout on every interface

jgrulich added a comment. I think all the methods should be called timeout() and setTimeout(), you are not changing default timeout which will always be 25s if -1 is set as timeout value. Also the getters should be const methods. REPOSITORY R281 ModemManagerQt REVISION DETAIL

D22395: Allow updating default DBus timeout on every interface

aleksanderm added a comment. F7006291: test.cpp attaching a tester program to exercise the new API in one of the interfaces. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D22395 To: aleksanderm, #frameworks, jgrulich,

D22395: Allow updating default DBus timeout on every interface

aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. aleksanderm requested review of this revision. REVISION SUMMARY Some

D21660: change audio dep logic wrt win32

nicolasfella added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > Update: nope. I think it's still use for the dbus interfaces. I confirmed by > ending the `dbus-daemon.exe` process by hand to see it. Turns out, dbus is > quite important for KDE Connect regardless of

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > I'm looking into the DBus problem, we currently use DBus for the system tray > icon on Windows. Once that is resolved, I should be able to completely remove > DBus from the Windows build Update: nope. I

D22339: Make sure solid backends are reentrant

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22392: [balooctl/baloo_file_extractor] Consolidate code that performs actual indexing

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY The file contents can be indexed in two ways: either by `baloo_file_extractor` after being added to

D7820: man ioslave: spurious numbers included in clang(1) man page

marten added a comment. Confirmed that man:clang(1) now correctly displays the man page with no spurious numbers shown. Would be happy to abandon this review request. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel, mkoller

D21427: Always skip trailing slashes in FilderedDirIterator

poboiko added a comment. Ping! Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n,

D21427: Always skip trailing slashes in FilderedDirIterator

poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21427 To: poboiko, #frameworks, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,