D23205: [KProcessList] Optimize KProcessList::processInfo

hallas edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas updated this revision to Diff 64914. hallas added a comment. Add bug reference REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23205?vs=64913=64914 BRANCH optimize_kprocesslist_processinfo REVISION DETAIL https://phabricator.kde.org/D23205

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas updated this revision to Diff 64913. hallas marked an inline comment as done. hallas added a comment. Fixed review comments, rebased. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23205?vs=63873=64913 BRANCH optimize_kprocesslist_processinfo

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/4/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 29 Aug 2019 05:31:00 + Build duration: 3 min 2 sec and counting JUnit Tests

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added inline comments. INLINE COMMENTS > klistopenfiles.cpp:44 > +if (!path.exists()) { > +job->setError(KJob::UserDefinedError); > +job->emitResult(); Should I also set an error string here? And what about defining custom error codes, is that how we

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added a comment. @meven , so I finally managed to rewrite this patch to use KJob instead. Please take a look at it again and see if this is better approach :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik,

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas updated this revision to Diff 64911. hallas added a comment. Rewrote the code to use KJob REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=59636=64911 BRANCH add_list_processes_with_open_files (branched from master) REVISION DETAIL

D23500: Support for native Matlab strings

dhaumann added a comment. You can also add the changes from your other review request if you want, since the changes are rather small. But on general it's a good idea to have many small manageable review request instead of one big one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D23552: ECM: remove set_package_properties from FindCanberra

kossebau added a comment. Compare though all the > Ideally this is set already directly in the Find-module. for `DESCRIPTION` and `URL` properties in the docs https://cmake.org/cmake/help/latest/module/FeatureSummary.html Which makes sense to me, at least for FindModules, where

D23552: ECM: remove set_package_properties from FindCanberra

sitter added a comment. No objections from me. This was explicitly suggested during review though, so I'd like @cgiboudeaux to approve this. INLINE COMMENTS > FindCanberra.cmake:95 > > include(FeatureSummary) > Can be removed as well. REPOSITORY R240 Extra CMake Modules REVISION

D23551: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. In D23551#521571 , @apol wrote: > This will only work one-way. If the "wrong" Qt is older, but it's not necessarily the case. > Also cmake may be linking against the "right" Qt but then use the "wrong" one at

D23552: ECM: remove set_package_properties from FindCanberra

dfaure created this revision. dfaure added reviewers: cgiboudeaux, sitter. Herald added projects: Frameworks, Build System. dfaure requested review of this revision. REVISION SUMMARY The user of this find module has to do it, so that they can specify the purpose of using canberra in their

D23551: CMake config files: use as min dep version the Qt version we built against

apol added a comment. This will only work one-way. If the "wrong" Qt is older, but it's not necessarily the case. Also cmake may be linking against the "right" Qt but then use the "wrong" one at runtime. I'm not convinced. REPOSITORY R263 KXmlGui REVISION DETAIL

D21328: Add qml import for KItemModels

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Alright then, let's get this in and kossebau can port it eventually. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson,

D23551: CMake config files: use as min dep version the Qt version we built against

kossebau added a reviewer: Build System. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23551 To: kossebau, #frameworks, aacid, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a reviewer: Build System. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau, #frameworks, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23551: CMake config files: use as min dep version the Qt version we built against

kossebau created this revision. kossebau added reviewers: Frameworks, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Some developers have multiple versions of Qt installed on their system.

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. If you think this makes sense, I would do the same change to all KDE Frameworks modules (and hope others pick up for their code with public library API). Target: KF 5.63 earliest. REPOSITORY R244 KCoreAddons REVISION DETAIL

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Some developers have multiple versions of Qt installed on their system. And

D21328: Add qml import for KItemModels

kossebau added a comment. In D21328#521535 , @davidedmundson wrote: > > Can you look into kossebau's coment? Let's get this in once that's ironed out. > > Kossebau's new API is not yet merged. It looks nice though. Yes, sorry, I

D21328: Add qml import for KItemModels

davidedmundson added a comment. > Can you look into kossebau's coment? Let's get this in once that's ironed out. Kossebau's new API is not yet merged. It looks nice though. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc:

D21328: Add qml import for KItemModels

apol added a comment. Can you look into kossebau's coment? Let's get this in once that's ironed out. INLINE COMMENTS > CMakeLists.txt:30 > > +if (${Qt5Qml_FOUND}) > +ecm_add_tests( I like `if (TARGET Qt5::Qml)` better. REPOSITORY R275 KItemModels REVISION DETAIL

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > Please add "@since 6.62" to all this new API, so consumers of them know which > min version of KActivitiesStat they need to require to be able to rely on > their existance. "5.62" of course :) REPOSITORY R159

D22144: Add kio recentlyused:/ to access KActivityStats data

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:68 > > +find_package(KF5ActivitiesStats QUIET) > +set_package_properties(KF5ActivitiesStats PROPERTIES Please add a min version, as the code seems to rely on new API only added recently: find_package(KF5ActivitiesStats

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

kossebau added inline comments. INLINE COMMENTS > query.h:101 > void addUrlFilters(const QStringList ); > +void setTypes(const Terms::Type ); > +void setAgents(const Terms::Agent ); Please add "@since 6.62" to all this new API, so consumers of them know which min version of

D7446: [Places panel] Revamp the Recently Saved section

ngraham accepted this revision. ngraham added a comment. +1 I don't think @markg'ss change requested status still applies since it was for the ancient version of the patch that I submitted two years ago (!!!). I also think that ultimately we should remove Modified Today and Modified

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

meven added a comment. This could be an alternative to D17595 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure,

D21328: Add qml import for KItemModels

davidedmundson updated this revision to Diff 64882. davidedmundson added a comment. Add KDescendentsProxyModel REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21328?vs=64881=64882 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21328

D21328: Add qml import for KItemModels

davidedmundson added a comment. > I wonder if it was necessary to do the whole move into core :P. It wasn't necessary, but I was trying to follow the framework convention. If it helps get this, I can remove it. REPOSITORY R275 KItemModels REVISION DETAIL

D21328: Add qml import for KItemModels

davidedmundson updated this revision to Diff 64881. davidedmundson added a comment. Port manual test to unit test REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21328?vs=58449=64881 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21328

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 64880. meven added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=62380=64880 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. With D22144 landing this is now ready for prime time ! And thanks to D23112 , this will support history from application using gtk as well (firefox, inkscape...) REPOSITORY R241 KIO

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D22144: Add kio recentlyused:/ to access KActivityStats data

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ae44042e541c: Add kio recentlyused:/ to access KActivityStats data (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64845=64879

Re: detect the Qt version KF5 frameworks were build against in CMake?

Am Mittwoch, 28. August 2019, 19:19:21 CEST schrieb René J.V. Bertin: > Hi, > > Some KF5 framework libraries pull in Qt5 headers and/or libraries via their > CMake modules, right? Can you specifiy some more what you mean by "pull in"? > Take the somewhat unusual situation where you have your

D23385: More porting from QRegExp to QRegularExpression

dhaumann added a comment. Oh, in that case can you or @cullmann simply revert this part or #ifdef it? I currently cannot at least until the weekend (sorry!). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23385 To: dhaumann, cullmann Cc: dvratil, kwrite-devel,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 56 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 28 Aug 2019 17:38:47 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/12/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 28 Aug 2019 17:38:47 + Build duration: 6 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 17:38:47 + Build duration: 5 min 57 sec and counting JUnit Tests Name:

D22862: [server] Wrap proxyRemoveSurface in smart pointer

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f77630523705: [server] Wrap proxyRemoveSurface in smart pointer (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22862?vs=62871=64876

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

davidedmundson abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma, apol Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

detect the Qt version KF5 frameworks were build against in CMake?

Hi, Some KF5 framework libraries pull in Qt5 headers and/or libraries via their CMake modules, right? Take the somewhat unusual situation where you have your KF5 frameworks built against, say, Qt 5.9 from the system and you want to test an application against a different, newer Qt build

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham added a comment. I think this can go in now. It's been reviewed by a bunch of the big cheeses. :) Very nice work! REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: broulik,

D23537: extend state verification to open connection commands

sitter added a comment. I do wonder if maybe it would make sense to revise the verification system to be based off of a list of allowed/forbidden functions that may be called during a command. e.g. for open the requirements are actually more complicated than this diff establishes. It

D23537: extend state verification to open connection commands

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - open/seek/read/write: may not call finished (only error) - close: must reach

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64855. leinir marked 11 inline comments as done. leinir added a comment. Address comments by @ahiemstra - Add a comment about why Button's configfile isn't aliased - Set the object ownership policy for QuickQuestionListener to cpp -

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 12 inline comments as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:355 > Since upstream Qt is starting to discourage usage of QList, maybe use QVector > instead. That'd be good, except the rest of the KNewStuff API is all QList

D23385: More porting from QRegExp to QRegularExpression

dvratil added inline comments. INLINE COMMENTS > katedocument.cpp:4676 > foreach (const QString , wildcards) { > -QRegExp wildcard(pattern, Qt::CaseSensitive, QRegExp::Wildcard); > +QRegularExpression wildcard(QLatin1Char('^') + >

D23500: Support for native Matlab strings

bbuch added a comment. Should I add the changes from D23498 here as well? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23500 To: bbuch, cullmann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D23500: Support for native Matlab strings

bbuch updated this revision to Diff 64854. bbuch added a comment. increase file version, kateversion to 5, remove hard coded colors, example to autotests input REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23500?vs=64751=64854 BRANCH

D23194: Making FileJob behave consistently.

chinmoyr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ConsistentRead (branched from master) REVISION DETAIL https://phabricator.kde.org/D23194 To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 14:23:52 + Build duration: 6 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/50/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 28 Aug 2019 14:23:52 + Build duration: 6 min 23 sec and counting BUILD ARTIFACTS

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:933887dc334f: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16311?vs=43909=64852#toc REPOSITORY R241

D23352: make button icons follow a reasonable size and layout

camiloh updated this revision to Diff 64851. camiloh added a comment. correct slip from toolbutton REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23352?vs=64850=64851 BRANCH arcpatch-D23352_2 REVISION DETAIL

D23352: make button icons follow a reasonable size and layout

camiloh updated this revision to Diff 64850. camiloh added a comment. suggested changes. use preferred width and height when the icon group height and width props are set REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23367: make the sizing of the toolbuttons more coherent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:069b4e95c155: make the sizing of the toolbuttons more coherent (authored by camiloh). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23344: assert slave command finality

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. You put on shows? On TV? :-) REPOSITORY R241 KIO BRANCH assert REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D23388: add a border for the toolbars WIP

mart added inline comments. INLINE COMMENTS > ToolBar.qml:47 > +bottom: control.position == T.ToolBar.Footer || > (control.parent.footer && control.parent.footer == control) ? undefined : > parent.bottom > +} > +} for now you need for now to add there:

D23367: make the sizing of the toolbuttons more coherent

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23367 REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2,

D23352: make button icons follow a reasonable size and layout

mart reopened this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64845. meven added a comment. Fix path example REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64736=64845 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D23367: make the sizing of the toolbuttons more coherent

camiloh updated this revision to Diff 64844. camiloh added a comment. make the icon fill height and width if the icon group height or width props are not set or are 0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64832=64844

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/11/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 28 Aug 2019 13:01:46 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 55 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/55/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 28 Aug 2019 13:01:45 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 13:01:46 + Build duration: 20 min and counting JUnit Tests Name:

D23535: [server] Use cached current mode more and assert validness

This revision was automatically updated to reflect the committed changes. Closed by commit R127:0c0a2710dd3b: [server] Use cached current mode more and assert validness (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D23493: [server] Cache current mode

This revision was automatically updated to reflect the committed changes. romangg marked an inline comment as done. Closed by commit R127:ce5e25a4b63c: [server] Cache current mode (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64834. apol added a comment. Address Bhushan's comments REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64325=64834 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED FILES

D22968: Make it possible to modify contacts

apol marked 3 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23535: [server] Use cached current mode more and assert validness

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH useCachedMode REVISION DETAIL https://phabricator.kde.org/D23535 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23493: [server] Cache current mode

romangg marked 2 inline comments as done. romangg added inline comments. INLINE COMMENTS > romangg wrote in outputdevice_interface.cpp:143 > Thanks. Will put it into a second diff. See D23535 REPOSITORY R127 KWayland BRANCH cacheMode REVISION DETAIL

D23535: [server] Use cached current mode more and assert validness

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY We can use the cached current mode in one more case. Additionally make it more

D23367: make the sizing of the toolbuttons more coherent

camiloh updated this revision to Diff 64832. camiloh added a comment. make usage of the icon group properties: height and width REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23367?vs=64449=64832 BRANCH arcpatch-D23367 REVISION

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga added a comment. When this patch is applied and Krusader is not installed: Dolphin (with "Open archives as folder" enabled): Opens the 7z/RAR archive using Ark. Gwenview: 7z/RAR archives will not appear (probably because it is unsupported without krarc). REPOSITORY R241 KIO

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga edited the summary of this revision. nhiga edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, #frameworks, cfeck, pino, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

sitter added a comment. @dfaure this is actually a different beast altogether, the current state validation is only run on the API for all slaves, seek/read/write are run in a completely different loop which I see isn't being verified at all. I'll add it in a separate diff once the

D23344: assert slave command finality

sitter updated this revision to Diff 64826. sitter added a comment. some days one has to wonder how I manage to put on shows. fix warning branch as per David's comments to actually do nothing when the cond was matched REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 28 Aug 2019 11:10:50 + Build duration: 7 min 33 sec and counting JUnit Tests Name:

D23493: [server] Cache current mode

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:143 > we can also just use currentMode directly here and remove the loop above Thanks. Will put it into a second diff. REPOSITORY R127 KWayland BRANCH cacheMode REVISION DETAIL

D23493: [server] Cache current mode

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > outputdevice_interface.cpp:143 > for (auto it = d->resources.constBegin(); it != > d->resources.constEnd(); ++it) { >

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 64816. meven added a comment. Make mapConfig return a const ref REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=64815=64816 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 AFFECTED

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

broulik added inline comments. INLINE COMMENTS > slavebase.h:343 > + */ > +QMap *mapConfig(); > + Why return a pointer, and why is this method not `const`? Or is this supposed to be writable? Then I would prefer returning a reference to communicate ownership properly. REPOSITORY

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven created this revision. meven added reviewers: davidedmundson, dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Inspired by

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 49 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/49/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 28 Aug 2019 06:49:04 + Build duration: 3 hr 10 min and counting BUILD ARTIFACTS

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. I have probably missed stuff, but here are my initial comments. INLINE COMMENTS > atticaprovider.cpp:355 > + > +QList> getCommentsList(const > Attica::Comment::List ,

D22143: Add proper logging using ECMQtDeclareLoggingCategory

This revision was automatically updated to reflect the committed changes. Closed by commit R159:2bb035ff67fd: Add proper logging using ECMQtDeclareLoggingCategory (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D23352: make button icons follow a reasonable size and layout

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R242:c6c882521f80: Revert make the sizing of the toolbuttons more coherent (authored by mart). CHANGED PRIOR TO COMMIT

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. In D22144#520684 , @dfaure wrote: > Yep. Either query argument, or KIO metaData(). Both require explicit action from the application, there's no magic currently to know which app is making the request. We could add that,

D23352: make button icons follow a reasonable size and layout

mart added inline comments. INLINE COMMENTS > Button.qml:53 > +id: icon > +anchors.centerIn: parent > +visible: parent.visible no anchors and no enclosing Item. This was ok as it was, including fillwidth/fillheight (perhaps) but with the line:

D23367: make the sizing of the toolbuttons more coherent

mart added inline comments. INLINE COMMENTS > ToolButton.qml:49 > + > +Item { > +Layout.preferredWidth: Kirigami.Units.iconSizes.smallMedium + > Kirigami.Units.largeSpacing this further item enclosing is not necessary, is an object instantation more for no functional gain

D23367: make the sizing of the toolbuttons more coherent

mart added a comment. In D23367#517658 , @ngraham wrote: > Not that it's an inappropriate fix, but are you sure you want to be using PlasmaComponents ToolButtons in Index? Why not use regular old QQC2 ToolButtons? The phone is using the

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 26 Aug 2019 17:34:06 + Build duration: 1 day 15 hr and counting JUnit Tests

D23352: make button icons follow a reasonable size and layout

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23352 To: camiloh, #plasma, mart, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23367: make the sizing of the toolbuttons more coherent

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23352: make button icons follow a reasonable size and layout

mart reopened this revision. mart added a comment. This revision is now accepted and ready to land. Same problem as the toolbutton one, button icons need to scale unless icon size fixed from client side REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D23367: make the sizing of the toolbuttons more coherent

mart reopened this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh, #plasma, mart, ngraham Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23367: make the sizing of the toolbuttons more coherent

mart added inline comments. INLINE COMMENTS > ToolButton.qml:56 > +anchors.centerIn: parent > +height: Kirigami.Units.iconSizes.smallMedium > +width: Kirigami.Units.iconSizes.smallMedium This fixes the icons to a single size no matter what, and

  1   2   >