D24773: kio_trash: Add size, modification, access and create date for trash:/

ngraham added a comment. Works great. Not sure creation date makes sense to show for the trash (if it's available) though. Can we suppress that? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-framew

D24350: [src/kpac/*] replace deprecated foreach with range for

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in script.cpp:157 > Why not just change this one to return `const &` and then use it in all > range-fors? > > [note that returning a const ref is bad in public API, but this is an > internal method so we can always change it agai

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 88 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/88/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 20 Oct 2019 21:05:22 + Build duration: 6 hr 3 min and counting JUnit Tests Na

D24350: [src/kpac/*] replace deprecated foreach with range for

ahmadsamir updated this revision to Diff 68395. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. In private API we can have a method return a const &, as it can be changed later without side-effects. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabri

D24811: tests: fix macos build failure

This revision was automatically updated to reflect the committed changes. Closed by commit R159:196b04531764: tests: fix macos build failure (authored by hindenburg). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24811?vs=68384&id=68394 REVISI

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 118 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/118/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 19:48:15 + Build duration: 3 hr 28 min and counting JUnit Tests Name: pro

D24671: Use ECMGenerateExportHeader to manage deprecated API better

apol added a comment. 👍 sorry about slow reviews. The patch looks good. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau, #frameworks, #plasma, mart, apol Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24350: [src/kpac/*] replace deprecated foreach with range for

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. sorry, missed this one. thanks for the ping. INLINE COMMENTS > script.cpp:157 > > QList addresses() const > { Why not just change this one to return `const &` and the

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 87 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/87/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 20 Oct 2019 15:29:02 + Build duration: 5 hr 35 min and counting CONSOLE OUTPUT

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. Volker Ok'd it that I used that on the co-maintained KSyntaxHighlighting framework, too. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, koss

D24620: Windows MSVC compile fix

This revision was automatically updated to reflect the committed changes. Closed by commit R159:1ea2058a09c9: Windows MSVC compile fix (authored by cullmann). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24620?vs=67869&id=68393 REVISION DETAI

D24575: Updates from CMake 3.16

This revision was automatically updated to reflect the committed changes. Closed by commit R216:dbd14c404867: Updates from CMake 3.16 (authored by cullmann). Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. REPOSITORY R216 Syntax Highlightin

D24811: tests: fix macos build failure

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Why not ;=) REPOSITORY R159 KActivities Statistics BRANCH fix-tests-model-boost-include (branched from master) REVISION DETAIL https://phabricator.kde.org/D24811 To: hindenburg,

D24350: [src/kpac/*] replace deprecated foreach with range for

ahmadsamir added a comment. Ping... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24350 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/26/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 17 Oct 2019 15:35:04 + Build duration: 3 days 4 hr and counting

D24261: Modernize code: use range-based for loop in more places

This revision was automatically updated to reflect the committed changes. Closed by commit R263:3836ef74bc2c: Modernize code: use range-based for loop in more places (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24261?vs=67047&id=68389

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 117 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/117/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 15:29:03 + Build duration: 4 hr 19 min and counting CONSOLE OUTPUT [...tr

D24807: Fix incorrect rendering of 22px edit-opacity icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2b218ddc6327: Fix incorrect rendering of 22px edit-opacity icon (authored by Rafael Brandmaier ). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://pha

D24620: Windows MSVC compile fix

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Imo we should simply try: We have another two weeks for testing. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24620 To: cullmann, #frameworks

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 120 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/120/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 20 Oct 2019 19:07:46 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 119 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/119/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 20 Oct 2019 15:29:03 + Build duration: 3 hr 38 min and counting CONSOLE OUTPUT [...truncate

D24811: tests: fix macos build failure

hindenburg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hindenburg requested review of this revision. REVISION SUMMARY Add boost include similiar to autotests/CMakeLists.txt TEST PLAN make && make tests bin/KActivitiesStatsTestA

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24663#550883 , @romangg wrote: > It's ok that you pushed. Can you give a link to your preferred resource for me to read up on ECMGenerateExportHeader? Not too comprehensive if possible. For one there are the

D24620: Windows MSVC compile fix

cullmann added a comment. Can I just push that? Then we no longer need to patch just this one framework for Windows. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24620 To: cullmann, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D24663: Use ECMGenerateExportHeader to manage deprecated API better

romangg added a comment. It's ok that you pushed. Can you give a link to your preferred resource for me to read up on ECMGenerateExportHeader? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: romangg, zzag, kde-frameworks-devel, LeGast0

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. Ok, I pushed this now. I will use that myself in KTextEditor and Kate instead of my old file and shell script. We can think about what to do with other frameworks now. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D245

D24568: Provide clang-format target with a KDE Frameworks style file

This revision was automatically updated to reflect the committed changes. cullmann marked an inline comment as done. Closed by commit R240:235fcabf5018: Provide clang-format target with a KDE Frameworks style file (authored by cullmann). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST U

D24568: Provide clang-format target with a KDE Frameworks style file

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmun

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/150/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 20 Oct 2019 14:12:33 + Build duration: 3 hr 18 min and counting JUnit Tests Name: projectroo

D24807: Fix incorrect rendering of 22px edit-opacity icon

simgunz accepted this revision. simgunz added a comment. This revision is now accepted and ready to land. The icon is now rendered correctly in Okular and cuttlefish. REPOSITORY R266 Breeze Icons BRANCH fix-edit-opacity-22px-icons (branched from master) REVISION DETAIL https://phabrica

D24807: Fix incorrect rendering of 22px edit-opacity icon

trickyricky26 added reviewers: VDG, simgunz. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24807 To: trickyricky26, #vdg, simgunz Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24807: Fix incorrect rendering of 22px edit-opacity icon

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY This patch should fix the incorrect rendering of the new 22px `edit-opacity` icon added in D24753

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_trash.cpp:500 > KIO::UDSEntry entry; > +entry.clear(); > createTopLevelDirEntry(entry); why? > trashimpl.cpp:1088 > > +KIO::UDSEntry Tras

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added inline comments. INLINE COMMENTS > dfaure wrote in clang-format.cmake:75 > (b) looks good to me, and more importantly, I like the goal of being as close > as possible to the Qt coding style. removed that setting, back to Webkit default of BreakBeforeTernaryOperators: true REPOS

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann updated this revision to Diff 68369. cullmann added a comment. - keep default of BreakBeforeTernaryOperators = true REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=68186&id=68369 BRANCH master REVISION DETAIL https://phabr

D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fa27b67d2784: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24685?vs=680

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven removed a dependent revision: D24774: Allow non-local directories to provide UDS_SIZE. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > elvisangelaccio wrote in trashimpl.cpp:1091 > Is this really needed? We just created `entry`. It was done previously in void TrashProtocol::createTopLevelDirEntry to save some memory, so I just kept it here a

D24753: Add edit-opacity icons

trickyricky26 added a comment. In D24753#550676 , @simgunz wrote: > First, thanks for the excellent work on the new icons for Okular. I really like them. > > I have noticed that the edit-opacity icon does not render correctly in some cases:

D21235: Add handling of fuseiso filesystem type

bruns added inline comments. INLINE COMMENTS > fstabhandling.cpp:301 > + > +QStringList Solid::Backends::Fstab::FstabHandling::currentMountPoints(const > QString &device) > +{ Please keep these functions at their current position, just adds unnecessary noise in the diff. REPOSITORY R245 Sol

D24753: Add edit-opacity icons

simgunz added a comment. First, thanks for the excellent work on the new icons for Okular. I really like them. I have noticed that the edit-opacity icon does not render correctly in some cases: F7636237: Screenshot_20191020_150623.png Previe

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 36 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/36/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 20 Oct 2019 08:54:19 + Build duration: 3 hr 49 min and counting BUILD ARTIFACTS acc/KF5Wi

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

dfaure added a comment. Thanks for the information. https://community.kde.org/Schedules doesn't have a 19.12 schedule so I guess there's no freeze yet :-) REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D24686 To: meven, dfaure Cc: elvisangel

D24799: Port away from deprecated SmallIcon method

vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24799 To: vkrause, mlaurent Cc: kde-frameworks-devel, LeGast

D24799: Port away from deprecated SmallIcon method

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24799 To: vkrause, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24799 AFFECTED FILES src/ksettings/component

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

elvisangelaccio added a comment. In D24686#550533 , @dfaure wrote: > I never know when it's OK to increase the KF5 version dependency from applications modules, though. > > I have a ton of pending patches (to port away from KWindowSystem depr

D24773: kio_trash: Add size, modification, access and create date for trash:/

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

elvisangelaccio added a comment. +1 INLINE COMMENTS > trashimpl.cpp:1091 > +KIO::UDSEntry entry; > +entry.clear(); > + Is this really needed? We just created `entry`. > trashimpl.cpp:1094 > +// refresh list of trashes and get the list of files in them > +const TrashedFileInf

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I never know when it's OK to increase the KF5 version dependency from applications modules, though. I have a ton of pending patches (to port away from KWindowSystem deprecated API) whi

D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24685 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

dfaure added inline comments. INLINE COMMENTS > cullmann wrote in clang-format.cmake:75 > I have no strong opinion on that, we can remove that or keep it. (b) looks good to me, and more importantly, I like the goal of being as close as possible to the Qt coding style. REPOSITORY R240 Extra C

D24752: WIP: Use a separate worker thread to run the actual deletion of files

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. `slotReport` isn't the only problem, all of the subjob handling etc. seems very racy to me. I suggest to start from scratch and write the smallest possible worker, whose only

D24261: Modernize code: use range-based for loop in more places

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH morerangebasedforloops REVISION DETAIL https://phabricator.kde.org/D24261 To: kossebau, dfaure Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24793: [Konqueror] Remove KonqView::setActiveComponent()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R226 Konqueror BRANCH ahmad/setactiveComponent (branched from master) REVISION DETAIL https://phabricator.kde.org/D24793 To: ahmadsamir, dfaure, stefanocrocco Cc: kde-frameworks-devel

D21235: Add handling of fuseiso filesystem type

hallas marked 3 inline comments as done. hallas added a comment. @bruns - I have now refactored the patch so that it uses the `getmntent` functions for parsing the mtab file, so I think this patch is pretty much ready for a serious review ;) Also - please take a look at the strings that

D21235: Add handling of fuseiso filesystem type

hallas updated this revision to Diff 68324. hallas added a comment. Rewrite to use the getmntent function for parsing the mtab file REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21235?vs=68230&id=68324 BRANCH add_handling_of_fuseiso (branched from master)