meven marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25079
To: meven, dfaure, #frameworks, davidedmundson
Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
meven marked 3 inline comments as done.
meven added inline comments.
INLINE COMMENTS
> file_unix.cpp:266
> #ifdef USE_SENDFILE
> -bool use_sendfile = buff_src.st_size < 0x7FFF;
> +bool use_sendfile = true;
> #endif
This prevented using sendfile for file bigger than 2 GB.
Our code h
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25249
To: dfaure, mlaurent, sandsmark, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/155/
Project:
kf5-qt5 WindowsMSVCQt5.13
Date of build:
Mon, 11 Nov 2019 10:02:01 +
Build duration:
12 min and counting
justinkb added a comment.
The test incorrectly fails when a user builds kfilemetadata without taglib
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77, lots
meven added a reviewer: ngraham.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngra
meven added a reviewer: astippich.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, s
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Seems good to me.
Tested and works
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
C
bruns added inline comments.
INLINE COMMENTS
> query.cpp:317
> +{
> +const QString jsonQuery(QStringLiteral("{\"dayFilter\": 0,\
> + \"monthFilter\": 0, \
dayFilter/monthFilter/yearFilter are pointless, as they just default, but have
to be parsed
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:49440c0cbea1: Replace usage of deprecated
SlaveBase::config() by SlaveBase::configValue (authored by meven).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24686
astippich added a comment.
Thanks! I pushed a fix which disables the test if taglib is not installed
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D23411
To: astippich, bruns, mgallien, ngraham
Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77, lots
jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
- Add overload of PersonPluginManager::addContact that takes a pluginId
- Add a DataSourceModel that can later b
jbbgameich added a reviewer: apol.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D25265
To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
jbbgameich updated this revision to Diff 69608.
jbbgameich added a comment.
Use more future proof roleNames and Enum
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25265?vs=69603&id=69608
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2526
Hi,
basically all Frameworks components reference the ECM website
using the old projects.kde.org URL, which is long gone and
it is just a (partial) redirect.
See for example:
set_package_properties(ECM PROPERTIES TYPE REQUIRED
DESCRIPTION "Extra CMake Modules."
URL "https://projects.kde.o
iasensio updated this revision to Diff 69613.
iasensio marked 2 inline comments as done.
iasensio added a comment.
Simplify helper function
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24433?vs=67361&id=69613
BRANCH
extend_query_url
REVISION DETAIL
ht
On 11/11/19 22:52, Luigi Toscano wrote:
> Hi,
> basically all Frameworks components reference the ECM website
> using the old projects.kde.org URL, which is long gone and
> it is just a (partial) redirect.
>
> See for example:
>
> set_package_properties(ECM PROPERTIES TYPE REQUIRED
> DESCR
Elvis Angelaccio ha scritto:
>
>
> On 11/11/19 22:52, Luigi Toscano wrote:
>> Hi,
>> basically all Frameworks components reference the ECM website
>> using the old projects.kde.org URL, which is long gone and
>> it is just a (partial) redirect.
>>
>> See for example:
>>
>> set_package_properties(
jbbgameich added a reviewer: Plasma: Mobile.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D25265
To: jbbgameich, apol, #plasma:_mobile
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
sandsmark created this revision.
sandsmark added reviewers: aacid, cfeck, apol, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sandsmark requested review of this revision.
REVISION SUMMARY
Now it can at least handle the simplest XCF files I have.
sandsmark updated this revision to Diff 69617.
sandsmark added a comment.
Forgot to fix the layer offset reading, and read the precision after instead
of before the image properties
REPOSITORY
R287 KImageFormats
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25267?vs=69616&id=696
sandsmark updated this revision to Diff 69618.
sandsmark added a comment.
Fixed masks as well, now even some more complex XCF files work again.
REPOSITORY
R287 KImageFormats
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25267?vs=69617&id=69618
REVISION DETAIL
https://phabricat
bruns added a subscriber: broulik.
bruns added inline comments.
INLINE COMMENTS
> kio_search.cpp:88
> -return jsonQueryForType(QStringLiteral("Document"));
> -} else if (path.endsWith(QLatin1String("/images"))) {
> -return jsonQueryForType(QStringLiteral("Image"));
@broulik -
23 matches
Mail list logo
