D25515: Only extract lyrics when the plain text flag is set

2019-11-25 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY One can argue that lyrics are not really metadata,

D25516: Remove unrequired private declarations for taglibextractor

2019-11-25 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham, mgallien. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY They do not need to be declared in the header REP

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

2019-11-25 Thread Méven Car
meven added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25517: Add an option to extract binary data and add front cover property

2019-11-25 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY prepare for the following patch to taglibextractor

D25518: Extract front cover in the taglib extractor

2019-11-25 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add the possibility to extract the front cover i

D25518: Extract front cover in the taglib extractor

2019-11-25 Thread Alexander Stippich
astippich added a comment. This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations. Baloo can continue to work as is due to the new flags. Taglib wr

D25516: Remove unrequired private declarations for taglibextractor

2019-11-25 Thread Alexander Stippich
astippich added a dependent revision: D25518: Extract front cover in the taglib extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25516 To: astippich, #baloo, bruns, ngraham, mgallien Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampalouka

D25517: Add an option to extract binary data and add front cover property

2019-11-25 Thread Alexander Stippich
astippich added a dependent revision: D25518: Extract front cover in the taglib extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampalouka

D25518: Extract front cover in the taglib extractor

2019-11-25 Thread Alexander Stippich
astippich added dependencies: D25517: Add an option to extract binary data and add front cover property, D25516: Remove unrequired private declarations for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgalli

D23579: port ftp slave to new error reporting system

2019-11-25 Thread Harald Sitter
sitter added a comment. I'll see about adding some debug output for the daemon state. Hard to say why it's flakey with the info at hand. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n,

D25506: Remove Attica from KAboutDialog

2019-11-25 Thread Dan Leinir Turthra Jensen
leinir added a comment. Given the amount of work being put into the KDE Store recently, i am dismayed that it is considered undesirable that we should use the information the store provides us. I understand the surprise phone-home-ness it suggests, but i also am not at all happy with this. I

D23579: port ftp slave to new error reporting system

2019-11-25 Thread David Faure
dfaure added a comment. Wait, nevermind, it was a regression in the mapConfig() related code, fixed meanwhile. KIO is green again on CI. Sorry for the false alert. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc: anthonyfieroni, dfaure, kde-f

D25107: Add install dir for systemd units

2019-11-25 Thread Fabian Vogt
fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. AFAICT this breaks if `LIBDIR` != "lib". `systemd` only looks in `/usr/lib` AFAICT, so hardcoding to `$prefix/lib/systemd` might be better. REPOSITORY R240 Extra CMake Modules REVISION DET

D25107: Add install dir for systemd units

2019-11-25 Thread Fabian Vogt
fvogt requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25107 To: davidedmundson, apol, fvogt Cc: fvogt, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, micha

D25495: Fix Sonnet autodetect failing on Indian langs

2019-11-25 Thread Waqar Ahmed
waqar updated this revision to Diff 70288. waqar added a comment. Add test for autodetection REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70262&id=70288 BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25

D25107: Add install dir for systemd units

2019-11-25 Thread David Edmundson
davidedmundson added a comment. Wow, this part of systemd is shitty :/ static const char* const user_data_unit_paths[] = { "/usr/local/lib/systemd/user", "/usr/local/share/systemd/user", USER_DATA_UNIT_PATH, "/usr/lib/systemd/user", "/usr/share/systemd/user", NUL

D25495: Fix Sonnet autodetect failing on Indian langs

2019-11-25 Thread Waqar Ahmed
waqar updated this revision to Diff 70289. waqar added a comment. Add Test for autodetection REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70288&id=70289 BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25

D25107: Add install dir for systemd units

2019-11-25 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:137-140 > +# [``SYSTEMD_UNIT_INSTALL_DIR``]. Since 5.FIXME > +# ``SYSTEMDUSERUNITDIR`` > +# Systemd uSER Units (``LIBDIR/systemd/user``) > +# [``SYSTEMD_USER_UNIT_INSTALL_DIR``]. Since 5.FIXME These fixme also

D25495: Fix Sonnet autodetect failing on Indian langs

2019-11-25 Thread Waqar Ahmed
waqar updated this revision to Diff 70290. waqar added a comment. Update copyright REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70289&id=70290 BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495 AFFEC

D25495: Fix Sonnet autodetect failing on Indian langs

2019-11-25 Thread Waqar Ahmed
waqar updated this revision to Diff 70291. waqar added a comment. Remove unused includes REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70290&id=70291 BRANCH fix-176537 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25495

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

2019-11-25 Thread Cyril Rossi
crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. crossi requested review of this revision. REVISION SUMMARY Some KCM use GridViewKCM as root item, and they may ha

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

2019-11-25 Thread Kai Uwe Broulik
broulik added a comment. Can't you do `view.enabled: false`? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

2019-11-25 Thread Cyril Rossi
crossi added a comment. In D25520#567254 , @broulik wrote: > Can't you do `view.enabled: false`? > Edit: Never mind, `view` is bound to `scroll.view`, not `scroll` I did, but the GridView's style was not updateed to show it was disabled

D25517: Add an option to extract binary data and add front cover property

2019-11-25 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, f

D25516: Remove unrequired private declarations for taglibextractor

2019-11-25 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH cleanupTagLib REVISION DETAIL https://phabricator.kde.org/D25516 To: astippich, #baloo, bruns, ngraham, mgallien Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

2019-11-25 Thread Cyril Rossi
crossi added a dependent revision: D25525: KCM Style : take into account immutable properties. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D25527: [activities/fileitemaction] Port plugin metadata to JSON

2019-11-25 Thread Nicolas Fella
nicolasfella created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R320 KIO Extras BRANCH json REVISION DETAIL https://phabricator.kde.org/D25527 AFFECTED FIL

D25527: [activities/fileitemaction] Port plugin metadata to JSON

2019-11-25 Thread Nicolas Fella
nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25527 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbamp

D25527: [activities/fileitemaction] Port plugin metadata to JSON

2019-11-25 Thread Nicolas Fella
nicolasfella added a task: T12250: Port KFileItemActionPlugin usage to KPluginLoader. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25527 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampalouka

D25511: Drop unused broken KGesture support

2019-11-25 Thread Aleix Pol Gonzalez
apol added a comment. In D25511#567036 , @vkrause wrote: > Seems used in KAction in kdelibs4support. how does it make a difference? it's already commented. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 T

D25511: Drop unused broken KGesture support

2019-11-25 Thread David Edmundson
davidedmundson added a comment. It might break kdelibs4support compiling, I'll fix it out. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25528: [activities] Clean up cmake

2019-11-25 Thread Nicolas Fella
nicolasfella created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R320 KIO Extras BRANCH clean REVISION DETAIL https://phabricator.kde.org/D25528 AFFECTED FI

D25512: Remove unused include

2019-11-25 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH incl REVISION DETAIL https://phabricator.kde.org/D25512 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25528: [activities] Clean up cmake

2019-11-25 Thread Nicolas Fella
nicolasfella added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D25528: [activities] Clean up cmake

2019-11-25 Thread Nicolas Fella
nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampalo

D25512: Remove unused include

2019-11-25 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R265:719569193c7d: Remove unused include (authored by nicolasfella). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25512?vs=70270&id=70302 REVISION DETAIL htt

D25517: Add an option to extract binary data and add front cover property

2019-11-25 Thread Alexander Stippich
astippich updated this revision to Diff 70303. astippich added a comment. - fix label comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=70284&id=70303 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFFECTED F

D25511: Drop unused broken KGesture support

2019-11-25 Thread Volker Krause
vkrause added a comment. Right, kdelibs4support seems to include the deleted private headers, and uses these types in public API in KAction. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: apol, vkrause, kde-frameworks-devel, LeGast00n,

D25511: Drop unused broken KGesture support

2019-11-25 Thread Aleix Pol Gonzalez
apol added a comment. In D25511#567355 , @vkrause wrote: > Right, kdelibs4support seems to include the deleted private headers, and uses these types in public API in KAction. 🤦 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabric

D25528: [activities] Clean up cmake

2019-11-25 Thread Aleix Pol Gonzalez
apol added a comment. This patch is changing the logic. I'd recommend changing the commit message to reflect it. INLINE COMMENTS > CMakeLists.txt:150 > add_subdirectory( about ) > -if(KF5Activities_FOUND) > +if(KF5Activities_FOUND AND Qt5Sql_FOUND) >add_subdirectory( activities ) I'd s

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Waqar Ahmed
waqar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. waqar requested review of this revision. REVISION SUMMARY QLocale is missing some locales and as a result the file name of the dictionaries of these locales are used in menus instea

D25107: Add install dir for systemd units

2019-11-25 Thread David Edmundson
davidedmundson updated this revision to Diff 70307. davidedmundson added a comment. Fabian fixes REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25107?vs=69238&id=70307 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25107 AFFEC

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Yuri Chornoivan
yurchor added inline comments. INLINE COMMENTS > loader.cpp:255 > +{QLatin1String("cv"), {QStringLiteral("Чӑвашла"), > QString()}}, //Chuvash > +{QLatin1String("cv_RU"), {QStringLiteral("Чӑвашла"), > QStringLiteral("Росси́я")}}, > +{QL

D25491: Remove kdeinit dependency from kded.

2019-11-25 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D25491 To: dfaure, mart, cordlandwehr, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KF6 Blogs

2019-11-25 Thread Volker Krause
On Saturday, 23 November 2019 16:34:01 CET Dominik Haumann wrote: > Hi everyone, > > could you who currently are at the KF6 sprint blog a bit more? There's 3 posts by Christoph and one by Kévin by now, and one or two more to come I think. Even more importantly IMHO, we discussed monthly summary

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Waqar Ahmed
waqar updated this revision to Diff 70310. waqar added a comment. Remove accent from Росси́я REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25530?vs=70306&id=70310 BRANCH add-missing-locales (branched from master) REVISION DETAIL https://phabricator.kd

D25107: Add install dir for systemd units

2019-11-25 Thread Fabian Vogt
fvogt accepted this revision. fvogt added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KDEInstallDirs.cmake:245 > set(_LIBDIR_DEFAULT "lib") > -# Override this default 'lib' with 'lib64' iff: > +# Override this default 'lib' with 'lib64' if: > # - we are

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Failing!

2019-11-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 25 Nov 2019 16:58:07 + Build duration: 2 hr 50 min and counting CONSOLE OUTPUT [...trunca

D25528: Only build activities support if QtSQL is found

2019-11-25 Thread Nicolas Fella
nicolasfella retitled this revision from "[activities] Clean up cmake" to "Only build activities support if QtSQL is found". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iase

D25528: Only build activities support if QtSQL is found

2019-11-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 70316. nicolasfella added a comment. - Use if TARGET REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25528?vs=70301&id=70316 BRANCH clean REVISION DETAIL https://phabricator.kde.org/D25528 AFFECTED FILES

D25533: Deprecate KFileWidget::toolBar

2019-11-25 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It leaks KToolBar from KXmlGui into the public API. I did no

D25533: Deprecate KFileWidget::toolBar

2019-11-25 Thread Nicolas Fella
nicolasfella added a task: T12206: Port KFileWidget away from KToolBar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25533 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Albert Astals Cid
aacid added a comment. Any reason we particularly need this here instead of improving Qt? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25530 To: waqar Cc: aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25527: [activities/fileitemaction] Port plugin metadata to JSON

2019-11-25 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH json REVISION DETAIL https://phabricator.kde.org/D25527 To: nicolasfella, #frameworks, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fpric

D25527: [activities/fileitemaction] Port plugin metadata to JSON

2019-11-25 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R320:f5b426a7f294: [activities/fileitemaction] Port plugin metadata to JSON (authored by nicolasfella). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25527?vs=70299&

D25233: [kded] Port plugin metadata to JSON

2019-11-25 Thread Nicolas Fella
nicolasfella added a reviewer: KF6. REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti, #kf6 Cc: kde-utils-devel

Re: KInit - Current state and benchmarks

2019-11-25 Thread Albert Astals Cid
El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va escriure: > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va > escriure: > > > > Are we sure it's fair to assume people have SSD? ou

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 203 - Still Unstable!

2019-11-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/203/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 25 Nov 2019 22:26:22 + Build duration: 7 min 17 sec and counting JUnit Tests Name: projectro

D25518: Extract front cover in the taglib extractor

2019-11-25 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D25528: Only build activities support if QtSQL is found

2019-11-25 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH clean REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella, #frameworks, apol Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D25528: Only build activities support if QtSQL is found

2019-11-25 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R320:839fe1b51aea: Only build activities support if QtSQL is found (authored by nicolasfella). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25528?vs=70316&id=70321

D25233: [kded] Port plugin metadata to JSON

2019-11-25 Thread Aleix Pol Gonzalez
apol added a comment. +1 REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti, #kf6 Cc: apol, kde-utils-devel

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Failing!

2019-11-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 26 Nov 2019 00:26:51 + Build duration: 1 min 25 sec and counting CONSOLE OUTPUT [...trunc

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

2019-11-25 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The interface is only provided by one unreleased application, so pe

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

2019-11-25 Thread Nicolas Fella
nicolasfella added a task: T12159: KTextWidgets: Remove plugin system. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D25538 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Waqar Ahmed
waqar marked 3 inline comments as done. waqar added a comment. In D25530#567472 , @aacid wrote: > Any reason we particularly need this here instead of improving Qt? Improving Qt is definitely the better and correct way. But in the meanwhil

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Alexander Potashev
aspotashev added inline comments. INLINE COMMENTS > loader.cpp:255 > +{QLatin1String("cv"), {QStringLiteral("Чӑвашла"), > QString()}}, //Chuvash > +{QLatin1String("cv_RU"), {QStringLiteral("Чӑвашла"), > QStringLiteral("Россия")}}, > +{

D25530: Sonnet: Add locales that are missing in QLocale

2019-11-25 Thread Waqar Ahmed
waqar added inline comments. INLINE COMMENTS > aspotashev wrote in loader.cpp:255 > Is there any rule behind your decision to spell some language names > capitalized and some others not capitalized? > > Examples: > > - Чӑвашла - first letter is capital > - коми - all letters in lowercase > >

Re: KInit - Current state and benchmarks

2019-11-25 Thread Milian Wolff
On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote: > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va escriure: > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va