KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/42/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 07:28:09 + Build duration: 1 min 14 sec and counting JUnit Tests Name: projectr

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

This revision was automatically updated to reflect the committed changes. Closed by commit R245:c97f0b2a3076: Ensure mounted nfs filesystems matches their fstab declared counterpart (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21204?vs=67981&id=71566#toc REPOSITORY

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/126/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 06:53:38 + Build duration: 4 min 16 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/77/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 15 Dec 2019 06:53:38 + Build duration: 3 min 36 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 06:53:38 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...tru

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik, mpyne Cc: mpyne, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

ndavis resigned from this revision. ndavis added a comment. This revision now requires review to proceed. Whoops, didn't mean to give my official approval REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: ndavis

D25999: Add optional subtitle to grid delegate

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 visually REPOSITORY R296 KDeclarative BRANCH optional-subtitle (branched from master) REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundso

D26010: Update the kiten log

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

ognarb added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Mix the labplot icon and the hiraganas for kiten Another possibility would be to use the kile icon with the same hi

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.h:262 > */ > -enum MessageBoxType { QuestionYesNo = 1, WarningYesNo = 2, > WarningContinueCancel = 3, WarningYesNoCancel = 4, Information

D25972: Support PyQt5 compiled with SIP 5

arojas marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25972 To: arojas, bruns, dfaure Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25972: Support PyQt5 compiled with SIP 5

arojas updated this revision to Diff 71563. arojas added a comment. Use HINTS REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25972?vs=71481&id=71563 REVISION DETAIL https://phabricator.kde.org/D25972 AFFECTED FILES find-modules/FindPythonM

D25434: [plasma-framework] port away from deprecated KF5 APIs

dfaure closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25434 To: dfaure, mart, davidedmundson, broulik, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25972: Support PyQt5 compiled with SIP 5

apol added a comment. LGTM overall INLINE COMMENTS > FindPythonModuleGeneration.cmake:312 >NAMES QtCoremod.sip > + PATHS ${KDE_INSTALL_PYTHON3DIR}/PyQt5/bindings/QtCore >PATH_SUFFIXES share/sip/PyQt5/QtCore Should probably be HINTS. REPOSITORY R240 Extra CMake Modules REVISION D

D25434: [plasma-framework] port away from deprecated KF5 APIs

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'd say we could make it so setupEngine knows itself that it's already been set up. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/

D26009: KCoreAddons: fix compilation with qtbase git dev branch

dfaure created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY - Remove unneeded endl in qDebug-like statements - Include , forward-decl doesn't work anymore, now that it's a typedef.

D25965: [plasmashell] Add signal for panelTakesFocus changing

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, provided that the rest make sense. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D25965 To: davidedmundson, apol Cc: apol, kde-framewor

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH http REVISION DETAIL https://phabricator.kde.org/D25995 To: chehrlic, dfaure, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH remoteencoding REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26006: Deprecate KPixmapProvider

nicolasfella added a task: T12310: Kill KUrlPixmapProvider and KPixmapProvider. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D26006 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26006: Deprecate KPixmapProvider

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It has no known non-deprecated users and can easily be replaced by

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.12 - Build # 62 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.12/62/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 20:06:54 + Build duration: 2 min 34 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.13 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.13/34/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Dec 2019 20:06:54 + Build duration: 2 min 5 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 20:06:54 + Build duration: 1 min 36 sec and counting JUnit Tests Name: projec

D25974: Fix Invalid-enum-value assignment

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R270:a890441e38ee: Fix Invalid-enum-value assignment (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.k

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 20:05:25 + Build duration: 1 min 32 sec and counting JUnit Tests Name:

D25937: pic: Fix Invalid-enum-value undefined behaviour

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25937 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew retitled this revision from "[WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO" to "Adding support for mounting KIOFuse URLs for applications that don't use KIO". feverfew edited the summary of this revision. feverfew edited the test plan for this revisio

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 71543. feverfew added a comment. - fix code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=71423&id=71543 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES src

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#577174 , @dfaure wrote: > For SMB shares I guess what can happen is that the URL doesn't have a username in it, but it still needs a password? IIRC there was no username in "old" samba (W95

D25999: Add optional subtitle to grid delegate

filipf added a comment. ^ No, it seems to be GridDelegate actually. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

filipf added a comment. In D25999#577780 , @ngraham wrote: > It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this? Yeah if we could it wouldn't be bad to add a condition.

D25999: Add optional subtitle to grid delegate

ngraham updated this revision to Diff 71540. ngraham marked an inline comment as done. ngraham added a comment. Remove pointless check REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25999?vs=71535&id=71540 BRANCH optional-subtitle (branched from mas

D25999: Add optional subtitle to grid delegate

davidedmundson added inline comments. INLINE COMMENTS > GridDelegate.qml:193 > +id: caption > +visible: delegate.subtitle && delegate.subtitle.length > 0 > +opacity: 0.6 what is the first clause for? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.k

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik added inline comments. INLINE COMMENTS > bruns wrote in kfileplacesmodel.cpp:758 > you have dropped the `allowedHere` check. Probably just `if (!allowedHere) > continue`. > > And for reasons unknown to me, `tags:` is not filtered per app - move the > allowedHere check to the very begin

D25999: Add optional subtitle to grid delegate

ngraham added a comment. It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: filipf, kde-f

D25999: Add optional subtitle to grid delegate

filipf added a comment. Thanks, I'll tweak my patch to use this. Does the implementation increase the horizontal spacing between delegates even if there are no subtitles present? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #pla

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 17:32:10 + Build duration: 21 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 200 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/200/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 17:32:06 + Build duration: 17 min and counting

D25999: Add optional subtitle to grid delegate

filipf added a dependent revision: D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGa

D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY ... but Qt XCB knows, such as Notifications type. This ensures QXcbWindow keeps the

D25999: Add optional subtitle to grid delegate

ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.13 - Build # 34 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.13/34/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 17:32:07 + Build duration: 10 min and counting CONSOLE OUTPUT [...tr

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 78 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 17:37:39 + Build duration: 3 min 42 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kmediaplayer » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 17:32:05 + Build duration: 8 min 50 sec and counting JUnit Tests

D25999: Add optional subtitle to grid delegate

ngraham created this revision. ngraham added reviewers: VDG, Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY In various cases, we may want some or all grid delegates to have a

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

chehrlic added a comment. It was clazy, not me - just wanted to fix a memleak in kio :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/43/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 17:32:04 + Build duration: 5 min 25 sec and counting

[kconfigwidgets] autotests: Revert "GIT_SILENT: remove which includes all of (scripted)"

Git commit 998ea068274ca4ce78903d18ea9afbbad6a67528 by Ben Cooksley. Committed on 14/12/2019 at 17:36. Pushed by bcooksley into branch 'master'. Revert "GIT_SILENT: remove which includes all of (scripted)" This change breaks the build within the autotests for KConfigWidgets, as noted by the CI

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

thiago added a comment. Good catch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifyconfig » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 17:32:03 + Build duration: 4 min 6 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 WindowsMSVCQt5.13 - Build # 30 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20WindowsMSVCQt5.13/30/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 17:32:02 + Build duration: 3 min 46 sec and counting JUnit Tests Nam

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 17:32:11 + Build duration: 2 min 0 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 37 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Dec 2019 17:32:08 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 17:32:09 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT [...truncated

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kfileplacesmodel REVISION DETAIL https://phabricator.kde.org/D25997 To: chehrlic, dfaure, nicolasfella, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D24433: Move URL parsing methods from kioslave to query object

This revision was automatically updated to reflect the committed changes. Closed by commit R293:34e682a1c0ed: Move URL parsing methods from kioslave to query object (authored by iasensio). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=71523&id=71531 R

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic added reviewers: dfaure, nicolasfella, ngraham, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25997 To: chehrlic, dfaure, nicolasfella, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

chehrlic added reviewers: thiago, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

chehrlic added reviewers: dfaure, ngraham, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25995 To: chehrlic, dfaure, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REPOSITORY R241 KIO BRANCH kfileplacesmodel REVISION DETAIL https://phabricator.kde.org/D25997 AFFECTED FILES src/filewidgets/

D25991: [KFilePlacesModel] Fix supported scheme check for devices

bruns added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:758 > +KFilePlacesItem *item = nullptr; > +if (deviceAvailable) { > +item = new KFilePlacesItem(bookmarkManager, > bookmark.address(), udi); you have dropped the `allowedHere`

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REPOSITORY R241 KIO BRANCH remoteencoding REVISION DETAIL https://phabricator.kde.org/D25996 AFFECTED FILES src/core/kremoteen

D25991: [KFilePlacesModel] Fix supported scheme check for devices

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham, bruns Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleig

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REPOSITORY R241 KIO BRANCH http REVISION DETAIL https://phabricator.kde.org/D25995 AFFECTED FILES src/ioslaves/http/http.cpp

D25994: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25994 To: chehrlic Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25994: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

chehrlic created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chehrlic requested review of this revision. REVISION SUMMARY HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 73 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/73/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 16:02:57 + Build duration: 8 min 45 sec and counting JUnit Tests Na

D24433: Move URL parsing methods from kioslave to query object

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich, bruns Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikh

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 76 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/76/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 14 Dec 2019 15:44:39 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT [...trunc

D25991: [KFilePlacesModel] Fix supported scheme check for devices

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh so nice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25991 To: broulik, #frameworks, dfaure, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Fe

D24433: Move URL parsing methods from kioslave to query object

iasensio updated this revision to Diff 71523. iasensio marked 5 inline comments as done. iasensio added a comment. - Use return statements REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=69836&id=71523 BRANCH extend_query_url REVISION DETAIL htt

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A device doesn't usually have a URL so we need to actutally check the underlying devic

KDE CI: Frameworks » kpackage » kf5-qt5 WindowsMSVCQt5.13 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20WindowsMSVCQt5.13/29/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 13:36:38 + Build duration: 1 hr 15 min and counting CONSOLE OUTPUT St

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/42/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 13:33:58 + Build duration: 1 hr 17 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 199 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/199/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 13:32:48 + Build duration: 1 hr 17 min and counting CONSOLE OUTPUT Starte

KDE CI: Frameworks » kmediaplayer » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 13:34:54 + Build duration: 1 hr 16 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 72 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/72/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 13:31:55 + Build duration: 1 hr 18 min and counting CONSOLE OUTPUT S

KDE CI: Frameworks » knotifyconfig » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20WindowsMSVCQt5.13/20/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 13:34:35 + Build duration: 1 hr 16 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/34/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 12:44:11 + Build duration: 1 hr 44 min and counting JUnit Tests N

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 12:09:52 + Build duration: 2 hr 0 min and counting JUnit Tests Name: pro

D25984: Load translations

broulik added a comment. Sounds good to me lol REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, ma

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.13 - Build # 33 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.13/33/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 14 Dec 2019 11:34:34 + Build duration: 2 hr 9 min and counting CONSOLE OUTPUT [.

D25988: document colorbutton with an example

sitter closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25988 To: sitter, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25988: document colorbutton with an example

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D25988 To: sitter, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25988: document colorbutton with an example

sitter created this revision. sitter added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY so people know what to import TEST PLAN it will just work! REPOSITORY R296

D25849: Ensure the dialog title is correct with an uninitialised engine

This revision was automatically updated to reflect the committed changes. leinir marked an inline comment as done. Closed by commit R304:197f257cb9b6: Ensure the dialog title is correct with an uninitialised engine (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE htt

D25849: Ensure the dialog title is correct with an uninitialised engine

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Kaboom REPOSITORY R304 KNewStuff BRANCH ensure-dialog-title-with-uninitialised-engine (branched from master) REVISION DETAIL https://phabricator.kde.org/D25849 To: leinir, #framew

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/76/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Dec 2019 12:26:03 + Build duration: 33 min and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 12:27:55 + Build duration: 25 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 47 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/47/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Dec 2019 11:12:24 + Build duration: 1 hr 39 min and counting BUILD ARTIFACTS abi-compatibil

D25960: [calendar] Check out of bounds array access in QLocale lookup

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25960 To: davidedmundson, #plasma, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, b

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 36 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/36/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 14 Dec 2019 12:11:41 + Build duration: 35 min and counting CONSOLE OUTPUT [...truncated 152 li

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 223 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/223/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 11:45:14 + Build duration: 59 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/61/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 11:53:34 + Build duration: 50 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 11:50:17 + Build duration: 49 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 11:46:19 + Build duration: 48 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 14 Dec 2019 11:22:39 + Build duration: 1 hr 5 min and counting JUnit Tests Name: proj

  1   2   >