D26265: Fix crash on non-unix based systems

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH fix REVISION DETAIL https://phabricator.kde.org/D26265 To: shubham, ngraham, pino Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24932: Add button to open the folder in filelight to view more details

shubham added a comment. @pino @ngraham Fixed here https://phabricator.kde.org/D26265. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D26265: Fix crash on non-unix based systems

shubham created this revision. shubham added reviewers: ngraham, pino. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY Depends upon D24932 REPOSITORY R241 KIO

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

Hi Stephen, Am Sonntag, 29. Dezember 2019, 00:10:50 CET schrieb Stephen Kelly: > On 22/12/2019 16:08, Stephen Kelly wrote: > > On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote: > >> Perhaps joining the "Release Service" (formerly known as "KDE > >> Applications") > >> is a better place then,

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

On 22/12/2019 16:08, Stephen Kelly wrote: On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote: Perhaps joining the "Release Service" (formerly known as "KDE Applications") is a better place then, it also contains a set of libraries already. That would serve the purpose of having releases

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

El divendres, 27 de desembre de 2019, a les 11:03:25 CET, Volker Krause va escriure: > On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote: > > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. > Kossebau va escriure: > > > Am Montag, 23. Dezember 2019,

D24932: Add button to open the folder in filelight to view more details

pino added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1453 > +// Open the current folder in filelight > +KRun::run(QStringLiteral("/usr/bin/filelight"), { properties->url() }, > properties->window(), QStringLiteral("Filelight"), > QStringLiteral("filelight")); > +}

D26043: Add edit mode menu item to desktop widget context menu

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart, ngraham Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel,

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

kossebau added a comment. (Just remember that using KDE_INSTALL_KNSRCDIR though needs at least KNewStuffCore from KF 5.57 (hint was missing in API dox, proposing D26248 to fix that).) Myself also need to reserve time to look closer at it, hoping to

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

pwojcik added inline comments. INLINE COMMENTS > apol wrote in KDEInstallDirs.cmake:376 > Why's /opt special? /usr is single special case, but any subdirectory of /opt/ is special by GNUInstallDirs.cmake, following Filesystem Hierarchy Standard. REPOSITORY R240 Extra CMake Modules REVISION

D25877: [KColorschemeManager] Add option to reenable following global theme

asemke added inline comments. INLINE COMMENTS > davidre wrote in kcolorschememanager.h:130 > I thought it would be nice to have as a convenience function if an > application has changed the scheme to easily go back to the system color > scheme. I don't know if it should be a slot. I put it

D26043: Add edit mode menu item to desktop widget context menu

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26043 To: GB_2, #plasma, #vdg, mart Cc: ngraham, broulik, mart, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D26227: Port to QRandomGenerator

This revision was automatically updated to reflect the committed changes. Closed by commit R283:20980f54fb4a: Port to QRandomGenerator (authored by mlaurent). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26227?vs=72192=72282 REVISION DETAIL