D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ad625f68f345: Fix the size and pixel alignment of checkboxes and radiobuttons (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26955: Fix background SVG colors and adjust background SVG corners

ndavis added a subscriber: niccolove. ndavis added a comment. In D26955#601684 , @ngraham wrote: > This fixes the color bug, so that's good. :) > > However with Breeze Dark, now I see pointy corners and very weak shadows: F7982216:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks visually broken in the exact same way in Plasma Theme Explorer, so I suspect the test code was lifted from it which explains why it's broken in the test. Looks perfect in

D26955: Fix background SVG colors and adjust background SVG corners

ngraham added a comment. This fixes the color bug, so that's good. :) However with Breeze Dark, now I see pointy corners and very weak shadows: F7982216: Screenshot_20200127_221203.png ...Whereas with the Breeze and Breeze Light plasma style, I

D26955: Fix background SVG colors and adjust background SVG corners

ndavis retitled this revision from "Fix background colors and adjust background corners" to "Fix background SVG colors and adjust background SVG corners". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26955 To: ndavis, #vdg, #plasma Cc:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601675 , @ngraham wrote: > I'd like to be able to verify that by looking at a radio button in the Plasma style but I can't actually find any. Do you know of any place where they're used?

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ngraham added a comment. I'd like to be able to verify that by looking at a radio button in the Plasma style but I can't actually find any. Do you know of any place where they're used? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To:

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74473. apol added a comment. clang format REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74241=74473 BRANCH apol/tablet-unstable-v2-1 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/101/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 28 Jan 2020 01:50:54 + Build duration: 1 min 52 sec and counting JUnit Tests Name:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In case it's not clear or for anyone skimming the conversation, I think the tests themselves are broken and can't be relied upon because they break things that normally work OK or at least better than they do in the tests. I don't know QML that well, but I don't see

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601535 , @ngraham wrote: > Found one small regression in the test suite. The new correct radio button sizing results in vertical misalignment (for both PC2 and PC3): > > Status quo: F7978647:

D26955: Fix background colors and adjust background corners

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The shadows patch before this patch had some problems with the SVGs that caused

D26167: Update holidays and add flagdays and namedays for Sweden

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks fine. I also tested and the changes don't break anything. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D26167 To: riiga, #kde_pim, winterz Cc:

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

This revision was automatically updated to reflect the committed changes. Closed by commit R237:87471e14b370: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader (authored by mlaurent). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26952: Make tags:/ ioslave not writable

bruns added a comment. The idea was to assign a tag to a file by dropping a (multiple) file into a tag folder, and that somewhat works. But you can also "delete" a file from a tags folder, which is semantically overloaded in a bad way: - it just removes the tag (you can not delete

D26948: [KColorSchemeManager] Don't list duplicates

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. REPOSITORY R265 KConfigWidgets BRANCH duplicates (branched from master) REVISION DETAIL https://phabricator.kde.org/D26948 To: davidre, #frameworks, ngraham Cc: ngraham,

D26951: Remove old code that is not used anymore

davidre added a comment. If it's still something we ship than I think it is better to just change the comment REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26951 To: davidre, dfaure, ervin, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n,

D26952: Make tags:/ ioslave not writable

ngraham added a comment. Agreed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26952 To: meven, ngraham, #baloo Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D26952: Make tags:/ ioslave not writable

meven added a comment. In D26952#601525 , @ngraham wrote: > That's fine, but what has that got to do with creating a file or folder inside the `tags:/` ioslave? The concept of creating a file or folder inside a tag does not make conceptual

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ngraham added a comment. Found one small regression in the test suite. The new correct radio button sizing results in vertical misalignment (for both PC2 and PC3): Status quo: F7978647: Screenshot_20200127_112436.PNG With patch: F7978654:

D26952: Make tags:/ ioslave not writable

ngraham added a comment. That's fine, but what has that got to do with creating a file or folder inside the `tags:/` ioslave? The concept of creating a file or folder inside a tag does not make conceptual sense; you apply tags to files and folders, but you don't create files and folders in

D26952: Make tags:/ ioslave not writable

meven added a comment. In D26952#601513 , @ngraham wrote: > You should be able to create tags, but how does it make any sense to be able to create a file or folder in the `tags:/` view? What does that even mean? Where does it end up living?

D26952: Make tags:/ ioslave not writable

ngraham added a comment. You should be able to create tags, but how does it make any sense to be able to create a file or folder in the `tags:/` view? What does that even mean? Where does it end up living? What's it for? That's what the bug report is all about. REPOSITORY R293 Baloo

D26931: Introduce SPDX license headers

cgiboudeaux added a comment. In D26931#601508 , @cgiboudeaux wrote: > In D26931#601505 , @cordlandwehr wrote: > > > Convert to SPDX-FileCopyrightText tags > > > some files have by , can I

D26931: Introduce SPDX license headers

cgiboudeaux added a comment. In D26931#601505 , @cordlandwehr wrote: > Convert to SPDX-FileCopyrightText tags some files have by , can I suggest removing this "by"? REPOSITORY R274 KIdleTime REVISION DETAIL

Re: Introducing SPDX License Headers

On Montag, 27. Januar 2020 01:35:07 CET Vlad Zahorodnii wrote: > Hi, > > On 1/26/20 7:59 PM, Andreas Cord-Landwehr wrote: > > Does this approach sound reasonable? If anybody wants to review my > > conversion tool and the license-header-to-SPDX-translations, I am happy > > for feedback! > +1 > >

D26931: Introduce SPDX license headers

cordlandwehr updated this revision to Diff 74452. cordlandwehr added a comment. Convert to SPDX-FileCopyrightText tags REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26931?vs=74400=74452 BRANCH master REVISION DETAIL

D26952: Make tags:/ ioslave not writable

meven abandoned this revision. meven added a comment. Makes no sense tags:/ is supposed to be able to have mkdir REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26952 To: meven, ngraham, #baloo Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas,

D26951: Remove old code that is not used anymore

davidedmundson added a comment. Does it affect: kwidgetsaddons/src/kselector.h:48 (no idea what that is, just something grep found) REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26951 To: davidre, dfaure, ervin, #frameworks Cc: davidedmundson,

D26952: Make tags:/ ioslave not writable

meven created this revision. meven added reviewers: ngraham, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 416819 FIXED-IN: 5.67 REPOSITORY R293 Baloo BRANCH master

D26951: Remove old code that is not used anymore

davidre created this revision. davidre added reviewers: dfaure, ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY According to the comment it was for Qt3 support which we don't

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. Ping. This patch doesn't fix everything, but it's still an improvement over the current state. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: davidedmundson, kde-frameworks-devel,

D21813: RFC: Consider adding more padding to the desktop theme

ngraham added a comment. Or maybe @niccolove would be interested? Could be an alternative to patches like D26944 , D26945 , and D26946 , and instead we sould just *remove* the extra

D21813: RFC: Consider adding more padding to the desktop theme

ngraham added a subscriber: niccolove. ngraham added a comment. Or maybe @niccolove would be interested? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: niccolove, martinsotirov, abetts,

D26948: [KColorSchemeManager] Don't list duplicates

davidre added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26948 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26948: [KColorSchemeManager] Don't list duplicates

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Loading code taken from the colors KCM. Additionally it ensures that when color schemes with the same file name

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2,

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74428. mlaurent added a comment. Use QStringRef here too REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74406=74428 BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added inline comments. INLINE COMMENTS > kconfigloader.cpp:125 > for (int i = 0; i < numAttrs; ++i) { > -QString name = attrs.localName(i).toLower(); > +const QString name = attrs.at(i).name().toString().toLower(); > if (name ==

D26858: Provide an implementation for the tablet interface

zzag added a comment. Looks good to me. There are still many coding style issues. I suggest to run `clang-format` over individual files in this patch and then adjust the most problematic places (I don't think there are that many). You could borrow a `.clang-format` file from

Re: Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Failing!

On lundi 27 janvier 2020 10:30:38 CET Ben Cooksley wrote: > Hi all, > > Any ideas why this would have suddenly started to fail like this in KHTML? > From what I can see there haven't been any changes in KHTML itself, so this > would have to be a regression in another Framework/ECM... > > (This

Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Failing!

Hi all, Any ideas why this would have suddenly started to fail like this in KHTML? >From what I can see there haven't been any changes in KHTML itself, so this would have to be a regression in another Framework/ECM... (This isn't FreeBSD specific either, as a Linux build just tripped up on the

D26888: work around to fully support the windows backend

meven added inline comments. INLINE COMMENTS > notifybysnore.cpp:165 > > -void NotifyBySnore::notifyDeferred(KNotification* notification) > -{ > +Q_UNUSED(config); > QProcess *proc = new QProcess(); no `;` here REPOSITORY R289 KNotifications REVISION DETAIL

T11627: Improve KIO asynchronicity

meven added a comment. In T11627#206210 , @broulik wrote: > I'm pretty sure there's a tonne of blocking DBus calls being done all over the place during file copy (checking for slaves on hold, updating kuiserver job tracking info, etc) which can