KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/2/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 23:53:34 + Build duration: 5 min 3 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.14 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.14/22/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:41 + Build duration: 1 min 50 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » syndication » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:36 + Build duration: 1 min 50 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwallet » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwallet/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:56 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.14 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/50/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:19 + Build duration: 1 min 43 sec and counting CONSOLE

KDE CI: Frameworks » kwindowsystem » kf5-qt5 WindowsMSVCQt5.14 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20WindowsMSVCQt5.14/18/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:02 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:06 + Build duration: 1 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:12 + Build duration: 1 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kunitconversion » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:50 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.14 - Build # 37 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.14/37/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:40 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:46 + Build duration: 1 min 36 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.14 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.14/20/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:56:27 + Build duration: 1 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:19 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knotifyconfig » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifyconfig/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:05 + Build duration: 1 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.14 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.14/22/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:02 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » krunner » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:33 + Build duration: 1 min 21 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.14 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.14/25/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:57 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 32 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/32/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:55:35 + Build duration: 1 min 25 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/7/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:26 + Build duration: 53 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 91 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/91/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:34 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kmediaplayer » kf5-qt5 WindowsMSVCQt5.14 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kmediaplayer/job/kf5-qt5%20WindowsMSVCQt5.14/10/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:52 + Build duration: 1 min 10 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kjsembed » kf5-qt5 WindowsMSVCQt5.14 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20WindowsMSVCQt5.14/10/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:51 + Build duration: 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kjobwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:44 + Build duration: 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:21 + Build duration: 49 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kemoticons » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:04 + Build duration: 34 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kded » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kded/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:39 + Build duration: 29 sec and counting CONSOLE OUTPUT Started by

KDE CI: Frameworks » kglobalaccel » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:12 + Build duration: 46 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdoctools » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:00 + Build duration: 30 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:54:10 + Build duration: 41 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdewebkit » kf5-qt5 WindowsMSVCQt5.14 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdewebkit/job/kf5-qt5%20WindowsMSVCQt5.14/9/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:53 + Build duration: 30 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/19/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:18 + Build duration: 14 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/16/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:09 + Build duration: 10 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.14 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.14/20/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:34 + Build duration: 24 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:28 + Build duration: 24 sec and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » kcompletion » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:13 + Build duration: 12 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:23 + Build duration: 20 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/15/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:53:03 + Build duration: 9.4 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.14 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.14/18/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:52:58 + Build duration: 3.6 sec and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » kactivities » kf5-qt5 WindowsMSVCQt5.14 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kactivities/job/kf5-qt5%20WindowsMSVCQt5.14/15/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 24 Mar 2020 23:52:48 + Build duration: 5.5 sec and counting CONSOLE OUTPUT

D28260: [QML] Set the remaining time in the monitor more reliably

bruns added a comment. In D28260#633929 , @ngraham wrote: > Much nicer! Should the timer be destroyed when indexing is finished, though? QElapsedTimer is basically a timestamp with is updated on `{re}start()`. So we have to start it at

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78417. apol added a comment. rebase REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=75505=78417 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 78416. nicolasfella added a comment. - Add a dedicated main page and link to the HIG from there - Move most content to main page - Fix code example REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D26918: Improve KNotification API docs

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in Mainpage.dox:9 > @class so we create a link. Doxygen should do that automatically http://www.doxygen.nl/manual/autolink.html REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To:

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28201 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28264: KIO: rename ProcessLauncherJob to ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28264 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28264: KIO: rename ProcessLauncherJob to ApplicationLauncherJob

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28264 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

davidedmundson accepted this revision. REPOSITORY R241 KIO BRANCH 2020_03_commandlauncherjob REVISION DETAIL https://phabricator.kde.org/D28201 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28264: KIO: rename ProcessLauncherJob to ApplicationLauncherJob

dfaure created this revision. dfaure added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Initially I thought it could do the job both for applications (running a

D28263: [autotests/client] Set event queue on registry

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise events are dispatched from the wrong thread. TEST PLAN

D28260: [QML] Set the remaining time in the monitor more reliably

ngraham added a comment. Much nicer! Should the timer be destroyed when indexing is finished, though? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28260 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

Re: Problems in KWayland causes by API and ABI compatibility promises

On mardi 24 mars 2020 17:55:48 CET David Edmundson wrote: > There's another problem we're going to hit with kwayland at some point > in the future. Sorry for hi-jacking, but there's another problem we're hitting right now in kwayland... There seems to be a nasty use-after-free in the

D28260: [QML] Set the remaining time in the monitor more reliably

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The remaining time was only updated when the count of indexed files modulo

D25495: Fix Sonnet autodetect failing on Indian langs

dfaure added inline comments. INLINE COMMENTS > test_autodetect.cpp:39 > + > +/* These tests will fail if you dont have the respective dictionary > installed. > + * They will also fail if the dictionary file name is different from > 'correct_lang' Is there an explicit way to check

D25495: Fix Sonnet autodetect failing on Indian langs

dfaure added a comment. The new unittest doesn't pass in CI. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/sonnet/job/kf5-qt5%20SUSEQt5.12/87/testReport/junit/projectroot/autotests/sonnet_test_autodetect/ Please have a look and submit fixes. REPOSITORY

D27883: Register spawned applications as an independent cgroups

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. It would be good to add a link to the spec as a code comment -- but I see that the docu isn't merged yet, so can't be done yet. INLINE COMMENTS > kprocessrunner.cpp:43 > + > +#include >

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

dfaure updated this revision to Diff 78407. dfaure added a comment. Add setDesktopName(), excellent idea by davidedmundson. Fix API docs, fix copyright years, fix "do terminate" comment. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28201?vs=78222=78407

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

dfaure added a comment. QMimeDatabase was modeled after QFontDatabase, so it's not surprising that they both work the same way ;) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc:

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28193#633829 , @dfaure wrote: > I don't think this makes any difference, they all share the same underlying private singleton. > So all this does is to use a tiny bit more

D28258: [TimeEstimator] Correct batch size, remove config reference

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Using a fixed batch size is wrong, as the contentIndexer may process smaller

D28229: [FileIndexScheduler] Emit change to LowPowerIdle state

This revision was automatically updated to reflect the committed changes. Closed by commit R293:cd446460b989: [FileIndexScheduler] Emit change to LowPowerIdle state (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28229?vs=78319=78403

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kfontchooserdialog.cpp:97 > hmmm. dfaure knows more about exec() and event loops more than me. > @dfaure WDYT? The theoretical answer is yes, this would crash. But note that the user cannot just close the application by

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

dfaure added a comment. I don't think this makes any difference, they all share the same underlying private singleton. So all this does is to use a tiny bit more memory while the widget is up (the member var). The additional CPU usage without this patch or the additional memory usage

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked an inline comment as done. meven added a comment. Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/ I like it a lot more, this adds quite a lot of type safety. REPOSITORY R241 KIO BRANCH

D28223: Add "Stat" prefix to StatDetails Enum entries

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28223 To: meven, #frameworks, kossebau, dfaure Cc: davidre, broulik, kde-frameworks-devel,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

dfaure added a comment. OK, I looked at the code more closely and I see now that on different partitions it will still show the menu, rather than make any assumptions. This still creates a risk for surprises, as to whether the menu will appear or not (on Windows one can look at two

D25660: Decouple KBookmarksMenu from KActionCollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:0c888e2f8098: Decouple KBookmarksMenu from KActionCollection (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25660?vs=73666=78402#toc REPOSITORY R294 KBookmarks

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in statjob.cpp:106 > This is a weird way of doing this. > > A C-style enum is used like KIO::StatBasic. > Here you're using the C++11-class-enum syntax on a C-style enum, which I'm > not sure

D28223: Add "Stat" prefix to StatDetails Enum entries

meven updated this revision to Diff 78401. meven added a comment. Properly use KIO::Stat* as C-style enum REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78301=78401 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28223 AFFECTED FILES

D28221: Don't write default value to configuration file when default value came from /etc/* file

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Note that the docu for KConfigGroup::hasDefault has this logic too: if ( (value == computedDefault) && !group.hasDefault(key) ) group.revertToDefault(key); else

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 104 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 19:48:27 + Build duration: 6 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 71 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/71/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 24 Mar 2020 19:48:27 + Build duration: 5 min 4 sec and counting JUnit Tests Name:

D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6136a9742626: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 2 (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH fixtr_thread_tests REVISION DETAIL https://phabricator.kde.org/D28253 To: kossebau, #frameworks, #build_system, dfaure Cc:

D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH

D28223: Add "Stat" prefix to StatDetails Enum entries

dfaure added inline comments. INLINE COMMENTS > statjob.cpp:106 > { > -KIO::StatDetails detailsFlag = KIO::StatDetail::Basic; > +KIO::StatDetails detailsFlag = KIO::StatDetail::StatBasic; > if (details > 0) { This is a weird way of doing this. A C-style enum is used like

D28245: [xdgoutput] Only send initial name and description if set

davidedmundson added a comment. > (a) Revert the recent xdg-output patches and land them in KF 5.70 or later. (Plasma 5.19 is going to depend on KF 5.70) That doesn't fix anything at all REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28245 To:

D28245: [xdgoutput] Only send initial name and description if set

zzag added a comment. In D28245#633649 , @davidedmundson wrote: > I interpreted the spec the same way when I wrote this...but we don't have a choice. I think we do. (a) Revert the recent xdg-output patches and land them in KF 5.70

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir updated this revision to Diff 78383. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Verbatim REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28193?vs=78266=78383 BRANCH l-kfontchooser-2 (branched from

D27873: sftp: do not show creation time when we do not know it

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns, kde-frameworks-devel, kfm-devel, nikolaik, pberestov,

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir reclaimed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27873: sftp: do not show creation time when we do not know it

bruns added a comment. Looks ok now. Should be followed up by a corresponding change for ACCESS_TIME/MODIFICATION_TIME - both are optional as well. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns,

D28191: [KFontChooser] General code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R236:f22c1864f5c8: [KFontChooser] General code cleanup (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78376=78382 REVISION

D28246: [KFontChooser] Use one QFontDatabase object for the Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28246 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28193: [KFontChooser] Use one QFontDatabase object for the ::Private class

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28193 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28246: [KFontChooser] Use one QFontDatabase object for the Private class

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, apol, bport, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Minor optimisation by instantiating one QFontDatabase Object, and using it in

Re: Problems in KWayland causes by API and ABI compatibility promises

There's another problem we're going to hit with kwayland at some point in the future. KWayland specifies the protocol version. This means, according to framework policies we might have a released kwin which suddenly gets a new protocol version of something being announced. I just had a near miss

D28191: [KFontChooser] General code cleanup

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser (branched from master) REVISION DETAIL https://phabricator.kde.org/D28191 To: ahmadsamir, #frameworks, cfeck, apol, bport, dfaure Cc: kde-frameworks-devel,

D28245: [xdgoutput] Only send initial name and description if set

davidedmundson added a comment. I interpreted the spec the same way when I wrote this...but we don't have a choice. > I believe it might be a problem From a QtWayland POV it's fine at least. > We should remove these ifs in KF 5.70. Why then? Removing them then would

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 16:38:56 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 16:38:57 + Build duration: 10 min and counting BUILD ARTIFACTS

D28245: [xdgoutput] Only send initial name and description if set

zzag added a comment. The spec says that `name` and `description` events will be sent after the `xdg-output` is created. I believe it might be a problem. We should remove these `if`s in KF 5.70. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28245 To:

D28245: [xdgoutput] Only send initial name and description if set

This revision was automatically updated to reflect the committed changes. Closed by commit R127:2b74a0386854: [xdgoutput] Only send initial name and description if set (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28245: [xdgoutput] Only send initial name and description if set

apol accepted this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28245 To: davidedmundson, #kwin, zzag, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28245: [xdgoutput] Only send initial name and description if set

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28245 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28245: [xdgoutput] Only send initial name and description if set

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We hit this if we run an old kwin against new kwayland. Kwin

D28244: GIT_SILENT minor code formatting

ahmadsamir updated this revision to Diff 78377. ahmadsamir added a comment. tweak REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28244?vs=78374=78377 BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78376. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Fix, arcanist is REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28191: [KFontChooser] General code cleanup

ahmadsamir updated this revision to Diff 78375. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Tweak REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28191?vs=78299=78375

D28244: GIT_SILENT minor code formatting

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH l-code-cleanup-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28244

D28220: Switch to using Kirigami's ShadowedRectangle

ahiemstra added inline comments. INLINE COMMENTS > EntryScreenshots.qml:134 > +Kirigami.Theme.colorSet: Kirigami.Theme.View > +shadow.xOffset: 0 > +shadow.yOffset: 0 The x and y offsets should be 0 by default, so there's little reason

<    1   2   3   >