D28328: [Inotify] Remove not-so-OptimizedByteArray

bruns updated this revision to Diff 78608. bruns edited the summary of this revision. bruns added reviewers: Baloo, ngraham. bruns added a comment. summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28328?vs=78607=78608 BRANCH submit REVISION DETAIL

D28328: [Inotify] Remove not-so-OptimizedByteArray

bruns created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28328 AFFECTED FILES

D28325: [Inotify] Call QFile::decode only in a single place

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28325 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28325: [Inotify] Call QFile::decode only in a single place

bruns updated this revision to Diff 78606. bruns added a comment. simplify condition, whitespace REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28325?vs=78601=78606 REVISION DETAIL https://phabricator.kde.org/D28325 AFFECTED FILES src/file/kinotify.cpp

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78605. apol added a comment. Don't leak REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78604=78605 BRANCH arcpatch-D28129 REVISION DETAIL https://phabricator.kde.org/D28129 AFFECTED FILES

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78604. apol marked 3 inline comments as done. apol added a comment. Rebase on top of ksyntaxhighlighting, works great REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78117=78604 BRANCH arcpatch-D28129 REVISION

D28325: [Inotify] Call QFile::decode only in a single place

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28325 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28325: [Inotify] Call QFile::decode only in a single place

bruns added inline comments. INLINE COMMENTS > apol wrote in kinotify.cpp:371 > This conditional looks off, maybe it would make sense to have an intermediate > class to decide when to initialize it? > > Something like this: > > template > class Delayed > { > public: >

D28325: [Inotify] Call QFile::decode only in a single place

apol added inline comments. INLINE COMMENTS > kinotify.cpp:365 > > + // All events which need a decoded path, i.e. everything > + // but EventMoveFrom | EventQueueOverflow | EventIgnored Indentation looks off. > kinotify.cpp:371 > +EventMoveTo | EventOpen | EventUnmount;

D28324: [Inotify] Remove dead/duplicate code

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28324 To: bruns, #baloo, ngraham Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28324: [Inotify] Remove dead/duplicate code

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > pino wrote in kinotify.cpp:350 > ... but only also if wd is < 0 man inotify > IN_Q_OVERFLOW > Event queue overflowed (wd is -1 for this event). REPOSITORY R293 Baloo REVISION DETAIL

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. By the way I looked through the 319 icons. - Some icons actually need fixing in icons/. - The emblem rating is blue in icons-dark/, because it links to another class. We can: - Leave rating in icons-dark/ - Change the light version to be blue too -

D28324: [Inotify] Remove dead/duplicate code

pino added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:350 > First check is here ... but only also if wd is < 0 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28324 To: bruns, #baloo, ngraham Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs,

D28324: [Inotify] Remove dead/duplicate code

bruns added inline comments. INLINE COMMENTS > kinotify.cpp:350 > } > > // the event name only contains an interesting value if we get an > event for a file/folder inside First check is here REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28324 To:

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. I have to take some short notes here. I have written a .sed script which we can use to convert icons/ files to icons-dark/ files. It does the same substitutions as my perl script above, but matches only in the stylesheet. That means, fixed colors will not be

D28327: [Inotify] Start the MoveFrom expire timer at most once per inotify batch

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY We may get several MoveFrom/MoveTo events per read. If we are lucky, we get

D28326: [UnindexedFileIndexer] Only mark file for content indexing when needed

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the index level is set to "non content indexing", the file was still

D28325: [Inotify] Call QFile::decode only in a single place

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Most events need a decoded path, so move it to the front. As only one flag

D28324: [Inotify] Remove dead/duplicate code

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY event->mask & EventQueueOverflow is already checked once early in the

D28323: Fix some stylesheet colors in 2 icon files

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This fixes two tiny inconsistencies in existing icon files in icons/. In the

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

dfaure added a comment. Interestingly, D28268 is also about executing a KServiceAction, but I cannot port it to this API, because the KService::Ptr is not known in that (public) method. The caller, KFileItemActions, knows it so it could pass it to a new

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

dfaure added a task: T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28201 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: ahmadsamir, kde-frameworks-devel,

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove,

D28033: Create ExpandableListItem

ngraham added a comment. Ready for re-review. @davidedmundson REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel,

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 78593. ngraham added a comment. Add new properties `defaultActionButtonVisible` and `subtitleColor`, used in the device notifier REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78324=78593

D28307: Fix build of KGantt

This revision was automatically updated to reflect the committed changes. Closed by commit R478:0fd515542b7c: Fix build of KGantt (authored by apol). REPOSITORY R478 KDiagram: Libraries for diagrams CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28307?vs=78548=78583 REVISION DETAIL

D28203: Move corner fold to top right in 24 icons

ngraham added a comment. Oh, you don't have one yet? That's surprising to me! You've submitted a ton of great stuff. You should apply for one and list me as the sponsor. :) https://community.kde.org/Infrastructure/Get_a_Developer_Account REPOSITORY R266 Breeze Icons BRANCH

D28307: Fix build of KGantt

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R478 KDiagram: Libraries for diagrams BRANCH master REVISION DETAIL https://phabricator.kde.org/D28307 To: apol, #frameworks, danders Cc: danders

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. I would need a developer account to land this. Same for D27983 I assume? REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis,

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooserdialog.cpp:97 > The theoretical answer is yes, this would crash. But note that the user > cannot just close the application by clicking somewhere while a modal dialog > is up. This requires much more subtle

D28312: Implement urls using hints

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Set the hint directly in KNotification instead of the

D28303: LaTeX: fix math parentheses in optional labels

This revision was automatically updated to reflect the committed changes. Closed by commit R216:213d4bb197a3: LaTeX: fix math parentheses in optional labels (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28303: LaTeX: fix math parentheses in optional labels

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix + regression test! REPOSITORY R216 Syntax Highlighting BRANCH update-latex REVISION DETAIL https://phabricator.kde.org/D28303 To: nibags,

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:153-154 > +{ > +for (auto r : d->resourceMap()) > +d->send_commit_state(r->handle, serial); > +} I don't understand why we need `resourceMap()` here. zwp_input_method_context_v1 is not a global so I would

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 80 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/80/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 26 Mar 2020 14:53:25 + Build duration: 17 min and counting BUILD ARTIFACTS

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78557. apol added a comment. vlad++ REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78553=78557 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:128 > +{ > +wl_resource_destroy(resource->handle); > +if (resourceMap().isEmpty()) Don't call wl_resource_destroy() in foobar_destroy_resource(), it's dangerous. void

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 120 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Mar 2020 14:53:25 + Build duration: 6 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 26 Mar 2020 14:53:24 + Build duration: 5 min 12 sec and counting JUnit Tests Name:

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78553. apol added a comment. forgot to save the file REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78549=78553 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES

D28309: Remove cppcheck from kwayland

This revision was automatically updated to reflect the committed changes. Closed by commit R127:665dc779c668: Remove cppcheck from kwayland (authored by apol). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28309?vs=78550=78552 REVISION DETAIL

D27660: Add Inno Setup syntax, including embedded Pascal scripting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:517dccc95ecf: Add Inno Setup syntax, including embedded Pascal scripting (authored by zrax, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28309: Remove cppcheck from kwayland

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28309 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27660: Add Inno Setup syntax, including embedded Pascal scripting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Cool +1 ;=) Thanks for the contribution. We use that at company, nice to have. REPOSITORY R216 Syntax Highlighting BRANCH innosetup (branched from master) REVISION DETAIL

D28309: Remove cppcheck from kwayland

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Like we did on kwin, it doesn't work. TEST PLAN This very patch REPOSITORY R127

D27338: Provide an initial implementation for input-method-unstable-v1

apol marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78549. apol added a comment. address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78515=78549 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES

D28307: Fix build of KGantt

apol updated this revision to Diff 78548. apol added a comment. Address @danders comment REPOSITORY R478 KDiagram: Libraries for diagrams CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28307?vs=78543=78548 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28307

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

davidedmundson added a comment. T11549 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28201 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

davidedmundson added a comment. > Do we have a kf6 workboard entry for this effort? T12163 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28201 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: ahmadsamir,

D28307: Fix build of KGantt

danders added a comment. Ummpf, my mistake, it is the GraphicsItem that needs exporting. REPOSITORY R478 KDiagram: Libraries for diagrams REVISION DETAIL https://phabricator.kde.org/D28307 To: apol, #frameworks Cc: danders

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

This revision was automatically updated to reflect the committed changes. Closed by commit R238:c2e0be30f87f: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles (authored by yurchor). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D28304 To: yurchor, #documentation, danders Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad,

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

yurchor updated this revision to Diff 78544. yurchor added a comment. Fixed definitions as suggested. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28304?vs=78537=78544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28304 AFFECTED

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

danders added a comment. I got the best result (imho) with this: div.sect3 h4 { font-size: 100%; font-weight: bold; } div.sect4 h5 { font-size: 100%; font-weight: bold; } div.sect5 h6 { font-size: 90%; font-style: italic; } Note the

D28307: Fix build of KGantt

apol created this revision. apol added a reviewer: Frameworks. apol requested review of this revision. REVISION SUMMARY My compiler doesn't like exporting namespaces. TEST PLAN Builds now REPOSITORY R478 KDiagram: Libraries for diagrams BRANCH master REVISION DETAIL

D27660: Add Inno Setup syntax, including embedded Pascal scripting

nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27660 To: zrax, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

yurchor edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D28304 To: yurchor, #documentation, danders Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

broulik added a comment. Do we have a kf6 workboard entry for this effort? I think we should also have a replacement job for `new KRun(url)` and I'd love if we could split out the "default app for this mimetype" logic we (also?) have in `KFileItemActions` out into a dedicated public class.

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

yurchor created this revision. yurchor added reviewers: Documentation, danders. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY Now the titles are small and hard to

D28303: LaTeX: fix math parentheses in optional labels

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, jpoelen. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 418979

D28302: [KNewFileMenu] Add extension to proposed filename

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Using "create new" text or html file, add the extension to the proposed filename, this makes those plain text

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. In D28161#634955 , @sitter wrote: > In D28161#634951 , @ahmadsamir wrote: > > > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here ->

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. In D28161#634951 , @ahmadsamir wrote: > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client > > That's confusing; but OK, I'll

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir updated this revision to Diff 78528. ahmadsamir added a comment. Leave out kdsoap-ws-discovery-client, it's maintained somewhere else... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28161?vs=78090=78528 BRANCH l-QRE (branched from

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. In D28161#634949 , @sitter wrote: > Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Unit tests are indeed useful... > Please don't

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#633820 , @dfaure wrote: > Implementation note: the fastest way to know if two items are on the same partition is to compare KIO::UDSEntry::UDS_DEVICE_ID values. But unfortunately it looks like this code takes

D28298: Reduce superfluous changedEntriesChanged emissions

broulik added a comment. Hmm, when doing this, Qt suddenly refuses to pass the entries through to a `QQmlListReference` REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28298 To: broulik, #frameworks, leinir, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack,

D28298: Reduce superfluous changedEntriesChanged emissions

broulik edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28298 To: broulik, #frameworks, leinir, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28298: Reduce superfluous changedEntriesChanged emissions

broulik created this revision. broulik added reviewers: Frameworks, leinir, ahiemstra. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY For some reason I couldn't entirely get behind,

D28295: Introduce KNotificationJobUiDelegate

broulik created this revision. broulik added reviewers: Frameworks, nicolasfella, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can be used for job error reporting using

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4f5503644aa6: [ApplicationLauncherJob] Add way to launch KServiceAction (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28285?vs=78470=78518

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:128-129 > +wl_resource_destroy(resource->handle); > +if (resourceMap().isEmpty()) > +q->deleteLater(); > +} Destroy `q` in zwp_input_method_context_v1_destroy_resource(). In the destructor