D17816: Support for xattrs on kio copy/move

cochise marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika,

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 78776. cochise added a comment. Camel case REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=78773=78776 BRANCH arcpatch-D17816_1 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES

D28396: [MTimeDB] Consolidate time interval handling code

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There are two places where half-bounded time intervals with [<=,<,==,>,>=]

D17816: Support for xattrs on kio copy/move

usta requested changes to this revision. usta added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:500 > + > +QProcess xattrwriter; > +xattrwriter.setProcessChannelMode(QProcess::MergedChannels); aren't we using camelcase rules for

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ndavis added a comment. In T12855#224570 , @davidhurka wrote: > Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it

D28391: [pc3/busyindicator] Hide when not running

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH running REVISION DETAIL https://phabricator.kde.org/D28391 To: nicolasfella, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 78773. cochise marked an inline comment as done. cochise added a comment. missed cast REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=78769=78773 BRANCH arcpatch-D17816_1 REVISION DETAIL

D17816: Support for xattrs on kio copy/move

cochise marked an inline comment as done. cochise added a comment. done REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho,

D17816: Support for xattrs on kio copy/move

bruns added inline comments. INLINE COMMENTS > jobtest.cpp:105 > + / > +m_getXattrCmd = > QStandardPaths::findExecutable("getfattr").split("/").last(); > +if (m_getXattrCmd == "getfattr") { Whats the reason to split off the path? Also, you can not just concatenate the command

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#637038 , @dfaure wrote: > Indeed. Bug in kio_file, fixed in D28388 . Ok, it works for symlinks now. How about normal files in a KDE Connect's mountpoint? It still

D28393: [Term] Provide toString(Term) overload for QTest

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Without the overload QTest only provides the generic "Compared values are

D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN ctest -V -R advancedqueryparsertest REPOSITORY R293 Baloo BRANCH submit

D28392: [ResultIterator] Remove unneeded SearchStore forward declaration

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY SearchStore is not even exported, while ResultIterator is. REPOSITORY R293

D17816: Support for xattrs on kio copy/move

cochise marked an inline comment as done. cochise added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:179 > Ah, I see, you still need to call `strlen()` yourself, for the code at the > end of the iteration > > Well, then you might as well pass the value to the

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 78769. cochise added a comment. Simplify. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=78767=78769 BRANCH arcpatch-D17816_1 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 00:07:10 + Build duration: 49 sec and counting JUnit Tests Name:

D17816: Support for xattrs on kio copy/move

dfaure added inline comments. INLINE COMMENTS > file_unix.cpp:179 > +keyLen = strlen(keyPtr); > +QByteArray key(keyPtr); > +#elif HAVE_SYS_EXTATTR_H Ah, I see, you still need to call `strlen()` yourself, for the code at the end of the iteration Well, then you might as well

D17816: Support for xattrs on kio copy/move

cochise added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:184 > You're doing two copies here. From `offset` to `key.data()`, and then from > `key.data()` -- the return value of qstrcpy -- into the QByteArray key (which > calls the QByteArray(const char*) constructor). > >

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 28 Mar 2020 23:48:24 + Build duration: 56 sec and counting JUnit Tests Name:

D28391: [pc3/busyindicator] Hide when not running

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When not running the indicator should be invisible. This matches the

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 78767. cochise marked 6 inline comments as done. cochise added a comment. Move away from strcpy =] REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=78763=78767 BRANCH arcpatch-D17816_1 REVISION DETAIL

D17816: Support for xattrs on kio copy/move

dfaure added a comment. Almost there ;) INLINE COMMENTS > file_unix.cpp:140 > +{ > +// Get the size of the list of keys from soure file > +#if HAVE_SYS_XATTR_H && !defined(__stub_getxattr) && !defined(Q_OS_MAC) typo: soure => source > file_unix.cpp:153 > +if (listlen == 0) { > +

D28390: KIO: remove waitForStarted() from the launcher jobs public API

dfaure created this revision. dfaure added reviewers: davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This only exists for KRun. I don't want apps to start using that. We

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

dfaure added a reviewer: meven. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28388 To: dfaure, trmdi, ahmadsamir, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

dfaure created this revision. dfaure added reviewers: trmdi, ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This was inconsistent, for everything else we follow symlinks, unless

D27951: Allow users to change dropAction to MoveAction through kdeglobals

dfaure added a comment. Indeed. Bug in kio_file, fixed in D28388 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: elvisangelaccio, davidedmundson, meven,

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 78763. cochise marked an inline comment as done. cochise added a comment. trailing space REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=78760=78763 BRANCH arcpatch-D17816_1 REVISION DETAIL

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#636980 , @dfaure wrote: > Seems to work for symlinks here. We *don't* want it to follow symlinks, right? > > I have /opt a symlink to /d/opt, where /d is on another partition > > $ kioclient5

D17816: Support for xattrs on kio copy/move

cochise marked 3 inline comments as done. cochise added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:183 > What's the purpose of these two lines modifying `key`, given that the next > line assigns to `key` anyway? Removed clear, as is redundant. REPOSITORY R241 KIO

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 78760. cochise added a comment. Using a STL-style iterator for keyList and qstrcpy and qtrncpy to get each key value. Small fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=77962=78760 BRANCH

D28387: [QueryTest] Make phrase test case data driven and extend

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Check if also filenames are matched by phrase queries. Add toString debug

D27951: Allow users to change dropAction to MoveAction through kdeglobals

dfaure added a comment. Seems to work for symlinks here. We *don't* want it to follow symlinks, right? I have /opt a symlink to /d/opt, where /d is on another partition $ kioclient5 openProperties /opt DEVICE 65025 $ kioclient5 openProperties /d/opt DEVICE 65028

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham resigned from this revision. ngraham added a comment. Maybe it was that darned plasma cache! Re-applying the patch and clearing the cache substantially improved the appearance. It would be helpful to remind people of those details in the Test Plan section in the future. :)

D28384: [Extractor] Delay mimetype check, cleanup debug output

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a file is skipped by a name filter there is no need to determine the

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#636646 , @dfaure wrote: > Note sure how you're testing UDS_* but you need to pass KIO::StatInode to KIO::statDetails for inode and device ID to be filled in. > > Testcase: apply

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove marked an inline comment as done. niccolove added inline comments. INLINE COMMENTS > davidedmundson wrote in PlasmoidHeading.qml:77 > What should happen if this is set to merged and someone uses a theme that > doesn't have a merged- prefix? > > The old SVG or no SVG at all? I'd go

D28302: [KNewFileMenu] Add extension to proposed filename

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ad0bbeebc568: [KNewFileMenu] Add extension to proposed filename (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28302?vs=78731=78743 REVISION

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove updated this revision to Diff 78742. niccolove added a comment. Specified false by default REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=78721=78742 BRANCH merged-plasmoidheading (branched from master) REVISION

D28302: [KNewFileMenu] Add extension to proposed filename

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-template-proposed-file-name-ext (branched from master) REVISION DETAIL https://phabricator.kde.org/D28302 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n,

D27245: Ki18n: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R249:10971279a3e7: Ki18n: Convert license headers to SPDX statements (authored by cordlandwehr). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75592=78740

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr, cgiboudeaux Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert copyright headers to SPDX expressions and add license texts as required by REUSE specification.

D28372: Added a merged look to the plasmoidheading and remove roundedborders

davidedmundson added inline comments. INLINE COMMENTS > PlasmoidHeading.qml:58 > + * If false, the plasmoidheading will display a separator. If true, it > will be considered merged > + * with another plasmoidheading and the separator won't be showed. > + */ Worth writing "the

D27741: KCodecs: Convert license statements to SPDX expressions

This revision was automatically updated to reflect the committed changes. cordlandwehr marked an inline comment as done. Closed by commit R270:25365771652b: KCodecs: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE

D28203: Move corner fold to top right in 24 icons

davidhurka requested review of this revision. davidhurka added a comment. One potentially important thing: See inline comment. INLINE COMMENTS > filename-title-amarok.svg:8 > +} > +.ColorScheme-ButtonFocus { > +color:#3daee9; I realized that

D28302: [KNewFileMenu] Add extension to proposed filename

ahmadsamir updated this revision to Diff 78731. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. - Fix unit test - Handle the case that a templatePath is a file with no extension REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28372 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove retitled this revision from "Added a merged look to the plasmoidheading" to "Added a merged look to the plasmoidheading and remove roundedborders". niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28372: Added a merged look to the plasmoidheading

niccolove updated this revision to Diff 78721. niccolove added a comment. Removed rounded borders and thus the enabledBorders check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=78719=78721 BRANCH merged-plasmoidheading

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f5d5390f32d2: [KOpenWithDialog] Add generic name from .desktop files as a tooltip (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kopenwith-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/D28371 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28372: Added a merged look to the plasmoidheading

niccolove planned changes to this revision. niccolove added a comment. The rounding in the svgs is not necessary. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28372 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28372: Added a merged look to the plasmoidheading

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Added a merged look (without a separator) so that multiple plasmoidheadings can be visually merged (e.g.: in

D28302: [KNewFileMenu] Add extension to proposed filename

dfaure added inline comments. INLINE COMMENTS > knewfilemenu.cpp:467 > text = text.trimmed(); // In some languages, there is a space in front > of "...", see bug 268895 > +// add the extension but also use the translations from "Name=" entry, > +// should work with .txt, .html and

D28371: [KOpenWithDialog] Add generic name from .desktop files as a tooltip

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Extend the current setup by adding a tooltip based on the generic name entry from the .desktop files. This

D28302: [KNewFileMenu] Add extension to proposed filename

ahmadsamir updated this revision to Diff 78717. ahmadsamir added a comment. - Change it as suggested by dfaure to use the translated text from Name= entry - Fix typos REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28302?vs=78535=78717 BRANCH

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

dfaure added a comment. In D28201#635026 , @broulik wrote: > I think we should also have a replacement job for `new KRun(url)` Yes, these launcher jobs are the building blocks for finally being able to turn KRun into a job

D28302: [KNewFileMenu] Add extension to proposed filename

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for all your work, I'm impressed! INLINE COMMENTS > knewfilemenu.cpp:464 > +// Prompt the user to set the destination filename, and initially display > +// the

D28295: Introduce KNotificationJobUiDelegate

kossebau added inline comments. INLINE COMMENTS > knotificationjobuidelegate.h:58 > +class Private; > +Private *const d; > +}; Using QScopedPointer or std::unique_ptr instead of raw pointer also avoids need to manually delete in destructor, also better practice these days. REPOSITORY

D27951: Allow users to change dropAction to MoveAction through kdeglobals

dfaure added a comment. Note sure how you're testing UDS_* but you need to pass KIO::StatInode to KIO::statDetails for inode and device ID to be filled in. Testcase: apply http://www.davidfaure.fr/2020/uds_device_test.diff then `kioclient5 openProperties ~/.bashrc` REPOSITORY R241

D28295: Introduce KNotificationJobUiDelegate

kossebau added inline comments. INLINE COMMENTS > knotificationjobuidelegate.cpp:24 > + > +class Q_DECL_HIDDEN KNotificationJobUiDelegate::Private > +{ Not using a nested class `Private` but a normal separate one like here to be named `KNotificationJobUiDelegatePrivate` seems more simple,

D28295: Introduce KNotificationJobUiDelegate

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Indeed missing @since 5.69 To get the description, just connect to the `description` signal and store it, until the time you need to show the error? INLINE COMMENTS >

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 503 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/503/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 28 Mar 2020 09:05:03 + Build duration: 11 min and counting BUILD ARTIFACTS

D25315: KDirModel: implement showing a root node for the requested URL

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:78329e2eb60d: KDirModel: implement showing a root node for the requested URL (authored by dfaure). CHANGED PRIOR TO

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

catherinez added a comment. Could someone commit this, please? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin, davidedmundson Cc: davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28362: Fix stylesheet linking in 8 icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:1bbf2a546894: Fix stylesheet linking in 8 icons (authored by davidhurka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28362: Fix stylesheet linking in 8 icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362 To: davidhurka, ndavis Cc: ndavis, kde-frameworks-devel,