D29814: Fix segfault on no restart args

jpalecek added a comment. In D29814#674013 , @dfaure wrote: > I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled?? > > Also, it sounds like a null check might be

D17816: Support for xattrs on kio copy/move

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:487 > +attrs["user.fattr.with.a.lot.of.namespaces"] = "true"; > +attrs["user.name with space"] = "value with spaces"; > +return attrs;

D29814: Fix segfault on no restart args

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled?? Also, it sounds like a null check might be

D29810: Don't use the setenv function after fork

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack,

D29809: Don't invoke qstring localized stuff in critical section

dfaure added a comment. Makes sense; just two minor things. INLINE COMMENTS > kcrash.cpp:95 > +#ifdef Q_OS_LINUX > +QByteArray socketpath; > +#endif prepend `static`, it's only used in this file. > kcrash.cpp:662 > > -// Create socket path to transfer ptrace scope and open

D17816: Support for xattrs on kio copy/move

arrowd marked an inline comment as done. arrowd added a comment. Mark stale command as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck,

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83166. arrowd marked an inline comment as done. arrowd added a comment. - Use std::function to store a generator function for m_setXattrCmd's arguments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83143=83166

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/21/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 27 May 2020 18:04:25 + Build duration: 3 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/98/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 May 2020 18:04:25 + Build duration: 3 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/22/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 27 May 2020 18:04:25 + Build duration: 1 min 34 sec and counting JUnit Tests Name:

D29461: Fix kio-extras build on Windows

brute4s99 closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/20/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 27 May 2020 14:16:28 + Build duration: 1 min 24 sec and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/29/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 27 May 2020 11:26:08 + Build duration: 1 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/20/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 27 May 2020 07:48:45 + Build duration: 2 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/97/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 May 2020 07:48:45 + Build duration: 1 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 27 May 2020 07:48:45 + Build duration: 1 min 24 sec and counting JUnit Tests Name:

D29050: KRunner fix prepare/teardown signals

alex closed this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot,