arrowd added inline comments.
INLINE COMMENTS
> dfaure wrote in ConfigureChecks.cmake:12
> Ah, I see, OK. No extra lib needed makes it simple.
>
> The FindACL.cmake stuff is a bit of a mess now, with the need for extended
> attributes outside the ACL related code.
> Maybe this could be split
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.15/24/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Fri, 30 Oct 2020 04:48:51 +
Build duration:
11 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/84/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Fri, 30 Oct 2020 01:17:22 +
Build duration:
2 min 30 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/280/
Project:
kf5-qt5 SUSEQt5.15
Date of build:
Thu, 29 Oct 2020 22:28:36 +
Build duration:
16 min and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/284/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 29 Oct 2020 22:28:36 +
Build duration:
15 min and counting
JUnit Tests
Name: projectroot
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/970/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 29 Oct 2020 22:28:36 +
Build duration:
9 min 30 sec and counting
BUILD ARTIFACTS
ngraham added a comment.
Phabricator didn't actually close the revision after I landed it because
@bruns forgot to change his status to accepted. You can close this now,
@arrowd. Great work!
REVISION DETAIL
https://phabricator.kde.org/D17816
To: arrowd, dfaure, chinmoyr, bruns,
ngraham added a comment.
After almost two years, I'm so happy to see this land!
REVISION DETAIL
https://phabricator.kde.org/D17816
To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann,
dfaure accepted this revision.
dfaure added inline comments.
INLINE COMMENTS
> arrowd wrote in ConfigureChecks.cmake:12
> > Has this been tested on a system with sys/extattr.h?
>
> I was working on this revision on such system all the time. FreeBSD contains
> extattr bits in its `libc`, so no
arrowd added inline comments.
INLINE COMMENTS
> dfaure wrote in ConfigureChecks.cmake:12
> This is already done by `cmake/FindACL.cmake`, why not add the other one
> (extattr.h) to that file as well?
>
> The CMakeLists.txt in this directory calls `find_package(ACL)` so it'll be
> used.
>
>
arrowd updated this revision to Diff 83375.
arrowd marked an inline comment as done.
arrowd added a comment.
- Put FileProtocol::copyXattrs inside a #if
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17816?vs=83366=83375
BRANCH
arcpatch-D17816
REVISION DETAIL
The future is nearly here so I've updated the Frameworks release schedule
for 2021 based on the same first + second saturday of the month formula.
https://community.kde.org/Schedules/Frameworks
https://phabricator.kde.org/calendar/
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/140/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 29 Oct 2020 15:14:01 +
Build duration:
2 min 56 sec and counting
BUILD ARTIFACTS
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.15/31/
Project:
kf5-qt5 SUSEQt5.15
Date of build:
Thu, 29 Oct 2020 15:14:01 +
Build duration:
2 min 55 sec and counting
BUILD ARTIFACTS
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.15/32/
Project:
kf5-qt5 FreeBSDQt5.15
Date of build:
Thu, 29 Oct 2020 15:14:01 +
Build duration:
2 min 28 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.15/8/
Project:
kf5-qt5 WindowsMSVCQt5.15
Date of build:
Thu, 29 Oct 2020 15:14:01 +
Build duration:
2 min 32 sec and counting
JUnit Tests
16 matches
Mail list logo
