arrowd added inline comments. INLINE COMMENTS
> dfaure wrote in ConfigureChecks.cmake:12 > This is already done by `cmake/FindACL.cmake`, why not add the other one > (extattr.h) to that file as well? > > The CMakeLists.txt in this directory calls `find_package(ACL)` so it'll be > used. > > Even though this isn't technically about ACLs, I'm guessing it all links > *because* FindACL.cmake links to libattr, right? > And then this might also mean that the condition in FindACL.cmake needs to be > updated, it currently *requires* HAVE_SYS_XATTR_H instead of allowing both > variants. > > But then I guess this means kpropertiesdialog.cpp needs to be ported to the > sys/extattr.h API. > > Has this been tested on a system with sys/extattr.h? I'm wondering if what > will happen is: FindACL didn't find sys/attr.h so it doesn't link to libattr, > and then the new code here fails to link. Or am I missing something? > Has this been tested on a system with sys/extattr.h? I was working on this revision on such system all the time. FreeBSD contains extattr bits in its `libc`, so no extra libraries are required. So, what should be done here, then? Just move `HAVE_SYS_EXTATTR_H` check to `FindACL.cmake` module? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh