Re: KDE Frameworks Release Cycle

2014-04-27 Thread Alex Merry
On 27/04/14 10:51, Kevin Ottens wrote: Hello people, As you may have noticed, we're covering quite a few tasks here during the sprint. But, we're also having discussion topics, and the most important one we covered is the release cycle. Indeed, we got the question several times already

Re: Review Request 117780: Add a FindKF5.cmake module

2014-04-26 Thread Alex Merry
files. Behaviour was as expected in all cases, including the feature summary output. Visually inspected generated documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: Would it be a good idea to start by reverting https://git.reviewboard.kde.org/r/116096/ ? Alex Merry wrote: So we have no unit tests? I don't really see how that would help (except in the strict sense of no unit tests

Infopage in frameworkintegration

2014-04-26 Thread Alex Merry
FrameworkIntegration installs a bunch of images and css files to ${DATA_INSTALL_DIR}/kf5/infopage. LXR suggests nothing ever references an infopage directory (either in kf5-qt5 or in qt4-latest), except for the CMakeLists.txt files in frameworkintegration, and the README.md (which suggests the

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml = metainfo.yaml)

2014-04-26 Thread Alex Merry
). src/kgenframeworksapidox https://git.reviewboard.kde.org/r/117795/#comment39500 Not needed any more src/kgenframeworksapidox https://git.reviewboard.kde.org/r/117795/#comment39501 don't bother checking for README.md any more (this script doesn't care about it). - Alex Merry

Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables

2014-04-25 Thread Alex Merry
. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-25 Thread Alex Merry
ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

2014-04-25 Thread Alex Merry
, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117617: New syntax for ecm_install_icons()

2014-04-25 Thread Alex Merry
of commit) pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-25 Thread Alex Merry
autotests pass. Freshly configured, built and installed KArchive - version header file and KF5ArchiveConfigVersion.cmake correct by inspection. KEmoticons then configured successfully (finding KF5Archive = 4.96.0). Thanks, Alex Merry ___ Kde

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-25 Thread Alex Merry
/entities/install-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

2014-04-25 Thread Alex Merry
Ran kmimeassociationstest directly. It passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

2014-04-25 Thread Alex Merry
(), and Wayland was found both times. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

2014-04-25 Thread Alex Merry
associations for real applications (that may or may not be installed) to test cascading. Diffs - autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117475/diff/ Testing --- Test still passes. Thanks, Alex Merry

Re: Review Request 117581: Remove ECMDBusAddActivationService module

2014-04-25 Thread Alex Merry
, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-25 Thread Alex Merry
/r/11/diff/ Testing --- Unit tests now pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117780: Add a FindKF5.cmake module

2014-04-25 Thread Alex Merry
inspected generated documentation. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117749: Allow kmimeassociationstest to be run alone

2014-04-24 Thread Alex Merry
the sycoca database. Diffs - autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117749/diff/ Testing --- rm -rf ~/.qttest Ran kmimeassociationstest directly. It passes. Thanks, Alex Merry

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

2014-04-24 Thread Alex Merry
. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
-compile.docbook 08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Alex Merry
08561cda904d6110b99de087e4b82e4ddd57ebe7 src/customization/th/entities/install-compile.docbook 6c40e081bc2725a51ec4dc29002f369136607e0f Diff: https://git.reviewboard.kde.org/r/117758/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/#review56118 --- Ship it! Ship It! - Alex Merry On April 21, 2014, 12:06

Re: Review Request 117582: Simplify D-Bus service CMake code

2014-04-21 Thread Alex Merry
://git.reviewboard.kde.org/r/117582/#review56125 --- On April 16, 2014, 10:23 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117677: Fix libintl discovery, especially for Mac

2014-04-21 Thread Alex Merry
the tests in C++, since the usage is in C++, so this looks like a no-brainer change. - Alex Merry On April 21, 2014, 4:01 p.m., Allen Winter wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117582: Simplify D-Bus service CMake code

2014-04-21 Thread Alex Merry
. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117582/#review56129 --- On April 16, 2014, 10:23 a.m., Alex Merry wrote

Re: Update your copy of extra-cmake-modules

2014-04-21 Thread Alex Merry
On 21/04/14 16:26, šumski wrote: On Friday 18 of April 2014 10:37:50 Aurélien Gâteau wrote: ... I made it that way intentionally because I consider it bad to have different code generated depending on whether you have the framework is built from a release tarball or from git. I understand

Re: Review Request 117582: Simplify D-Bus service CMake code

2014-04-21 Thread Alex Merry
, built, installed. Installation step reported that /home/kf5-devel/kf5/share/dbus-1/services/org.kde.kded5.service was Up-to-date. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

2014-04-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117655/#review56134 --- Ship it! Ship It! - Alex Merry On April 21, 2014, 6:35

Re: Review Request 117581: Remove ECMDBusAddActivationService module

2014-04-21 Thread Alex Merry
128482e35f9f15025868f3e283db839556a0ce82 Diff: https://git.reviewboard.kde.org/r/117581/diff/ Testing (updated) --- Built docs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-21 Thread Alex Merry
. Freshly configured, built and installed KArchive - version header file and KF5ArchiveConfigVersion.cmake correct by inspection. KEmoticons then configured successfully (finding KF5Archive = 4.96.0). Thanks, Alex Merry ___ Kde-frameworks-devel mailing

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-21 Thread Alex Merry
--- On April 21, 2014, 9:49 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619

Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

2014-04-20 Thread Alex Merry
/r/117658/diff/ Testing --- Tests pass. Also made a little test that called find_package(Wayland), both using set(CMAKE_MODULE_PATH ${ECM_FIND_MODULE_DIR}) and using ecm_use_find_modules(), and Wayland was found both times. Thanks, Alex Merry

Re: Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

2014-04-19 Thread Alex Merry
analysis of the Qt translation system. modules/ECMQmLoader.cpp.in https://git.reviewboard.kde.org/r/117629/#comment39115 Just from a style point of view, it would be nicer to change the conditional to != and put the loadTranslation calls inside it. - Alex Merry On April 18, 2014, 2:29 p.m

Re: Review Request 117624: Make documentation generation python3 compatible

2014-04-18 Thread Alex Merry
changes to CMake? - Alex Merry On April 18, 2014, 8:29 a.m., Uwe L. Korn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117624

Re: Review Request 117624: Make documentation generation python3 compatible

2014-04-18 Thread Alex Merry
On April 18, 2014, 8:53 a.m., Alex Merry wrote: Thanks! Might you consider submitting similar changes to CMake? Ah, looks like you don't have commit access, so I'll commit it for you. - Alex --- This is an automatically generated e

Re: Review Request 117578: Use ThumbCreator instead of KFilePlugin when querying for thumbnails services

2014-04-18 Thread Alex Merry
the thumbnailer is *providing*, while this block is seeing if it can use an already-existing thumbnailer from the metadata (I think it's supposed to be something extracted by strigi). In fact, I suspect that entire block should go - KFileMetaInfo is in KDELibs4Support. - Alex Merry On April 15

Review Request 117617: New syntax for ecm_install_icons()

2014-04-17 Thread Alex Merry
PRE-CREATION tests/ECMInstallIconsTest/v1-syntax/ox16-categories-system-help.mng PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117617/diff/ Testing --- Tests (included as part of commit) pass. Thanks, Alex Merry ___ Kde-frameworks

Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-17 Thread Alex Merry
and KF5ArchiveConfigVersion.cmake correct by inspection. KEmoticons then configured successfully (finding KF5Archive = 4.96.0). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 117581: Deprecate ecm_dbus_add_activation_service()

2014-04-16 Thread Alex Merry
. Diffs - modules/ECMDBusAddActivationService.cmake 128482e35f9f15025868f3e283db839556a0ce82 Diff: https://git.reviewboard.kde.org/r/117581/diff/ Testing --- Built documentation; built and installed KWallet (one of the two users of this macro). Thanks, Alex Merry

Review Request 117582: Simplify D-Bus service CMake code

2014-04-16 Thread Alex Merry
/org.kde.kded5.service was Up-to-date. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117583: Remove use of ecm_dbus_add_activation_service()

2014-04-16 Thread Alex Merry
--- Configured, built, installed, visually inspected $PREFIX/share/dbus-1/services/org.kde.kwalletd5.service. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117585: ECMFindModuleHelpers: set traditional variables

2014-04-16 Thread Alex Merry
find-modules/FindWayland.cmake b7790e750e8ae9b1c6d5be81b7683b489d60a5a7 Diff: https://git.reviewboard.kde.org/r/117585/diff/ Testing --- Configured, built and installed KWindowSystem and KWin. Thanks, Alex Merry ___ Kde-frameworks-devel mailing

Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

2014-04-16 Thread Alex Merry
bff2961f9a5fe72c84dff4d0ea4466c7693fe00c Diff: https://git.reviewboard.kde.org/r/117593/diff/ Testing --- Configured, built and installed KArchive. Visually inspected installed .pri file. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

2014-04-16 Thread Alex Merry
/ECMCreateQmFromPoFiles.cmake b8f3c651d29bec273834d848de89150829a1c91e Diff: https://git.reviewboard.kde.org/r/117596/diff/ Testing --- Built, ran `make test`. Note to self: ECM needs more unit tests. Thanks, Alex Merry ___ Kde-frameworks

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-16 Thread Alex Merry
d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117475/diff/ Testing --- Test still passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-16 Thread Alex Merry
On April 16, 2014, 4:50 p.m., Commit Hook wrote: This review has been submitted with commit 9bbdd1615b484c229657fd0896b2dbebdea9988d by Alex Merry to branch master. Oops, wrong RR number. - Alex --- This is an automatically

Re: Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

2014-04-16 Thread Alex Merry
variable directly and built it again. Both times, `make VERBOSE=1` showed that ECMQmLoader.cpp was compiled and linked into the executable. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

2014-04-15 Thread Alex Merry
/license notice) to match the style/syntax of the other modules? modules/ECMCreateQmFromPoFiles.cmake https://git.reviewboard.kde.org/r/117560/#comment38864 Some info about where mylib.qm will be looked for would be useful. - Alex Merry On April 14, 2014, 1:18 p.m., Aurélien Gâteau wrote

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

2014-04-15 Thread Alex Merry
https://git.reviewboard.kde.org/r/117560/#comment38875 double-backticks around variable - Alex Merry On April 15, 2014, 3:36 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117485: Add note about Kiosk to docs

2014-04-14 Thread Alex Merry
/kbookmarkmenu.h 017fc96193c04e85e06c161b6becda2bf659d8bf Diff: https://git.reviewboard.kde.org/r/117485/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117487: Add Kiosk documentation

2014-04-14 Thread Alex Merry
f03149ac4fc1d4c0e17f100d413d83f46074de60 src/ktoolbar.h df6132ad349750473afd5544cfb4b66debab4927 Diff: https://git.reviewboard.kde.org/r/117487/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 117488: Improve Kiosk documentation

2014-04-14 Thread Alex Merry
53018e6bff296b99652910e9c0e28b1b7297db61 src/widgets/krun.h 3ded003297ef1ff2c78945b956417ed4f5628ae3 Diff: https://git.reviewboard.kde.org/r/117488/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 117154: Simplify the plugin lookup code

2014-04-14 Thread Alex Merry
://git.reviewboard.kde.org/r/117154/diff/ Testing --- Builds, tests pass and generally seems to work on my Linux machine. Windows stuff completely untested. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Alex Merry
actually work Diffs - find-modules/FindEGL.cmake 765b6692a23486afa36c9c92adad7cb294756a30 Diff: https://git.reviewboard.kde.org/r/117490/diff/ Testing --- Configured and built KWin successfully. Thanks, Alex Merry ___ Kde-frameworks

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-14 Thread Alex Merry
/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review55486 --- On April 1, 2014, 10:09 a.m., Alex Merry wrote

Re: Review Request 117508: KIO metadata: resume - range-start, resume_until - range-end.

2014-04-12 Thread Alex Merry
hit? - Alex Merry On April 12, 2014, 9:55 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508

Re: Review Request 117508: KIO metadata: resume - range-start, resume_until - range-end.

2014-04-12 Thread Alex Merry
On April 12, 2014, 10:11 a.m., Alex Merry wrote: Would it not make sense to put the compatibility stuff in KIO::Job::addMetaData, rather than the slaves? That way it should maintain compatibility on both the application and slave side (for slaves shipped outside KIO). Although

Re: Review Request 117508: KIO metadata: resume - range-start, resume_until - range-end.

2014-04-12 Thread Alex Merry
On April 12, 2014, 10:11 a.m., Alex Merry wrote: Would it not make sense to put the compatibility stuff in KIO::Job::addMetaData, rather than the slaves? That way it should maintain compatibility on both the application and slave side (for slaves shipped outside KIO). Although

Re: Review Request 117508: KIO metadata: resume - range-start, resume_until - range-end.

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/#review55496 --- Ship it! OK, I'm convinced. - Alex Merry On April 12

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-12 Thread Alex Merry
-it without his agreement. - Alex Merry On April 9, 2014, 8:47 a.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-12 Thread Alex Merry
/#comment38614 This should happen even if the env var is used. - Alex Merry On April 9, 2014, 8:47 a.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016

Re: Review Request 117320: Update the kbuildsycoca5 man page

2014-04-12 Thread Alex Merry
. (in other news I started work to get rid of kbuildsycoca completely, but that will take a bit longer) Alex Merry wrote: Users also won't be running this unless someone tells them to. And desktop file system configuration cache suggests it's more general than it is. How about

Re: Review Request 117320: Update the kbuildsycoca5 man page

2014-04-12 Thread Alex Merry
/r/117320/diff/ Testing --- Built and visually inspected the man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: APIDox for Plasma Framework

2014-04-12 Thread Alex Merry
On 12/04/14 12:48, Aleix Pol wrote: Hi, I just realized that we're not generating the API documentation for Plasma Framework here [1]. Maybe it would be worth adding? I think it currently just grabs everything in /frameworks on project.kde.org. Alex

KPluginLoader move

2014-04-12 Thread Alex Merry
Just a heads up that I'm planning to move KPluginLoader, KPluginFactory and kexportplugin.h from KService to KCoreAddons this weekend, as previously discussed (it's SC, as it will involve putting KCoreAddons into the link interface of KService). I have an open review request for KPluginLoader in

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-12 Thread Alex Merry
://git.reviewboard.kde.org/r/117475/diff/ Testing --- Test still passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117330: Update documentation not found docbook

2014-04-12 Thread Alex Merry
--- Builds and installs, although I can't get khelpcenter to display it (tried `khelpcenter help:blah`, but that just displays the string There is no documentation available for /blah.). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 117486: Rewrite kiosk documentation

2014-04-11 Thread Alex Merry
. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55426 --- On April 10, 2014, 6:40 p.m., Alex Merry wrote

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-11 Thread Alex Merry
actually work Diffs (updated) - find-modules/FindEGL.cmake 765b6692a23486afa36c9c92adad7cb294756a30 Diff: https://git.reviewboard.kde.org/r/117490/diff/ Testing --- Configured and built KWin successfully. Thanks, Alex Merry ___ Kde

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-11 Thread Alex Merry
/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing --- Configured and build KWindowSystem successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-11 Thread Alex Merry
/FindX11_XCB.cmake 687a4f3d57f67aa2e35a8bcfe201e0324e84204e Diff: https://git.reviewboard.kde.org/r/117491/diff/ Testing (updated) --- Configured and build KIdleTime successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review55425 --- On April 11, 2014, 8:32 p.m., Alex Merry wrote

Re: KDE(Libs)4Support rename

2014-04-10 Thread Alex Merry
On 10/04/14 06:21, Kevin Ottens wrote: Are there any objections to me pushing this (along with relevant changes - mostly to CMake code and comments - in other repos, of course)? Good to go from my side. The earlier the better for that one. I've got some compatbility CMake code written. I'll

Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-10 Thread Alex Merry
passes. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[kdelibs4support] /: Add a compatibility CMake config file

2014-04-10 Thread Alex Merry
Git commit 7f707a8c28b92b1ad79b31dc74f0978255eaee9a by Alex Merry. Committed on 09/04/2014 at 21:55. Pushed by alexmerry into branch 'master'. Add a compatibility CMake config file This allows projects to continue using find_package(KF5KDE4Suport) and KF5::KDE4Support in CMake files, keeping

Review Request 117485: Add note about Kiosk to docs

2014-04-10 Thread Alex Merry
/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117488: Improve Kiosk documentation

2014-04-10 Thread Alex Merry
: https://git.reviewboard.kde.org/r/117488/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117487: Add Kiosk documentation

2014-04-10 Thread Alex Merry
://git.reviewboard.kde.org/r/117487/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117486: Rewrite kiosk documentation

2014-04-10 Thread Alex Merry
45dd828448be24cf3108a7ef042ca07e4e98d74a src/core/kauthorized.cpp c9b14f5033a9e4aa117b3fd5ba298d85eee65062 Diff: https://git.reviewboard.kde.org/r/117486/diff/ Testing --- Generated and visually inspected apidox. Thanks, Alex Merry ___ Kde-frameworks-devel mailing

Re: How do we want to ship framework translations

2014-04-10 Thread Alex Merry
On 10/04/14 17:06, Aurélien Gâteau wrote: Hi, Until now, kdelibs translations have always been released as part of the kde-l10n-$lang tarballs. I was wondering whether it should still be the case with frameworks, or if each frameworks should instead ship with its own translations. The work

Review Request 117489: Remove the old tutorial

2014-04-10 Thread Alex Merry
/117489/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdeinit5 binary and man page in different repos

2014-04-10 Thread Alex Merry
On 09/04/14 19:08, Michael Palimaka wrote: Hi, I noticed that kdeinit5 is in kinit, and its man page appears to be in kservice. I guess the man page should be moved, but I'm not sure of the best procedure with regards to preserving history etc. I've done this now. Alex

KDE4 references task status

2014-04-10 Thread Alex Merry
Update on the KDE4 references task[0]: This is mostly done. There are some review requests still open, some things for translators to do in kdoctools, a couple of things I've asked David to look at and src/kwrapper/kwrapper_win.cpp in kinit, which needs a Windows person to look at it.

Review Request 117491: Rework FindX11_XCB.cmake

2014-04-10 Thread Alex Merry
/diff/ Testing --- Configured and build KWindowSystem successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117490: Improve FindEGL.cmake

2014-04-10 Thread Alex Merry
Diff: https://git.reviewboard.kde.org/r/117490/diff/ Testing --- Configured and built KWin successfully. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: libmm-qt/libnm-qt as KF5

2014-04-09 Thread Alex Merry
On 08/04/14 23:51, Lamarque Souza wrote: Hi, I understood that, I just do not know all the other things we need to do to make NMQt/MMQt part of KF5. And yes, I agree in making NMQt/MMQt part of KF5. The other doubt I still have is where _kde_add_platform_definitions is defined. By what I

Re: KDE(Libs)4Support rename

2014-04-09 Thread Alex Merry
On 09/04/14 18:38, Aleix Pol wrote: What happens with the cmake side? are we going to have to rename all KF5::KDE4Support for KF5::KDELibs4Support? Yes, that's what the changes I've got queued up require. Alex ___ Kde-frameworks-devel mailing list

Re: kdeinit5 binary and man page in different repos

2014-04-09 Thread Alex Merry
On 09/04/14 19:08, Michael Palimaka wrote: Hi, I noticed that kdeinit5 is in kinit, and its man page appears to be in kservice. I guess the man page should be moved, but I'm not sure of the best procedure with regards to preserving history etc. Huh, so it is. *Adds it to his TODO list*

Re: kdeinit5 binary and man page in different repos

2014-04-09 Thread Alex Merry
On 09/04/14 19:34, Alex Merry wrote: On 09/04/14 19:08, Michael Palimaka wrote: Hi, I noticed that kdeinit5 is in kinit, and its man page appears to be in kservice. I guess the man page should be moved, but I'm not sure of the best procedure with regards to preserving history etc. Huh, so

Re: KDE(Libs)4Support rename

2014-04-09 Thread Alex Merry
On 09/04/14 20:07, Martin Graesslin wrote: On Wednesday 09 April 2014 19:33:20 Alex Merry wrote: On 09/04/14 18:38, Aleix Pol wrote: What happens with the cmake side? are we going to have to rename all KF5::KDE4Support for KF5::KDELibs4Support? Yes, that's what the changes I've got queued up

Re: [kinit] /: Revert Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-04-08 Thread Alex Merry
On 08/04/14 11:09, Alex Merry wrote: Git commit b15084d9316e34462c2508051c6ac89bcf8d77ee by Alex Merry. Committed on 08/04/2014 at 10:06. Pushed by alexmerry into branch 'master'. Revert Replace GPL proctitle code with BSD-licensed code from OpenSSH This reverts commit

Re: Kioslave repos

2014-04-08 Thread Alex Merry
On 08/04/14 12:21, Aleix Pol wrote: Given that premise, would you suggest having kurifilter-plugins in this repository as well? We can have a kio-extras repository with KIO::everything in it. That seems reasonable to me. Alex ___

Re: Kioslave repos

2014-04-08 Thread Alex Merry
On 08/04/14 14:02, Àlex Fiestas wrote: I personally do not want to have those not of interest or unmaintained kiosalves around, I do not want to maintain them, I do not want distros to ship them by default (which will happen for those distros that will pacakge the entire repository) etc.

KDE4 refs in kio and kxmlgui

2014-04-07 Thread Alex Merry
Hi David, Any chance you could look at the last kio and kxmlgui KDE4 TODOs in http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References ? They both need maintainer decisions about whether to attempt to resolve them (at least partially) for KF5, punt them to KF6 or drop

Re: Review Request 117304: Update comment about re-fetching clipboard data.

2014-04-07 Thread Alex Merry
/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117328: Update the docbook

2014-04-07 Thread Alex Merry
f3f859ba14e4e70049b29b87ed8a7487b9136284 Diff: https://git.reviewboard.kde.org/r/117328/diff/ Testing --- Temporarily re-enabled building the docbook, and checked it still built. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Status of the KDE Runtime module splitting

2014-04-07 Thread Alex Merry
On 07/04/14 17:57, Aleix Pol wrote: - kioslaves, kioslaves-extra: I'm waiting to get the respositories, the sysadmin team seems to have some concerns. Discussing it at the moment (when the time zones let us). Question: why two? This means kioslaves split across three repos: kio, kioslaves and

<    1   2   3   4   5   6   7   8   9   10   >