---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
65e75234b1d52e519d34a47bb14521d3b1ed6482
Diff: https://git.reviewboard.kde.org/r/116732/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
59337085e005c9ad93f490e269dfcdcae8628d78
Diff: https://git.reviewboard.kde.org/r/116739/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Fix kdeglobals location in apidox
Diffs
-
src/kcheckaccelerators.h 7ce96430b584543bf853a0595db93c1a0a569e59
Diff: https://git.reviewboard.kde.org/r/116740/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
---
On March 11, 2014, 5 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116729
f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0
Diff: https://git.reviewboard.kde.org/r/116729/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote:
Strange, it works fine here. Which version of CMake are you using and which
repository is failing?
Aurélien Gâteau wrote:
Oh, version is in the request title. /me tests with 2.8.
Aurélien Gâteau wrote:
Just tried with
://git.reviewboard.kde.org/r/116653/diff/
Testing
---
Tested various configurations with a test CMakeLists.txt file, including with
various include files missing.
Configured and built kwindowsystem and kde-workspace.
Thanks,
Alex Merry
___
Kde
://git.reviewboard.kde.org/r/116616/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116639/#review52312
---
Ship it!
Ship It!
- Alex Merry
On March 6, 2014, 3:42 p.m
modules
Diffs (updated)
-
README.md 85b97b7fa003282e1eeb1113c4668a9b73e3f731
docs/writing-find-modules.md PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/116025/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing
On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote:
The problem with doing this in support code is that it is not strictly
source compatible. An example this would break is if you want to embed the
value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
add_definitions
/diff/
Testing
---
Tests build. 3 out of 4 pass.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
. Most tests still pass; note that the non-alpha pic
tests fail without https://git.reviewboard.kde.org/r/116568/diff/ as the wrong
format (ARGB32 instead of RGB32) is constructed.
This should make the xcf tests pass again on Jenkins.
Thanks,
Alex Merry
On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote:
The problem with doing this in support code is that it is not strictly
source compatible. An example this would break is if you want to embed the
value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
add_definitions
* fail. What
shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
- Alex Merry
On March 5, 2014, 9 a.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 5, 2014, 12:31 p.m., Alex Merry wrote:
Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What
shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
I hadn't realised that about pkg_check_modules(), though. I'll have to update
the docs I
.
Repository: extra-cmake-modules
Description
---
Remove unused find-modules back to the attic
Diffs
-
find-modules/FindBlueZ.cmake
find-modules/FindLibUSB1.cmake
Diff: https://git.reviewboard.kde.org/r/116616/diff/
Testing
---
Thanks,
Alex Merry
On March 4, 2014, 12:06 a.m., Aleix Pol Gonzalez wrote:
Ok, I just realized this was being dealt with and I did a different patch:
https://git.reviewboard.kde.org/r/116573/
I think that having UI strings on a header file is quite bad TBH, but since
I see there's consensus I'll
/#comment36905
allows to interact with is bad grammar; allows interaction with would
work, and allows foo to interact with would be better. Maybe clients in
place of foo?
- Alex Merry
On March 4, 2014, 7:49 a.m., Martin Gräßlin wrote
On 02/03/14 18:58, Kevin Ottens wrote:
On Thursday 27 February 2014 17:15:56 John Layt wrote:
I've done the first step, and I just need a volunteer to do the git magic
required to:
* Move kcurrencycode.h and kcurrencycode.cpp including history from
kunitconversion/src to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116568/#review51854
---
On March 3, 2014, 1:15 p.m., Alex Merry wrote
On March 4, 2014, 11:02 a.m., Alex Merry wrote:
README.md, line 9
https://git.reviewboard.kde.org/r/116588/diff/1/?file=251921#file251921line9
allows to interact with is bad grammar; allows interaction with
would work, and allows foo to interact with would be better. Maybe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116588/#review51872
---
Ship it!
Ship It!
- Alex Merry
On March 4, 2014, 12:32
On 03/03/14 11:28, Aaron J. Seigo wrote:
hello,
over the weekend i wrote up a small tool that does what is needed for
libsprinter, which is a Qt5 library (no frameworks deps), to harvest
translations from .desktop files into .json files for inclusion in its
plugins.
one decision i
.
This should make the xcf tests pass again on Jenkins.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/diff/
Testing
---
Builds and tests pass, both with and without
https://git.reviewboard.kde.org/r/116567/ applied.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116566/#review51769
---
Ship it!
Ship It!
- Alex Merry
On March 3, 2014, 12:58
and Alex Merry.
Changes
---
Transfer copyright/license information properly from merged files.
Repository: kimageformats
Description
---
Fixes to PIC image format handler
Better error handling (returns false on error in read() and write()) and
use the correct format
still works. Most tests still pass; note that the non-alpha pic
tests fail without https://git.reviewboard.kde.org/r/116568/diff/ as the wrong
format (ARGB32 instead of RGB32) is constructed.
This should make the xcf tests pass again on Jenkins.
Thanks,
Alex Merry
On March 1, 2014, 4:17 p.m., David Faure wrote:
Hmm, this might be equivalent, but all it means is that the orig code was
wrong.
We should not make any memory allocations within the crash handler.
So we should instead store the startup id as a const char* somewhere and
use
strlcpy.
Unless we can make sure that the call to startupId() will always just
return an existing QByteArray - but looking at the code, this doesn't seem
to be the case.
Alex Merry wrote:
Hrm... I think we're actually querying the wrong place anyway. We should
be asking the xcb
formats)
imagedump something.xcf something.data (dumps data in ARGB32 format)
imagedump something.png something.data (dumps data in ARGB32 format)
imagedump -q RGB32 something.xcf something.data (dumps data in RGB32 format)
All data dumps sanity-checked in Okteta.
Thanks,
Alex Merry
On 01/03/14 09:55, David Faure wrote:
On Tuesday 25 February 2014 20:37:28 Alex Merry wrote:
I've had a look at the kdnssd repositoy, and it contains two related
bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify
KIO about changes to available services.
These two
On 01/03/14 09:57, David Faure wrote:
On Wednesday 26 February 2014 14:36:49 Nicolas Lécureuil wrote:
as there is already a kdnssd tarball for kde 4, i think this would be safer
to keep the -framework in the name.
I can't see how the name of the kde-sc-4 tarballs matter?
This is version 5
to a website.
- Alex Merry
On Feb. 23, 2014, 11 a.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959
for these with a
note saying what QUrl method should be used instead.
Diffs
-
src/kdecore/kurl.h 4ac893382c76def83f8e6e12698931df243085f9
Diff: https://git.reviewboard.kde.org/r/116064/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959/#review51426
---
Ship it!
Ship It!
- Alex Merry
On Feb. 23, 2014, 11 a.m
On March 1, 2014, 11:15 a.m., Alex Merry wrote:
The implementation all looks fine. The only concern I have is that it's an
odd location for it; I wouldn't expect to go looking for a method to invoke
Help in KConfigWidgets. Although I'm not sure where it would go instead,
given
On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote:
have you tried removing the include?
Albert Astals Cid wrote:
Ignore me, there's i18n calls in there :D
Alex Merry wrote:
However, I wonder if those calls should really be in the header. I have
no idea what catalogue
On 27/02/14 13:02, Alex Merry wrote:
On 27/02/14 11:21, John Layt wrote:
On 23 February 2014 20:02, John Layt jl...@kde.org wrote:
2) Copy code from kprintutils to kde4support
- Do we bother to keep the history?
- Where do we put it?
Alex, if you have that git magic I'd appreciate your
as the argv array itself, so
should be fine.
- Alex Merry
On Feb. 26, 2014, 5 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116087
is obviously not what was wanted.
- Alex Merry
On Feb. 26, 2014, 5:03 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116090
: KDEInstallDirs is really
just one more file layout policy, like GNUInstallDirs. I think KDEInstallDirs
makes more sense than GNUInstallDirs for Qt-based code in general, though.
If you're going to use it, though, I suggest using it consistently (eg: for
include files as well).
- Alex Merry
On Feb
On 26/02/14 23:45, T.C. Hollingsworth wrote:
So, perhaps we need a kde-core-docs.git or something like that to
house them in? And advise distros to make sure and add runtime
Requires on it from kdoctools or whereever the help: kioslave is
shipped? (Alternatively we could just include them in
On 27/02/14 11:21, John Layt wrote:
On 23 February 2014 20:02, John Layt jl...@kde.org wrote:
2) Copy code from kprintutils to kde4support
- Do we bother to keep the history?
- Where do we put it?
Alex, if you have that git magic I'd appreciate your doing it, I have
no clue what to do :-)
-
CMakeLists.txt 15b01a0745206cbc761fd3572393ec56753ff2b6
KF5SuConfig.cmake.in 9c2f96e3712490c56fd697b862c5d6a39755402d
Diff: https://git.reviewboard.kde.org/r/115953/diff/
Testing
---
Configures, compiles, installs.
Thanks,
Alex Merry
Git commit 5bebd4332ea137849f2060f12a684551dbc81dc6 by Alex Merry.
Committed on 28/02/2014 at 00:41.
Pushed by alexmerry into branch 'master'.
Relicense solid imports files to LGPLv2.1+
Permission granted by Ivan Čukić.
CCMAIL: ivan.cu...@kde.org
CCMAIL: kde-licens...@kde.org
CCMAIL: kde
4a35879a15992d19378c7e9baa9b206e187713fd
src/kfilterdev.cpp 60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3
Diff: https://git.reviewboard.kde.org/r/116012/diff/
Testing
---
Builds, tests pass. No deprecation warnings (before there were two in the
tests).
Thanks,
Alex Merry
4a35879a15992d19378c7e9baa9b206e187713fd
src/kfilterdev.cpp 60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3
Diff: https://git.reviewboard.kde.org/r/116012/diff/
Testing
---
Builds, tests pass. No deprecation warnings (before there were two in the
tests).
Thanks,
Alex Merry
On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote:
have you tried removing the include?
Albert Astals Cid wrote:
Ignore me, there's i18n calls in there :D
Alex Merry wrote:
However, I wonder if those calls should really be in the header. I have
no idea what catalogue
On 26/02/14 07:09, Kevin Ottens wrote:
On Tuesday 25 February 2014 20:37:28 Alex Merry wrote:
I've had a look at the kdnssd repositoy, and it contains two related
bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify
KIO about changes to available services.
These two
---
On Feb. 25, 2014, 11:03 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116064/
---
(Updated Feb. 25, 2014
are usually hanging
around on #kde-devel on irc, and there's the kde-frameworks-devel email list.
- Alex Merry
On Feb. 25, 2014, 8:02 p.m., Matthieu Gallien wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
ee6bfd6f7e79a9f842ad6d34931a9273c2ee3c4f
Diff: https://git.reviewboard.kde.org/r/116080/diff/
Testing
---
None yet, but I'll do a rebuild of the frameworks before I commit.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
On 26/02/14 10:01, Alex Merry wrote:
Actually, having slept on it, my suggestion is:
- rename kdnssd to zeroconf-ioslave
- rename kdnssd-framework to kdnssd
- merge the frameworks branch of zeroconf-ioslave into kio
I don't think the last part is necessarily a blocker, either (although
it's
).
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Feb. 26, 2014, 3:36 p.m., Aurélien Gâteau wrote:
My memory may be failing me, but I think it was actually decided to go the
other way around for Qt5 includes: not prepending the module dir. Can
anyone else confirm? This should be mentioned in the framework policies, I
think.
.
Alex Merry wrote:
Yeah, the conclusion was that using module names in includes caused more
trouble than it was worth.
We're generally assuming that downstreams will use either qmake or CMake;
this shouldn't be an issue with either.
Although: see
http://mail.kde.org/pipermail/kde
On 20/02/14 11:41, Alex Merry wrote:
[1] https://build.opensuse.org/request/show/223061
KItemModels
kcheckableproxymodel.(cpp|h) is Stephen Kelly (and, for safety, David
Faure).
Changed.
modeltest.(cpp|h) were taken from Qt Concurrent, and subsequently
modified by Stephen Kelly
---
Tests build. 3 out of 4 pass.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote:
have you tried removing the include?
Albert Astals Cid wrote:
Ignore me, there's i18n calls in there :D
However, I wonder if those calls should really be in the header. I have no
idea what catalogue they will use at runtime; I
---
On Feb. 24, 2014, 5:02 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116025/
---
(Updated Feb. 24, 2014
85b97b7fa003282e1eeb1113c4668a9b73e3f731
docs/writing-find-modules.md PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/116025/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
with by find_package_handle_standard_args (the last call,
with HANDLE_COMPONENTS) anyway.
- Alex Merry
On Feb. 25, 2014, 7:46 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018
on WIN32 about how
we're not looking for anything. Some of the stuff should then go outside the
WIN32 clause, like find_package_handle_standard_args and set_package_properties.
Also: what about APPLE? Does that use Mesa?
Also: capitalisation. Shouldn't it be EGL, rather than Egl?
- Alex Merry
On 24/02/14 22:16, Luigi Toscano wrote:
Alex Merry wrote:
I screwed up the history import of the FindDocBook*.cmake files from
e-c-m into KDocTools, so Luigi asked me to do it again. This involves
removing those files, then merging in a more sensible history (that
isn't curtailed like
On Feb. 25, 2014, 11:46 a.m., Alex Merry wrote:
Generally looks good, but I'm wondering about the WIN32 clause. EGL is
really just an API, right? What we're really searching for is the Mesa
implementation. I guess that other platforms may well have their own
implementations
/116014/#comment35678
Caps
find-modules/FindEgl.cmake
https://git.reviewboard.kde.org/r/116014/#comment35679
Caps
find-modules/FindEgl.cmake
https://git.reviewboard.kde.org/r/116014/#comment35680
Caps
- Alex Merry
On Feb. 25, 2014, 12:02 p.m., Martin Gräßlin wrote
68ddbbf334031ea8d023b16a4904f07b8cc8d0ba
Diff: https://git.reviewboard.kde.org/r/116026/diff/
Testing
---
Compiles, installs, tests pass.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116014/#review50811
---
Ship it!
Ship It!
- Alex Merry
On Feb. 25, 2014, 12:42
protocol designed to replace X11, or something like that.
- Alex Merry
On Feb. 25, 2014, 12:46 p.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116046/#review50822
---
Ship it!
Ship It!
- Alex Merry
On Feb. 25, 2014, 1:45 p.m
://git.reviewboard.kde.org/r/116025/#review50830
---
On Feb. 25, 2014, 10:59 a.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/116025/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
I've had a look at the kdnssd repositoy, and it contains two related
bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify
KIO about changes to available services.
These two obviously belong together; the question is where? They can go
in kdnssd-framework, making it depend on
/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c
Diff: https://git.reviewboard.kde.org/r/115897/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
4ac893382c76def83f8e6e12698931df243085f9
Diff: https://git.reviewboard.kde.org/r/116064/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
Hi David,
The convert-kurl.pl script doesn't appear to actually convert any KUrl
usages or API, as the comments at the top (and the name) suggest it
should. In fact, the git history suggests it never did. Is there
actually a script around to do this?
Alex
://git.reviewboard.kde.org/r/116012/diff/
Testing
---
Builds, tests pass. No deprecation warnings (before there were two in the
tests).
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
On 23/02/14 19:02, John Layt wrote:
2) Copy code from kprintutils to kde4support
- Do we bother to keep the history?
- Where do we put it?
I would be inclined to keep the history. I can dig up the magic to do
that if you like.
Alex
___
).
- Alex Merry
On Feb. 24, 2014, 1:08 p.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116014
for better examples).
- Alex Merry
On Feb. 24, 2014, 1:52 p.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116018
I screwed up the history import of the FindDocBook*.cmake files from
e-c-m into KDocTools, so Luigi asked me to do it again. This involves
removing those files, then merging in a more sensible history (that
isn't curtailed like the other one was).
This can be found at
Alex,
I seem to have ended up becoming the de facto extra-cmake-modules
maintainer. Kevin said that you might interested in taking up the reins
again at some point in the future, so I thought I'd check whether you
were happy with me taking on the role officially, at least until you
feel you have
On Feb. 24, 2014, 2:51 p.m., Alex Merry wrote:
Three things:
- what projects are using it? I guess KWin is one; any others?
- it needs to set the DESCRIPTION and URL package properties (from
FeatureSummary)
- I've been aiming to create imported targets in new find modules, because
,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
clashes with mime packages from other
software).
Diffs
-
src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6
Diff: https://git.reviewboard.kde.org/r/115913/diff/
Testing
---
Installs with correct name. Mime database properly updated.
Thanks,
Alex Merry
to
find_package(), and it will find that DTD version, otherwise it will find 4.2.
- Alex Merry
On Feb. 22, 2014, 6:19 p.m., Luigi Toscano wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115897/#review50553
---
On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote
/115028/diff/
Testing
---
configures, compiles, tests pass (well, except KDirWatch-FAM, which has never
passed for me).
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
marked as submitted.
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
Only perform tests for plugins that are built
This both excludes the autotests and tests subdirs if the user sets
BUILD_TESTING off, and makes sure we do not run tests
/r/115956/#comment35589
You'll need to include the FeatureSummary module for this.
cmake/FindDocBookXSL.cmake
https://git.reviewboard.kde.org/r/115956/#comment35590
Likewise, FeatureSummary is needed
- Alex Merry
On Feb. 23, 2014, 2:34 p.m., Luigi Toscano wrote
On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote:
As this was already committed, can this RR be closed?
Alex Merry wrote:
Actually, I never committed this one, since I never got a ship it. I
added the files to kdoctools, but never removed them from e-c-m.
Luigi Toscano wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115956/#review50594
---
Ship it!
Ship It!
- Alex Merry
On Feb. 23, 2014, 3:02 p.m
On 22/02/14 09:11, David Faure wrote:
On Friday 21 February 2014 16:33:29 Hrvoje Senjan wrote:
On Feb. 20, 2014, 12:56 p.m., Commit Hook wrote:
This review has been submitted with commit
4fbbc75429597dc545ae8af24e870d9bac5f2f2a by Alex Merry to branch
master.
Seems Qt 5.3 will have it's own
On 21/02/14 16:01, Shivam Makkar wrote:
/CMake Error at
/home/amourphious/kf5/inst/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52
(find_package):/
/ Could not find a configuration file for package KF5Pty that is
compatible/
/ with requested version 5.2./
Huh. I have no idea
On 22/02/14 11:26, Alex Merry wrote:
On 21/02/14 16:01, Shivam Makkar wrote:
/CMake Error at
/home/amourphious/kf5/inst/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52
(find_package):/
/ Could not find a configuration file for package KF5Pty that is
compatible/
/ with requested
On Feb. 22, 2014, 1:35 p.m., Chusslove Illich wrote:
I tried to run a standalone non-GUI program using ki18n:
#include QDebug
#include KLocalizedString
int main (int argc, char *argv[])
{
setlocale (LC_ALL, );
801 - 900 of 1560 matches
Mail list logo
