D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

alex created this revision. alex added reviewers: KNewStuff, meven, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY As described in the bug report the uninstallation failed, but the service

D29101: WIP BUG: 420312 Fix file path and process call

alex created this revision. alex added reviewers: KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The bug was caused by two issues:

D28574: KRunner: Improve code snippet

This revision was automatically updated to reflect the committed changes. Closed by commit R308:b503fc4578b8: KRunner: Improve code snippet (authored by alex). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28574?vs=79342=80842 REVISION DETAIL

D29050: WIP KRunner: Fix Bug 420311

alex edited the summary of this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: WIP KRunner: Fix Bug 420311

alex created this revision. alex added reviewers: meven, ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY BUG: 420311. Because the teardown was rquested and checked the prepped

D27597: KRunner: Refactor deprecated toSet() method

alex abandoned this revision. alex added a comment. This gets already handled/discussed in D28135 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel,

D28582: KRunner: Show error message for Actions in dbus runner

alex updated this revision to Diff 79377. alex added a comment. Update comment REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79376=79377 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D28582

D28582: KRunner: Show error message for Actions in dbus runner

alex updated this revision to Diff 79376. alex added a comment. Update if condition REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79375=79376 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL

D28582: KRunner: Show error message for Actions in dbus runner

alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY KRunner now shows error messages for the Actions dbus

D28574: KRunner: Improve code snippet

alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The code snippet now uses the Qt5 syntax for the signals and

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

This revision was automatically updated to reflect the committed changes. Closed by commit R241:86832ca00e7b: KAbstractFileItemActionPlugin: Add missing quotes in code example (authored by alex). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27591?vs=76203=78255

D27597: KRunner: Refactor deprecated toSet() method

alex added a reviewer: Plasma. alex added a comment. Thanks :-) REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

alex updated this revision to Diff 76219. alex added a comment. Keep compatibility with Qt < 5.14 REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27597?vs=76213=76219 BRANCH deprecation_fix (branched from master) REVISION DETAIL

D27597: KRunner: Refactor deprecated toSet() method

alex created this revision. alex added reviewers: mlaurent, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The deprecated toSet method of the QList class has been refactored as in the

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

alex added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

alex created this revision. alex added a reviewer: elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The quotes around the json file name were added. Without these the moc process would

<    1   2