D13698: Improve ECMAddAppIconMacro.

This revision was automatically updated to reflect the committed changes. dschmidt marked an inline comment as done. Closed by commit R240:2c2bb8f4766f: Improve ECMAddAppIconMacro. (authored by dschmidt). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D13698: Improve ECMAddAppIconMacro.

dschmidt marked 8 inline comments as done. dschmidt added inline comments. INLINE COMMENTS > cgiboudeaux wrote in ECMAddAppIcon.cmake:161 > 36? It's not mentioned in the doc. Good catch, I forgot to update this part after I fixed the resolutions in a different place.. The resolutions I copied f

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36891. dschmidt added a comment. Fix since version in FindIcoTool too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36890&id=36891 BRANCH app-icon-modernization REVISION DETAIL https://phabr

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36890. dschmidt added a comment. Fix comment REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36889&id=36890 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AF

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36889. dschmidt added a comment. Fix "Since version" and wrong resolutions in a few places REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36719&id=36889 BRANCH app-icon-modernization REVISION D

D13698: Improve ECMAddAppIconMacro.

dschmidt marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36719. dschmidt added a comment. Remove debug spam ... REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36718&id=36719 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36718. dschmidt added a comment. Commit fixes to the actual ECMAddAppIconMacro REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36715&id=36718 BRANCH app-icon-modernization REVISION DETAIL http

D13698: Improve ECMAddAppIconMacro.

dschmidt edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36715. dschmidt added a comment. Squashed everything into one commit, sigh. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36713&id=36715 BRANCH app-icon-modernization REVISION DETAIL https:/

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36713. dschmidt added a comment. Removed crap commit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36712&id=36713 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AFFECTED FILES docs/find-module

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36712. dschmidt added a comment. Fix macOS tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36710&id=36712 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AFFECTED FILES docs/find-module/Fin

D13698: Improve ECMAddAppIconMacro.

dschmidt added a comment. Added license, documentation and Alex Merry as copyright holder as the find module for png2ico was written by him. REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsys

D13698: Improve ECMAddAppIconMacro.

dschmidt marked 4 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36710. dschmidt added a comment. - Add copyright, license and documentation to FindIcoTool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36707&id=36710 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36707. dschmidt added a comment. Tests stub and parameter rename CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36564&id=36707 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AFFECTED FILES test

D13698: Improve ECMAddAppIconMacro.

dschmidt marked an inline comment as done. dschmidt added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindIcoTool.cmake:1 > - Missing doc > - Missing license @vpinon Can you let me know what you want here? > cgiboudeaux wrote in ECMAddAppIcon.cmake:105-106 > ECMAddAppIcon has an uni

D13698: Improve ECMAddAppIconMacro.

dschmidt edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36564. dschmidt added a comment. Update documentation again REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36563&id=36564 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36563. dschmidt added a comment. Updated documentation REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36562&id=36563 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/

D13698: Improve ECMAddAppIconMacro.

dschmidt edited the summary of this revision. dschmidt added reviewers: vpinon, apol, alexmerry. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D13698: Improve ECMAddAppIconMacro.

dschmidt edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt created this revision. dschmidt added a reviewer: vonreth. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. dschmidt requested review of this revision. REVISION SUMMARY - Add support for SID