Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi, 2016-02-29 19:04 GMT+01:00 Milian Wolff: > On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced everywhere right

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi Albert, 2016-02-28 11:54 GMT+01:00 Albert Astals Cid: > El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced ev

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi, 2016-02-26 13:25 GMT+01:00 Jan Kundrát: > On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: >> >> This becomes a problem if the read-only data that the QString refers >> to are not there any more, which can happen if the QString was stored >> in

QString -> QStringLiteral conversions might make applications crash on exit

Hi everyone, sorry if most of you know about this already, but since it seems that QStringLiterals are being introduced everywhere right now, I think that it is important to raise awareness about the fact that this might be more dangerous that it seems at first sight. QStringLiteral has the nice

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

-- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127111/ > --- > > (Updated Feb. 18, 2016, 9:53 p.m.) > > > Review request for Dol

Re: Review Request 126894: Refactor the listjobtest to allow listing of multile paths.

eping overhead is added to each allocation. Each allocation takes at least 32 bytes of memory when using GCC+glibc on a 64-bit system. But I guess that there must be a better way than the `cin.ignore()` hack to easily get the real memory usage. - Frank Reininghaus On Jan. 26, 2016, 3:34

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

affects Plasma somehow because I currently do not > have a full self-built Plasma session running. It could probably be checked > by opening the "Properties..." of a file in FolderView, clicking the icon, > and then opening the "Browse..." sub dialog of the KIconD

Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

erView, clicking the icon, and then opening the "Browse..." sub dialog of the KIconDialog. This should hopefully not lock the entire Plasma session (because the dialogs are window modal, and not application modal). If anyone finds problems with that or has ideas for improvement, please let me

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

find a fail-safe solution with a dynamically increasing buffer prettier, but it's so extremely unlikely that this will ever cause problems that it's not worth arguing about it :-) - Frank Reininghaus On Okt. 10, 2015, 3:29 nachm., David F

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Am 07.10.2015 22:25 schrieb "Albert Astals Cid" : > > El Tuesday 06 October 2015, a les 19:20:00, Frank Reininghaus va escriure: > > Hi, > > > > 2015-10-06 15:04 GMT+02:00 : > > > GENERAL INFO > > > > > > BUILD UNSTABLE > >

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Hi, 2015-10-06 15:04 GMT+02:00 : > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Tue, 06 Oct 2015 12:34:13 + > Build duration: 14 min > > CHANGE SET >

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 4b24b70c93523c5bc56c90c04a5a666331e96a1b by Frank Reininghaus to branch master. Bugs: 350769 https://bugs.kde.org/show_bug.cgi?id=350769 Repository: kio Description

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 1b98a313983b75f3340639e5cd9519c56fca7113 by Frank Reininghaus to branch master. Bugs: 349654 https://bugs.kde.org/show_bug.cgi?id=349654 Repository: kio Description

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

ularly) until they get a functional context menu again. - Frank ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

ether 1000 bytes are guaranteed to be enough. Some quick Googling tells me that path lengths of 4096 are possible. Maybe we could allocate a temporary large array on the heap if the readlink call fails with the 1000 byte buffer on the stack? - Frank Reininghaus On Okt. 4, 2015, 9:24 vorm.,

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

sole service actions are shown in the context menu again. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

oth, > > querying for both and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? > > Frank Reininghaus wrote: > If we change the ServiceType entry in the file, then every service menu > will have to be changed, right? No

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 ------- On Sept. 27, 2015, 6:18 nachm., Frank Reininghaus wrote: > > -

Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

ame KIO release. What do others think? Diffs - src/widgets/CMakeLists.txt 820cd34 src/widgets/kioservicemenuplugin.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125425/diff/ Testing --- Konsole service actions are shown in the co

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

t;Create New..." menu was empty then, but it is populated again with this patch. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by Frank Reininghaus to branch master. Bugs: 352770 https://bugs.kde.org/show_bug.cgi?id=352770 Repository: kio Description

Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

the dialog work now: it is possible to create hidden directories, and it is also possible to choose a new name. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125158: add logic to use icons for default xdg user dirs

annot just add a .directory file with the desired icon name. Is there a reason why the problem can't be solved this way? - Frank Reininghaus On Sept. 11, 2015, 10:50 vorm., Harald Sitter wrote: > > --- > This is an automatica

Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

this patch. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

> On Mai 12, 2015, 3:49 nachm., Jan Kundrát wrote: > > Was the old code a part of some release? If yes, this should get a CVE > > security announcement because it allows a local attacker to e.g. force you > > to overwirte some of your user's files. > > Michael Palimaka wrote: > It looks li

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

2014-12-28 23:22 GMT+01:00 David Faure: > On Sunday 28 December 2014 22:54:51 Frank Reininghaus wrote: >> Hi, >> >> 2014-12-23 9:44 GMT+01:00 David Faure: >> > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: >> >> Fixed

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

eviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

------ On Dez. 11, 2014, 10:08 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118452/

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

Hi, 2014-12-23 9:44 GMT+01:00 David Faure: > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: >> Fixed in >> http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 >> >> Ooops, should I have pushed this through Gerrit before committing? > > Nope, that's fine, trivial fix

Change in kio[master]: Apply the edited URL to the navigator when clicking the "Che...

Frank Reininghaus has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/233 Change subject: Apply the edited URL to the navigator when clicking the "Check" button .. Apply the edited URL to the

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2/#review71763 --- On Dez. 9, 2014, 10:44 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kd

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

iewboard.kde.org/r/118452/#review71774 --- On Dez. 9, 2014, 10:44 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

ll haven't set up a Qt5/KF5 build in release mode (shame on me!), so I cannot present any benchmark results. File Attachments (updated) Benchmark results https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-bench

Re: Review Request 119607: Support for ".hidden" files

> On Sept. 14, 2014, 3:27 nachm., Frank Reininghaus wrote: > > src/core/kfileitem.h, line 262 > > <https://git.reviewboard.kde.org/r/119607/diff/2/?file=301216#file301216line262> > > > > Since we probably do not want to make it possible that all users

Re: How to port KTabBar::mouseMiddleClick?

Hi, 2014-11-06 2:59 GMT+01:00 Milian Wolff: > Hey all, > > what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? > Previously, we used KTabBar and its mouseMiddleClick signal. AFAIK, currently the only solution is to subclass QTabBar, override the mousePressEvent method and emit a

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Okt. 23, 2014, 11:14 vorm., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code

Re: KConfig build fails

Hi, 2014-07-14 23:21 GMT+02:00 David Gil Oliva: > Hi! > > KConfig build fails with this messages, all of them related to > QBasicAtomicInt. Are they KF5 bugs? probably this is the same issue that has been discussed in https://git.reviewboard.kde.org/r/119257/ ? According to David F., this might d

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

r_p.h 2660e99 src/core/kfileitem.h bc2f90c Diff: https://git.reviewboard.kde.org/r/118775/diff/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expected. Thanks, Frank Reininghaus __

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

-- src/core/kcoredirlister.cpp fef28db src/core/kcoredirlister_p.h 2660e99 src/core/kfileitem.h bc2f90c Diff: https://git.reviewboard.kde.org/r/118775/diff/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expe

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

order to at least get the binary incompatible change in before it's too late. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60180 ---------

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

7;m always a bit unsure which C++11 features are allowed. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60179 -------

Review Request 118775: Make KFileItem a Q_MOVABLE type

r/118775/diff/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KCoreAddons does not install most of its headers on my system

Hello everyone, I tried to set up a separate Qt5+KF5 build in release mode. Unfortunately, I did not succeed :-( The first package that fails to build (even if I repeat the kdesrc-build process many times) is kservice. The comiler reports [ 30%] Building CXX object src/CMakeFiles/KF5Service.dir/

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

tor>). > > (b) No space is reserved in the vectors when key/value pairs are inserted one > by one. Implementing this would make UDSEntry faster on the slave side (since > repeated re-allocations would not be necessary any more), but this can be > done in a later patch. Moreover, i

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

ps://git.reviewboard.kde.org/r/118269/#review58902 --- On May 22, 2014, 9:39 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

cpp fb4c99a Diff: https://git.reviewboard.kde.org/r/118269/diff/ Testing --- Fixes the crash for me, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus _

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: > Hi, > > 2014-06-02 20:54 GMT+02:00 Mark Gaiser: >> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >>> On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >>>> dolphin on a massive folder. In f

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: > On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >> On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >>> dolphin on a massive folder. In fact, those that use kio::listdir for >>> listing folders only have interfaces that become usable when al

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 18:42 GMT+02:00 Aaron J. Seigo: > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >> dolphin on a massive folder. In fact, those that use kio::listdir for >> listing folders only have interfaces that become usable when all >> entries are fetched. > > assuming these UIs receive

Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

obtest with a directory with 100,000 files is reduced from 71344 K to 35392 K according to KSysGuard. I see similar savings when opening the directory in Dolphin. I still haven't set up a Qt5/KF5 build in release mode (shame on me!), so I cannot present any benchmark results. Thanks,

Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

the crash for me, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

leItem out of the KDirModel. > > > > However, do we really want that the detailed listview in dolphin? I can > > more easily recognize the biggest number by being the one with most digits, > > than having to go through a list of kB, MB, and GB values. > > > > It might even

Re: KIO directory listing - CPU slows down SSD

Hi Mark, 2014-05-11 21:57 GMT+02:00 Mark Gaiser: > Hi, > > I've been playing with KIO speed improvements for quite a while now > and found some very interesting issues with KIO in combination with my > SSD drive: "Samsung SSD 840 PRO Series". > > My testcase is one directory filled with 500.000 fi

Re: Review Request 117799: Clean up private slots in KCompletion

very straightforward transformation, and I haven't spotted anything that looks like it could break things. Considering that the tests still work for you, I think that there is no reason not to push it. - Frank Reininghaus On April 26, 2014, 11:23 p.m., David Gil O

RFC: Do we want the entire commit history to be pushed if code is moved to another repository?

Hi everyone, when kdelibs was split into the different frameworks repositories, the git history was dropped. I think that this was a good idea - splitting the history properly would have been an extremely complex task, and everyone who wants to do source code archaelogy can just look at the kdelib

Re: Review Request 116886: Refactor private variables of KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53705 --- Ship it! Looks reasonable to me, thanks! - Frank

Re: Review Request 116886: Refactor private variables of KCompletion

save memory here, one could make 'order' a bitfield and move it next to the bools. - Frank Reininghaus On March 18, 2014, 11:01 p.m., David Gil Oliva wrote: > > --- > This is an automatically generat

Re: Review Request 116542: Fix compilation with clang 3.4.

thanks for taking care of it. I wasn't aware at all that there might be a problem if the "operator==" is declared outside the namespace, but if I had been, then I would have put it inside he namespace, of course. So "Ship it!" from me too. - Frank Reininghaus On March 2

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

getting reliable benchmark results when I work on further improvements in the future. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

> On Feb. 15, 2014, 7:38 p.m., David Faure wrote: > > src/khistorycombobox.cpp, line 508 > > > > > > infinite recursion! > > > > Sounds like a unittest for reset() should be added. > > David Gil Oliva w

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

ve than just increasing a refcount. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review49873 --- On Feb. 13, 2

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

#review49739 ------- On Feb. 13, 2014, 8:23 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/

Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

DSEntry essentially only depends on qtbase, I might be able to just do a release build of qtbase and build a stand-alone version of UDSEntry+benchmarks on top of that. I'll look into this option for getting reliable benchmark results when I work on further improve

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

d.kde.org/r/114921/diff/ Testing --- New unit test crashes with master, and passes if the patch is applied. Existing kio unit tests pass on my system (except for kiocore-kacltest, but I believe that the failure is unrelated to this patch). Thanks,

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

ebe src/widgets/kfileitemactions_p.h 9f9a701 Diff: https://git.reviewboard.kde.org/r/114921/diff/ Testing --- New unit test crashes with master, and passes if the patch is applied. Existing kio unit tests pass on my system (except for kiocore-kacltest, but I believe that the fail

Review Request 114921: Make KFileItemActions the parent of the actions it creates

e patch is applied. Existing kio unit tests pass on my system (except for kiocore-kacltest, but I believe that the failure is unrelated to this patch). Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org ht

Re: Tracking bugs in Frameworks

Hi, 2013/12/14 David Edmundson: > As we gear Frameworks up for release we need a way to track bugs that > exist in the new Frameworks. > > We have two options; either we copy all the bugs in kdelibs, triaging, > testing and moving to the right new component or we start fresh. > > There are approxi

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

> On Nov. 25, 2013, 1:48 p.m., Kevin Ottens wrote: > > Any chance for a review? We really need to tie up loose ends now. I think that this is a very nice piece of work, and the new data-driven test also looks good to me. The only thing I'm concerned about is the run time of the test - I like u

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

e required to come up with a less time-consuming solution. If there was a signal that was emitted if everything went OK, one could simply wait for it. - Frank Reininghaus On Nov. 15, 2013, 10:42 a.m., Martin Gräßlin wrote: > > ---

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

pport "it = container.erase(it)" for the removal of an item that an iterator points to, and having "it" point to the next item (or end()) afterwards. - Frank Reininghaus On Nov. 15, 2013, 9:48 a.m., Martin Gräßlin wrote: > > --

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really famili

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really famili

Re: Review Request 112717: Start adopting QCollator

t could still be that Qt was built without ICU support. Probably the best solution would be to try to get something like our KStringHandler::naturalCompare() function into qcollator_posix.cpp, to make sure that the fallback that is used if ICU isn't available actually uses "numeric mo

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

Hi, 2013/8/22 David Faure: > On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote: >> Hi David, >> >> 2013/8/7 David Faure: >> > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: >> >> OK, I see now that it uses pointers to be abl

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

Hi David, 2013/8/7 David Faure: > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: >> OK, I see now that it uses pointers to be able to modify the actual >> KFileItems in KDirListerCache (if it would just keep KFileItems and >> modify these, I guess that they would

Re: Review Request 111916: Port khtml_part away from kde_file.h

If you mean the segfault in kdirlistertest - that's my fault. I've reverted my bad commit now. Sorry for the trouble! http://mail.kde.org/pipermail/kde-frameworks-devel/2013-August/004135.html - Frank Reininghaus On Aug. 6, 2013, 6:14 p.m., Vishes

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982

Hi, 2013/8/6 Frank Reininghaus: > Hi, > > 2013/8/6 KDE CI System : >> See <http://build.kde.org/job/kdelibs_frameworks_qt5/982/changes> > > the crash in KDirListerTest has been caused by my recent change > > https://git.reviewboard.kde.org/r/111789/ > > F

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982

Hi, 2013/8/6 KDE CI System : > See the crash in KDirListerTest has been caused by my recent change https://git.reviewboard.kde.org/r/111789/ First of all, I apologize for not having run that test before. I had thought that running KF

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

> On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: > > I was just working on the same thing. > > > > I'm not sure if we want to move this to kde4support. Can we just throw it > > away? Or would that be terribly wrong? We have a replacement in > > nepomuk-widgets. > > > > Strigi doesn't need to b

Re: Revising changing configurations with KConfig

Hi, 2013/8/1 Kevin Ottens: > On Thursday 01 August 2013 00:57:05 Aleix Pol wrote: >> Well, that setting is used in KDirSortFilterProxyModel as well... Should we >> just always sort naturally by default there then? > > Would make sense to add an accessor pair to KDirSortFilterProxyModel, and have >

Review Request 111789: Improve KFileItemList memory usage and performance

files/2013/07/29/before.png Memory usage WITH patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/after.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/lis

Re: naturalCompare Qt5 task

Hi, 2013/7/19 Thiago Macieira: > On sexta-feira, 19 de julho de 2013, às 13.17.26, you wrote: >> Hi, >> I was looking at that task in the Qt5 epics list and I didn't understand it >> fully. >> >> contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is >> naturalCompare function b

Re: naturalCompare Qt5 task

Hi, 2013/7/19 Aleix Pol: > Hi, > I was looking at that task in the Qt5 epics list and I didn't understand it > fully. > > contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is > naturalCompare function but private and not as good as from KStringHandler. > Thiago says: add the f

Re: KF5 Update Meeting Minutes 2013-w24

Hi, thanks for the explanation! 2013/6/12 Kevin Ottens: > Hello, > > On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: >> 2013/6/11 Kevin Ottens: >> [...] >> >> > * ItemViews will be tier 2 until we contribute the natural compare to Qt; >&

Re: KF5 Update Meeting Minutes 2013-w24

Hi, 2013/6/11 Kevin Ottens: [...] > * ItemViews will be tier 2 until we contribute the natural compare to Qt; I thought that Qt 5.1 will have the QCollator class, which can perform natural comparison of strings if you use "numeric mode"? Cheers, Frank ___

Re: please make it easier to hack on frameworks

Hi, 2013/4/30 Aaron J. Seigo: > On Tuesday, April 30, 2013 11:20:47 Stephen Kelly wrote: > >> I am clueless to understand why building cmake from git and installing it > >> into your kf5 prefix is a showstopper. Can you tell me? > > Time is limited. > > Every repository that I have to build (e.g.

Re: Review Request 109538: port KFileMetaDataReader to QProcess

> On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: > > But why? KFileMetadataReader and the other KFileMetadataStuff should just > > be marked as deprecated. Why are we porting them? We already have better > > alternatives in the nepomuk-widgets repository. > > Martin Tobias Holmedahl Sandsm

Re: Separating everything ?

Hi Patrick, 2013/2/8 Patrick Spendrin: > Am 07.02.2013 23:32, schrieb Frank Reininghaus: > ... > > Since I am reading this thread by chance, I might as well reply. > > One of the reasons of splitting kdelibs into separate repositories is to > simplify the usage of singl

Re: Separating everything ?

Hi, 2013/2/7 Kevin Ottens: > On Thursday 7 February 2013 16:09:51 Frank Reininghaus wrote: >> Is there anything obvious that I'm overlooking? One could argue that >> separate repositories make it easier for non-KDE people to contribute >> to one particular fr

Re: Separating everything ?

Hi, 2013/2/6 Alexander Neundorf: > Hi, > > at Kevin's talk about KDE frameworks at FOSDEM last weekend, one guy from the > audience asked why he should not use all KDE libs if he decides to use one > already... > > This got me thinking. > Obviously, dragging in everything is what we want to avoid.

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/2/5 David Faure: [...] > Another possible conclusion: who in their right mind puts 500.000 files in a > directory? :-) I'm glad to see that I'm finally not the only one who has such thoughts ;-) I might be repeating myself, but even though ensuring that everything works efficiently with

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi Mark, 2013/2/4 Mark: > I really really really dislike KDirModel and friends (KDirLister, > KFileItem). before you get even more emotional in your next reply to this thread, please consider reading http://www.kde.org/code-of-conduct/ I sort of got used to reading disrespectful messages with l

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/21 Aaron J. Seigo : > On Monday, January 21, 2013 17:53:48 Frank Reininghaus wrote: >> http://ppenz.blogspot.de/2011/08/introducing-dolphin-20.html > > Ah, that's right .. it uses ItemViewsNG. of which the last commits seem to be > in 2010, and QGraphicsVie

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/21 Aaron J. Seigo: > On Tuesday, January 15, 2013 10:40:58 Frank Reininghaus wrote: >> Right, but considering that Dolphin doesn't even use KDirModel any >> more, going the QAbstractItemView way would feel like throwing away >> most of what happened in D

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/10 Aaron J. Seigo: [...] >> However, one of the main goals Peter >> had when rewriting the view engine was to get rid of QModelIndex, >> SortFilterProxyModels and things like these. And I really have the >> feeling that using plain ints to index items and not needing things >> like mapT

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/10 Aaron J. Seigo: > in the case of dolphin, i can imagine a goal that could lead to over- > calculating: wanting even spacing between all icons, which in turn means > knowing how much space each and every icon will require (thumbnail? how much > text? etc.) The number of text lines re

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/9 Mark: > On Wed, Jan 9, 2013 at 2:51 PM, David Faure wrote: >> On Wednesday 09 January 2013 11:15:20 Mark wrote: >>> A little more in depth questions for KDirLister and KFileItem. In my >>> profiling KFileItem ends up high due to various reasons, but >>> KDirLister is also a bit of a h

Re: Introduction and PhononQt5 porting

Hi Jon, 2012/10/7 Jon Severinsson: > Hi again > > With the previosly mentioned updated phonon [1], and these three fixes > to kdelibs [2], it all compiles for me. The unit test does however show > several failure, but I'll have to investigate that another day, as it is > past midnight here... > >

  1   2   >