Re: version numbers towards kf6

On Monday, 26 June 2023 17:32:18 CEST, Jos van den Oever wrote: On 26/06/2023 17.27, Heiko Becker wrote: On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote: ... So that the user can see that they are running a snapshot and not an official release and to make it easy to report

Re: version numbers towards kf6

On Monday, 26 June 2023 14:06:04 CEST, Jos van den Oever wrote: On 26/06/2023 13.15, Heiko Becker wrote: On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote: The new versions of frameworks, plasma and gear presumably all start with '6'. Following Fedora versioning for snapshots [0

Re: version numbers towards kf6

On Monday, 26 June 2023 11:13:56 CEST, Jos van den Oever wrote: The new versions of frameworks, plasma and gear presumably all start with '6'. Following Fedora versioning for snapshots [0] gives this: 6^20230627git5328c27e3 Like Jonathan said, versioning of snapshots is a downstream thing.

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

heikobecker added a comment. In D29303#677015 , @dfaure wrote: > So this is basically the same as https://phabricator.kde.org/D29136 except that D29136 gives priority to the non-deprecated variable. Any

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. How do we move this or https://phabricator.kde.org/D29136 forward? @ilic As a maintainer, do you have an opinion? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc:

D29136: Use non-deprecated KDEInstallDir

heikobecker reclaimed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

heikobecker abandoned this revision. heikobecker added a comment. Abandoned in favour of https://phabricator.kde.org/D29136 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

heikobecker added a comment. Fixes the problem I had with marble, which prompted the creation of https://phabricator.kde.org/D29136. Passing the destination as an parameter seems indeed like a better way, so +1 from me. REPOSITORY R249 KI18n REVISION DETAIL

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ideally would be documented though. (my first approach would be to also allow a soft

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. In D29136#660270 , @kossebau wrote: > using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps

D29136: Use non-deprecated KDEInstallDir

heikobecker updated this revision to Diff 81035. heikobecker added a comment. Added missing parentheses REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29136?vs=81033=81035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29136 AFFECTED FILES

D29136: Use non-deprecated KDEInstallDir

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I noticed that when installeding marble, which sets KDE_INSTALL_DIRS_NO_DEPRECATED, which then invalidates a

D28108: Handle busybox's sed like GNU sed

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0855a40a1131: Handle busyboxs sed like GNU sed (authored by heikobecker). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28108?vs=77864=77880 REVISION DETAIL

D28108: Handle busybox's sed like GNU sed

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY Otherwise it uses the POSIX-style and fails with "sed: : No such file

D25795: Rename kf5quickcharts_example to kquickcharts_example

heikobecker closed this revision. heikobecker added a comment. In D25795#612749 , @ahiemstra wrote: > @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? I have

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker added a comment. In D25794#612748 , @ahiemstra wrote: > @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? I have and I already committed it:

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker closed this revision. REVISION DETAIL https://phabricator.kde.org/D25794 To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

heikobecker created this revision. heikobecker added reviewers: Frameworks, ahiemstra. heikobecker requested review of this revision. REVISION SUMMARY Matching the project name. TEST PLAN exmaple is installed under the new name, runs fine BRANCH master REVISION DETAIL

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker created this revision. heikobecker added reviewers: Frameworks, ahiemstra. heikobecker requested review of this revision. REVISION SUMMARY Allows the test to run without a display server. TEST PLAN Builds, test still passes BRANCH master REVISION DETAIL

D21695: Add FindTaglib.cmake

heikobecker added a comment. I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which

D21695: Add FindTaglib.cmake

heikobecker created this revision. heikobecker added reviewers: kde-buildsystem, kde-frameworks-devel. Herald added projects: Frameworks, Build System. heikobecker requested review of this revision. REVISION SUMMARY The old one from KDELibs4 times is used by several projects from Frameworks,

D17650: Install kioslave as kioslave5 on Windows

heikobecker added a comment. > no, it is only used in kio internally by klauncher to start io slaves. at least kinit disagrees: src/klauncher/klauncher.cpp:1021 arg_list.prepend(QLatin1String("kioslave")); REPOSITORY R241 KIO REVISION DETAIL

D17650: Install kioslave as kioslave5 on Windows

heikobecker added a comment. In D17650#379396 , @habacker wrote: > I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ? I'd argue that the problem is with

D17479: Fix build without phonon

This revision was automatically updated to reflect the committed changes. Closed by commit R305:78a1dcc794f5: Fix build without Phonon (authored by heikobecker). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17479?vs=47283=47288 REVISION DETAIL

D17479: Fix build without phonon

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY f6d55baf5aa88eaab6b2f96c025064f081d13cea

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. I can confirm that the crash doesn't occur anymore. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker,

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker added a comment. In D15251#322168 , @kossebau wrote: > ...as well as request to finally enable BUILD_QCH on CI, so this is covered. I wondered why that's not the case. I, for one, would welcome it. REPOSITORY R249 KI18n

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7b2936a6d673: Fix autotests with -DBUILD_QCH:BOOL=TRUE (authored by heikobecker). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15251?vs=40932=41194 REVISION

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker added reviewers: kossebau, habacker. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D15251 To: heikobecker, kossebau, habacker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY After 507415c54bd111fbb35716bd9809119d990f9a16

D14008: Use QTEST_GUILESS_MAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R235:3a82a775b1c3: Use QTEST_GUILESS_MAIN (authored by heikobecker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14008?vs=37463=39143 REVISION DETAIL

D14008: Use QTEST_GUILESS_MAIN

heikobecker added a comment. Ping? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D14008 To: heikobecker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

This revision was automatically updated to reflect the committed changes. Closed by commit R240:59b311bcc2ed: ECMOptionalAddSubdirectory: Provide a bit more detail (authored by heikobecker). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. heikobecker requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION

D14008: Use QTEST_GUILESS_MAIN

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY Allowing the tests to pass without a running X server. REPOSITORY R235

D12872: ScalableTest, add "scalable" plasma-browser-integration

heikobecker added a comment. +1 Btw, this is BUG: 393999 REPOSITORY R266 Breeze Icons BRANCH scalable_pbi (branched from master) REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask Cc: heikobecker,

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

This revision was automatically updated to reflect the committed changes. heikobecker marked an inline comment as done. Closed by commit R249:918e304f057b: KF5I18NMacros: Dont install an empty dir when no po files exist (authored by heikobecker). REPOSITORY R249 KI18n CHANGES SINCE LAST

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

heikobecker marked an inline comment as done. heikobecker added a comment. Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime. INLINE COMMENTS > ltoscano wrote in KF5I18NMacros.cmake.in:138-139 > I guess that those two lines are the

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I saw this happen with kdecoration from git since

D12216: Don't need to run previous iterations commands again

heikobecker added a comment. In D12216#247225 , @apol wrote: > I'm unsure if it's worth re-spinning ki18n. It's already out, so it would need a .1, but it may be worth it as it appears builds are hanging otherwise. REPOSITORY R249

D12225: Also make installation of translated docs optional

This revision was automatically updated to reflect the committed changes. Closed by commit R317:03d503362514: Also make installation of translated docs optional (authored by heikobecker). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12225?vs=32186=32273

D12225: Also make installation of translated docs optional

heikobecker created this revision. heikobecker added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY 76f3f5b541eea8128297e68bd80278e7f525c1aa

D10340: Clean up old, unreachable code

This revision was automatically updated to reflect the committed changes. Closed by commit R306:7387d21c4516: Clean up old, unreachable code (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10340?vs=26647=27537 REVISION DETAIL

D10339: Drop obsolete version checks

This revision was automatically updated to reflect the committed changes. Closed by commit R306:faf16778ea6b: Drop obsolete version checks (authored by heikobecker). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10339?vs=26646=26660 REVISION DETAIL

D10340: Clean up old, unreachable code

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Nepomuk is never searched for, so the removed code wasn't used in a long time. Furthermore Nepomuk

D10339: Drop obsolete version checks

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. heikobecker requested review of this revision. REVISION SUMMARY Frameworks already require Qt 5.7.0. REPOSITORY R306 KParts BRANCH master REVISION DETAIL

D8672: Fix build with LibreSSL

This revision was automatically updated to reflect the committed changes. heikobecker marked an inline comment as done. Closed by commit R239:00cae452ac61: Fix build with LibreSSL (authored by heikobecker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D8672: Fix build with LibreSSL

heikobecker marked an inline comment as done. heikobecker added inline comments. INLINE COMMENTS > dfaure wrote in ksslcertificate.cpp:1225 > This seems to be missing parenthesis... > > KSSL_HAVE_SSL && ( ... || ... ) Thanks, added. REPOSITORY R239 KDELibs4Support REVISION DETAIL

D8672: Fix build with LibreSSL

heikobecker marked an inline comment as done. heikobecker added inline comments. INLINE COMMENTS > dfaure wrote in kopenssl.cpp:1047 > this syntax will lead to a preprocessor warning when LIBRESSL_VERSION_NUMBER > isn't defined. > Did you mean `|| defined(...)` ? Yeah, that's indeed better...

D8672: Fix build with LibreSSL

heikobecker updated this revision to Diff 23301. heikobecker added a comment. Added define(..) REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8672?vs=21939=23301 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8672 AFFECTED FILES

D8672: Fix build with LibreSSL

heikobecker added a reviewer: FreeBSD. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D8672 To: heikobecker, #frameworks, #freebsd

D8672: Fix build with LibreSSL

heikobecker added a comment. Ping? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D8672 To: heikobecker, #frameworks

D8672: Fix build with LibreSSL

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Unfortunately LibreSSL sets OPENSSL_VERSION_NUMBER to 0x2000L and doesn't support the OpenSSL 1.1 API. TEST PLAN Builds with LibreSSL

D7478: Escape hyphen in rest.xml regular expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ad077e4045e6: Escape hyphen in rest.xml regular expressions (authored by heikobecker). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7478: Escape hyphen in rest.xml regular expressions

heikobecker updated this revision to Diff 18602. heikobecker added a comment. Increased version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7478?vs=18584=18602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 AFFECTED

D7478: Escape hyphen in rest.xml regular expressions

heikobecker added a comment. In https://phabricator.kde.org/D7478#138855, @alexeymin wrote: > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? Wasn't aware of the bug report, but yes. Will add a BUG: reference before pushing if this is accepted. REPOSITORY

D7478: Escape hyphen in rest.xml regular expressions

heikobecker updated this revision to Diff 18584. heikobecker added a comment. Removed accidentally included change. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7478?vs=18583=18584 BRANCH master REVISION DETAIL

D7478: Escape hyphen in rest.xml regular expressions

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The unescaped hyphen caused a build failure with pcre2-10.30 due to a broken regex: 'syntax-highlighting/data/syntax/rest.xml" line 27

D7239: Drop unused dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R169:478b31fd1b92: Drop unused dependency (authored by heikobecker). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7239?vs=17984=18528 REVISION DETAIL

D7239: Drop unused dependency

heikobecker added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7239 To: heikobecker, #plasma, #frameworks Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

heikobecker added a comment. Ping? Not sure what to do with this, still would like to hear something from @skelly. Or should I just go ahead and use ClangConfig.cmake (meaning dropping the version requirement, I don't have any older clang versions around to easily test it.) REPOSITORY

D4051: kcm_useraccount is dead, long live user_manager

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8f81a80f5dd9: kcm_useraccount is dead, long live user_manager (authored by heikobecker). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4051?vs=9935=14061

D4051: kcm_useraccount is dead, long live user_manager

heikobecker added a comment. Ping? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D4051 To: heikobecker, #frameworks

D5413: makes KArchive be optional and do not build extractors needing it

heikobecker added a comment. In https://phabricator.kde.org/D5413#102273, @dfaure wrote: > Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing? > Not sure if that works for KF5 components. No, OPTIONAL

D5274: extractorcollectiontest: Use QTEST_GUILESS_MAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6d7468be4cc6: autotests: Use QTEST_GUILESS_MAIN (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5274?vs=13044=13099#toc REPOSITORY R286 KFileMetaData CHANGES

D5291: FindPyModGen: Also search for an unversioned clang++

This revision was automatically updated to reflect the committed changes. Closed by commit R240:47a4c068a4ec: FindPyModGen: Also search for an unversioned clang++ (authored by heikobecker). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

heikobecker added a comment. In https://phabricator.kde.org/D5289#99625, @shaheed wrote: > Fwiw, I think that a specific version check may not be needed. The original > code I wrote, which I assume Steve may have simply carried forward in the > cmake ecm logic, DID have a version

D5290: FindPyModGen: Don't hard-code share dir

heikobecker added a comment. In https://phabricator.kde.org/D5290#99713, @apol wrote: > That's not how ECM is intended to work, these find modules are supposed to be separate from the variables we use in KDE. > What problem are you trying to address? My distro uses a

D5291: FindPyModGen: Also search for an unversioned clang++

heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY While my distro does have a versioned clang executable, it doesn't have a versioned clang++ executable. The versioned executable is still searched first, falling back to the

D5290: FindPyModGen: Don't hard-code share dir

heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY ...but use KDE_INSTALL_DATAROOTDIR instead. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5290 AFFECTED FILES

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY On non Debian-based systems libclang is mostly installed as libclang.so., evading detection by clang-${_LIBCLANG_FIND_VERSION}.0. Instead of specyfing and maintaing a list

D5274: extractorcollectiontest: Use QTEST_GUILESS_MAIN

heikobecker created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Allowing the tests to pass without a running X server. TEST PLAN Test still passes REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D5274

[Differential] [Closed] D4052: kbugreport: Remove reference to deprecated KCmdLineArgs

This revision was automatically updated to reflect the committed changes. Closed by commit R263:78ff1ebd4a18: kbugreport: Remove reference to deprecated KCmdLineArgs (authored by heikobecker). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4052?vs=9936=9945

[Differential] [Request, 4 lines] D4052: kbugreport: Remove reference to deprecated KCmdLineArgs

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D4052 AFFECTED FILES src/kbugreport.h EMAIL PREFERENCES

Re: Shipping prison with next frameworks version

Hi, sorry for writing this mail shortly before the tagging of the next Frameworks release, but I got sidetracked by other things. On 09/30/16 09:42, David Faure wrote: > On dimanche 18 septembre 2016 20:03:00 CEST Sune Vuorela wrote: >> Other than asking sysadmin to move prison from kdesupport

Re: Review Request 129559: Also search for hunspell-1.5

marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit 5fc1e9679e0607d7d918b27ee13092a234abefe6 by Heiko Becker to branch master. Repository: sonnet Description --- Also search for hunspell-1.5 Diffs

Re: Review Request 128992: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Marco Martin. Changes --- Submitted with commit c75362b095fb249e8bc60743c7a3ac2ec6e9ee16 by Heiko Becker to branch master. Repository: kdeclarative Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128992: Drop obsolete version check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128992/#review101113 --- Ping? - Heiko Becker On Sept. 21, 2016, 7:36 nachm

Re: Review Request 129559: Also search for hunspell-1.5

the tests. Thanks, Heiko Becker

Review Request 129559: Also search for hunspell-1.5

. Repository: sonnet Description --- Also search for hunspell-1.5 Diffs - cmake/FindHUNSPELL.cmake f028abe Diff: https://git.reviewboard.kde.org/r/129559/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 129418: Adjust directory structure to Frameworks policies

marked as submitted. Review request for KDE Frameworks and Sune Vuorela. Changes --- Submitted with commit 96d2e4e7dfe3d13b85ee37df0961d33566e8659a by Heiko Becker to branch master. Repository: prison Description --- According to the requirements listed on https://community.kde.org

Re: Review Request 129417: Add metainfo.yaml

marked as submitted. Review request for KDE Frameworks and Sune Vuorela. Changes --- Submitted with commit 1b72429bdd256711b1f430367408abe9ddee8186 by Heiko Becker to branch master. Repository: prison Description --- Striking one requirement for becoming a framework from the list

Review Request 129417: Add metainfo.yaml

Description --- Striking one requirement for becoming a framework from the list. Diffs - metainfo.yaml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129417/diff/ Testing --- Thanks, Heiko Becker

Review Request 129418: Adjust directory structure to Frameworks policies

a722367 tools/CMakeLists.txt tools/prison-datamatrix.cpp 6491b76 Diff: https://git.reviewboard.kde.org/r/129418/diff/ Testing --- cmake .. && make Thanks, Heiko Becker

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

marked as submitted. Review request for KDE Frameworks, David Edmundson and Michael Pyne. Changes --- Submitted with commit d922477fc2ca03cc0a2e9ee2470f3cb4b37e0c2e by Heiko Becker to branch master. Repository: kcoreaddons Description --- 70c745d6147e465ce1e34b6037eb7dedb8e77f27

Review Request 129351: Only search for a avatar if loginName isn't empty

Testing --- kusertest doesn't fail anymore. Thanks, Heiko Becker

Re: Review Request 128989: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 5fdcdff6e387b5f6285a6eb5ad0c7f7a99b8bd1a by Heiko Becker to branch master. Repository: kimageformats Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128983: Drop obsolete version check

/diff/ Testing --- Thanks, Heiko Becker

Re: Review Request 128994: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Changes --- Submitted with commit f2f0b2722e2cf53d982c5ebb52425e84278140e1 by Heiko Becker to branch master. Repository: kglobalaccel Description --- Frameworks already require Qt 5.5.0. Diffs

Re: Review Request 128991: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 40077d52b554d5903aa53fffaba46912aa55918a by Heiko Becker to branch master. Repository: kactivities Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128990: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 36142ace3236517180a3ccbcb3e692beebe53498 by Heiko Becker to branch master. Repository: kjobwidgets Description --- Frameworks already require Qt 5.5.0. Diffs - src/debug.cpp

Re: Review Request 128987: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 61c63d6b8e08c60f3336604f45a647691c32cf91 by Heiko Becker to branch master. Repository: kauth Description --- Frameworks already require Qt 5.5.0. Diffs - src/backends/dbus

Re: Review Request 128986: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit c55f73557ca7ab09caaa593d951297cc551c6d72 by Heiko Becker to branch master. Repository: sonnet Description --- Frameworks already require Qt 5.5.0

Re: Review Request 128985: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ed9e2553a92844567f76e7ce468a5d3128e9fb51 by Heiko Becker to branch master. Repository: kitemmodels Description --- Frameworks already require Qt 5.5.0. Diffs - autotests

Re: Review Request 128984: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8c58398b4cafe22ce1cf28fdaf9fb62948425d36 by Heiko Becker to branch master. Repository: kidletime Description --- Frameworks already require Qt 5.5.0. Diffs - src/logging.cpp

Re: Review Request 128988: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker to branch master. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128988: Drop obsolete version check

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker to branch master. Repository: kcrash Description --- Frameworks already require Qt 5.5.0. Diffs - src

Re: Review Request 128988: Drop obsolete version check

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128988/#review99438 --- On Sept. 21, 2016, 7:11 nachm., Heiko Becker wrote: > > --- > This is an

Re: Review Request 128993: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 1536ab6c8996d5f21d7a59089bf99de675faee18 by Heiko Becker to branch master. Repository: kdesignerplugin Description --- Frameworks already require Qt 5.5.0. Diffs

Review Request 128995: Drop obsolete version check

Description --- Frameworks already require Qt 5.5.0. Diffs - src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 Diff: https://git.reviewboard.kde.org/r/128995/diff/ Testing --- Thanks, Heiko Becker

  1   2   >