src/kdropwidgetdecorator.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125521/diff/
Testing
---
It builds, the headers I expect are in the right places, etc. I just noticed
I'm not exporting the class though, will fix that and reupload.
Thanks,
Jere
the class though, will fix that and reupload.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Thanks,
First patch here: https://git.reviewboard.kde.org/r/125521/. After
that I'll try using it in Kile and Okular, see how that goes.
On Thu, Sep 24, 2015 at 11:47 PM, Michel Ludwig wrote:
>
> On 09/25/2015 01:57 AM, Jeremy Whiting wrote:
>>
>> Michel,
>>
&g
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/#review86352
---
On Oct. 4, 2015, 1:43 p.m., Jeremy Whiting wrote:
>
> --
I'd like to weigh in a bit here too. I agree with Boud and Christoph,
most users (developers of applications) of KF5 that aren't KDE
community members will be building the frameworks themselves. At my
last job we built Qt ourselves on all the platforms we targetted and
shipped shared libraries with
Christoph.
I have had similar goals for a while, but haven't reached the point
that I was having much success yet in that regard. One thing to keep
in mind when developing installers, Qt Installer Framework. I did a
quick test with attica on OS X I can put on reviewboard to see what
you think. I a
Christoph,
I'm not trying to argue against having applications come in complete
bundles at all. That is a worthy goal also actually, it's just not the
direction I was headed in. You've made a lot more progress in this
regard than I had though tbh. I see the kdewin installer as something
that went
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125656/#review87199
---
Ship it!
Ship It!
- Jeremy Whiting
On Oct. 21, 2015, 4:29
Yeah, if we go that direction on mac it would be fine for bundled Qt,
but not for shared Qt. It would make all applications that use qt5-mac
or qt5-kde or whatnot use linuxy paths or not. It's a runtime switch,
so not very helpful if you've installed stuff to linuxy paths and then
let the user choo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125767/#review87363
---
Ship it!
Ship It!
- Jeremy Whiting
On Oct. 23, 2015, 12
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125884/#review87824
---
Ship it!
Ship It!
- Jeremy Whiting
On Oct. 30, 2015, 3
Alex,
Last time I checked api.kde.org was generated by scripts in the
websites/quality-kde-org git repository. It includes instructions for
installing it locally, though the instructions are a bit outdated. I
think perl's setup scripts have changed since it was written since I
needed to tweak the
Yeah, that makes sense. Ok will do.
On Sun, Dec 6, 2015 at 3:37 AM, David Faure wrote:
> On Thursday 24 September 2015 20:35:24 Jeremy Whiting wrote:
>> If so I guess the logical place for it would be a TTS group in
>> kdeglobals, does that make sense?
>
> Stay away fro
.
- Jeremy Whiting
On Nov. 12, 2015, 4:15 p.m., Andrew McCann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126948/#review91908
---
Ship it!
Ship It!
- Jeremy Whiting
On Feb. 1, 2016, 12
ds and installs.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ard.kde.org/r/112730/#review41599
---
On Oct. 9, 2013, 2:24 p.m., Jeremy Whiting wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
newstuff/src/ui/entrydetailsdialog.cpp
65b75d79941d9026f368f82c7b6df91d754e0925
knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729
Diff: http://git.reviewboard.kde.org/r/112730/diff/
Testing
---
It builds and installs.
Thanks,
knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1
Diff: http://git.reviewboard.kde.org/r/113388/diff/
Testing
---
Builds.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
orted knewstuff from KImageIO to QImageReader to get the qimage supported
> file formats to put in a filter for QFileDialog.
>
>
> Diffs
> -
>
> knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a
> knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b
&
g.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b
knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1
Diff: http://git.reviewboard.kde.org/r/113388/diff/
Testing
---
Builds.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frame
a42d35443c0d3596d8ef18e46a1ec905fd14a33a
knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b
knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1
Diff: http://git.reviewboard.kde.org/r/113388/diff/
Testing
---
Builds.
Thanks,
Jeremy Whiting
13500/diff/
Testing
---
Builds by itself and as part of kdelibs.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
f/src/CMakeLists.txt 0cdfe43608397b756aba80dcc9c47c7ddf398d66
Diff: http://git.reviewboard.kde.org/r/113500/diff/
Testing
---
Builds by itself and as part of kdelibs.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-
---
KImageIO functions can be deprecated in favor of QImageReader and QImageWriter
functionality.
Diffs
-
kio/kio/kimageio.h cecadf1
Diff: http://git.reviewboard.kde.org/r/113510/diff/
Testing
---
it still builds.
Thanks,
Jeremy Whiting
/diff/
Testing
---
it still builds.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
it still builds.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113500/#review42829
-----------
On Oct. 30, 2013, 9:41 a.m., Jeremy Whiting wrote:
>
> -
s.txt 534ff2f5276591620fa0250d7d6971d75f572209
tier3/knewstuff/src/CMakeLists.txt 24a601ab8df2465382d9114d47f6ff805a17a317
Diff: http://git.reviewboard.kde.org/r/113500/diff/
Testing
---
Builds by itself and as part of kdelibs.
Thanks,
Jeremy Wh
f/src/CMakeLists.txt 24a601ab8df2465382d9114d47f6ff805a17a317
Diff: http://git.reviewboard.kde.org/r/113500/diff/
Testing
---
Builds by itself and as part of kdelibs.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kd
org/r/113696/diff/
Testing
---
It still builds.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
I was actually wondering that myself the other day as I added to it in
kdelibs master (that got branched into KDE/4.12) for a feature that
hit jovie in KDE SC 4.12.
It's used but really only needed to expose jovie's dbus interface for
applications to use. Interestingly, knotify uses jovie but does
, Nov 8, 2013 at 10:40 PM, Jeremy Whiting wrote:
> I was actually wondering that myself the other day as I added to it in
> kdelibs master (that got branched into KDE/4.12) for a feature that
> hit jovie in KDE SC 4.12.
>
> It's used but really only needed to expose jovie&
f/src/uploaddialog_p.h 084d626c095465b5176aa928fed1d6d6342e6e2d
Diff: http://git.reviewboard.kde.org/r/113696/diff/
Testing
---
It still builds.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
I see, and agree. So the way forward with kspeech would be to make it
it's own framework. then at some point turn the header/dbus interface
into a library that can hide the implementation details of using the
dbus interface directly, right?
Something like libkspeech.so that has a class/namespace to
/dbustexttospeech.desktop
interfaces/kspeech/kspeech.h
interfaces/kspeech/org.kde.KSpeech.xml
tier3/CMakeLists.txt c801fd299d95f64d28676f80e86e2c86f9b39024
Diff: http://git.reviewboard.kde.org/r/113844/diff/
Testing
---
Thanks,
Jeremy Whiting
r tier
makes more sense though.
- Jeremy
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/#review43616
---
On Nov. 13, 2013, 10
s.txt c77fa19ad700c6e9af68434d7c6fdc304fceeba6
Diff: http://git.reviewboard.kde.org/r/113844/diff/
Testing
---
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/113844/diff/
Testing
---
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
KNewStuff's Config.cmake is missing it's public dependencies. This adds them.
Diffs
-
tier3/knewstuff/KNewStuffConfig.cmake.in
54bee483444919ee0a337d117ff5f48139d04359
Diff: http://git.reviewboard.kde.org/r/113867/diff/
Testing
---
Thanks,
Jere
Diff: http://git.reviewboard.kde.org/r/113867/diff/
Testing
---
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/diff/
Testing
---
Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hello,
In trying to build frameworks on arch here I'm getting a build error
in kjs/src/kjs/operations.cpp I'm not sure what I may be missing here,
others report it builds fine on other distros. The offending _isnan
seems to be in the original commit also, but I haven't tried to build
since the fra
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115416/#review48709
---
Ship it!
Ship It!
- Jeremy Whiting
On Jan. 31, 2014, 11
lso, since no one stepped up to say if it should be in or out, I'd
> say it
>> > should be with no declared maintainer until someone claims it.
>>
>> I was under the impression that it had a maintainer, although right now I
>> can't remember if that was Jeremy
On Wed, Feb 26, 2014 at 2:30 PM, Milian Wolff wrote:
> Hey,
>
> not sure this is the right list. I noticed that kdesrc-build happily continues
> building even when a module failed to build. Is this desired? I find it highly
> unintuitive, esp. as most modules failing at the beginning will mean all
Hello all, I've realized a bit ago that kspeech was not included in
the kdelibs split (probably because it was in staging at the time and
didn't conform to the other framework policies yet). I've cleaned it
up a bit and put it in my scratch space, but have some architectural
questions about it befo
kde applications to use.
Any thoughts on that? I would be pretty interested in helping with
qtspeech if it greatly simplifies or even deprecates jovie as it looks
like it could do possibly.
Jeremy
On Wed, Mar 5, 2014 at 12:29 PM, Frederik Gladhorn wrote:
> On Tuesday 4. March 2014 16.43.10 Jer
On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn wrote:
> Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting:
>> Took a quick read through that just now and it looks pretty promising
>> from what I saw. I guess I don't know my way around gerrit very well
>> because
Hello,
I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2
on the frameworks branch of it's git repo. If someone would take a
look and check if I did anything wrong that would be great. It builds
here and the tests all pass, but a second (or more) set of eyes is
always welcome.
Hey all,
In looking at frameworks e-mail each day I find it would be much
simpler if we would all add the git repo we are submitting the review
request for in the subject. e-mail with subjects like "make
documentation match new values in code" (not trying to single this one
out, many are not that
Ok, Added myself, good to know. That should help a bit.
On Wed, Apr 30, 2014 at 4:39 PM, Christoph Feck wrote:
> On Wednesday 30 April 2014 22:55:55 Jeremy Whiting wrote:
>> In looking at frameworks e-mail each day I find it would be much
>> simpler if we would all add the
On Wed, Apr 30, 2014 at 6:08 PM, Michael Pyne wrote:
> On Wed, April 30, 2014 14:55:55 Jeremy Whiting wrote:
>> Hey all,
>>
>> In looking at frameworks e-mail each day I find it would be much
>> simpler if we would all add the git repo we are submitting the review
>&
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118962/
---
Review request for KDE Frameworks, Marco Martin and Jeremy Whiting
and the tests run.
Unrelated the sharedkvtmlfilestest exposes a bug in KEduVocDocument::open where
the KFilterDev wont open, (bug from previous commit) not sure what to do here
to fix it though.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing
::open where
the KFilterDev wont open, (bug from previous commit) not sure what to do here
to fix it though.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
though.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks, Marco Martin and Jeremy Whiting.
Repository: knewstuff
Description
---
Add api for setting download widget and dialog title. Helps with bug 336737
Diffs
-
src/downloaddialog.h 7d8f2b40ee46baf18af401631816e0623d797623
src
.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119345/#review62618
---
Ship it!
Ship It!
- Jeremy Whiting
On July 17, 2014, 11
Hello all,
I'm reaching out because I can't seem to find a solution myself.
TLDR If you can get a backtrace from building and running
scratch/whiting/testqmlapp which uses QtWebKit's QML WebView I'd very
much appreciate it.
KAnagram qt4 version from master (before frameworks branch was merged)
ll keep digging I guess.
thanks,
Jeremy
On Fri, Aug 22, 2014 at 3:57 PM, Albert Astals Cid wrote:
> El Divendres, 22 d'agost de 2014, a les 15:45:12, Jeremy Whiting va escriure:
>> Hello all,
>>
>> I'm reaching out because I can't seem to find a solution
55 0x08066d79 in main (argc=1, argv=0xb3d4)
at /home/jeremy/devel/kde/frameworks/kde/kdeedu/kanagram/src/main.cpp:60
The only thing I'm doing in the qml is making the WebView visible and
after about one or two seconds I get this segfault. Anyone with
QtWebKit experience know what&
Hmm, could I be hitting the crash on
TSymbolTableLevel::~TSymbolTableLevel() mentioned here:
http://download.opensuse.org/ports/armv7hl/factory/repo/oss/ChangeLog
On Sat, Aug 23, 2014 at 6:45 PM, Jeremy Whiting wrote:
> Ok, I rebuilt frameworks and such on a fresh debian jessie vm w
Valorie,
I'm a bit confused. books.kde.org says the book is hosted at
flossmanuals, but that url takes me to the oldish "KDE Dev Guide" is
thi Frameworks Cookbook a different thing than that old book, right?
Is the current wip book available somewhere ? I guess if so we should
point that link at i
ate these non-const ones instead.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
es of these methods
that are const and deprecate these non-const ones instead.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
es should all happen on Monday's anymore :)
- Jeremy
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120535/#review68095
-----------
ow BIC changes in frameworks like attica or not
> > is for someone else to answer.
>
> Jeremy Whiting wrote:
> Yes, I saw that, the real question is if we allow BIC changes or not.
> Also I guess if we don't allow BIC changes in frameworks anymore we should
>
only question about committing this is if it's allowed since it's a binary
incompatible change. If it's not allowed I will add duplicates of these methods
that are const and deprecate these non-const ones instead.
Thanks,
Jeremy Whiting
___
K
e. If it's not allowed I will add duplicates of these methods
that are const and deprecate these non-const ones instead.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/list
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120574/
---
Review request for KDE Frameworks and Jeremy Whiting.
Repository
Do we support building and using frameworks on Windows CE anymore? I
don't see it on
http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess
not, is that correct? If not I can clean up some old ifdefs in
knewstuff sources.
thanks,
Jeremy
___
, David Faure, Vavelin Kevin, and Jeremy
Whiting.
Changes
---
Added Kevin and David to weigh in.
Repository: knewstuff
Description
---
Add explicit to ctors with one parameter
Diffs
-
src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165
src/button.h
marked as submitted.
Review request for KDE Frameworks, David Faure, Vavelin Kevin, and Jeremy
Whiting.
Repository: knewstuff
Description
---
Add explicit to ctors with one parameter
Diffs
-
src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165
src/button.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120589/
---
Review request for KDE Frameworks, Nicolás Alvarez and Jeremy Whiting
Hello,
In KNewStuff autotests there are two disabled tests that build and
work if I export the Author and EntryInternal classes, but these two
classes are private (declared in _p.h files) so I'd rather not export
them, since they aren't public api. Is there a way to have them
exported when BUILD_T
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/
---
Review request for KDE Frameworks and Jeremy Whiting.
Repository
Jeremy Whiting.
Changes
---
Fix summary
Summary (updated)
-
enable autotests for knewstuff
Repository: knewstuff
Description
---
Enable autotests.
Make autotests build in the sources they need to test to avoid exporting.
Patch by Albert Astals Cid
Diffs
Meh, Albert found a decent enough way to do it. Posted to rb to look at.
On Tue, Oct 14, 2014 at 5:03 PM, Aleix Pol wrote:
> On Tue, Oct 14, 2014 at 10:37 PM, Jeremy Whiting wrote:
>>
>> Hello,
>>
>> In KNewStuff autotests there are two disabled tests that build
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Repository: knewstuff
Description
---
Enable autotests.
Make autotests build in the sources they need to test to avoid exporting.
Patch by Albert Astals Cid
Diffs
-
autotests/CMakeLists.txt
marked as submitted.
Review request for KDE Frameworks, Nicolás Alvarez and Jeremy Whiting.
Repository: knewstuff
Description
---
Remove #ifndefs for WIN CE, we don't support CE anymore.
Diffs
-
src/core/installation.cpp b69837db5b9ec05bce0a9c7bdc854fa0c9391f0e
Diff:
Description
---
Fix typo in documentation.
Diffs
-
src/kconfigdialog.h 436aa05e7e206ccb8a814bb590d9c1af28c1fb98
Diff: https://git.reviewboard.kde.org/r/120903/diff/
Testing
---
It's a comment, no code to test.
Thanks,
Jeremy Wh
7;s a comment, no code to test.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
s, then move it to
kde/workspace unless someone has a better idea for it. It only needs
CoreAddons, WidgetsAddons, I18n, and Wallet frameworks.
thanks,
Jeremy
On Sat, Nov 1, 2014 at 2:40 PM, Jeremy Whiting wrote:
> Ok, I'll push it to git somewhere today and let the list know where so
>
Ok, pushed to kde:ksshaskpass now. I'll request it move to kdereview
tomorrow. I would like at least one other person to try it before
that, as I'm the only one that has built and run the kf5 port that I
know of.
thanks,
Jeremy
On Sat, Nov 1, 2014 at 3:14 PM, Jeremy Whiting wrote:
&g
> Regards.
>
>
> Le Sunday 02 November 2014 16:21:32 Jeremy Whiting a écrit :
>> Ok, pushed to kde:ksshaskpass now. I'll request it move to kdereview
>> tomorrow. I would like at least one other person to try it before
>> that, as I'm the only one that has
Hey David,
I started taking a stab at the KApplication -> QApplication
fix/conversions, then pulled and can't build currently. I can't tell
from the last few commits what broke it either. The error I'm getting
is about KDE_DEPRECATED in kdecore/config/kconfig.h included from
ksharedconfig.h
Not
On Fri, Aug 3, 2012 at 6:52 PM, David Faure wrote:
> On Friday 03 August 2012 13:57:54 Jeremy Whiting wrote:
>> Hey David,
>>
>> I started taking a stab at the KApplication -> QApplication
>> fix/conversions, then pulled and can't build currently. I can'
appen, maybe not worth it to add to the wiki, dunno.
Jeremy
On Sun, Aug 5, 2012 at 5:17 AM, David Faure wrote:
> On Saturday 04 August 2012 09:41:28 Kevin Ottens wrote:
>> On Saturday 04 August 2012 00:52:16 David Faure wrote:
>> > On Friday 03 August 2012 13:57:54 Jeremy Whiting
I tried adding frameworks group to the last review I posted for the
cleanup task I just finished, but rb said there's no such group...
Jeremy
On Fri, Jul 20, 2012 at 10:04 AM, David Faure wrote:
> There is now a "frameworks" group on reviewboard, which you can use so that
> reviews are sent to t
I didn't check the make test against the result you are getting on the main
branch, no. I'll remove the KAboutData from these and check that. Some of
these KAboutData have quite a bit in them, is it ok to nuke them?
I also found one KApplication usage in an io slave that's part of the
patch, is
Just to clarify. that page about building qt5 builds the stable branch, and
in order to change to the dev branch we need to in each submodule do git
checkout -b dev origin/dev ? or is there some easy way to get all
submodules on the dev branch to build the dev version of all of qt5? I
didn't find
Hello,
Apparently my commit to knewstuff broke the build. The problem is that
knewstuff/src/knewstuffbutton.h includes which
hasn't been installed yet when building kdelibs. I looked around and
saw some other frameworks install headers install directly into
include (kauth.h includes "kauthaction
ki18n/KI18nConfig.cmake.in 18b6e2f
tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION
tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112785/diff/
Testing
---
Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
Thanks,
J
ould we reintroduce kde4uic.cmake in the ki18n framework (with a
> > better name), to have this work like in kde4?
> >
> >
Yep, doing so in a different review.
- Jeremy
---
This is an automatically generated e-mail. To reply, visit:
http:/
E-CREATION
> tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112785/diff/
>
>
> Testing
> ---
>
> Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
>
>
> Thanks,
>
> Jeremy Whitin
> On Sept. 23, 2013, 4:37 a.m., Kevin Ottens wrote:
> > I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
> > partly.
>
> Jeremy Whiting wrote:
> well, qt5_wrap_ui wasn't around when this was created (as
> kde4_add_ui_fil
Aurélien,
Thanks for the detailed explanation. Now the questions become:
a) when will that cmake feature be in a released version of cmake?
b) what should we do to get frameworks ready if not making them build
by themself and part of kdelibs both?
I guess I can go rename my private headers to _
src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729
Diff: http://git.reviewboard.kde.org/r/112730/diff/
Testing
---
It builds and installs.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1 - 100 of 239 matches
Mail list logo
