D20039: [KConfig] Add Notify capability for revertToDefault

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This enables `KConfigWatcher` TEST PLAN In preparation

D19979: Don't create thumbnails for encrypted Vaults

broulik added inline comments. INLINE COMMENTS > previewjob.cpp:307 > > +auto mountsList = KMountPoint::currentMountPoints(); > +KMountPoint::List encryptedMountsList; Did you profile the impact of this call? I don't think it's cached. Can this maybe be moved to the thumbnail KIO so

D19990: Switch URLs to https

broulik added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19990 To: vkrause, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19985: [KStatusNotifierItem] Send desktop-entry hint

broulik created this revision. broulik added a reviewer: Framework: Syntax Highlighting. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This allows the notification service to know where the

D19985: [KStatusNotifierItem] Send desktop-entry hint

broulik edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19985 To: broulik, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19978: Allow to set custom hints for notifications

broulik added a comment. +1 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19978 To: nicolasfella, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19908: [ConfigModule] Pass initial properties

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN There's probably some std algo for it but `std::copy` didn't work so I gave up.

D19806: Allow selecting only supported audio files

This revision was automatically updated to reflect the committed changes. Closed by commit R305:5e2b9c838f3f: Allow selecting only supported audio files (authored by broulik). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19806?vs=54014=54358 REVISION

D19805: Manager: Don't require Media1 interface for initialization

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH bug405478 REVISION DETAIL https://phabricator.kde.org/D19805 To: drosca, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19806: Allow selecting only supported audio files

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY While Phonon could play all the files, libcanberra as a low-latency

D19786: Fix WebDAV directory renaming if KeepAlive is off

broulik added a reviewer: sitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19762: Only get clearTextPath when used

This revision was automatically updated to reflect the committed changes. Closed by commit R245:185177379cc0: Only get clearTextPath when used (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19762?vs=53892=53996 REVISION DETAIL

D19767: Fix malloc/delete mismatch

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D19768: Fixes memory leak of ssh_session

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19768 To: hallas, #frameworks, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19762: Only get clearTextPath when used

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It does some queries and introspection that takes up to 2ms. TEST PLAN

D19500: [KDirModel] Fix job urls change signal connection

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik, #frameworks, dfaure, jtamate Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19728: [GridViewKCM] Fix implicit width calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:72f438f8e7ad: [GridViewKCM] Fix implicit width calculation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19728?vs=53799=53800

D19728: [GridViewKCM] Fix implicit width calculation

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Take into account paddings around the page and scroll view and also use the

D19728: [GridViewKCM] Fix implicit width calculation

broulik edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19728 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

This revision was automatically updated to reflect the committed changes. Closed by commit R288:4f4298539104: [KUiServerJobTracker] Update destUrl before finishing the job (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE

D19698: Remove crash in plasmashell

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH remove_crash_bug_405351 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19698 To: mlaurent, dfaure, #frameworks, #plasma, broulik Cc:

D19696: Add blender thumbnailer

broulik added a comment. Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is kdegraphics-thumbnailers a thing that is installed out of the box in most distros? REPOSITORY R320

D19699: [DataModel] Add nullptr check

broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19699 To: broulik, #plasma, mlaurent, arojas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19698: Remove crash in plasmashell

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > datamodel.cpp:67 > { > -return sourceModel()->roleNames(); > +if (sourceModel()) > + return sourceModel()->roleNames(); Coding style, braces

D19699: [DataModel] Add nullptr check

broulik created this revision. broulik added reviewers: Plasma, mlaurent, arojas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Regression introduced by 9fc663d9f0edf41acd098b7c6c7b090d2c7b5aea

D19418: Make it compiles without deprecated method

broulik reopened this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.cpp:67 > +{ > +return sourceModel()->roleNames(); > +} Likely culprit here, `sourceModel()` being `null` REPOSITORY R242 Plasma Framework (Library)

D19418: Make it compiles without deprecated method

broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol, broulik Cc: broulik, arojas, kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

broulik added a comment. I'm confused. Doesnt this undo the use of @2x icons and return to the old behavior of just loading a larger icon? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: broulik, ngraham, bruns, fvogt,

D19679: Support image/vnd.zbrush.pcx mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f74cec16ec01: Support image/vnd.zbrush.pcx mime type (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19679?vs=53647=53648#toc REPOSITORY R320 KIO Extras CHANGES SINCE

D19679: Support image/vnd.zbrush.pcx mime type

broulik created this revision. broulik added reviewers: Frameworks, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `image/x-pcx` is deprecated TEST PLAN I now

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik added a comment. In plasma-browser-integration I get a download started event by the browser right away and only when the user chose a download location I will get notified of that, so the job does not have a `destUrl` in the beginning. REPOSITORY R288 KJobWidgets REVISION DETAIL

D19674: [Icon Item] Also clear image icon when using Plasma Svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:017954185c83: [Icon Item] Also clear image icon when using Plasma Svg (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19677: WIP: Port UDisks to using DBus ObjectManager

broulik retitled this revision from "Port UDisks to using DBus ObjectManager" to "WIP: Port UDisks to using DBus ObjectManager". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D19677 To: broulik, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19677: Port UDisks to using DBus ObjectManager

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Right now it introspects DBus and fetches properties all over the place.

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2404693b9975: [CopyJob] Treat URL as dirty when renaming file as conflict resolution (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik added a comment. Isn't "where the job first has to examine the real destination and only can then set it and start." and "In plasma-browser-integration I only get the destination after the job has been started." sufficient? REPOSITORY R288 KJobWidgets REVISION DETAIL

D19674: [Icon Item] Also clear image icon when using Plasma Svg

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When changing an `IconItem` from using a local image (e.g. PNG file) to using a

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

broulik added a dependent revision: D19588: [Notifications] Improve finished notification. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19586 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19585: [CopyJob] Report results after finishing copy

broulik added a dependent revision: D19588: [Notifications] Improve finished notification. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19585 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

broulik created this revision. broulik added reviewers: dfaure, chingku. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When a file already exists and user choses to rename the file, the URL wasn't

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

broulik edited reviewers, added: chinmoyr; removed: chingku. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19586 To: broulik, dfaure, chinmoyr, chingku Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19585: [CopyJob] Report results after finishing copy

broulik created this revision. broulik added reviewers: dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently, `slotReport` is called all the way at the end when in

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik edited the test plan for this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19583 To: broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik created this revision. broulik added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is not really meant to be changing after the job started, but there can be

D19557: Update css

broulik added a comment. Can't we just go SVG with the icon? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

broulik added a reviewer: sitter. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19500: [KDirModel] Fix job urls change signal connection

broulik added a comment. > Just out of curiosity, Did you notice the problem because something was missing in execution? I was toying around with the transfer jobs visible feature in `KDirModel` and got a warning when I enabled it. It isn't used by Dolphin anymore and not supported by

D19500: [KDirModel] Fix job urls change signal connection

broulik created this revision. broulik added reviewers: Frameworks, dfaure, jtamate. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The private slot declaration for `_k_slotJobUrlsChanged` got removed as part

D19421: [Icon Item] Block next animation also based on window visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b6a6bb8e175b: [Icon Item] Block next animation also based on window visibility (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19421?vs=52830=52832#toc REPOSITORY R242

D19421: [Icon Item] Block next animation also based on window visibility

broulik retitled this revision from "WIP: [Icon Item] Block next animation also based on window visibility" to "[Icon Item] Block next animation also based on window visibility". broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D19421: WIP: [Icon Item] Block next animation also based on window visibility

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Plasma `Dialog` used to change the item's visiblity but this is no longer the case,

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

broulik added a comment. Works fine here, thanks, but I don't feel qualified enough to comment on this patch, I added Frameworks reviewers. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: kde-frameworks-devel, michaelh,

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

broulik added a reviewer: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19339: Add option to change drive label to places panel context menu

broulik added a comment. Also, this should probably go into Solid StorageVolume with proper backend abstraction REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19339 To: chinmoyr, #dolphin, #frameworks Cc: broulik, ngraham, bruns, kfm-devel, alexde, feverfew,

D18883: Add PDF thumbnailer

broulik added a comment. Perhaps but it's only recently become an issue since kioslaves now support KCrash. Previously such thumbnailer crashes just went unnoticed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc:

D18883: Add PDF thumbnailer

broulik added a comment. However, you will get a Dr Konqi each time it encounters that file as it will try to generate a thumbnail for it every time you open the folder. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate

D19020: [breeze-icons] Revamp system.svgz

broulik added a comment. What's the air conditioning do? suspend to disk? +1 on the moon for suspend REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: broulik, kde-frameworks-devel, michaelh,

D18883: Add PDF thumbnailer

broulik added a comment. Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef,

D18940: Add battery icons

broulik added a comment. The do a proper proposal (I bet you already have a task about that) instead of just slipping things in one by one in unrelated reviews REPOSITORY R266 Breeze Icons BRANCH battery-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18940

D18940: Add battery icons

broulik added a comment. The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon. I'm in favor of adding proper battery icons to the Breeze iconset, definitely need "battery", "battery-caution", "battery-low" icons (from the

D18940: Add battery icons

broulik added a comment. In D18940#411316 , @ndavis wrote: > Won't 3rd party themes contain their own icons? Sure but in the style of a Plasma battery.svgz, so if we change the `BatteryIcon` to use icon theme instead of Plasma theme

D18940: Add battery icons

broulik added a comment. > maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme And in the process break all third party Plasma themes? REPOSITORY R266 Breeze Icons REVISION DETAIL

D18883: Add PDF thumbnailer

broulik added inline comments. INLINE COMMENTS > dhaumann wrote in pdfcreator.cpp:62 > Does this also give nice results with high dpi displays? KIO Thumbnailer doesn't support high dpi at all at this point. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To:

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. But that will create additional, potentially defunct entries in Previewer settings? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde,

D18882: [Image Thumbnailer] Support eps files

broulik planned changes to this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns,

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. Ah, yeah, it tries and if it fails, it aborts, it doesn't try every thumbnailer that claims to support a format. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham,

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. > OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure, ngraham Cc: pino, ngraham,

D18883: Add PDF thumbnailer

broulik updated this revision to Diff 51292. broulik added a comment. - Render image at desired size already - Remove unused include REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18883?vs=51290=51292 REVISION DETAIL

D18882: [Image Thumbnailer] Support eps files

broulik added a comment. You'll get a thumbnail either way \o/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18882 To: broulik, jtamate, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef,

D18883: Add PDF thumbnailer

broulik added inline comments. INLINE COMMENTS > pino wrote in pdfcreator.cpp:45-46 > please honor the requested width and height I can't. The `renderToImage` can only be told a resolution or part of the page to render, to render downscaled into a certain box. The `ThumbnailJob` downscales

D18883: Add PDF thumbnailer

broulik updated this revision to Diff 51290. broulik added a comment. - Remove mimetypes left from testing - Don't encode filename (missed that there's one other than the `QByteArray` one) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D18883: Add PDF thumbnailer

broulik created this revision. broulik added reviewers: dfaure, aacid, jtamate. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This adds a PDF thumbnailer using libpoppler.

D18882: [Image Thumbnailer] Support eps files

broulik created this revision. broulik added reviewers: jtamate, dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY There's a KImageFormats plugin for EPS files, so we can

D18849: [KPropertiesDialog] Fix group combobox

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18849 To: cfeck, #frameworks, #dolphin, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

This revision was automatically updated to reflect the committed changes. Closed by commit R320:c6da4dabf635: Extend Open Document thumbnailer to Open Packaging Conventions format (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D18739: Sync QML module padding to reflect system setting pages

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma, broulik Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

broulik retitled this revision from "Extend Open Document thumbnailer to Office Open XML" to "Extend Open Document thumbnailer to Open Packaging Conventions format". broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R320 KIO Extras

D18768: Extend Open Document thumbnailer to Office Open XML

broulik updated this revision to Diff 51173. broulik added a comment. - Read thumbnail location from `rels` - Add `.xps` file format (used in Windows for printing, I believe) which also follows the spec and qualifies as "office document" REPOSITORY R320 KIO Extras CHANGES SINCE LAST

D18739: Sync QML module padding to reflect system setting pages

broulik added a comment. If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch. kcmshell5 icons style Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same

D18487: Do background contrast fallback at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7ca1f01ea91a: Do background contrast fallback at runtime (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D18487: Do background contrast fallback at runtime

broulik updated this revision to Diff 51085. broulik retitled this revision from "Reparse background contrast settings when colors changed" to "Do background contrast fallback at runtime". broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE

D18738: Add ebook thumbnailer

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kio-extras.git/commit/?id=db7e30823b8a26b1f8bec721f2079bed6132a155 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

broulik added a comment. +1 I think this is a fine tradeoff between aesthetics and usability REPOSITORY R296 KDeclarative BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma,

D18768: Extend Open Document thumbnailer to Office Open XML

broulik created this revision. broulik added reviewers: Plasma, VDG, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This tries to extract the `docProps/thumbnail.*`

D18487: Reparse background contrast settings when colors changed

broulik added inline comments. INLINE COMMENTS > mart wrote in theme_p.cpp:754 > but it wouldn't be guaranteed to be the same of the value stored in the > config file no? If the theme does not supply background contrast values, they are auto-determined from the background color (dark or

D18755: Read IKWS search provider icon from desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e1c386f04303: Read IKWS search provider icon from desktop file (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18755?vs=50934=50938 REVISION

D18755: Read IKWS search provider icon from desktop file

broulik created this revision. broulik added reviewers: Frameworks, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to give them more meaningful icons rather than the one derived

D18730: Use breeze icons for search providers

broulik added a comment. Check out D18730 Then you can put `Icon=foo` in the respective search provider desktop file REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc:

D18730: Use breeze icons for search providers

broulik added a comment. Yeah -1, `filterData.iconNameForPreferredSearchProvider` should give us a proper icon. https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps needs to have icons added REPOSITORY R223 Okular REVISION DETAIL

D18731: Replace KIconThemes dependency with equivalent QIcon usage

broulik added a comment. I think `QIcon::fromTheme` also handles absolute paths, if given. This should be fine. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18731 To: vkrause, davidedmundson Cc: broulik, cfeck, kde-frameworks-devel, michaelh,

D18612: Cache the default KColorScheme configuration

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18738: Add ebook thumbnailer

broulik updated this revision to Diff 50896. broulik added a comment. - Resolve path to cover relative to OPF file - Search for `iTunesArtwork` as fallback - Search for any file `*cover*` as fallback REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D18738: Add ebook thumbnailer

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can extract thumbnails from epub and fb2 ("fiction book",

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

broulik added a comment. Can we put the buttons at least fully inside the frame? With the boxes halfway outside it looks weird imho REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts,

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fa6eaac55beb: [PreviewJob] Also pass along that were the thumbnailer when stating file (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18699: [KIO/RenameDialog] Add new apply behaviour

broulik added a comment. I find the wording and usability a bit confusing, "Older Dest", "Newer Dest", etc. I think that dialog needs to be overhauled entirely for this approach to work, cf. to how windows uses command links for that (they're also quite hard to grasp at a glance imho), not

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

broulik added a dependent revision: D18654: [fonts:/ KIO] Implement stat() call. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18653 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Enables the KIO to react differently when being stat'd by the thumbnail

D18612: Cache the default KColorScheme configuration

broulik added a comment. I also noticed that on application startup two default color schemes are created: One by plasma-integration set on `QApplication` and the other by `QStyle::standardPalette()` in the widget style. I couldn't figure out a way to avoid this (have QStyle use the

D18630: Fix warning

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18630 To: apol, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

<    3   4   5   6   7   8   9   10   11   12   >