D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

kfunk added a comment. FYI: I'll wait with pushing until v5.33 is released. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5302 To: kfunk, kossebau, dfaure, apol Cc: apol, #frameworks, #build_system

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

kfunk added a comment. In https://phabricator.kde.org/D5302#99816, @apol wrote: > +1 > > Which warnings? Are they proper warnings that should be fixed? See comment inside the source code: It's triggered by normal usage from `qCDebug()`... REPOSITORY R240 Extra CMake Modules

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

kfunk updated this revision to Diff 13096. kfunk added a comment. Re-enable for Clang REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5302?vs=13094&id=13096 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5302 AFFECTED FILES k

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

kfunk added reviewers: kossebau, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5302 To: kfunk, kossebau, dfaure Cc: #frameworks, #build_system

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Add it to KDECompilerSettings.cmake instead of KDEFrameworkCompilerSettings.cmake. Users can then just enable

D5299: Fix KDirlister Gui Test setting URL scheme twice

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5299 To: davidedmundson, #frameworks, kfunk

D4778: Add include that is needed in msys2

This revision was automatically updated to reflect the committed changes. Closed by commit R245:21118a62b546: Add include that is needed in msys2 (authored by kfunk). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4778?vs=11798&id=13083 REVISION DETAIL https:

D4778: Add include that is needed in msys2

kfunk added a comment. I've pushed your patch now. Usually the author is responsible for pushing, as long as he has commit access to our infrastructure ;) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4778 To: russellg, #frameworks, kfunk Cc: kfunk

Re: kioslave nogui

can drop the call > entirely and if not if we there is any downside to dropping it for > windows. > > Cheers, > HS -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D5231: Fix build with Qt branch 5.9

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D5231 To: apol, #frameworks, kfunk

D5233: Fix build with Qt 5.9

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D5233 To: apol, #frameworks, ivan, kfunk

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

kfunk added inline comments. INLINE COMMENTS > config-kioslave-file.h.cmake:13 > > +/* Defined if st_birthime is defined */ > +#cmakedefine01 HAVE_ST_BIRTHTIME Note: typo REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, ra

D5136: Introduce fetch-translations build command

kfunk added a comment. In https://phabricator.kde.org/D5136#96878, @aacid wrote: > I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. > > This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. >

D5136: Introduce fetch-translations build command

kfunk added inline comments. INLINE COMMENTS > KF5I18nConfig.cmake.in:12 > + > +execute_process(COMMAND git config --get remote.origin.url > +OUTPUT_VARIABLE reponame Can you delay that git invocation to when the custom target is executed? Otherwise we also pay for this whenever `KF5I18nCon

D5136: Introduce fetch-translations build command

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#96418, @kossebau wrote: > In https://phabricator.kde.org/D3987#95858, @kfunk wrote: > > > Closing. This Diff refactored the code technically correct. > > > Technically correct, as in: it builds. > But semantically it

D5108: Fix setPen call

kfunk added a comment. Thanks for the quick fix! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5108 To: cullmann, kfunk Cc: kwrite-devel, #frameworks

D5108: Fix setPen call

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5108 To: cullmann, kfunk Cc: kwrite-devel, #frameworks

D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. Closing. This Diff refactored the code technically correct. If you want to replace `MyFlags flags = nullptr` by `... = {}` please do so in a follow-up patch/review. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D3987 To: kfunk, #framework

D3850: Pass -fno-operator-names when supported

kfunk closed this revision. kfunk added a comment. Closing. Please just strip the flag from CMake flags if you're using a library making use of alternative tokens. We've just seen compilation failing early because some lib in KF5 accidentally used alternative tokens => would have broken

D5089: KDE compiler settings fail to consider AppleClang

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system

D5089: KDE compiler settings fail to consider AppleClang

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system

D5089: KDE compiler settings fail to consider AppleClang

kfunk added a comment. +1 to apol's recommendation. `... MATCHES "Clang"` is the expression everyone uses. Even in cmake.git: Modules/CMakeDetermineCCompiler.cmake 138: if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang") Also see: http://stackov

Re: D4941: Avoid a lot allocations in KConfig

g/D4910 Cheers, Kevin > TEST PLAN > Given it only alters the allocation behavior, no changes visible, beside > less heap allocs. > > REPOSITORY > R237 KConfig > > REVISION DETAIL > https://phabricator.kde.org/D4941 > > AFFECTED FILES > src/core/kconfigini.cpp

Re: Differential e-mail subject re-arrangement

g a "vertical" line in which all the > > > subjects of the differential emails start makes it much easier to read.> > > +1 I'd even shorten The 'Differential' part of it to just 'Diff'. > > Agreed to both. +1 > Regards, > - Michael Pyn

[Differential] [Accepted] D4778: Add include that is needed in msys2

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #frameworks, kfunk Cc: kfunk

[Differential] [Accepted] D4733: Port to categorized logging and clean includes

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH categorized-logging REVISION DETAIL https://phabricator.kde.org/D4733 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, kfunk Cc: #

[Differential] [Abandoned] D4727: Avoid excessive debugging output for "Loaded URL="

kfunk abandoned this revision. kfunk added a comment. Okay, please do. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ltoscano Cc: #frameworks, #document

[Differential] [Updated] D4727: Avoid excessive debugging output for "Loaded URL="

kfunk added a reviewer: ltoscano. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ltoscano Cc: #frameworks, #documentation

[Differential] [Updated] D4727: Avoid excessive debugging output for "Loaded URL="

kfunk added a reviewer: Frameworks. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks Cc: #frameworks, #documentation

[Differential] [Request, 4 lines] D4727: Avoid excessive debugging output for "Loaded URL="

kfunk created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D4727 AFFECTED FILES src/xslt.cpp EMAI

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

kfunk added a comment. Thanks for the investigation, Francis! \o/ REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks, graesslin Cc: kfunk, graesslin

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. I start to agree that it's probably better to revert this patch, for the simple reason: We might break compilation of a project using boost if boost decides to add code which uses alternative tokens to any of its headers. This is not under our control. On the othe

[Differential] [Accepted] D3826: Detect inotify.

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH inotify REVISION DETAIL https://phabricator.kde.org/D3826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, apol, arrowdodg

Re: Qt::WindowFlags f = nullptr in framworks headers

On Friday, 20 January 2017 09:19:21 CET Kevin Funk wrote: > On Wednesday, 18 January 2017 21:12:07 CET Stephen Kelly wrote: > > Hello, > > > > As a result of the recent porting from 0 to nullptr, we have things like > > > > Qt::WindowFlags f = nullptr Please

Re: Qt::WindowFlags f = nullptr in framworks headers

s obvious that the headers should be fixed to solve the issue) can not > handle this. > > Thanks, > > Steve. -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#78420, @kossebau wrote: > In https://phabricator.kde.org/D3987#78383, @dfaure wrote: > > > I agree. But it's the default value anyway, so why not remove it completely, thus making everyone happy? > > > What do you mean

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#78421, @kossebau wrote: > Another possible issue with using `nullptr`as value for flags: it might break calling methods with overloads when once a pointer type and once a flags type is used. Not seen, but there is a risk. >

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#78257, @kossebau wrote: > Seems the porting script had a few wrong matches, where 0 values for enums were misinterpreted as pointer: > > E.g. > > @@ -1015 +1015 @@ void KWindowSystemPrivateX11::setShowingDesktop(bool s

[Differential] [Accepted] D4179: Fix compilation with clang

kfunk accepted this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision is now accepted and ready to land. Note: That's due to my patch in https://phabricator.kde.org/D3850 REPOSITORY R378 KExiv2 Library BRANCH master REVISION DETAIL https://phabricator.kde.or

[Differential] [Closed] D4154: Fix some -Wdocumentation warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9888ddd2e1b9: Fix some -Wdocumentation warnings (authored by kfunk). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4154?vs=10270&id=10284 REVISION DETAIL https://ph

[Differential] [Updated] D4154: Fix some -Wdocumentation warnings

kfunk marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4154 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks Cc: aacid, #frameworks

[Differential] [Updated, 104 lines] D4154: Fix some -Wdocumentation warnings

kfunk updated this revision to Diff 10270. kfunk added a comment. Address comments by aacid & fix a few more warnings REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4154?vs=10208&id=10270 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4154 AF

[Differential] [Abandoned] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk abandoned this revision. kfunk added a comment. Patched Qt instead: https://phabricator.kde.org/R138:7f78f7297add7c510c1cf0f1707197c8c403fcee I can't make my mind up how to fix this cleanly, to be honest. REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES

[Differential] [Abandoned] D2546: Cleanup DBus-related resources before qApp exits

kfunk abandoned this revision. kfunk added a comment. Patched Qt instead: https://phabricator.kde.org/R138:7f78f7297add7c510c1cf0f1707197c8c403fcee I can't make my mind up how to fix this cleanly, to be honest. REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES

[Differential] [Closed] D3392: winutils_p.h: Restore compatibility with WinXP SDK

kfunk closed this revision. kfunk added a comment. This has been pushed: commit f86e587aefd94b5ea2c6f7ecca29c266f36256fa Author: Kevin Funk Date: Wed Nov 16 22:32:32 2016 +0100 winutils_p.h: Restore compatibility with WinXP SDK REVISION DETAIL https

[Differential] [Commented On] D3393: Make compile against WinXP SDK

kfunk added a comment. This has been pushed: commit 61f3c9fef7a5ca1a952e7681f5d37b7a9f0689c4 Author: Kevin Funk Date: Wed Nov 16 23:02:33 2016 +0100 Make compile against WinXP SDK REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL PREFERENCES https

[Differential] [Abandoned] D3393: Make compile against WinXP SDK

kfunk abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, arichardson, #frameworks Cc: dhaumann

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#77726, @dfaure wrote: > In https://phabricator.kde.org/D3987#77725, @kfunk wrote: > > > Want me to do a `s/Q_NULLPTR/nullptr/`, too? > > > This would make things consistent and avoid confusing future contributors about

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. Hmm, one thing I forgot to ask: Want me to do a `s/Q_NULLPTR/nullptr/`, too? REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, dfau

[Differential] [Commented On] D3826: Detect inotify.

kfunk added a comment. @dfaure `find_path` is okay here, it's commonly used for finding includes. See: https://cmake.org/cmake/help/v3.0/command/find_path.html `check_include_files` is used for just checking the existence of a include, not finding out //where// it is. Example use: `CHE

[Differential] [Requested Changes To] D3826: Detect inotify.

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FindInotify.cmake:51 > +if(Inotify_INCLUDE_DIRS) > + # On Linux there is no library to link against, on the BSDs there is. > + #

[Differential] [Updated] D4154: Fix some -Wdocumentation warnings

kfunk added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4154 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks Cc: #frameworks

[Differential] [Request, 88 lines] D4154: Fix some -Wdocumentation warnings

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4154 AFFECTED FILES src/core/global.h src/core/job_base.h src/core/j

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

have applied `Q_DECL_OVERRIDE` everywhere. Do you want to double-check? - Kevin Funk On Dec. 29, 2016, 11:48 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Frameworks minimum required GCC version raised to 4.6

y.kde.org/Frameworks/Policies Regards, Kevin [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2016-December/ 040653.html -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

[Differential] [Closed] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

This revision was automatically updated to reflect the committed changes. Closed by commit R280:42ae697a1afe: Use nullptr everywhere (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3987?vs=9785&id=10206#toc REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, dfaure Cc: dfaure, graesslin

[Differential] [Closed] D3850: Pass -fno-operator-names when supported

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a5f3a76e1479: Pass -fno-operator-names when supported (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3850?vs=9443&id=10205 REVISIO

[Differential] [Accepted] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D2075#76591, @jonathans wrote: > They interrupt the logical flow of the code, and because the conditionally executed code no longer sits inside an indented

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk added a comment. Why did you remove all the early-returns? Was that the case before in one of your earlier patches? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D2075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T

Re: including kde classes in qt

to the original post. Also please include replies you've already seen, next time... Thanks, Kevin [1] http://lists.qt-project.org/pipermail/interest/2017-January/025694.html -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

py to receive any patches that improve shortcut handling in KDevelop on Mac. Cheers, Kevin > > R. -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added inline comments. INLINE COMMENTS > graesslin wrote in job.h:50 > Question: is this change API and ABI stable? Definitely ABI stable, since default arguments are not part of the function signature. I'm not aware this could break API compat either (well, only in case the compiler co

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

Re: To C++11 or not?

On Friday, 30 December 2016 15:29:52 CET Kevin Funk wrote: > On Friday, 30 December 2016 15:25:56 CET David Faure wrote: > > On vendredi 30 décembre 2016 12:56:09 CET Albert Astals Cid wrote: > > > El divendres, 30 de desembre de 2016, a les 12:24:38 CET, Luig

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Request, 2,027 lines] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk created this revision. kfunk added a reviewer: Frameworks. kfunk set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. REVISION SUMMARY The full patch (all Frameworks ported to using nullptr instead of null literals) changes around 9000 line

Enabling Clang's -Wdocumentation in Frameworks...?

those warnings and fix them -- only then we could enabled -Wdocumentation globally... Would be nice to have though. I've just enabled it for all of kdevplatform/ kdevelop. Cheers, Kevin [1] http://clang.llvm.org/docs/UsersManual.html#comment-parsing-options -- Kevin Funk | kf...@kde.org |

[Differential] [Accepted] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kfunk accepted this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision is now accepted and ready to land. Rest LGTM, but let's wait for another review INLINE COMMENTS > kdynamicjobtrackernowidgetstest.cpp:34 > +public: > +virtual void start() { QTimer::singleSho

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

too many warnings caused by this change. We'll reapply it after the KF5 release. Most of the warnings have been fixed by Laurent a few days ago (and I have a few more patches I'll push after the release). - Kevin Funk On Dec. 29, 2016, 11:48 p.m., Albert Astals

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: I'll push this after the imminent KF5 release if no-one objects. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfun

Re: To C++11 or not?

on. > > Sorry. > > We need to have a way to enable that warning flag which is accompanied > by a way to resolve the huge amount warnings it generates. We can't just > add that much noise to all the builds indefinitely. > > clang-tidy seems to have a modernize-use-ove

Re: To C++11 or not?

gt;> > >> escriure: > >> > Il 30 dicembre 2016 10:30:22 CET, Kevin Funk ha scritto: > >> > >Following-up on this thread, since I saw some more discussion about > >> > >C++11 > >> > > > >> > >usage in this RR: >

Re: To C++11 or not?

On Friday, 30 December 2016 15:25:56 CET David Faure wrote: > On vendredi 30 décembre 2016 12:56:09 CET Albert Astals Cid wrote: > > El divendres, 30 de desembre de 2016, a les 12:24:38 CET, Luigi Toscano va > > > > escriure: > > > Il 30 dicembre 2016 10:30:

Re: To C++11 or not?

use nullptr unconditonally ACK? PS: I can do the work, I can script the refactoring with clang-tidy. Let's move forward please. Cheers, Kevin [1] https://community.kde.org/Frameworks/ Policies#Frameworks_compiler_requirements_and_C.2B.2B11 [2] http://en.cppreference.com/w/cpp/compiler_sup

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72308, @rakuco wrote: > Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? -fno-operator-names is an ancient compiler flag, supported by GCC since at least 2000

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... Hmm... You cou

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: ivan. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: Just refreshing my complete KF5 build to test the change. kactivities fails: /home/kfunk/devel/src/kf5/kactivities/autotests/common/test.h:143:25: error: token is not a valid binary operator in a preprocessor subexpression #if defined(Q_NO_DEBUG) or

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Accepted] D3733: Force colored warnings in ninja's output

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH ninja-colors REVISION DETAIL https://phabricator.kde.org/D3733 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Requested Changes To] D3733: Force colored warnings in ninja's output

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision now requires changes to proceed. This flag is only needed for Ninja, correct? Thus please check for Ninja in `CMAKE_GENERATOR ` before adding the compiler flag. REPOSITORY R240 Extr

[Differential] [Updated] D3548: Add begin/end insert/remove columns to RearrangeColumns

kfunk added a reviewer: dfaure. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lepagevalleeemmanuel, #frameworks, dfaure Cc: kfunk, ltoscano

[Differential] [Changed Subscribers] D3548: Add begin/end insert/remove columns to RearrangeColumns

kfunk added inline comments. INLINE COMMENTS > krearrangecolumnsproxymodel.cpp:44 > + > +const int cc = d_ptr->m_sourceColumns.size(); > + Please no short hand variable names. `cc` -> `sourceColCount`? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAI

[Differential] [Commented On] D3830: Add a new FindGperf module

kfunk added a comment. Windows: We have working gperf recipe in Craft => we're fine. QtWebKit already had an (optional) dependency on gperf. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings

Re: All Frameworks modules are now available as repositories on Phabricator

On Monday, 26 December 2016 01:19:41 CET Luigi Toscano wrote: > ... so that it's easier to use Differential for reviews. \o/ Thanks a lot for this! -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Review Request 129678: Make it possible for KConcatenateRowsProxyModel to work in QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129678/#review101519 --- Ship it! Ship It! - Kevin Funk On Dec. 20, 2016, 2:55

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. In https://phabricator.kde.org/D2545#69298, @thiago wrote: > In https://phabricator.kde.org/D2545#69187, @kfunk wrote: > > > In https://phabricator.kde.org/D2545#69091, @thiago wrote: > > > > > There doesn't seem to be a way of doing some clean up before the

[Differential] [Closed] D3691: Update QMake syntax highlighting file

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c3fc1271d6ad: Update QMake syntax highlighting file (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3691?vs=9048&id=9163#toc REPOSITORY R216 Syntax Highlighting CHANGES

[Differential] [Commented On] D3691: Update QMake syntax highlighting file

kfunk added a comment. Bump REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk added a comment. In https://phabricator.kde.org/D2075#66751, @jonathans wrote: > Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where t

[Differential] [Closed] D3702: kconfig_compiler: Use nullptr in generated code

This revision was automatically updated to reflect the committed changes. Closed by commit R237:e6c88f67e2cb: kconfig_compiler: Use nullptr in generated code (authored by kfunk). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3702?vs=9072&id=9075 REVISION DET

[Differential] [Updated] D3702: kconfig_compiler: Use nullptr in generated code

kfunk added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. In https://phabricator.kde.org/D2545#69091, @thiago wrote: > There doesn't seem to be a way of doing some clean up before the threads are forcibly killed. > > Maybe if I abuse qtmain(). This would only fix it for non-console GUI applications if I underst

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. For the record, since I don't see an easy fix I'm pondering about patching qtbase in craft.git: Ideas: a ) Add this to QDBusConnectionManager ctor: qAddPostRoutine([]() { QMetaObject::invokeMethod(QDBusConnectionManager::instance(), "quit");

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. > Here's the other problem: it's possible for threads to simply disappear on Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I can't rule out that this has happened. Qt 5.6 has a workaround to another deadlock caused by Windows. Can you try t

[Differential] [Updated, 674 lines] D3691: Update QMake syntax highlighting file

kfunk updated this revision to Diff 9048. kfunk added a comment. Add generator REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3691?vs=9047&id=9048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3691 AFFECTED FILES data/gener

[Differential] [Updated] D3691: Update QMake syntax highlighting file

kfunk added a reviewer: Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

Re: kconfig_compiler (Re: KDE Frameworks 5.29.0)

o this in 1-2 weeks (would fit our schedule). I don't think we want to rush and release v5.0.4 right now though. That would be an almost identical release to v5.0.3. Cheers, Kevin -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

<    1   2   3   4   5   6   >