D28457: kdirwatch: fix a recently introduced crash

meven created this revision. meven added reviewers: bruns, Frameworks, iasensio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevent a crash when browsing nfs without FAM installed introduced in

D28349: Fix Warnings

meven added inline comments. INLINE COMMENTS > bruns wrote in kdirwatch.cpp:946 > m_nfsPreferredMethod defaults to `KDirWatch::FAM`, i.e. it will crash below > now on NFS when FAM is disabled. So either change the default, or add a Q_FALLTHROUH() ? REPOSITORY R244 KCoreAddons REVISION

D28440: Mark KIOFuse mounts as Probably slow

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems fine to me. REPOSITORY R241 KIO BRANCH slowKIOFUse (branched from master) REVISION DETAIL https://phabricator.kde.org/D28440 To: feverfew, #frameworks, dfaure, broulik, bruns,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

meven added a comment. In D27951#637118 , @trmdi wrote: > In D27951#637038 , @dfaure wrote: > > > Indeed. Bug in kio_file, fixed in D28388 . > > > Ok, it

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. This gonna change the behavior of the function compared to before the StatDetails stat patch (details = 3 returned the inode of the link and not the one of the link destination), but it make

D28351: Fix a warning, remove outdated #pragma

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28351

D28349: Fix Warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R244:fcdf263339b4: Fix Warnings (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28349?vs=78655=78656 REVISION DETAIL

D28349: Fix Warnings

meven updated this revision to Diff 78655. meven added a comment. Add an argc value check REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28349?vs=78654=78655 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28349 AFFECTED FILES

D28349: Fix Warnings

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY We had 10 compile warnings before. 0 after REPOSITORY R244 KCoreAddons BRANCH

D28223: Add "Stat" prefix to StatDetails Enum entries

meven added a comment. In D28223#633824 , @meven wrote: > Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/ > I like it a lot more, this adds quite a lot

D28223: Add "Stat" prefix to StatDetails Enum entries

This revision was automatically updated to reflect the committed changes. Closed by commit R241:36038b904f68: Add Stat prefix to StatDetails Enum entries (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78401=78429 REVISION DETAIL

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked an inline comment as done. meven added a comment. Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/ I like it a lot more, this adds quite a lot of type safety. REPOSITORY R241 KIO BRANCH

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in statjob.cpp:106 > This is a weird way of doing this. > > A C-style enum is used like KIO::StatBasic. > Here you're using the C++11-class-enum syntax on a C-style enum, which I'm > not sure

D28223: Add "Stat" prefix to StatDetails Enum entries

meven updated this revision to Diff 78401. meven added a comment. Properly use KIO::Stat* as C-style enum REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78301=78401 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28223 AFFECTED FILES

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: cfeck, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27873: sftp: do not show creation time when we do not know it

meven accepted this revision. meven added a comment. Ok to me @bruns ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

meven added inline comments. INLINE COMMENTS > kfontchooserdialog.cpp:93 > + > +// static > +int KFontChooserDialog::getFontDiff(QFont , > KFontChooser::FontDiffFlags , Shouldn't this be not commented > kfontchooserdialog.cpp:110 > + > +// static > +int KFontChooserDialog::getFont(QFont ,

D27873: sftp: do not show creation time when we do not know it

meven added a comment. In D27873#624567 , @sitter wrote: > In D27873#623582 , @bruns wrote: > > > Please correct the comment in the code - it depends on the server SFTP implementation. > > >

D27936: Windows: Add suport for file date creation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:50bc53ffbcf2: Windows: Add suport for file date creation (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27936?vs=77236=78343 REVISION DETAIL

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28223 To: meven, #frameworks, kossebau, dfaure Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28223: Add "Stat" prefix to StatDetails Enum entries

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > davidre wrote in global.h:322 > I think this enum was not released yet Indeed it will be part of KF 5.69 (as the comment above the enum tells), view discussion in D25010

D28223: Add "Stat" prefix to StatDetails Enum entries

meven created this revision. meven added reviewers: Frameworks, kossebau, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Relates to D25010 TEST PLAN

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. In D25010#632977 , @kossebau wrote: > In D25010#632835 , @dfaure wrote: > > > Yes, either prefixes or the C++11 way with enum class. > > > I propose to go with prefixes

D27902: smb: figure out the best host to use for the UDS_URL

meven added a comment. Seems fine to me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in global.h:320 > This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the > KIO namespace, with no futher hint that these belong to this very enum, > resulting in

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c5009b8b4ab9: Move createUDSEntry from file.cpp to file_unix.cpp (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=78159=78207 REVISION

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven updated this revision to Diff 78159. meven marked 3 inline comments as done. meven added a comment. Add 3 missing static REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=78141=78159 BRANCH arcpatch-D25301 REVISION DETAIL

D27455: FileWidgets: Ignore Return events from KDirOperator

meven added a comment. I did some secondary review. I'd like to add a test. REPOSITORY R241 KIO BRANCH arcpatch-D27455 REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27455: FileWidgets: Ignore Return events from KDirOperator

meven updated this revision to Diff 78142. meven added a comment. Add event->accept() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27455?vs=75822=78142 BRANCH arcpatch-D27455 REVISION DETAIL https://phabricator.kde.org/D27455 AFFECTED FILES

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven updated this revision to Diff 78141. meven added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25301?vs=69731=78141 BRANCH arcpatch-D25301 REVISION DETAIL https://phabricator.kde.org/D25301 AFFECTED FILES

D27936: Windows: Add suport for file date creation

meven added reviewers: elvisangelaccio, Windows, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27936 To: meven, #frameworks, elvisangelaccio, #windows, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Please wait for me review. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontdlg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28122 To:

D28128: Add force save behavior to KEntryMap

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

meven added inline comments. INLINE COMMENTS > kconfigdata.cpp:139 > > +// If overidded entry is global and not default. And it's overrided by a > non global > +if (e.bGlobal && !(options & EntryGlobal) && !k.bDefault) s/overidded/overridden REPOSITORY R237 KConfig REVISION

D27504: smb faster copy to local

meven added a comment. Looks good to me. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

meven abandoned this revision. meven added a comment. This is not needed anymore. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

meven added inline comments. INLINE COMMENTS > kcmoduleqml.cpp:87 > + > +// changed is also manipulated extermally by KCModule, we need to keep > the Quick implementation in sync > +// TODO KF6 remove the differed "emit changed" in KConfigModule and then > we can remove this here

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

meven added a comment. Good to me REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:203 > Ah, was already fixed. 5434ffd0c655b0996e881fec605dc988a672d85c REPOSITORY R241 KIO REVISION

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9537bca2b542: [StatJob] Use A QFlag to specify the details returned by StatJob (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77386=77460

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. Ok to merge ? REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77386. meven added a comment. Improve comment of StatJob *statDetails REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77385=77386 BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77385. meven added a comment. Fix typo, make StatJob::setDetails(KIO::StatDetail detail) build only when build_deprecated(5.69) is set REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77235=77385 BRANCH

D27965: [KPasswdServer] replace foreach with range/index-based for

meven added a comment. In D27965#625381 , @apol wrote: > Looks good to me, I wonder why you turned some to for+iterators. Those modified the list as they iterated through the list : `authList->removeOne(current);` REPOSITORY R241 KIO

D27455: FileWidgets: Ignore Return events from KDirOperator

meven added a comment. Well I meant to do some checking, despite this works, it does not look nice. Adding a test would be nice too. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc:

D27152: Introduce FilesystemEntry class

meven added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:209 > add temporary for fstype The temporary for fstype is gone it seems. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc:

D27951: Allow users to change dropAction to MoveAction through workspace kcm

meven added a comment. This does not include the workspace-option kcm setting. So I would title this "Allow users to change dropAction to MoveAction through a dndToMove kdeglobal setting" INLINE COMMENTS > dropjob.cpp:288 > } > +if

D27965: [KPasswdServer] replace foreach with range/index-based for

meven added a comment. Please wait for a second review, I am not authoritative here. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n,

D27965: [KPasswdServer] replace foreach with range/index-based for

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack,

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-http-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27963 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven added inline comments. INLINE COMMENTS > dropjob.cpp:150 > Qt::KeyboardModifiers m_keyboardModifiers; > +KFileItemList m_fileItems; > +KFileItemListProperties m_itemProps; I think you don't need a member here, a local variable should suffice. REPOSITORY R241 KIO REVISION

D23926: Move "Details" tab to second place in Properties dialog

meven added a comment. In D23926#624753 , @mthw wrote: > @meven So, the first version of this diff is good enough? Well no I missed @ngraham points that still stands. And your current code result with the same effect anyway as long as

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven added a comment. And BTW I reported a QT bug relating to the keyboard modifiers not working as expected a while back, making this feature more appealing : https://bugreports.qt.io/browse/QTBUG-79919 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To:

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven added a comment. I added the bug wish https://bugs.kde.org/show_bug.cgi?id=224257 althoug it will require a KCM setting to be feature complete. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: meven, kde-frameworks-devel,

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27839: Properly name the content of the kcmcontrols project

meven added a comment. LGTM REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27941: [protocoltojson] Replace foreach with range-for

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-protocoltojson (branched from master) REVISION DETAIL https://phabricator.kde.org/D27941 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack,

D25454: Prevent a crash when deleting a device Interface

meven abandoned this revision. meven added a comment. Was superseeded by D26117 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D25454 To: meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

meven updated this revision to Diff 77257. meven added a comment. Add @since 5.69 REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27940?vs=77256=77257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27940 AFFECTED FILES

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

meven updated this revision to Diff 77256. meven added a comment. Remove unnecessary changes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27940?vs=77255=77256 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27940 AFFECTED FILES

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

meven created this revision. meven added reviewers: cfeck, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Question: Is there a way to get theme colors for kconfigwidgets rather than a

D23926: Move "Details" tab to second place in Properties dialog

meven added a comment. In D23926#538778 , @mthw wrote: > > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd want to do something more like this: > > > > > > > > if (plugin == "details" /* this is

D27936: Windows: Add suport for file date creation

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27936 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77235. meven added a comment. Get code ready for 5.69, I really HOPE that the last time I have to do this, remove a few qDebug(), add some test assertions, make test more reliable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

meven added a comment. In D27833#622353 , @apol wrote: > What's the use-case? Originally D27934 was needing it, but in the end this is not needed anymore, so I think it should be best to postpone

D27463: KconfigXT: Add a value attribute to Enum field choices

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ec207330d5bd: KconfigXT: Add a value attribute to Enum field choices (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77225=77226

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77225. meven added a comment. Rebase on master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77077=77225 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77077. meven added a comment. Fix typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77064=77077 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77064. meven marked 2 inline comments as done. meven added a comment. Fix comment and formatting REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77006=77064 BRANCH arcpatch-D27463_2 REVISION DETAIL

D27839: Properly name the content of the kcmcontrols project

meven accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27864: KIO::iconNameForUrl(): handle the case of a file/folder under trash:/

meven accepted this revision. REPOSITORY R241 KIO BRANCH l-trash-stuff (branched from master) REVISION DETAIL https://phabricator.kde.org/D27864 To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.cpp:580 > No I meant the comment needs to be adjusted due to the changes (fields > changing place and such) sorry if I was unclear. I updated the comment since your first

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77006. meven added a comment. Fix typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76999=77006 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added inline comments. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.cpp:580 > Will need an update You mean I should prepare this and put it in KF6 waiting for merge queue ? > ervin wrote in kcoreconfigskeleton.h:788 > const QString > > Probably worth adding a KF6 comment

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76999. meven marked 9 inline comments as done. meven added a comment. Remove enumValues, const ref args, move mValues to KCoreConfigSkeletonItemPrivate, improve comments REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27835: sftp: fix free space query for urls with empty path

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-free-path REVISION DETAIL https://phabricator.kde.org/D27835 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

meven retitled this revision from "Add an accessor to get the last load value for KConfigSkeletonItem" to "Add an accessor to get the last loaded value for KConfigSkeletonItem". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi,

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

meven updated this revision to Diff 76938. meven added a comment. Clean qDebug traces REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27833?vs=76937=76938 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27833 AFFECTED FILES

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

meven updated this revision to Diff 76937. meven added a comment. Avoid some space changes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27833?vs=76936=76937 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27833 AFFECTED FILES

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

meven added a comment. Inspired by 4c3d3751968422ff5cba56b5da2036a1bceba314 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi, #frameworks Cc:

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

meven created this revision. meven added reviewers: ervin, bport, crossi, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY It allows to know the last load values from KConfig, for some edge

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added a comment. I fixed an issue when testing this with D27477 and it is fixed and the issue it revealed is tested. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc:

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76866. meven added a comment. Improve naming, fix case of normal entries, adding a test for this case REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76856=76866 BRANCH arcpatch-D27463_1 REVISION DETAIL

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76856. meven added a comment. Fix no value set case REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76849=76856 BRANCH arcpatch-D27463_1 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76849. meven added a comment. Move values attribute for ItemEnum::Choice to KCoreConfigSkeleton::ItemEnum::ItemEnum::mValues to preserve Binary compatiblity REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27717: fix min/max entries with dpointer

meven accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27717 To: hchain, meven, ervin Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

meven marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76446. meven added a comment. Move construct of QRegularExpression out of loop REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76405=76446 BRANCH arcpatch-D27463 REVISION DETAIL

D27672: Fix tests after D27497

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ed960455a112: Fix tests after D27497 (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27672?vs=76444=76445 REVISION DETAIL

D27672: Fix tests after D27497

meven added reviewers: crossi, Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27672 To: meven, hchain, ervin, bport, crossi, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27672: Fix tests after D27497

meven created this revision. meven added reviewers: hchain, ervin, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D27497#618156 TEST PLAN ctest REPOSITORY

D27497: Fix code generation for entries with min/max

meven added inline comments. INLINE COMMENTS > test_properties_minmax.h.ref:43 > +Q_PROPERTY(int bar READ bar WRITE setBar NOTIFY barChanged) > +Q_PROPERTY(bool isBarImmutable CONSTANT) > +/** This is incorrrect since D27496 , too bad this was

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:764 > QString whatsThis; > +QString val; > + Something I have noticed while testing this. Since it changes the memory of a very common data struct in a very common lib, it creates a lot of crashes if

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76405. meven marked 6 inline comments as done. meven added a comment. Move KCoreConfigSkeleton::ItemEnum::Choice::value to cpp file, use a regex to filter valid choice name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

This revision was automatically updated to reflect the committed changes. Closed by commit R241:eb20176d1a42: KIO::iconNameForUrl: fix searching for kde protocol icons (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76156=76162

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76156. meven marked 2 inline comments as done. meven added a comment. Improve comment, remove unnecessary check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76148=76156 BRANCH arcpatch-D27539 REVISION DETAIL

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven added a comment. In D27539#615654 , @dfaure wrote: > This is about an icon name. Apps don't (shouldn't) "check the value". > > We should return application-octet-stream if we did find the file, but mimetype determination failed. That's

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76148. meven added a comment. Add an https test case REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76147=76148 BRANCH arcpatch-D27539 REVISION DETAIL https://phabricator.kde.org/D27539 AFFECTED FILES

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven added a comment. In D27539#615288 , @dfaure wrote: > kfileitemtest still passes? It does, and I added more tests. A question I have is that in case we don't find an icon depending on how we determine it we can return

<    1   2   3   4   5   6   7   8   9   10   >